14913 2007-08-09 09:04:01 -0700 GTK API does not allow going forwards/backwards by multiple steps 2007-12-27 14:40:59 -0800 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) PC Linux RESOLVED DUPLICATE 14811 P2 Normal --- 0 gwright webkit-unassigned christian jasuarez xan.lopez oldest_to_newest 2757 0 gwright 2007-08-09 09:04:01 -0700 The WebKit API allows you to go forwards and backwards in the browser history by more than one page. The GTK API does not. This should be implemented so that browsers can utilise such features. 2756 1 15881 gwright 2007-08-09 09:26:31 -0700 Created attachment 15881 Proposed fix 2755 2 15882 gwright 2007-08-09 09:31:34 -0700 Created attachment 15882 Proposed fix, take 2 Update to the originally proposed patch, which accidentally mangled the ChangeLog. 2694 3 zecke 2007-08-09 17:51:31 -0700 Duplicate of bug #14811 2696 4 zecke 2007-08-09 18:41:17 -0700 Default arguments for ANSI C? I think not. I would r=- it. 2384 5 15882 aroben 2007-08-13 17:44:28 -0700 Comment on attachment 15882 Proposed fix, take 2 r- due to Holger's comments. 2380 6 christian 2007-08-13 19:29:24 -0700 In my opinion this feature should be an extra function which behaves the same as goBackOrForward, taking the widget and the steps as arguments. The currently suggested implementation is a bit confusing. 2094 7 jasuarez 2007-08-17 08:12:31 -0700 IMHO this bug should have Gtk keyword. 57961 8 xan.lopez 2007-10-06 14:50:33 -0700 +1 for closing this as duplicate of bug 14811. Even if we agree on adding this API it should come as a new function, not as an extra argument (with default value!?) of the existing functions. 65407 9 christian 2007-12-27 14:40:59 -0800 *** This bug has been marked as a duplicate of 14811 *** 15881 2007-08-09 09:26:31 -0700 2007-08-09 09:31:34 -0700 Proposed fix webkit-forwards-backwards.patch text/plain 2762 gwright SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDgt MDkgIEdlb3JnZSBXcmlnaHQgIDxnZW9yZ2Uud3JpZ2h0QGNvbGxhYm9yYS5jby51az4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkxMworICAgICAgICBHVEsgQVBJIGRvZXMgbm90 IGFsbG93IGdvaW5nIGZvcndhcmRzL2JhY2t3YXJkcyBieSBtdWx0aXBsZSBzdGVwcy4KKworICAg ICAgICBDaGFuZ2VkIEdUSyBBUEkgdG8gYWxsb3cgZm9yIGdvaW5nIGZvcndhcmRzIGFuZCBiYWNr d2FyZHMgYnkgbXVsdGlwbGUgc3RlcHMuCisKKyAgICAgICAgKiBndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwOgorICAgICAgICAqIGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5oOgorCiAyMDA3LTA4LTA4 ICBLZXZpbiBEZWNrZXIgPGtkZWNrZXJAYXBwbGUuY29tPgpieSBtb3JlIHRoYW4gb25lIHBhZ2Uu IFRoZSBHVEsgQVBJIGRvZXMgbm90LiBUaGlzIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBzbyB0aGF0 CmJyb3dzZXJzIGNhbiB1dGlsaXNlIHN1Y2ggZmVhdHVyZXMuCisgICAgICAgIENoYW5nZWQgR1RL IEFQSSB0byBhbGxvdyBmb3IgZ29pbmcgZm9yd2FyZHMgYW5kIGJhY2t3YXJkcyBieSBtdWx0aXBs ZSBzdGVwcy4KKworICAgICAgICAqIGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHA6CisgICAgICAg ICogZ3RrL0FwaS93ZWJraXRndGtwYWdlLmg6CisKIDIwMDctMDgtMDggIEtldmluIERlY2tlciA8 a2RlY2tlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29u LgpJbmRleDogZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBndGsvQXBp L3dlYmtpdGd0a3BhZ2UuY3BwCShyZXZpc2lvbiAyNDk1NSkKKysrIGd0ay9BcGkvd2Via2l0Z3Rr cGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4MywxOCArMzgzLDE4IEBAIFdlYktpdEd0a1Nl dHRpbmdzKiB3ZWJraXRfZ3RrX3BhZ2VfZ2V0X3MKICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCB3 ZWJraXRfZ3RrX3BhZ2VfZ29fYmFja3dhcmQoV2ViS2l0R3RrUGFnZSogcGFnZSkKK3ZvaWQgd2Vi a2l0X2d0a19wYWdlX2dvX2JhY2t3YXJkKFdlYktpdEd0a1BhZ2UqIHBhZ2UsIGludCBzdGVwcykK IHsKICAgICBXZWJLaXRHdGtQYWdlUHJpdmF0ZSogcGFnZURhdGEgPSBXRUJLSVRfR1RLX1BBR0Vf R0VUX1BSSVZBVEUocGFnZSk7CiAgICAgV2ViS2l0R3RrRnJhbWVQcml2YXRlKiBmcmFtZURhdGEg PSBXRUJLSVRfR1RLX0ZSQU1FX0dFVF9QUklWQVRFKHBhZ2VEYXRhLT5tYWluRnJhbWUpOwotICAg IGZyYW1lRGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5nb0JhY2tPckZvcndhcmQoLTEpOworICAgIGZy YW1lRGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5nb0JhY2tPckZvcndhcmQoLXN0ZXBzKTsKIH0KIAot dm9pZCB3ZWJraXRfZ3RrX3BhZ2VfZ29fZm9yd2FyZChXZWJLaXRHdGtQYWdlKiBwYWdlKQordm9p ZCB3ZWJraXRfZ3RrX3BhZ2VfZ29fZm9yd2FyZChXZWJLaXRHdGtQYWdlKiBwYWdlLCBpbnQgc3Rl cHMpCiB7CiAgICAgV2ViS2l0R3RrUGFnZVByaXZhdGUqIHBhZ2VEYXRhID0gV0VCS0lUX0dUS19Q QUdFX0dFVF9QUklWQVRFKHBhZ2UpOwogICAgIFdlYktpdEd0a0ZyYW1lUHJpdmF0ZSogZnJhbWVE YXRhID0gV0VCS0lUX0dUS19GUkFNRV9HRVRfUFJJVkFURShwYWdlRGF0YS0+bWFpbkZyYW1lKTsK LSAgICBmcmFtZURhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Z29CYWNrT3JGb3J3YXJkKDEpOworICAg IGZyYW1lRGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5nb0JhY2tPckZvcndhcmQoc3RlcHMpOwogfQog CiBnYm9vbGVhbiB3ZWJraXRfZ3RrX3BhZ2VfY2FuX2dvX2JhY2t3YXJkKFdlYktpdEd0a1BhZ2Uq IHBhZ2UpCkluZGV4OiBndGsvQXBpL3dlYmtpdGd0a3BhZ2UuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBndGsv QXBpL3dlYmtpdGd0a3BhZ2UuaAkocmV2aXNpb24gMjQ5NTUpCisrKyBndGsvQXBpL3dlYmtpdGd0 a3BhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtMTI4LDEwICsxMjgsMTAgQEAgV0VCS0lUX0dUS19B UEkgZ2Jvb2xlYW4KIHdlYmtpdF9ndGtfcGFnZV9jYW5fZ29fZm9yd2FyZCAoV2ViS2l0R3RrUGFn ZSogcGFnZSk7CiAKIFdFQktJVF9HVEtfQVBJIHZvaWQKLXdlYmtpdF9ndGtfcGFnZV9nb19iYWNr d2FyZCAoV2ViS2l0R3RrUGFnZSogcGFnZSk7Cit3ZWJraXRfZ3RrX3BhZ2VfZ29fYmFja3dhcmQg KFdlYktpdEd0a1BhZ2UqIHBhZ2UsIGludCBzdGVwcyA9IDEpOwogCiBXRUJLSVRfR1RLX0FQSSB2 b2lkCi13ZWJraXRfZ3RrX3BhZ2VfZ29fZm9yd2FyZCAoV2ViS2l0R3RrUGFnZSogcGFnZSk7Cit3 ZWJraXRfZ3RrX3BhZ2VfZ29fZm9yd2FyZCAoV2ViS2l0R3RrUGFnZSogcGFnZSwgaW50IHN0ZXBz ID0gMSk7CiAKIFdFQktJVF9HVEtfQVBJIHZvaWQKIHdlYmtpdF9ndGtfcGFnZV9zdG9wX2xvYWRp bmcgKFdlYktpdEd0a1BhZ2UqIHBhZ2UpOwo= 15882 2007-08-09 09:31:34 -0700 2007-08-13 17:44:28 -0700 Proposed fix, take 2 webkit-forwards-backwards.patch text/plain 2436 gwright SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI0OTU2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDgt MDkgIEdlb3JnZSBXcmlnaHQgIDxnZW9yZ2Uud3JpZ2h0QGNvbGxhYm9yYS5jby51az4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkxMworICAgICAgICBHVEsgQVBJIGRvZXMgbm90 IGFsbG93IGdvaW5nIGZvcndhcmRzL2JhY2t3YXJkcyBieSBtdWx0aXBsZSBzdGVwcy4KKworICAg ICAgICBDaGFuZ2VkIEdUSyBBUEkgdG8gYWxsb3cgZm9yIGdvaW5nIGZvcndhcmRzIGFuZCBiYWNr d2FyZHMgYnkgbXVsdGlwbGUgc3RlcHMuCisKKyAgICAgICAgKiBndGsvQXBpL3dlYmtpdGd0a3Bh Z2UuY3BwOgorICAgICAgICAqIGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5oOgorCiAyMDA3LTA4LTA4 ICBLZXZpbiBEZWNrZXIgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IGd0ay9BcGkvd2Via2l0Z3RrcGFnZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gZ3RrL0FwaS93ZWJraXRndGtwYWdlLmNwcAkocmV2aXNpb24gMjQ5NTUpCisrKyBn dGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODMsMTggKzM4Mywx OCBAQCBXZWJLaXRHdGtTZXR0aW5ncyogd2Via2l0X2d0a19wYWdlX2dldF9zCiAgICAgcmV0dXJu IDA7CiB9CiAKLXZvaWQgd2Via2l0X2d0a19wYWdlX2dvX2JhY2t3YXJkKFdlYktpdEd0a1BhZ2Uq IHBhZ2UpCit2b2lkIHdlYmtpdF9ndGtfcGFnZV9nb19iYWNrd2FyZChXZWJLaXRHdGtQYWdlKiBw YWdlLCBpbnQgc3RlcHMpCiB7CiAgICAgV2ViS2l0R3RrUGFnZVByaXZhdGUqIHBhZ2VEYXRhID0g V0VCS0lUX0dUS19QQUdFX0dFVF9QUklWQVRFKHBhZ2UpOwogICAgIFdlYktpdEd0a0ZyYW1lUHJp dmF0ZSogZnJhbWVEYXRhID0gV0VCS0lUX0dUS19GUkFNRV9HRVRfUFJJVkFURShwYWdlRGF0YS0+ bWFpbkZyYW1lKTsKLSAgICBmcmFtZURhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Z29CYWNrT3JGb3J3 YXJkKC0xKTsKKyAgICBmcmFtZURhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Z29CYWNrT3JGb3J3YXJk KC1zdGVwcyk7CiB9CiAKLXZvaWQgd2Via2l0X2d0a19wYWdlX2dvX2ZvcndhcmQoV2ViS2l0R3Rr UGFnZSogcGFnZSkKK3ZvaWQgd2Via2l0X2d0a19wYWdlX2dvX2ZvcndhcmQoV2ViS2l0R3RrUGFn ZSogcGFnZSwgaW50IHN0ZXBzKQogewogICAgIFdlYktpdEd0a1BhZ2VQcml2YXRlKiBwYWdlRGF0 YSA9IFdFQktJVF9HVEtfUEFHRV9HRVRfUFJJVkFURShwYWdlKTsKICAgICBXZWJLaXRHdGtGcmFt ZVByaXZhdGUqIGZyYW1lRGF0YSA9IFdFQktJVF9HVEtfRlJBTUVfR0VUX1BSSVZBVEUocGFnZURh dGEtPm1haW5GcmFtZSk7Ci0gICAgZnJhbWVEYXRhLT5mcmFtZS0+bG9hZGVyKCktPmdvQmFja09y Rm9yd2FyZCgxKTsKKyAgICBmcmFtZURhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Z29CYWNrT3JGb3J3 YXJkKHN0ZXBzKTsKIH0KIAogZ2Jvb2xlYW4gd2Via2l0X2d0a19wYWdlX2Nhbl9nb19iYWNrd2Fy ZChXZWJLaXRHdGtQYWdlKiBwYWdlKQpJbmRleDogZ3RrL0FwaS93ZWJraXRndGtwYWdlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gZ3RrL0FwaS93ZWJraXRndGtwYWdlLmgJKHJldmlzaW9uIDI0OTU1KQorKysg Z3RrL0FwaS93ZWJraXRndGtwYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyOCwxMCArMTI4LDEw IEBAIFdFQktJVF9HVEtfQVBJIGdib29sZWFuCiB3ZWJraXRfZ3RrX3BhZ2VfY2FuX2dvX2Zvcndh cmQgKFdlYktpdEd0a1BhZ2UqIHBhZ2UpOwogCiBXRUJLSVRfR1RLX0FQSSB2b2lkCi13ZWJraXRf Z3RrX3BhZ2VfZ29fYmFja3dhcmQgKFdlYktpdEd0a1BhZ2UqIHBhZ2UpOword2Via2l0X2d0a19w YWdlX2dvX2JhY2t3YXJkIChXZWJLaXRHdGtQYWdlKiBwYWdlLCBpbnQgc3RlcHMgPSAxKTsKIAog V0VCS0lUX0dUS19BUEkgdm9pZAotd2Via2l0X2d0a19wYWdlX2dvX2ZvcndhcmQgKFdlYktpdEd0 a1BhZ2UqIHBhZ2UpOword2Via2l0X2d0a19wYWdlX2dvX2ZvcndhcmQgKFdlYktpdEd0a1BhZ2Uq IHBhZ2UsIGludCBzdGVwcyA9IDEpOwogCiBXRUJLSVRfR1RLX0FQSSB2b2lkCiB3ZWJraXRfZ3Rr X3BhZ2Vfc3RvcF9sb2FkaW5nIChXZWJLaXRHdGtQYWdlKiBwYWdlKTsK