149121 2015-09-14 11:08:39 -0700 Web Inspector: Turn off line wrapping in resource text editors 2015-09-16 10:38:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1125662 0 joepeck 2015-09-14 11:08:39 -0700 * SUMMARY Turn off line wrapping in resource text editors. * NOTES - Firefox and Chrome both do not have line wrapping in these cases. - In pretty printing cases, it looks unusual to have a line wrapped even when pretty printed 1125664 1 joepeck 2015-09-14 11:08:53 -0700 <rdar://problem/22677239> 1125666 2 261115 joepeck 2015-09-14 11:09:37 -0700 Created attachment 261115 [PATCH] Proposed Fix 1125984 3 261115 bburg 2015-09-15 09:26:38 -0700 Comment on attachment 261115 [PATCH] Proposed Fix This seems kind of subjective. In many cases (HTML with huge inline styles) it's unusable without line wrapping. Should we defer until editor settings are added? 1126002 4 joepeck 2015-09-15 10:04:00 -0700 (In reply to comment #3) > Comment on attachment 261115 [details] > [PATCH] Proposed Fix > > This seems kind of subjective. In many cases (HTML with huge inline styles) > it's unusable without line wrapping. Should we defer until editor settings > are added? I'm fine with deferring / blocking on: <https://webkit.org/b/149120> Web Inspector: Preferences for Text Editor behavior 1126397 5 261115 commit-queue 2015-09-16 10:38:45 -0700 Comment on attachment 261115 [PATCH] Proposed Fix Clearing flags on attachment: 261115 Committed r189872: <http://trac.webkit.org/changeset/189872> 1126398 6 commit-queue 2015-09-16 10:38:49 -0700 All reviewed patches have been landed. Closing bug. 261115 2015-09-14 11:09:37 -0700 2015-09-16 10:38:45 -0700 [PATCH] Proposed Fix line-wrapping.patch text/plain 1559 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAxNjE2ZmEuLjAyYmJlMjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVHVybiBv ZmYgbGluZSB3cmFwcGluZyBpbiByZXNvdXJjZSB0ZXh0IGVkaXRvcnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTEyMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9U ZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IpOgorCiAyMDE1 LTA5LTExICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IEFSSUEg MS4xIEBhcmlhLWN1cnJlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCmluZGV4IDFiZDdkNTguLjc4ODEwNDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRF ZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qcwpAQCAtMzIsMTIgKzMyLDEzIEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y ID0gY2xhc3MgVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAg dGhpcy5fZWxlbWVudCA9IGVsZW1lbnQgfHwgZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7 CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgidGV4dC1lZGl0b3IiLCBXZWJJ bnNwZWN0b3IuU3ludGF4SGlnaGxpZ2h0ZWRTdHlsZUNsYXNzTmFtZSk7CiAKKyAgICAgICAgLy8g RklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDkxMjA+IFdlYiBJbnNwZWN0b3I6IFByZWZl cmVuY2VzIGZvciBUZXh0IEVkaXRvciBiZWhhdmlvcgogICAgICAgICB0aGlzLl9jb2RlTWlycm9y ID0gQ29kZU1pcnJvcih0aGlzLmVsZW1lbnQsIHsKICAgICAgICAgICAgIHJlYWRPbmx5OiB0cnVl LAogICAgICAgICAgICAgaW5kZW50V2l0aFRhYnM6IHRydWUsCiAgICAgICAgICAgICBpbmRlbnRV bml0OiA0LAogICAgICAgICAgICAgbGluZU51bWJlcnM6IHRydWUsCi0gICAgICAgICAgICBsaW5l V3JhcHBpbmc6IHRydWUsCisgICAgICAgICAgICBsaW5lV3JhcHBpbmc6IGZhbHNlLAogICAgICAg ICAgICAgbWF0Y2hCcmFja2V0czogdHJ1ZSwKICAgICAgICAgICAgIGF1dG9DbG9zZUJyYWNrZXRz OiB0cnVlCiAgICAgICAgIH0pOwo=