149111 2015-09-13 22:04:27 -0700 [GTK] timeline is not updated after few seconds when mouse hovers on controls 2015-09-21 01:37:48 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 149396 1 changseok changseok calvaris cgarcia commit-queue gustavo pnormand oldest_to_newest 1125536 0 changseok 2015-09-13 22:04:27 -0700 1. go http://www.w3schools.com/html/html5_video.asp 2. click a play button 3. stay cursor on the playbutton. 4. you can see time is paused after 4 seconds. 1125600 1 261112 changseok 2015-09-14 09:26:46 -0700 Created attachment 261112 Patch 1126311 2 calvaris 2015-09-16 00:57:43 -0700 Can you please tell me which diagnostics have you made so that you reach the conclusion that this is the best patch? It is weird because we shouldn't need to check the opacity as precisely, we handle the opacity thru CSS with the classes we add to the element. 1126316 3 changseok 2015-09-16 01:26:19 -0700 (In reply to comment #2) > Can you please tell me which diagnostics have you made so that you reach the > conclusion that this is the best patch? > > It is weird because we shouldn't need to check the opacity as precisely, we > handle the opacity thru CSS with the classes we add to the element. As I described the situation in the ChangeLog, We changed not to update time if controllAreHidden is true in https://bugs.webkit.org/show_bug.cgi?id=137773. However this affects on controls behavior very much. Let guess this scenario. (move cursor on playbutton) -> (click play button) -> (hideControl timer fired by resetHideControlsTimer after 4 secs) -> (now controlsAreHidden is true since panel has neither -webkit-media-controls-panel.show nor -webkit-media-controls-panel.hidden) -> (playing along with visible controls due to -webkit-media-controls-panel:hover which sets opacity to 1, but time is not updated because of controlsAreHidden == 1) So the problem here is controlsAreHidden does not actually mean "hidden" and I check the opacity is really 0. I don't want to argue this approach is the best. Any better idea is welcome. =) 1126317 4 changseok 2015-09-16 01:29:01 -0700 This fixes audio controls broken as well. Try http://www.quackit.com/html_5/tags/html_audio_tag.cfm 1126326 5 calvaris 2015-09-16 04:04:02 -0700 (In reply to comment #3) > As I described the situation in the ChangeLog, We changed not to update time > if controllAreHidden is true in > https://bugs.webkit.org/show_bug.cgi?id=137773. > However this affects on controls behavior very much. Let guess this scenario. > (move cursor on playbutton) -> (click play button) -> (hideControl timer > fired by resetHideControlsTimer after 4 secs) -> (now controlsAreHidden is > true since panel has neither -webkit-media-controls-panel.show nor > -webkit-media-controls-panel.hidden) -> (playing along with visible controls > due to -webkit-media-controls-panel:hover which sets opacity to 1, but time > is not updated because of controlsAreHidden == 1) > So the problem here is controlsAreHidden does not actually mean "hidden" and > I check the opacity is really 0. I understand now, good catch. You're right, another check needs to be done, though I don't think checking for opacity is the best way to go, but checking for the :hover property as :hover can change opacity, display or whatever we want from CSS. IMHO, we are safer with checking for :hover. 1126351 6 261311 changseok 2015-09-16 09:10:34 -0700 Created attachment 261311 Patch 1126353 7 changseok 2015-09-16 09:14:36 -0700 (In reply to comment #5) > (In reply to comment #3) > > As I described the situation in the ChangeLog, We changed not to update time > > if controllAreHidden is true in > > https://bugs.webkit.org/show_bug.cgi?id=137773. > > However this affects on controls behavior very much. Let guess this scenario. > > (move cursor on playbutton) -> (click play button) -> (hideControl timer > > fired by resetHideControlsTimer after 4 secs) -> (now controlsAreHidden is > > true since panel has neither -webkit-media-controls-panel.show nor > > -webkit-media-controls-panel.hidden) -> (playing along with visible controls > > due to -webkit-media-controls-panel:hover which sets opacity to 1, but time > > is not updated because of controlsAreHidden == 1) > > So the problem here is controlsAreHidden does not actually mean "hidden" and > > I check the opacity is really 0. > > I understand now, good catch. You're right, another check needs to be done, > though I don't think checking for opacity is the best way to go, but > checking for the :hover property as :hover can change opacity, display or > whatever we want from CSS. IMHO, we are safer with checking for :hover. Otherwise we can use querySelector to check :hover existence. However, I'm not sure if that way is better than checking opacity directly in performance aspect.. 1126656 8 calvaris 2015-09-17 02:34:59 -0700 (In reply to comment #7) > Otherwise we can use querySelector to check :hover existence. However, I'm > not sure if that way is better than checking opacity directly in performance > aspect.. LGTM. I don't think, unless you correct me, that performance is going to be a problem. 1127590 9 261311 changseok 2015-09-21 00:51:05 -0700 Comment on attachment 261311 Patch Thanks! 1127599 10 261311 commit-queue 2015-09-21 01:37:44 -0700 Comment on attachment 261311 Patch Clearing flags on attachment: 261311 Committed r190053: <http://trac.webkit.org/changeset/190053> 1127600 11 commit-queue 2015-09-21 01:37:48 -0700 All reviewed patches have been landed. Closing bug. 261112 2015-09-14 09:26:46 -0700 2015-09-16 09:10:20 -0700 Patch bug-149111-20150915012635.patch text/plain 5331 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI5NGU2MGNhYzNhMGUz NDc0YTUzZjI0MDg1Yjc5ZTMxN2IwMWI3Ny4uYWJiMDFkNTJkNTkzN2RjNGU4MjdjYmYyODhiNTg3 OTU1NDNkMjdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTE0ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSB0 aW1lbGluZSBpcyBub3QgdXBkYXRlZCBhZnRlciBmZXcgc2Vjb25kcyB3aGVuIG1vdXNlIGhvdmVy cyBvbiBjb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ5MTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGltZWxpbmUgaXMgbm90IHVwZGF0ZWQgaWYgY29udHJvbHNBcmVIaWRkZW4gaXMgdHJ1 ZS4gVGhlIHByb2JsZW0gaGVyZSBpcyB0aGF0CisgICAgICAgIHRoZSBmdW5jdGlvbiBkb2VzIG5v dCBtZWFuIGFjdHVhbGx5ICdoaWRkZW4nIHNpbmNlIGl0IG9ubHkgY2hlY2tlcyAnc2hvdycgYW5k ICdoaWRkZW4nCisgICAgICAgIGNsYXNzIGV4aXN0ZW5jZXMuIFRoZSBwYW5lbCdzIHZpc2liaWxp dHkgYXJlIG5vdCBvbmx5IGNvbnRyb2xsZWQgYnkgdGhlIHR3byBjbGFzc2VzLAorICAgICAgICBi dXQgYWxzbyBieSB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbDpob3Zlci4gVGhl IHBhbmVsIGNvdWxkIGJlIHZpc2libGUKKyAgICAgICAgYnkgc2V0dGluZyB0aGUgcHNldWRvIGhv dmVyIGNsYXNzLiBTbyB3ZSBuZWVkIHRvIGNoZWNrIHBhbmVsJ3Mgb3BhY2l0eSBhcyB3ZWxsIGlu IGNvbnRyb2xzQXJlSGlkZGVuKCkuCisKKyAgICAgICAgVGVzdDogbWVkaWEvbWVkaWEtY29udHJv bHMtdGltZWxpbmUtdXBkYXRlcy13aGVuLWhvdmVyZWQuaHRtbAorCisgICAgICAgICogTW9kdWxl cy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNCYXNlLmpzOgorICAgICAgICAoQ29udHJvbGxl ci5wcm90b3R5cGUuY29udHJvbHNBcmVIaWRkZW4pOgorCiAyMDE1LTA5LTEwICBDaGFuZ1Nlb2sg T2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBbR1RLXSBWb2x1bWUg YmFyIGlzIGJyb2tlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNCYXNlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YWNvbnRyb2xzL21lZGlhQ29udHJvbHNCYXNlLmpzCmluZGV4IDhiMjEzM2I5NzgyMTc0YTViODZk NzcwNjA1NjM2NDZkNjBhYzZkZDkuLjg5Mjg2N2VmMjQxODcxMDA4ZWZjNmU4NGVjYWE5ZGYwOWQ5 MGVjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzQmFzZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u dHJvbHMvbWVkaWFDb250cm9sc0Jhc2UuanMKQEAgLTEwMjMsNyArMTAyMyw5IEBAIENvbnRyb2xs ZXIucHJvdG90eXBlID0gewogCiAgICAgY29udHJvbHNBcmVIaWRkZW46IGZ1bmN0aW9uKCkKICAg ICB7Ci0gICAgICAgIHJldHVybiAhdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QuY29udGFp bnModGhpcy5DbGFzc05hbWVzLnNob3cpIHx8IHRoaXMuY29udHJvbHMucGFuZWwuY2xhc3NMaXN0 LmNvbnRhaW5zKHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pOworICAgICAgICB2YXIgcGFuZWwgPSB0 aGlzLmNvbnRyb2xzLnBhbmVsOworICAgICAgICByZXR1cm4gKCFwYW5lbC5jbGFzc0xpc3QuY29u dGFpbnModGhpcy5DbGFzc05hbWVzLnNob3cpIHx8IHBhbmVsLmNsYXNzTGlzdC5jb250YWlucyh0 aGlzLkNsYXNzTmFtZXMuaGlkZGVuKSkKKyAgICAgICAgICAgICYmIChwYXJzZUZsb2F0KHdpbmRv dy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKS5vcGFjaXR5KSA9PT0gMCk7CiAgICAgfSwKIAogICAg IHJlbW92ZUNvbnRyb2xzOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjQyNTQ0MjI0MmYwZWQ3ZDY2MzRj MDFiZjNlZDBhMmM5YWJkYmI1Yy4uMDU1YjMzMDE2YjkxYTBiYTYyZjUyYzliZGYwNjI2ZGIxYmM2 NWI3YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTE0ICBDaGFuZ1Nlb2sgT2ggIDxj aGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSB0aW1lbGluZSBpcyBu b3QgdXBkYXRlZCBhZnRlciBmZXcgc2Vjb25kcyB3aGVuIG1vdXNlIGhvdmVycyBvbiBjb250cm9s cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MTEx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRp YS9tZWRpYS1jb250cm9scy10aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL21lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLXVwZGF0 ZXMtd2hlbi1ob3ZlcmVkLmh0bWw6IEFkZGVkLgorCiAyMDE1LTA5LTEwICBDaGFuZ1Nlb2sgT2gg IDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBbR1RLXSBWb2x1bWUgYmFy IGlzIGJyb2tlbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtY29udHJvbHMt dGltZWxpbmUtdXBkYXRlcy13aGVuLWhvdmVyZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv bWVkaWEvbWVkaWEtY29udHJvbHMtdGltZWxpbmUtdXBkYXRlcy13aGVuLWhvdmVyZWQtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjhhMDM3NmNkMmQ0NjVmNjk2MWVhZDM5MTg1MmY0NGNiNzNiMjk1 NGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9scy10 aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBA QAorVGhpcyB0ZXN0cyBpZiBtZWRpYSBjb250cm9scyB0aW1lbGluZSBpcyBwcm9wZXJseSB1cGRh dGVkIHdoZW4gYSBjdXJzb3IgaG92ZXJzIHRoZSBjb250cm9scyBkdXJpbmcgcGxheWJhY2suCisK KworRVZFTlQoY2FucGxheXRocm91Z2gpCitFWFBFQ1RFRCAodGltZUxpbmVWYWx1ZSgpID09ICcw JykgT0sKK1JVTih2aWRlby5wbGF5KCkpCitFVkVOVChwbGF5KQorRVZFTlQodGltZXVwZGF0ZSkK K1RFU1QodGltZUxpbmVWYWx1ZSgpID4gMSkgT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL21lZGlhL21lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLXVwZGF0ZXMtd2hlbi1o b3ZlcmVkLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9scy10aW1lbGluZS11 cGRhdGVzLXdoZW4taG92ZXJlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVkNTkzMjIyNWQyNDI0NDBiYTA5 YmQ5OGUyMWZjMTYwN2VjMmRiYTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRp YS9tZWRpYS1jb250cm9scy10aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC5odG1sCkBAIC0w LDAgKzEsNTMgQEAKKzwhRE9DVFlQRSBodG1sPgorPHA+VGhpcyB0ZXN0cyBpZiBtZWRpYSBjb250 cm9scyB0aW1lbGluZSBpcyBwcm9wZXJseSB1cGRhdGVkIHdoZW4gYSBjdXJzb3IgaG92ZXJzIHRo ZSBjb250cm9scyBkdXJpbmcgcGxheWJhY2suPC9wPgorPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+ Cis8c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9dmlkZW8t dGVzdC5qcz48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPW1lZGlhLWNvbnRyb2xzLmpzPjwvc2NyaXB0 PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRpbWVMaW5lVmFsdWUoKQoreworICAgIHZhciB0aW1lbGlu ZSA9IG1lZGlhQ29udHJvbHNFbGVtZW50KGludGVybmFscy5zaGFkb3dSb290KHZpZGVvKS5maXJz dENoaWxkLmZpcnN0Q2hpbGQsICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lJyk7Cisg ICAgaWYgKCF0aW1lbGluZSkKKyAgICAgICAgdGhyb3cgIkZhaWxlZCB0byBmaW5kIC13ZWJraXQt bWVkaWEtY29udHJvbHMtdGltZWxpbmUiOworCisgICAgcmV0dXJuIHRpbWVsaW5lLnZhbHVlOwor fQorCitmdW5jdGlvbiBjYW5wbGF5dGhyb3VnaCgpCit7CisgICAgaWYgKCF3aW5kb3cudGVzdFJ1 bm5lcikgeworICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAg ICB0ZXN0RXhwZWN0ZWQoInRpbWVMaW5lVmFsdWUoKSIsIDApOworCisgICAgdmFyIHBsYXlCdXR0 b25Db29yZHM7CisgICAgdHJ5IHsKKyAgICAgICAgcGxheUJ1dHRvbkNvb3JkcyA9IG1lZGlhQ29u dHJvbHNCdXR0b25Db29yZGluYXRlcyh2aWRlbywgInBsYXktYnV0dG9uIik7CisgICAgfSBjYXRj aCAoZXhjZXB0aW9uKSB7CisgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhwbGF5QnV0dG9uQ29vcmRzWzBdLCBwbGF5 QnV0dG9uQ29vcmRzWzFdKTsKKworICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoInRpbWV1cGRh dGUiLCBmdW5jdGlvbigpIHsKKyAgICAgICAgIGlmICh2aWRlby5jdXJyZW50VGltZSA+IDEuMCkg eworICAgICAgICAgICAgY29uc29sZVdyaXRlKCJFVkVOVCh0aW1ldXBkYXRlKSIpOworICAgICAg ICAgICAgdGVzdCgidGltZUxpbmVWYWx1ZSgpID4gMSIpOworICAgICAgICAgICAgZW5kVGVzdCgp OworICAgICAgICAgfQorICAgIH0pOworCisgICAgcnVuKCJ2aWRlby5wbGF5KCkiKTsKK30KKwor dmFyIHZpZGVvOworZmluZE1lZGlhRWxlbWVudCgpOwordmlkZW8uc3JjID0gZmluZE1lZGlhRmls ZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7CisKK3dhaXRGb3JFdmVudCgiY2FucGxheXRocm91 Z2giLCBjYW5wbGF5dGhyb3VnaCk7Cit3YWl0Rm9yRXZlbnQoInBsYXkiKTsKK3dhaXRGb3JFdmVu dEFuZEZhaWwoImVycm9yIik7Cis8L3NjcmlwdD4K 261311 2015-09-16 09:10:34 -0700 2015-09-21 01:37:44 -0700 Patch bug-149111-20150917011022.patch text/plain 5427 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNjZmFhYjA0ODE4MDg1 MjZmYzA3ODE0NWRiMTE0MDY2YWI1Nzc1MC4uMjdlZTZlOTE3NjM2MzU3YTAzNTlkNzAyOGUwMzg3 NGI5OTQxMWM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSB0 aW1lbGluZSBpcyBub3QgdXBkYXRlZCBhZnRlciBmZXcgc2Vjb25kcyB3aGVuIG1vdXNlIGhvdmVy cyBvbiBjb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ5MTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGltZWxpbmUgaXMgbm90IHVwZGF0ZWQgaWYgY29udHJvbHNBcmVIaWRkZW4gaXMgdHJ1 ZS4gVGhlIHByb2JsZW0gaGVyZSBpcyB0aGF0CisgICAgICAgIHRoZSBmdW5jdGlvbiBkb2VzIG5v dCBtZWFuIGFjdHVhbGx5ICdoaWRkZW4nIHNpbmNlIGl0IG9ubHkgY2hlY2tlcyAnc2hvdycgYW5k ICdoaWRkZW4nCisgICAgICAgIGNsYXNzIGV4aXN0ZW5jZXMuIFRoZSBwYW5lbCdzIHZpc2liaWxp dHkgYXJlIG5vdCBvbmx5IGNvbnRyb2xsZWQgYnkgdGhlIHR3byBjbGFzc2VzLAorICAgICAgICBi dXQgYWxzbyBieSB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbDpob3Zlci4gVGhl IHBhbmVsIGNvdWxkIGJlIHZpc2libGUKKyAgICAgICAgYnkgc2V0dGluZyB0aGUgcHNldWRvIGhv dmVyIGNsYXNzLiBTbyB3ZSBuZWVkIHRvIGNoZWNrIGlmIHBhbmVsIGlzIGhvdmVyZWQgYXMgd2Vs bCBpbiBjb250cm9sc0FyZUhpZGRlbigpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL21lZGlhLWNv bnRyb2xzLXRpbWVsaW5lLXVwZGF0ZXMtd2hlbi1ob3ZlcmVkLmh0bWwKKworICAgICAgICAqIE1v ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQmFzZS5qczoKKyAgICAgICAgKENvbnRy b2xsZXIucHJvdG90eXBlLmNvbnRyb2xzQXJlSGlkZGVuKToKKwogMjAxNS0wOS0xNCAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gUmVtb3Zl IGNyZWF0ZSgpIGZhY3RvcnkgZnVuY3Rpb24gaW4gRXZhc0dMQ29udGV4dCBhbmQgRXZhc0dMU3Vy ZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNCYXNlLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNCYXNlLmpzCmluZGV4IDhiMjEzM2I5NzgyMTc0YTViODZkNzcwNjA1NjM2 NDZkNjBhYzZkZDkuLmE0NGMzZDEwMTEwZjIwOTQ4NzJjYmI1OWViYTNmZWNmN2NiMWVjMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy b2xzQmFzZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVk aWFDb250cm9sc0Jhc2UuanMKQEAgLTEwMjMsNyArMTAyMyw5IEBAIENvbnRyb2xsZXIucHJvdG90 eXBlID0gewogCiAgICAgY29udHJvbHNBcmVIaWRkZW46IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAg ICAgIHJldHVybiAhdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QuY29udGFpbnModGhpcy5D bGFzc05hbWVzLnNob3cpIHx8IHRoaXMuY29udHJvbHMucGFuZWwuY2xhc3NMaXN0LmNvbnRhaW5z KHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pOworICAgICAgICB2YXIgcGFuZWwgPSB0aGlzLmNvbnRy b2xzLnBhbmVsOworICAgICAgICByZXR1cm4gKCFwYW5lbC5jbGFzc0xpc3QuY29udGFpbnModGhp cy5DbGFzc05hbWVzLnNob3cpIHx8IHBhbmVsLmNsYXNzTGlzdC5jb250YWlucyh0aGlzLkNsYXNz TmFtZXMuaGlkZGVuKSkKKyAgICAgICAgICAgICYmIChwYW5lbC5wYXJlbnRFbGVtZW50LnF1ZXJ5 U2VsZWN0b3IoJzpob3ZlcicpICE9PSBwYW5lbCk7CiAgICAgfSwKIAogICAgIHJlbW92ZUNvbnRy b2xzOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FiN2U2ZjBlMThkNTE1MjU1ZmVhZGQzNTE1OThlNDk5 ZWQzNTljZC4uM2JmODk5OGMwY2Q3MGQyMmM5NDhmN2Y2N2JkYzUwOWMyZDAwOWI2MyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTE2ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hA Y29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSB0aW1lbGluZSBpcyBub3QgdXBkYXRlZCBh ZnRlciBmZXcgc2Vjb25kcyB3aGVuIG1vdXNlIGhvdmVycyBvbiBjb250cm9scworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MTExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRpYS9tZWRpYS1jb250 cm9scy10aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIG1lZGlhL21lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLXVwZGF0ZXMtd2hlbi1ob3Zl cmVkLmh0bWw6IEFkZGVkLgorCiAyMDE1LTA5LTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmViYXNlbGluZSBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2ludGVyZmFjZXMuaHRtbCBvbiBpT1MuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9scy10aW1lbGluZS11cGRhdGVzLXdo ZW4taG92ZXJlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9s cy10aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZWZkMWYyYWM2NTk0NzUxNzgzZTI4YjU4YjY2ZTU3YjI2ZGFjNzhhYwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLXVwZGF0ZXMtd2hl bi1ob3ZlcmVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUaGlzIHRlc3RzIGlmIG1l ZGlhIGNvbnRyb2xzIHRpbWVsaW5lIGlzIHByb3Blcmx5IHVwZGF0ZWQgd2hlbiBhIGN1cnNvciBo b3ZlcnMgdGhlIGNvbnRyb2xzIGR1cmluZyBwbGF5YmFjay4KKworCitFVkVOVChjYW5wbGF5dGhy b3VnaCkKK0VYUEVDVEVEICh0aW1lTGluZVZhbHVlKCkgPT0gJzAnKSBPSworUlVOKHZpZGVvLnBs YXkoKSkKK0VWRU5UKHBsYXkpCitFVkVOVCh0aW1ldXBkYXRlKQorVEVTVCh0aW1lTGluZVZhbHVl KCkgPj0gMSkgT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlh L21lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLXVwZGF0ZXMtd2hlbi1ob3ZlcmVkLmh0bWwgYi9MYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9scy10aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJl ZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjBkMGU1YTQ4ZDc2YjEwMDZjMjZhNTI3NjQyMjc1MGM5MDIyN2U4 OTIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1jb250cm9scy10 aW1lbGluZS11cGRhdGVzLXdoZW4taG92ZXJlZC5odG1sCkBAIC0wLDAgKzEsNTMgQEAKKzwhRE9D VFlQRSBodG1sPgorPHA+VGhpcyB0ZXN0cyBpZiBtZWRpYSBjb250cm9scyB0aW1lbGluZSBpcyBw cm9wZXJseSB1cGRhdGVkIHdoZW4gYSBjdXJzb3IgaG92ZXJzIHRoZSBjb250cm9scyBkdXJpbmcg cGxheWJhY2suPC9wPgorPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+Cis8c2NyaXB0IHNyYz1tZWRp YS1maWxlLmpzPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPW1lZGlhLWNvbnRyb2xzLmpzPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0 aW9uIHRpbWVMaW5lVmFsdWUoKQoreworICAgIHZhciB0aW1lbGluZSA9IG1lZGlhQ29udHJvbHNF bGVtZW50KGludGVybmFscy5zaGFkb3dSb290KHZpZGVvKS5maXJzdENoaWxkLmZpcnN0Q2hpbGQs ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lJyk7CisgICAgaWYgKCF0aW1lbGluZSkK KyAgICAgICAgdGhyb3cgIkZhaWxlZCB0byBmaW5kIC13ZWJraXQtbWVkaWEtY29udHJvbHMtdGlt ZWxpbmUiOworCisgICAgcmV0dXJuIHRpbWVsaW5lLnZhbHVlOworfQorCitmdW5jdGlvbiBjYW5w bGF5dGhyb3VnaCgpCit7CisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICBl bmRUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICB0ZXN0RXhwZWN0ZWQoInRp bWVMaW5lVmFsdWUoKSIsIDApOworCisgICAgdmFyIHBsYXlCdXR0b25Db29yZHM7CisgICAgdHJ5 IHsKKyAgICAgICAgcGxheUJ1dHRvbkNvb3JkcyA9IG1lZGlhQ29udHJvbHNCdXR0b25Db29yZGlu YXRlcyh2aWRlbywgInBsYXktYnV0dG9uIik7CisgICAgfSBjYXRjaCAoZXhjZXB0aW9uKSB7Cisg ICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbyhwbGF5QnV0dG9uQ29vcmRzWzBdLCBwbGF5QnV0dG9uQ29vcmRzWzFdKTsK KworICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoInRpbWV1cGRhdGUiLCBmdW5jdGlvbigpIHsK KyAgICAgICAgIGlmICh2aWRlby5jdXJyZW50VGltZSA+PSAxKSB7CisgICAgICAgICAgICBjb25z b2xlV3JpdGUoIkVWRU5UKHRpbWV1cGRhdGUpIik7CisgICAgICAgICAgICB0ZXN0KCJ0aW1lTGlu ZVZhbHVlKCkgPj0gMSIpOworICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICAgfQorICAg IH0pOworCisgICAgcnVuKCJ2aWRlby5wbGF5KCkiKTsKK30KKwordmFyIHZpZGVvOworZmluZE1l ZGlhRWxlbWVudCgpOwordmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVu dC90ZXN0Iik7CisKK3dhaXRGb3JFdmVudCgiY2FucGxheXRocm91Z2giLCBjYW5wbGF5dGhyb3Vn aCk7Cit3YWl0Rm9yRXZlbnQoInBsYXkiKTsKK3dhaXRGb3JFdmVudEFuZEZhaWwoImVycm9yIik7 Cis8L3NjcmlwdD4K