149088 2015-09-11 21:42:41 -0700 Web Inspector: Move Already Generic Inspector Page Context Menu to Generic Setup 2015-09-12 11:31:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1125343 0 joepeck 2015-09-11 21:42:41 -0700 * SUMMARY Move Already Generic Inspector Page Context Menu to Generic Setup. This is not Mac specific, it can be shared with all other ports. 1125345 1 261043 joepeck 2015-09-11 21:44:33 -0700 Created attachment 261043 [PATCH] Proposed Fix 1125388 2 261043 bburg 2015-09-12 10:44:02 -0700 Comment on attachment 261043 [PATCH] Proposed Fix r=me 1125394 3 261043 commit-queue 2015-09-12 11:31:33 -0700 Comment on attachment 261043 [PATCH] Proposed Fix Clearing flags on attachment: 261043 Committed r189655: <http://trac.webkit.org/changeset/189655> 1125395 4 commit-queue 2015-09-12 11:31:37 -0700 All reviewed patches have been landed. Closing bug. 261043 2015-09-11 21:44:33 -0700 2015-09-12 11:31:33 -0700 [PATCH] Proposed Fix better.patch text/plain 6127 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNDNkN2YyLi5jMWI2NDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDktMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBNb3ZlIEFscmVhZHkgR2VuZXJpYyBJbnNwZWN0b3IgUGFn ZSBDb250ZXh0IE1lbnUgdG8gR2VuZXJpYyBTZXR1cAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpnZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1lbnUpOgorICAg ICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6ZWFnZXJseUNyZWF0ZUluc3BlY3RvclBh Z2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06Cisg ICAgICAgIChXZWJLaXQ6OmdldENvbnRleHRNZW51RnJvbVByb3Bvc2VkTWVudSk6IERlbGV0ZWQu CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUluc3Bl Y3RvclBhZ2UpOgorCiAyMDE1LTA5LTExICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4K IAogICAgICAgICBBbm90aGVyIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCmluZGV4IGQ5ZjMyNTEuLjY1YWFhNTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcApAQCAtMjksNiAr MjksOSBAQAogCiAjaW5jbHVkZSAiQVBJUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmgiCiAjaW5j bHVkZSAiQVBJVVJMUmVxdWVzdC5oIgorI2luY2x1ZGUgIldLQXJyYXkuaCIKKyNpbmNsdWRlICJX S0NvbnRleHRNZW51SXRlbS5oIgorI2luY2x1ZGUgIldLTXV0YWJsZUFycmF5LmgiCiAjaW5jbHVk ZSAiV2ViRnJhbWVQb2xpY3lMaXN0ZW5lclByb3h5LmgiCiAjaW5jbHVkZSAiV2ViRnJhbWVQcm94 eS5oIgogI2luY2x1ZGUgIldlYkluc3BlY3Rvck1lc3NhZ2VzLmgiCkBAIC0zODIsNiArMzg1LDMw IEBAIHN0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV0tQYWdlUmVm LCBXS0ZyYW1lUmVmIGZyYW1lUmVmLCBXS0ZyCiAgICAgd2ViSW5zcGVjdG9yUHJveHktPmluc3Bl Y3RlZFBhZ2UoKS0+bG9hZFJlcXVlc3QodG9JbXBsKHJlcXVlc3RSZWYpLT5yZXNvdXJjZVJlcXVl c3QoKSk7CiB9CiAKK3N0YXRpYyB2b2lkIGdldENvbnRleHRNZW51RnJvbVByb3Bvc2VkTWVudShX S1BhZ2VSZWYgcGFnZVJlZiwgV0tBcnJheVJlZiBwcm9wb3NlZE1lbnVSZWYsIFdLQXJyYXlSZWYq IG5ld01lbnVSZWYsIFdLSGl0VGVzdFJlc3VsdFJlZiwgV0tUeXBlUmVmLCBjb25zdCB2b2lkKikK K3sKKyAgICBXS011dGFibGVBcnJheVJlZiBtZW51SXRlbXMgPSBXS011dGFibGVBcnJheUNyZWF0 ZSgpOworCisgICAgc2l6ZV90IGNvdW50ID0gV0tBcnJheUdldFNpemUocHJvcG9zZWRNZW51UmVm KTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKKyAgICAgICAgV0tD b250ZXh0TWVudUl0ZW1SZWYgY29udGV4dE1lbnVJdGVtID0gc3RhdGljX2Nhc3Q8V0tDb250ZXh0 TWVudUl0ZW1SZWY+KFdLQXJyYXlHZXRJdGVtQXRJbmRleChwcm9wb3NlZE1lbnVSZWYsIGkpKTsK KyAgICAgICAgc3dpdGNoIChXS0NvbnRleHRNZW51SXRlbUdldFRhZyhjb250ZXh0TWVudUl0ZW0p KSB7CisgICAgICAgIGNhc2Uga1dLQ29udGV4dE1lbnVJdGVtVGFnT3BlbkxpbmtJbk5ld1dpbmRv dzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuSW1hZ2VJbk5ld1dpbmRv dzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuRnJhbWVJbk5ld1dpbmRv dzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuTWVkaWFJbk5ld1dpbmRv dzoKKyAgICAgICAgY2FzZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdEb3dubG9hZExpbmtUb0Rpc2s6 CisgICAgICAgIGNhc2Uga1dLQ29udGV4dE1lbnVJdGVtVGFnRG93bmxvYWRJbWFnZVRvRGlzazoK KyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgV0tBcnJh eUFwcGVuZEl0ZW0obWVudUl0ZW1zLCBjb250ZXh0TWVudUl0ZW0pOworICAgICAgICAgICAgYnJl YWs7CisgICAgICAgIH0KKyAgICB9CisKKyAgICAqbmV3TWVudVJlZiA9IG1lbnVJdGVtczsKK30K KwogI2lmIEVOQUJMRShJTlNQRUNUT1JfU0VSVkVSKQogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 ZW5hYmxlUmVtb3RlSW5zcGVjdGlvbigpCiB7CkBAIC00NzAsOCArNDk3LDE5IEBAIHZvaWQgV2Vi SW5zcGVjdG9yUHJveHk6OmVhZ2VybHlDcmVhdGVJbnNwZWN0b3JQYWdlKCkKICAgICAgICAgbnVs bHB0ciwgLy8gc2hvdWxkS2VlcEN1cnJlbnRCYWNrRm9yd2FyZExpc3RJdGVtSW5MaXN0CiAgICAg fTsKIAorICAgIFdLUGFnZUNvbnRleHRNZW51Q2xpZW50VjMgY29udGV4dE1lbnVDbGllbnQgPSB7 CisgICAgICAgIHsgMywgdGhpcyB9LAorICAgICAgICAwLCAvLyBnZXRDb250ZXh0TWVudUZyb21Q cm9wb3NlZE1lbnVfZGVwcmVjYXRlZEZvclVzZVdpdGhWMAorICAgICAgICAwLCAvLyBjdXN0b21D b250ZXh0TWVudUl0ZW1TZWxlY3RlZAorICAgICAgICAwLCAvLyBjb250ZXh0TWVudURpc21pc3Nl ZAorICAgICAgICBnZXRDb250ZXh0TWVudUZyb21Qcm9wb3NlZE1lbnUsCisgICAgICAgIDAsIC8v IHNob3dDb250ZXh0TWVudQorICAgICAgICAwLCAvLyBoaWRlQ29udGV4dE1lbnUKKyAgICB9Owor CiAgICAgV0tQYWdlU2V0UGFnZVBvbGljeUNsaWVudCh0b0FQSShtX2luc3BlY3RvclBhZ2UpLCAm cG9saWN5Q2xpZW50LmJhc2UpOwogICAgIFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQodG9BUEko bV9pbnNwZWN0b3JQYWdlKSwgJmxvYWRlckNsaWVudC5iYXNlKTsKKyAgICBXS1BhZ2VTZXRQYWdl Q29udGV4dE1lbnVDbGllbnQodG9BUEkobV9pbnNwZWN0b3JQYWdlKSwgJmNvbnRleHRNZW51Q2xp ZW50LmJhc2UpOwogCiAgICAgbV9pbnNwZWN0b3JQYWdlLT5wcm9jZXNzKCkuYWRkTWVzc2FnZVJl Y2VpdmVyKE1lc3NhZ2VzOjpXZWJJbnNwZWN0b3JQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgp LCBtX2luc3BlY3RlZFBhZ2UtPnBhZ2VJRCgpLCAqdGhpcyk7CiAgICAgbV9pbnNwZWN0b3JQYWdl LT5wcm9jZXNzKCkuYXNzdW1lUmVhZEFjY2Vzc1RvQmFzZVVSTChXZWJJbnNwZWN0b3JQcm94eTo6 aW5zcGVjdG9yQmFzZVVSTCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCmluZGV4IDE5YmFiNTkuLmZmOTBhYWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMu bW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1h Yy5tbQpAQCAtMjksOCArMjksNiBAQAogI2lmIFBMQVRGT1JNKE1BQykgJiYgV0tfQVBJX0VOQUJM RUQKIAogI2ltcG9ydCAiV0tBUElDYXN0LmgiCi0jaW1wb3J0ICJXS0FycmF5LmgiCi0jaW1wb3J0 ICJXS0NvbnRleHRNZW51SXRlbS5oIgogI2ltcG9ydCAiV0tJbnNwZWN0b3JQcml2YXRlTWFjLmgi CiAjaW1wb3J0ICJXS011dGFibGVBcnJheS5oIgogI2ltcG9ydCAiV0tPcGVuUGFuZWxQYXJhbWV0 ZXJzLmgiCkBAIC0yMzUsMzAgKzIzMyw2IEBAIHN0YXRpYyB2b2lkIHJ1bk9wZW5QYW5lbChXS1Bh Z2VSZWYgcGFnZSwgV0tGcmFtZVJlZiBmcmFtZSwgV0tPcGVuUGFuZWxQYXJhbWV0ZXJzCiAgICAg ICAgIGNvbXBsZXRpb25IYW5kbGVyKFtvcGVuUGFuZWwgcnVuTW9kYWxdKTsKIH0KIAotc3RhdGlj IHZvaWQgZ2V0Q29udGV4dE1lbnVGcm9tUHJvcG9zZWRNZW51KFdLUGFnZVJlZiBwYWdlUmVmLCBX S0FycmF5UmVmIHByb3Bvc2VkTWVudVJlZiwgV0tBcnJheVJlZiogbmV3TWVudVJlZiwgV0tIaXRU ZXN0UmVzdWx0UmVmLCBXS1R5cGVSZWYsIGNvbnN0IHZvaWQqKQotewotICAgIFdLTXV0YWJsZUFy cmF5UmVmIG1lbnVJdGVtcyA9IFdLTXV0YWJsZUFycmF5Q3JlYXRlKCk7Ci0KLSAgICBzaXplX3Qg Y291bnQgPSBXS0FycmF5R2V0U2l6ZShwcm9wb3NlZE1lbnVSZWYpOwotICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgewotICAgICAgICBXS0NvbnRleHRNZW51SXRlbVJlZiBj b250ZXh0TWVudUl0ZW0gPSBzdGF0aWNfY2FzdDxXS0NvbnRleHRNZW51SXRlbVJlZj4oV0tBcnJh eUdldEl0ZW1BdEluZGV4KHByb3Bvc2VkTWVudVJlZiwgaSkpOwotICAgICAgICBzd2l0Y2ggKFdL Q29udGV4dE1lbnVJdGVtR2V0VGFnKGNvbnRleHRNZW51SXRlbSkpIHsKLSAgICAgICAgY2FzZSBr V0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuTGlua0luTmV3V2luZG93OgotICAgICAgICBjYXNlIGtX S0NvbnRleHRNZW51SXRlbVRhZ09wZW5JbWFnZUluTmV3V2luZG93OgotICAgICAgICBjYXNlIGtX S0NvbnRleHRNZW51SXRlbVRhZ09wZW5GcmFtZUluTmV3V2luZG93OgotICAgICAgICBjYXNlIGtX S0NvbnRleHRNZW51SXRlbVRhZ09wZW5NZWRpYUluTmV3V2luZG93OgotICAgICAgICBjYXNlIGtX S0NvbnRleHRNZW51SXRlbVRhZ0Rvd25sb2FkTGlua1RvRGlzazoKLSAgICAgICAgY2FzZSBrV0tD b250ZXh0TWVudUl0ZW1UYWdEb3dubG9hZEltYWdlVG9EaXNrOgotICAgICAgICAgICAgYnJlYWs7 Ci0gICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBXS0FycmF5QXBwZW5kSXRlbShtZW51SXRl bXMsIGNvbnRleHRNZW51SXRlbSk7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAg IH0KLQotICAgICpuZXdNZW51UmVmID0gbWVudUl0ZW1zOwotfQotCiB2b2lkIFdlYkluc3BlY3Rv clByb3h5OjphdHRhY2htZW50Vmlld0RpZENoYW5nZShOU1ZpZXcgKm9sZFZpZXcsIE5TVmlldyAq bmV3VmlldykKIHsKICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJl bW92ZU9ic2VydmVyOm1faW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlci5nZXQoKSBuYW1lOk5TVmll d0ZyYW1lRGlkQ2hhbmdlTm90aWZpY2F0aW9uIG9iamVjdDpvbGRWaWV3XTsKQEAgLTQ4NSwxOCAr NDU5LDYgQEAgV2ViUGFnZVByb3h5KiBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJ bnNwZWN0b3JQYWdlKCkKIAogICAgIFdLUGFnZVNldFBhZ2VVSUNsaWVudCh0b0FQSShpbnNwZWN0 b3JQYWdlKSwgJnVpQ2xpZW50LmJhc2UpOwogCi0gICAgV0tQYWdlQ29udGV4dE1lbnVDbGllbnRW MyBjb250ZXh0TWVudUNsaWVudCA9IHsKLSAgICAgICAgeyAzLCB0aGlzIH0sCi0gICAgICAgIDAs IC8vIGdldENvbnRleHRNZW51RnJvbVByb3Bvc2VkTWVudV9kZXByZWNhdGVkRm9yVXNlV2l0aFYw Ci0gICAgICAgIDAsIC8vIGN1c3RvbUNvbnRleHRNZW51SXRlbVNlbGVjdGVkCi0gICAgICAgIDAs IC8vIGNvbnRleHRNZW51RGlzbWlzc2VkCi0gICAgICAgIGdldENvbnRleHRNZW51RnJvbVByb3Bv c2VkTWVudSwKLSAgICAgICAgMCwgLy8gc2hvd0NvbnRleHRNZW51Ci0gICAgICAgIDAsIC8vIGhp ZGVDb250ZXh0TWVudQotICAgIH07Ci0KLSAgICBXS1BhZ2VTZXRQYWdlQ29udGV4dE1lbnVDbGll bnQodG9BUEkoaW5zcGVjdG9yUGFnZSksICZjb250ZXh0TWVudUNsaWVudC5iYXNlKTsKLQogICAg IHJldHVybiBpbnNwZWN0b3JQYWdlOwogfQogCg==