149086 2015-09-11 21:22:05 -0700 Whitespace underlines are not repainted on color changes 2024-01-16 17:33:30 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pdr mmaxfield ahmad.saleem792 bfulgham fujii karlcow kling mmaxfield webkit-bug-importer oldest_to_newest 1125339 0 261042 pdr 2015-09-11 21:22:05 -0700 Created attachment 261042 Repro for webkit wkrev.com/150259 introduced a small regression where text decorations such as underlines are not repainted for whitespace text. A user recently reported this against Chrome and I had merged the above patch a few years ago so we shared this bug. I fixed this by removing the whitespace check which keeps the original optimization but causes whitespace runs to be repainted. My fix landed in https://src.chromium.org/viewvc/blink?revision=202164&view=revision and a similar fix would work in WebKit too. 1125448 1 mmaxfield 2015-09-12 21:13:56 -0700 This repro is fantastic, thank you! 1883825 2 bfulgham 2022-07-14 14:44:40 -0700 WebKit still gets this wrong, 7 years later. 1883826 3 webkit-bug-importer 2022-07-14 14:44:49 -0700 <rdar://problem/97036299> 1905974 4 ahmad.saleem792 2022-10-16 10:59:44 -0700 I think this change should be here: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/rendering/RenderElement.cpp#L319 Replacing "isAllCollapsibleWhitespace" with equivalent of "isBR". 2005452 5 fujii 2024-01-16 17:27:44 -0800 This is not reproducible with Safari 17.2.1 and STP 186 to me. 2005455 6 ahmad.saleem792 2024-01-16 17:31:55 -0800 (In reply to Fujii Hironori from comment #5) > This is not reproducible with Safari 17.2.1 and STP 186 to me. Yes - I can't reproduce it as well. Might be fixed between 2022 to 2024 now. 2005457 7 fujii 2024-01-16 17:33:30 -0800 Thank you for the confirmation. Closed. 261042 2015-09-11 21:22:05 -0700 2015-09-11 21:22:05 -0700 Repro for webkit webkitminimized.html text/html 876 pdr PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KZGl2IHsKICAgIGRpc3BsYXk6IGJsb2NrOwogICAgd2lk dGg6IDUwMHB4OwogICAgaGVpZ2h0OiAxZW07CiAgICBjb2xvcjogYmx1ZTsKfQpkaXY6aG92ZXIg ewogICAgdGV4dC1kZWNvcmF0aW9uOiB1bmRlcmxpbmU7CiAgICBjb2xvcjogcmVkOwp9Cjwvc3R5 bGU+CjxzY3JpcHQ+Ci8vIFRoaXMgcmVwYWludCBsb2dpYyBpc24ndCByZXF1aXJlZCwganVzdCBt YWtlcyB0aGUgYnVnIGVhc2llciB0byBzZWUuIFlvdSBjYW4gYWxzbyBzZWxlY3QgdG8gZm9yY2Ug YSByZXBhaW50Lgp2YXIgYmdFdmVuT2RkID0gZmFsc2U7CmZ1bmN0aW9uIGZvcmNlUmVwYWludCgp IHsKICAgIHdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUoZnVuY3Rpb24oKSB7CiAgICAgICAg YmdFdmVuT2RkID0gIWJnRXZlbk9kZDsKICAgICAgICB2YXIgZGl2ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2RpdicpOwogICAgICAgIGRpdi5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSBiZ0V2 ZW5PZGQgPyAnI2ZmZmZmZicgOiAnI2ZlZmVmZSc7CiAgICB9KTsKfQo8L3NjcmlwdD4KPGRpdiBp ZD0iZGl2IiBvbm1vdXNlZW50ZXI9ImZvcmNlUmVwYWludCgpIj4KPHNwYW4+V2hlbjwvc3Bhbj4g PHNwYW4+dW4taG92ZXJlZCw8L3NwYW4+IDxzcGFuPnRoZXJlPC9zcGFuPiA8c3Bhbj5zaG91bGQ8 L3NwYW4+IDxzcGFuPmJlPC9zcGFuPiA8c3Bhbj5ubzwvc3Bhbj4gPHNwYW4+bGVmdG92ZXI8L3Nw YW4+IDxzcGFuPnVuZGVybGluZXMuPC9zcGFuPgo8c3Bhbj4mbmJzcDs8L3NwYW4+IDxzcGFuPiZu YnNwOzwvc3Bhbj4gPHNwYW4+Jm5ic3A7PC9zcGFuPiA8c3Bhbj4mbmJzcDs8L3NwYW4+IDxzcGFu PiZuYnNwOzwvc3Bhbj4KPC9kaXY+