149083 2015-09-11 16:58:36 -0700 LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor 2015-09-11 17:16:00 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff ap oldest_to_newest 1125304 0 msaboff 2015-09-11 16:58:36 -0700 You get a crash at * thread #1: tid = 0x3bafd6, 0x00007fff8df47f26 CoreFoundation`CFDictionaryGetValue + 38, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) frame #0: 0x00007fff8df47f26 CoreFoundation`CFDictionaryGetValue + 38 CoreFoundation`CFDictionaryGetValue: -> 0x7fff8df47f26 <+38>: movq (%rbx), %rax 0x7fff8df47f29 <+41>: testq %rax, %rax 0x7fff8df47f2c <+44>: je 0x7fff8df47f6e ; <+110> 0x7fff8df47f2e <+46>: leaq -0x14889efd(%rip), %rcx ; __CFConstantStringClassReferencePtr bt frame #0: 0x00007fff8df47f26 CoreFoundation`CFDictionaryGetValue + 38 frame #1: 0x000000010000152f LayoutTestHelper`main + 157 at LayoutTestHelper.m:73 frame #1: 0x0000000100001492 LayoutTestHelper`main + 259 at LayoutTestHelper.m:123 frame #2: 0x000000010000138f LayoutTestHelper`main [inlined] installLayoutTestColorProfile + 21 at LayoutTestHelper.m:167 frame #3: 0x000000010000137a LayoutTestHelper`main(argc=<unavailable>, argv=<unavailable>) + 176 at LayoutTestHelper.m:256 frame #4: 0x00007fff9a1bb5ad libdyld.dylib`start + 1 From LayoutTestHelper.m::static NSURL *colorProfileURLForDisplay(NSString *displayUUIDString): 66 CFURLRef profileURL; 67 CFDictionaryRef profileInfo = (CFDictionaryRef)CFDictionaryGetValue(deviceInfo, kColorSyncCustomProfiles); 68 if (profileInfo) 69 profileURL = (CFURLRef)CFDictionaryGetValue(profileInfo, CFSTR("1")); 70 else { 71 profileInfo = (CFDictionaryRef)CFDictionaryGetValue(deviceInfo, kColorSyncFactoryProfiles); 72 CFDictionaryRef factoryProfile = (CFDictionaryRef)CFDictionaryGetValue(profileInfo, CFSTR("1")); 73 profileURL = (CFURLRef)CFDictionaryGetValue(factoryProfile, kColorSyncDeviceProfileURL); 74 } 75 It appears that factoryProfile can be nil. 1125309 1 261034 msaboff 2015-09-11 17:02:27 -0700 Created attachment 261034 Patch 1125319 2 msaboff 2015-09-11 17:16:00 -0700 Committed r189639: <http://trac.webkit.org/changeset/189639> 261034 2015-09-11 17:02:27 -0700 2015-09-11 17:05:32 -0700 Patch 149083.patch text/plain 1874 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4OTYzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTA5LTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIExheW91dFRlc3RIZWxwZXIgY3Jhc2hlcyBpZiBhIGNvbG9yIHByb2ZpbGUg aXNuJ3Qgc2V0IGZvciBhIDNyZCBwYXJ0eSBtb25pdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkwODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0byBtYWtlIHN1cmUgdGhhdCB3ZSBoYXZl IGEgdmFsaWQgZmFjdG9yeVByb2ZpbGUgQ0ZEaWN0aW9uYXJ5UmVmIGJlZm9yZSB1c2luZyBpdC4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0SGVscGVyLm06CisgICAg ICAgIChjb2xvclByb2ZpbGVVUkxGb3JEaXNwbGF5KToKKwogMjAxNS0wOS0xMSAgU2FhbSBiYXJh dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBUaGVyZSBzaG91bGQgYmUgYSBkZWZh dWx0U3BvdENoZWNrLWxpa2UgbW9kZSB0aGF0IGRvZXNuJ3QgcnVuIHRoZSBNYXhpbWFsRmx1c2hJ bnNlcnRpb25QaGFzZSBpbiBydW4tanNjLXN0cmVzcy10ZXN0cwpJbmRleDogVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0xheW91dFRlc3RIZWxwZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1w UmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tCShyZXZpc2lvbiAxODk2MjYpCisrKyBU b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tCSh3b3JraW5nIGNvcHkp CkBAIC02MywxNCArNjMsMTUgQEAgc3RhdGljIE5TVVJMICpjb2xvclByb2ZpbGVVUkxGb3JEaXNw bGF5KAogICAgICAgICByZXR1cm4gbmlsOwogICAgIH0KIAotICAgIENGVVJMUmVmIHByb2ZpbGVV Ukw7CisgICAgQ0ZVUkxSZWYgcHJvZmlsZVVSTCA9IG5pbDsKICAgICBDRkRpY3Rpb25hcnlSZWYg cHJvZmlsZUluZm8gPSAoQ0ZEaWN0aW9uYXJ5UmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKGRldmlj ZUluZm8sIGtDb2xvclN5bmNDdXN0b21Qcm9maWxlcyk7CiAgICAgaWYgKHByb2ZpbGVJbmZvKQog ICAgICAgICBwcm9maWxlVVJMID0gKENGVVJMUmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKHByb2Zp bGVJbmZvLCBDRlNUUigiMSIpKTsKICAgICBlbHNlIHsKICAgICAgICAgcHJvZmlsZUluZm8gPSAo Q0ZEaWN0aW9uYXJ5UmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKGRldmljZUluZm8sIGtDb2xvclN5 bmNGYWN0b3J5UHJvZmlsZXMpOwogICAgICAgICBDRkRpY3Rpb25hcnlSZWYgZmFjdG9yeVByb2Zp bGUgPSAoQ0ZEaWN0aW9uYXJ5UmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKHByb2ZpbGVJbmZvLCBD RlNUUigiMSIpKTsKLSAgICAgICAgcHJvZmlsZVVSTCA9IChDRlVSTFJlZilDRkRpY3Rpb25hcnlH ZXRWYWx1ZShmYWN0b3J5UHJvZmlsZSwga0NvbG9yU3luY0RldmljZVByb2ZpbGVVUkwpOworICAg ICAgICBpZiAoZmFjdG9yeVByb2ZpbGUpCisgICAgICAgICAgICBwcm9maWxlVVJMID0gKENGVVJM UmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKGZhY3RvcnlQcm9maWxlLCBrQ29sb3JTeW5jRGV2aWNl UHJvZmlsZVVSTCk7CiAgICAgfQogICAgIAogICAgIGlmICghcHJvZmlsZVVSTCkgewo=