149067 2015-09-11 08:59:29 -0700 FAIL: Tried to install a second TestRunner callback 2015-09-11 12:00:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED MakingBotsRed P2 Normal --- 1 ap thorton thorton oldest_to_newest 1125187 0 ap 2015-09-11 08:59:29 -0700 This new error message is emitted on fast/hidpi/image-set-without-specified-width.html, and possibly on other tests: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&revision=189617&showExpectations=true&tests=fast%2Fhidpi%2Fimage-set-without-specified-width.html 1125230 1 261009 thorton 2015-09-11 11:53:32 -0700 Created attachment 261009 Patch 1125231 2 thorton 2015-09-11 12:00:11 -0700 http://trac.webkit.org/changeset/189626 If there are other tests that get this wrong, the fixes for them will be different. I'm going to try to change WKTR in a way that we can easily find any similar mistakes. 261009 2015-09-11 11:53:32 -0700 2015-09-11 11:55:11 -0700 Patch bug-149067-20150911115325.patch text/plain 2773 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NDk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzEyNGFjNzdlYjA0YjlmNzFkMzQ5 NzAzMGQ5ZDE4YmJjMGMwZjQ4My4uZTQxOTE4MGEwMTkzMjZkOGQzYzdlMTA5MTFlMTE0N2I2N2E1 NjYzNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTExICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvaGlkcGkvaW1hZ2Utc2V0LXdp dGhvdXQtc3BlY2lmaWVkLXdpZHRoLmh0bWwgZmxha2lseSB0cmllcyB0byBpbnN0YWxsIG11bHRp cGxlIGNhbGxiYWNrcyBmb3IgdGhlIHNhbWUgZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTA2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9oaWRwaS9pbWFnZS1zZXQtd2l0aG91dC1z cGVjaWZpZWQtd2lkdGguaHRtbDoKKyAgICAgICAgV2FpdCB1bnRpbCB3ZSd2ZSBzdWNjZXNzZnVs bHkgc2V0IHRoZSBkZXZpY2VTY2FsZUZhY3RvcgorICAgICAgICBiZWZvcmUgcmVsb2FkaW5nIHRo ZSBwYWdlOyBvdGhlcndpc2UsIHdlIGNhbiBlbmQgdXAgdHJ5aW5nIHRvIHNldCBpdAorICAgICAg ICBhZ2FpbiBhZnRlciB0aGUgcmVsb2FkIChhbmQgZGVwZW5kaW5nIG9uIGhvdyBsb25nIGl0IHRh a2VzIHRoZSBjYWxsYmFjaworICAgICAgICB0byByZXR1cm4sIGFnYWluLCBhbmQgYWdhaW4sIGFu ZCBhZ2Fpbi4uLikKKwogMjAxNS0wOS0wOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5j b20+CiAKICAgICAgICAgTWFyayBhbmltYXRpb25zL3RyaWdnZXItY29udGFpbmVyLXNjcm9sbC1i b3VuZGFyaWVzLmh0bWwgYXMgZmFpbHVyZSBvbiBpT1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvaGlkcGkvaW1hZ2Utc2V0LXdpdGhvdXQtc3BlY2lmaWVkLXdpZHRoLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2hpZHBpL2ltYWdlLXNldC13aXRob3V0LXNwZWNpZmllZC13aWR0aC5odG1s CmluZGV4IDhlY2FjNDliZjcwY2U4ZDdhZjY4Mzg0MjBlMDE3OTg1ZWU4MTY1YTMuLjUzNTk5ODcz ZGI5NjljN2VmYmY0YWFmYmQyMjk2ZWM2MjI4MGNiZDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvaGlkcGkvaW1hZ2Utc2V0LXdpdGhvdXQtc3BlY2lmaWVkLXdpZHRoLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9oaWRwaS9pbWFnZS1zZXQtd2l0aG91dC1zcGVjaWZpZWQtd2lkdGgu aHRtbApAQCAtNSwyNSArNSwyMCBAQAogICAgICAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyIHx8 ICF3aW5kb3cuc2Vzc2lvblN0b3JhZ2UpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAg aWYgKCFzZXNzaW9uU3RvcmFnZS5zY2FsZUZhY3RvcklzU2V0KSB7Ci0gICAgICAgICAgICB0ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0QmFja2lu Z1NjYWxlRmFjdG9yKDIsIHNjYWxlRmFjdG9ySXNTZXQpOwotICAgICAgICB9Ci0gICAgICAgIAot ICAgICAgICBpZiAoc2Vzc2lvblN0b3JhZ2UucGFnZVJlbG9hZGVkICYmIHNlc3Npb25TdG9yYWdl LnNjYWxlRmFjdG9ySXNTZXQpIHsKKyAgICAgICAgaWYgKHNlc3Npb25TdG9yYWdlLnBhZ2VSZWxv YWRlZCkgewogICAgICAgICAgICAgZGVsZXRlIHNlc3Npb25TdG9yYWdlLnBhZ2VSZWxvYWRlZDsK LSAgICAgICAgICAgIGRlbGV0ZSBzZXNzaW9uU3RvcmFnZS5zY2FsZUZhY3RvcklzU2V0OwogICAg ICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAg ICAgICAgICAvLyBSaWdodCBub3cgdGhlcmUgaXMgYSBidWcgdGhhdCBpbWFnZS1zZXQgZG9lcyBu b3QgcHJvcGVybHkgZGVhbCB3aXRoIGR5bmFtaWMgY2hhbmdlcyB0byB0aGUgc2NhbGUgZmFjdG9y LAotICAgICAgICAgICAgLy8gc28gdG8gd29yayBhcm91bmQgdGhhdCwgd2UgbXVzdCByZWxvYWQg dGhlIHBhZ2UgdG8gZ2V0IHRoZSAyeCBpbWFnZS4KLSAgICAgICAgICAgIHNlc3Npb25TdG9yYWdl LnBhZ2VSZWxvYWRlZCA9IHRydWU7Ci0gICAgICAgICAgICBkb2N1bWVudC5sb2NhdGlvbi5yZWxv YWQodHJ1ZSk7CisgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAg ICAgICAgIHRlc3RSdW5uZXIuc2V0QmFja2luZ1NjYWxlRmFjdG9yKDIsIHNjYWxlRmFjdG9ySXNT ZXQpOwogICAgICAgICB9CiAgICAgfQogICAgIAogICAgIGZ1bmN0aW9uIHNjYWxlRmFjdG9ySXNT ZXQoKSB7Ci0gICAgICAgIHNlc3Npb25TdG9yYWdlLnNjYWxlRmFjdG9ySXNTZXQgPSB0cnVlOwor ICAgICAgICAvLyBSaWdodCBub3cgdGhlcmUgaXMgYSBidWcgdGhhdCBpbWFnZS1zZXQgZG9lcyBu b3QgcHJvcGVybHkgZGVhbCB3aXRoIGR5bmFtaWMgY2hhbmdlcyB0byB0aGUgc2NhbGUgZmFjdG9y LAorICAgICAgICAvLyBzbyB0byB3b3JrIGFyb3VuZCB0aGF0LCB3ZSBtdXN0IHJlbG9hZCB0aGUg cGFnZSB0byBnZXQgdGhlIDJ4IGltYWdlLgorICAgICAgICBzZXNzaW9uU3RvcmFnZS5wYWdlUmVs b2FkZWQgPSB0cnVlOworICAgICAgICBkb2N1bWVudC5sb2NhdGlvbi5yZWxvYWQodHJ1ZSk7CiAg ICAgfQogCiAgICAgd2luZG93Lm9ubG9hZCA9IHJ1blRlc3Q7Cg==