149063 2015-09-11 05:55:36 -0700 [GTK] [Stable] Build failure at GLContextEGL.cpp on 2.8.5 2019-07-11 06:11:05 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Other Linux RESOLVED FIXED P2 Normal --- 1 clopez clopez bugs-noreply cgarcia commit-queue mario oldest_to_newest 1125170 0 clopez 2015-09-11 05:55:36 -0700 While trying to build WebKitGTK+ 2.8.5 with Yocto/OpenEmbedded (With GLESv2) I get this error: /home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:194:91: error: 'DefaultRootWindow' was not declared in this scope /home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:194:105: error: 'XCreatePixmap' was not declared in this scope /home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:202:47: error: 'XFreePixmap' was not declared in this scope /home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:276:49: error: 'XFreePixmap' was not declared in this scope make[2]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/platform/graphics/egl/GLContextEGL.cpp.o] Error 1 make[1]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/all] Error 2 1125171 1 261004 clopez 2015-09-11 06:02:31 -0700 Created attachment 261004 Patch Patch for stable (2.8.5). 1125172 2 commit-queue 2015-09-11 06:04:55 -0700 Attachment 261004 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:44: "X11/Xlib.h" already included at Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:40 [build/include] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1125173 3 clopez 2015-09-11 06:09:03 -0700 (In reply to comment #2) > Attachment 261004 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:44: > "X11/Xlib.h" already included at > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:40 [build/include] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This is checking against trunk, which already includes this change. The patch is for the stable branch. Ignore this warning. 261004 2015-09-11 06:02:31 -0700 2015-09-11 07:54:39 -0700 Patch bug-149063-20150911150222.patch text/plain 1387 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNmMGIyNjYzZWJlMzAx N2RmN2FjNWQxMDJhNmYxZGY3Mzg2ZGFmZS4uYzRlMTY2MWQ4Y2JmMzZjMGY0MTE0ZmQwOWExYTZm NjkxNTNkNzA2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTExICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIFtTdGFibGVdIEJ1aWxkIGZhaWx1cmUgYXQgR0xDb250ZXh0RUdMLmNwcCBvbiAyLjguNQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MDYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaXgg aXMgYWxyZWFkeSBpbmNsdWRlZCBvbiB0cnVuayBhcyBwYXJ0IG9mIHIxODU2MjAuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHA6CisKIDIwMTUtMDgtMDYgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu IEZpeCB0aGUgYnVpbGQgd2l0aCBSRVNPVVJDRV9USU1JTkcgZGlzYWJsZWQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCmlu ZGV4IDJhZWI5MzZjNzlmZTI5NWFhNjc0NDczMTkxNGM2ZmVkNmYxYzJlYzIuLjQzMzhiNTZjMDgz YjdiMzZiYjEyMTNiZmM5ZWJhZDQ5ZDI5YzA3MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCkBAIC00Miw2ICs0Miwx MCBAQAogI2VuZGlmCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKFgxMSkKKyNpbmNsdWRlIDxYMTEv WGxpYi5oPgorI2VuZGlmCisKICNpZiBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKQogLy8g Y2Fpcm8tZ2wuaCBpbmNsdWRlcyBzb21lIGRlZmluaXRpb25zIGZyb20gR0xYIHRoYXQgY29uZmxp Y3Qgd2l0aAogLy8gdGhlIG9uZXMgcHJvdmlkZWQgYnkgdXMuIFNpbmNlIEdMQ29udGV4dEVHTCBk b2Vzbid0IHVzZSBhbnkgR0xYCg==