149060 2015-09-11 03:38:18 -0700 [ThreadedCompositor] Scrolling artifacts on accelerated subframes 2016-09-17 01:34:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 emanuele.aina webkit-unassigned cgarcia mcatanzaro mrobinson yoon zan oldest_to_newest 1125163 0 261000 emanuele.aina 2015-09-11 03:38:18 -0700 Created attachment 261000 Accelerated subframe testcase When scrolling an accelerated subframe (eg. an <iframe> containing a transformed element, see the attached scroll.html file) the main frame is scrolled temporarily producing ugly glitches. This seems to due to excessive scroll notifications where the lower layers notify the upper layers again. I guess an automated testcase would be appropriate, but I don't know where to start, any suggestion would be appropriate. 1125164 1 261001 emanuele.aina 2015-09-11 03:39:58 -0700 Created attachment 261001 Patch 1159623 2 mcatanzaro 2016-01-27 21:03:58 -0800 Yoon, what do you think? 1165104 3 261001 zan 2016-02-16 03:43:08 -0800 Comment on attachment 261001 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261001&action=review This needs some clarification. Yoon should chip in as well. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:126 > void ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents(const WebCore::IntRect& rect) The parameter is now unused. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-128 > - m_compositor->scrollTo(rect.location()); After removing this, ThreadedCompositor::scrollTo() is not called anymore. Do we still need it? > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:-242 > - if (m_lastScrollPosition != roundedIntPoint(rect.location())) { > - m_lastScrollPosition = roundedIntPoint(rect.location()); > - > - if (!m_webPage->corePage()->mainFrame().view()->useFixedLayout()) > - m_webPage->corePage()->mainFrame().view()->notifyScrollPositionChanged(m_lastScrollPosition); > - } > - > - if (m_lastScaleFactor != scale) { > - m_lastScaleFactor = scale; > - didScaleFactorChanged(m_lastScaleFactor, m_lastScrollPosition); > - } Same for m_lastScrollPosition and m_lastScaleFactor -- these are unused afterwards. 1202154 4 cgarcia 2016-06-14 04:04:27 -0700 I don't see any differences with the attached test case between threaded compositor enabled and disabled. 1212978 5 mcatanzaro 2016-07-20 17:44:10 -0700 Emanuele, any update on this? 1229959 6 emanuele.aina 2016-09-15 02:18:06 -0700 I still see the page jumping badly when trying to scroll down https://people.collabora.com/~em/wk/tests/scroll.html My steps (under X11): * ./MiniBrowser https://people.collabora.com/~em/wk/tests/scroll.html * move mouse pointer over the top iframe with the 300x300 image placeholder * scroll down with a double-finger drag on my touchpad * iframe scrolls correctly * when the iframe has been scrolled completely, the scroll events propagate to the main frame, scrolling the page correctly * if I keep scrolling down at some point the page goes back to its zero scrolling position 1229960 7 emanuele.aina 2016-09-15 02:19:54 -0700 Tested on r205858/git 804075239217. 1229961 8 emanuele.aina 2016-09-15 02:20:30 -0700 I haven't re-tested the patch. 1229969 9 emanuele.aina 2016-09-15 03:17:22 -0700 It seems that the jump happens as soon as the mouse pointer enters the second iframe during the scroll gesture. 1229970 10 emanuele.aina 2016-09-15 03:20:00 -0700 Oh, right, that's what I meant in the original report when I was talking about iframes, the scrollable placeholder on top isn't an iframe... :/ In fact, touch-scrolling in the nested iframe produces the flashes due to the page being temporarily scrolled to 0,0 and then back to the right offset. 1229972 11 288948 emanuele.aina 2016-09-15 03:35:49 -0700 Created attachment 288948 Patch 1229973 12 emanuele.aina 2016-09-15 03:37:10 -0700 The updated patch seems to fix the issue on my testcase. I'm not sure if it breaks anything else though. :) 1229986 13 emanuele.aina 2016-09-15 04:57:22 -0700 For what is worth, the one I removed was the only use of SimpleViewportController::didScroll(), so I tried to drop it as well and things still seem to work. I now need to check where SimpleViewportController::visibleContentsRect() is called, as it uses the value updated by didScroll(). 1230376 14 288948 cgarcia 2016-09-16 04:36:13 -0700 Comment on attachment 288948 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288948&action=review > w/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:82 > - m_viewportController.didScroll(rect.location()); > didChangeViewport(); This is not correct, it breaks fixed layout scrolling. Also, if we don't call didScroll, we shouldn't need to call didChangeViewport() either. 1230377 15 289055 cgarcia 2016-09-16 04:39:04 -0700 Created attachment 289055 Patch This should fix the issue 1230780 16 cgarcia 2016-09-17 01:34:40 -0700 Committed r206066: <http://trac.webkit.org/changeset/206066> 261000 2015-09-11 03:38:18 -0700 2015-09-11 03:38:18 -0700 Accelerated subframe testcase scroll.html text/html 1875 emanuele.aina PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHRpdGxlPlNjcm9sbCB0ZXN0PC90 aXRsZT4KICAgIDxzdHlsZT4KICAgICAgKiB7IGJveC1zaXppbmc6IGJvcmRlci1ib3ggfQogICAg ICBodG1sIHsgYmFja2dyb3VuZDogI0ZFRTsgfQogICAgICBoMSB7IGJhY2tncm91bmQ6ICM2Njk7 IGRpc3BsYXk6IGJsb2NrOyB3aWR0aDogMTEwJTsgYm9yZGVyLWJvdHRvbTogMnB4IHNvbGlkICMw MDY7IH0KICAgICAgaDEgYSB7IGNvbG9yOiB3aGl0ZTsgfQogICAgICBoMSBhOmhvdmVyIHsgdGV4 dC1zaGFkb3c6IDFweCAxcHggMnB4IGJsYWNrLCAwIDAgMWVtIGdyYXksIDAgMCAwLjJlbSBncmF5 OyB9CiAgICAgIGgxIGE6YWN0aXZlIHsgdGV4dC1zaGFkb3c6IDFweCAxcHggMnB4IHJlZCwgMCAw IDFlbSByZWQsIDAgMCAwLjJlbSByZWQ7IH0KICAgICAgI2NvbnRhaW5lciB7IHdpZHRoOiAzNTBw eDsgaGVpZ2h0OiAyMDBweDsgb3ZlcmZsb3c6IGF1dG87IGJhY2tncm91bmQ6ICNDQ0Y7IG9wYWNp dHk6IDAuNTsgfQogICAgICAjY29udGFpbmVlIHsgYm9yZGVyOiA1cHggc29saWQgZ3JlZW47IG9w YWNpdHk6IDAuNTsgfQogICAgICAjY29udGFpbmVlIGltZyB7IC13ZWJraXQtdHJhbnNmb3JtOiB0 cmFuc2xhdGVaKDAuMDAwMDFweCk7IGJvcmRlcjogM3B4IHNvbGlkIHB1cnBsZTsgfQogICAgICBp ZnJhbWUgeyB3aWR0aDogMzUwcHg7IGhlaWdodDogMzUwcHg7IH0KICAgICAgaW5wdXRbdHlwZT10 ZXh0XSB7IHdpZHRoOiAzNTBweDsgfQogICAgICAjZmlsbGVyIHsgYm94LW1vZGVsOiBib3JkZXIt Ym94OyBoZWlnaHQ6IDMwMHB4OyB3aWR0aDogMzUwcHg7IGJhY2tncm91bmQ6ICM2Njk7IGNvbG9y OiAjMjIzOyBwYWRkaW5nOiAyMHB4OyB9CiAgICAgICNjbGlja2FibGVzIHsgYm94LW1vZGVsOiBi b3JkZXItYm94OyB3aWR0aDogMzUwcHg7IGJhY2tncm91bmQ6ICM2NjY7IHBhZGRpbmc6IDIwcHg7 IH0KICAgICAgI2ZpeGVkIHsgcG9zaXRpb246IGZpeGVkOyB6LWluZGV4OiAxMDA7IHRvcDogMTBw eDsgcmlnaHQ6IDEwcHg7IHBhZGRpbmc6IDEwcHg7IGJhY2tncm91bmQ6ICMwNzI7IGNvbG9yOiB3 aGl0ZTsgZm9udC13ZWlnaHQ6IGJvbGQ7IGJvcmRlcjogM3B4IHNvbGlkIGJsYWNrOyB9CiAgICAg IGZvb3RlciB7IGJhY2tncm91bmQ6ICNmZjg7IG9wYWNpdHk6IDAuMTU7IH0KICAgIDwvc3R5bGU+ CiAgPC9oZWFkPgogIDxib2R5PgogICAgPGgxPlNjcm9sbCB0ZXN0IChvciBnbyB0byA8YSBocmVm PSJodHRwOi8vcGxhbmV0LmNvbGxhYm9yYS5jb20iPlBsYW5ldCBDb2xsYWJvcmE8L2E+KTwvaDE+ CiAgICA8ZGl2IGlkPSJmaXhlZCI+SSdtIGZpeGVkITwvZGl2PgogICAgPGRpdiBpZD0iY29udGFp bmVyIj4KICAgICAgPGRpdiBpZD0iY29udGFpbmVlIj4KICAgICAgICA8aW1nIHNyYz0icGxhY2Vo b2xkZXIucG5nIi8+CiAgICAgIDwvZGl2PgogICAgPC9kaXY+CiAgICA8ZGl2IGlkPSJpbnB1dCI+ CiAgICAgIDxpbnB1dCB0eXBlPSJ0ZXh0IiBwbGFjZWhvbGRlcj0iVHJ5IHRvIGZvY3VzIG1lISIg Lz4KICAgIDwvZGl2PgogICAgPGlmcmFtZSBzcmM9InNjcm9sbC5odG1sIj48L2lmcmFtZT4KICAg IDxkaXYgaWQ9ImZpbGxlciI+CiAgICAgIDxwPlRoaXMgc3BhY2UgaW50ZW50aW9uYWxseSBsZWZ0 IGJsYW5rPC9wPgogICAgPC9kaXY+CiAgICA8Zm9vdGVyPgogICAgR28gdG8gPGEgaHJlZj0iaHR0 cDovL3d3dy5jb2xsYWJvcmEuY29tIj5Db2xsYWJvcmEgd2Vic2l0ZTwvYT4gb3IKICAgIDxhIGhy ZWY9Imh0dHA6Ly9wbGFuZXQuY29sbGFib3JhLmNvbSI+UGxhbmV0IENvbGxhYm9yYTwvYT4gZm9y IGEgdmVyeSBsb25nIHBhZ2UuCiAgICA8L2Zvb3Rlcj4KICA8L2JvZHk+CjwvaHRtbD4K 261001 2015-09-11 03:39:58 -0700 2016-09-15 03:34:07 -0700 Patch bug-149060-20150911123949.patch text/plain 2449 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzJjYTkyNmNiY2ZkNjE0 YzNkMGQ3NGM3M2I0NGU0MGVmZmViN2I3Yy4uOTgwYzYyMzM4NjFkMDQ5YzI3NmNkZjgzOWYyZGZh YTQyYWFhY2IwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTExICBFbWFu dWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtUaHJl YWRlZENvbXBvc2l0b3JdIFNjcm9sbGluZyBhcnRpZmFjdHMgb24gYWNjZWxlcmF0ZWQgc3ViZnJh bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkw NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRM YXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgQXZvaWQgcmVjdXJzaXZlIHNjcm9sbCBub3RpZmlj YXRpb25zIGNhdXNpbmcgdGhlIG1haW4gZnJhbWUgdG8gYmUKKyAgICAgICAgdGVtcG9yYXJpbHkg c2Nyb2xsZWQgd2hlbiBzY3JvbGxpbmcgYW4gYWNjZWxlcmF0ZWQgc3ViZnJhbWUuCisKIDIwMTUt MDgtMjYgIEVtYW51ZWxlIEFpbmEgIDxlbWFudWVsZS5haW5hQGNvbGxhYm9yYS5jb20+CiAKICAg ICAgICAgW1RocmVhZGVkQ29tcG9zaXRvcl0gVXNlIFdURjo6Q29uZGl0aW9uIHRvZ2V0aGVyIHdp dGggV1RGOjpMb2NrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9UaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9UaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggOGQ0ODczMWJiZTQy ODI1NmU4M2MyNDljNTdjMWExNDVmYWEzYmEwMy4uMjEyZTQ2ZGIyYTY3YzcyZmJlMjdhMmUwMDk5 NzU0YWIxZWQxMWJlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvVGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApAQCAtMTI1LDcgKzEy NSw3IEBAIHZvaWQgVGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OmludmFsaWRhdGUo KQogCiB2b2lkIFRocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpzY3JvbGxOb25Db21w b3NpdGVkQ29udGVudHMoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgcmVjdCkKIHsKLSAgICBtX2Nv bXBvc2l0b3ItPnNjcm9sbFRvKHJlY3QubG9jYXRpb24oKSk7CisgICAgbV9jb21wb3NpdG9yLT5z ZXROZWVkc0Rpc3BsYXkoKTsKICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKIH0KIApAQCAtMjI5 LDE4ICsyMjksNiBAQCB2b2lkIFRocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpzY2hl ZHVsZUFuaW1hdGlvbigpCiB2b2lkIFRocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0Ojpz ZXRWaXNpYmxlQ29udGVudHNSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgRmxvYXRQ b2ludCYgdHJhamVjdG9yeVZlY3RvciwgZmxvYXQgc2NhbGUpCiB7CiAgICAgbV9jb29yZGluYXRv ci0+c2V0VmlzaWJsZUNvbnRlbnRzUmVjdChyZWN0LCB0cmFqZWN0b3J5VmVjdG9yKTsKLSAgICBp ZiAobV9sYXN0U2Nyb2xsUG9zaXRpb24gIT0gcm91bmRlZEludFBvaW50KHJlY3QubG9jYXRpb24o KSkpIHsKLSAgICAgICAgbV9sYXN0U2Nyb2xsUG9zaXRpb24gPSByb3VuZGVkSW50UG9pbnQocmVj dC5sb2NhdGlvbigpKTsKLQotICAgICAgICBpZiAoIW1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+bWFp bkZyYW1lKCkudmlldygpLT51c2VGaXhlZExheW91dCgpKQotICAgICAgICAgICAgbV93ZWJQYWdl LT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS52aWV3KCktPm5vdGlmeVNjcm9sbFBvc2l0aW9uQ2hh bmdlZChtX2xhc3RTY3JvbGxQb3NpdGlvbik7Ci0gICAgfQotCi0gICAgaWYgKG1fbGFzdFNjYWxl RmFjdG9yICE9IHNjYWxlKSB7Ci0gICAgICAgIG1fbGFzdFNjYWxlRmFjdG9yID0gc2NhbGU7Ci0g ICAgICAgIGRpZFNjYWxlRmFjdG9yQ2hhbmdlZChtX2xhc3RTY2FsZUZhY3RvciwgbV9sYXN0U2Ny b2xsUG9zaXRpb24pOwotICAgIH0KLQogICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCgpOwogfQogCg== 288948 2016-09-15 03:35:49 -0700 2016-09-16 04:39:04 -0700 Patch bug-149060-20160915123310.patch text/plain 1803 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1OTY1CmRpZmYgLS1naXQgYy9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgdy9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWIxMzhkNTU1OWRiNGMx MmVjMjVhMDFmYzkyYjk5YzhkM2YyZGFiZC4uZGZkMzA2NWRhZjRiMzFkNzRiMWI4OGViMzhjNjU0 NjExYzdmMjYyNyAxMDA2NDQKLS0tIGMvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyB3L1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTE1ICBFbWFu dWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtUaHJl YWRlZENvbXBvc2l0b3JdIFNjcm9sbGluZyBhcnRpZmFjdHMgb24gYWNjZWxlcmF0ZWQgc3ViZnJh bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkw NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRM YXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgQXZvaWQgcmVjdXJzaXZlIHNjcm9sbCBub3RpZmlj YXRpb25zIGNhdXNpbmcgdGhlIG1haW4gZnJhbWUgdG8gYmUKKyAgICAgICAgdGVtcG9yYXJpbHkg c2Nyb2xsZWQgd2hlbiBzY3JvbGxpbmcgYSBzdWJmcmFtZSB3aXRoIGNvbXBvc2l0ZWQKKyAgICAg ICAgY29udGVudHMuCisgICAgICAgIFRoaXMgY2F1c2VkIGJvdGggZnVsbCBzY3JvbGxpbmcgb2Zm c2V0IGVycm9ycyAod2hlbiB0aGUgc2Nyb2xsCisgICAgICAgIHN0YXJ0ZWQgaW4gdGhlIG1haW4g ZnJhbWUpIGFuZCB0cmFuc2llbnQgZ2xpdGNoZXMgKHdoZW4gdGhlIHNjcm9sbAorICAgICAgICBz dGFydGVkIGluIGEgbmVzdGVkIGlmcmFtZSkuCisKIDIwMTYtMDktMTQgIFdlbnNvbiBIc2llaCAg PHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWEgY29udHJvbHMgYmVoYXZl IHN0cmFuZ2VseSB3aGVuIGNoYW5naW5nIG1lZGlhIHNvdXJjZXMKZGlmZiAtLWdpdCBjL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVk Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcCB3L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVhZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVI b3N0LmNwcAppbmRleCAzYzI0MGVjZWQ4NDE3MmVlMjhjMzkyOWFmYjNiNjYzZmEzZDc3MjQ1Li4y ZTBhZWU3NGE2NmE3NTNlZjQxMjIzZWQzNmEzNGE3MjkxZWNiNDhhIDEwMDY0NAotLS0gYy9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9UaHJlYWRl ZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKKysrIHcvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvVGhyZWFkZWRDb29yZGluYXRlZExheWVy VHJlZUhvc3QuY3BwCkBAIC03OSw3ICs3OSw2IEBAIHZvaWQgVGhyZWFkZWRDb29yZGluYXRlZExh eWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludCgpCiAKIHZvaWQgVGhyZWFkZWRDb29yZGluYXRlZExh eWVyVHJlZUhvc3Q6OnNjcm9sbE5vbkNvbXBvc2l0ZWRDb250ZW50cyhjb25zdCBJbnRSZWN0JiBy ZWN0KQogewotICAgIG1fdmlld3BvcnRDb250cm9sbGVyLmRpZFNjcm9sbChyZWN0LmxvY2F0aW9u KCkpOwogICAgIGRpZENoYW5nZVZpZXdwb3J0KCk7CiB9CiAK 289055 2016-09-16 04:39:04 -0700 2016-09-16 09:57:17 -0700 Patch wk2-tc-subframes-scrolling.diff text/plain 1724 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlYTJlM2NiLi4xNmE0Mzc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTYtMDktMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtUaHJlYWRlZENvbXBvc2l0b3JdIFNjcm9sbGluZyBhcnRpZmFjdHMgb24g YWNjZWxlcmF0ZWQgc3ViZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDkwNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFyZSBzY3JvbGxpbmcgdGhlIG1h aW4gZnJhbWUgZXZlbiB3aGVuIHNjcm9sbGluZyBpcyBub3QgZGVsZWdhdGVkLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvVGhyZWFkZWRDb29yZGlu YXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpUaHJlYWRlZENvb3JkaW5h dGVkTGF5ZXJUcmVlSG9zdDo6c2Nyb2xsTm9uQ29tcG9zaXRlZENvbnRlbnRzKTogUmV0dXJuIGVh cmx5IGlmIG1haW4gZnJhbWUgdmlldyBkb2Vzbid0CisgICAgICAgIGRlbGVnYXRlIHNjcm9sbGlu Zy4KKwogMjAxNi0wOS0xNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgV0tXZWJWaWV3Lmhhc09ubHlTZWN1cmVDb250ZW50IGFsd2F5cyByZXR1cm5zICJZRVMi IGFmdGVyIGdvaW5nIGJhY2sgdG8gYSBDYWNoZWRQYWdlIChldmVuIGlmIGl0IGhhcyBodHRwIHJl c291cmNlcykuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv Q29vcmRpbmF0ZWRHcmFwaGljcy9UaHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9U aHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggM2MyNDBlYy4uYWVkMjM3 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvVGhyZWFkZWRDb29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL1RocmVh ZGVkQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApAQCAtNzksNiArNzksMTAgQEAgdm9pZCBU aHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50KCkKIAogdm9pZCBU aHJlYWRlZENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6c2Nyb2xsTm9uQ29tcG9zaXRlZENvbnRl bnRzKGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CisgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBt X3dlYlBhZ2UubWFpbkZyYW1lVmlldygpOworICAgIGlmICghZnJhbWVWaWV3IHx8ICFmcmFtZVZp ZXctPmRlbGVnYXRlc1Njcm9sbGluZygpKQorICAgICAgICByZXR1cm47CisKICAgICBtX3ZpZXdw b3J0Q29udHJvbGxlci5kaWRTY3JvbGwocmVjdC5sb2NhdGlvbigpKTsKICAgICBkaWRDaGFuZ2VW aWV3cG9ydCgpOwogfQo=