149057 2015-09-10 21:35:32 -0700 document.body = "text" should throw a TypeError, not a HierarchyRequestError 2015-09-11 07:50:53 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 1 cdumez cdumez ap commit-queue rniwa webkit-bug-importer oldest_to_newest 1125138 0 cdumez 2015-09-10 21:35:32 -0700 document.body = "text" should throw a TypeError, not a HierarchyRequestError: https://html.spec.whatwg.org/multipage/dom.html#dom-document-body This is because "text" is a DOMString and it cannot be converted into an HTMLElement?. Therefore, the WebIDL specification says we should throw a TypeError in this case. 1125139 1 cdumez 2015-09-10 21:36:21 -0700 rdar://problem/22567157 1125141 2 260988 cdumez 2015-09-10 22:03:31 -0700 Created attachment 260988 Patch 1125180 3 260988 commit-queue 2015-09-11 07:50:49 -0700 Comment on attachment 260988 Patch Clearing flags on attachment: 260988 Committed r189617: <http://trac.webkit.org/changeset/189617> 1125181 4 commit-queue 2015-09-11 07:50:53 -0700 All reviewed patches have been landed. Closing bug. 260988 2015-09-10 22:03:31 -0700 2015-09-11 07:50:49 -0700 Patch bug-149057-20150910220324.patch text/plain 5670 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzRkNWYzNjc5YjhlZWI4 OWM3MzNlZjJkODVhYWNmOTVjOTg1YjNhNi4uODY3MTVmZjQ2MWY5MzI2N2Y0YTUyOTE1ODc0Mzlj Yjg0NjkwNDY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA5LTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnQuYm9keSA9ICJ0 ZXh0IiBzaG91bGQgdGhyb3cgYSBUeXBlRXJyb3IsIG5vdCBhIEhpZXJhcmNoeVJlcXVlc3RFcnJv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MDU3 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjU2NzE1Nz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkb2N1bWVudC5ib2R5ID0gInRleHQiIHNob3Vs ZCB0aHJvdyBhIFR5cGVFcnJvciwgbm90IGEKKyAgICAgICAgSGllcmFyY2h5UmVxdWVzdEVycm9y OgorICAgICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9kb20uaHRt bCNkb20tZG9jdW1lbnQtYm9keQorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSAidGV4dCIgaXMg YSBET01TdHJpbmcgYW5kIGl0IGNhbm5vdCBiZSBjb252ZXJ0ZWQgaW50byBhbgorICAgICAgICBI VE1MRWxlbWVudD8uIFRoZXJlZm9yZSwgdGhlIFdlYklETCBzcGVjaWZpY2F0aW9uIHNheXMgd2Ug c2hvdWxkIHRocm93IGEKKyAgICAgICAgVHlwZUVycm9yIGluIHRoaXMgY2FzZS4KKworICAgICAg ICBDaHJvbWUgYW5kIEZpcmVmb3ggdGhyb3cgdGhlIHJpZ2h0IGV4Y2VwdGlvbi4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAg ICAgICogZG9tL0RvY3VtZW50LmlkbDoKKwogMjAxNS0wOS0xMCAgQ2hyaXMgRmxlaXphY2ggIDxj ZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBNYXZlcmlja3M6IFRleHQgY3Vyc29y IGRvZXMgbm90IG1vdmUgYWxvbmcgd2l0aCBWb2ljZU92ZXIgY3Vyc29yIGZvciB0ZXh0IGZpZWxk cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmlkbCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5pZGwKaW5kZXggMTg2OTkxNDA4Y2E3OWE4ZjJjMWEwYjQyNjg3 NjVmYjVmN2EwY2M5ZS4uYTllMThkM2RmNDhhZjU0YWE0MWVlMTQxMjBmM2FjYWI0NWUzMzdkNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCkBAIC0xNTcsNyArMTU3LDcgQEAKIAogICAgIFtUcmVh dE51bGxBcz1OdWxsU3RyaW5nLCBHZXR0ZXJSYWlzZXNFeGNlcHRpb24sIFNldHRlclJhaXNlc0V4 Y2VwdGlvbl0gYXR0cmlidXRlIERPTVN0cmluZyBjb29raWU7CiAKLSAgICBbU2V0dGVyUmFpc2Vz RXhjZXB0aW9uLCBJbXBsZW1lbnRlZEFzPWJvZHlPckZyYW1lc2V0XSBhdHRyaWJ1dGUgSFRNTEVs ZW1lbnQgYm9keTsKKyAgICBbU2V0dGVyUmFpc2VzRXhjZXB0aW9uLCBJbXBsZW1lbnRlZEFzPWJv ZHlPckZyYW1lc2V0LCBTdHJpY3RUeXBlQ2hlY2tpbmddIGF0dHJpYnV0ZSBIVE1MRWxlbWVudCBi b2R5OwogCiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxIZWFkRWxlbWVudCBoZWFkOwogICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MQ29sbGVjdGlvbiBpbWFnZXM7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGVjYjBh YTc4YjJmMWVlYmJhOTY1YjIyZWE5MDczZDVlMDEzYjc2Mi4uNWQzYTc0YTFmZTBlN2YwZTFjOTk2 MjIwYmFhOGU0NTViMTBlMTVhNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTEwICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnQuYm9keSA9 ICJ0ZXh0IiBzaG91bGQgdGhyb3cgYSBUeXBlRXJyb3IsIG5vdCBhIEhpZXJhcmNoeVJlcXVlc3RF cnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5 MDU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjU2NzE1Nz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIHRlc3QgYXMgd2Ugbm93 IHRocm93IGEgZGlmZmVyZW50IGV4Y2VwdGlvbi4KKworICAgICAgICAqIGZhc3QvZG9tL3NldHRl ci10eXBlLWVuZm9yY2VtZW50LWV4cGVjdGVkLnR4dDoKKwogMjAxNS0wOS0xMCAgQ29tbWl0IFF1 ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE4OTU5NS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDQ0Y2M3 YjFlZmQzNDIwNmFhOTBjN2ZlMjc3MWNmYTkyZTliYzNhOGEuLmQwY2YyY2YwZjRiYTk1NzkyNTAw NTJkY2Q3MzAzNTBlYTZmNTJjMmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAt MSw1ICsxLDE3IEBACiAyMDE1LTA5LTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKKyAgICAgICAgZG9jdW1lbnQuYm9keSA9ICJ0ZXh0IiBzaG91bGQgdGhyb3cgYSBUeXBlRXJy b3IsIG5vdCBhIEhpZXJhcmNoeVJlcXVlc3RFcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MDU3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y MjU2NzE1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWJhc2VsaW5lIHRlc3Qgbm93IHRoYXQgYSBuZXcgY2hlY2sgaXMgcGFzc2luZy4KKworICAg ICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNj ZXNzb3JzL2RvY3VtZW50LmJvZHktc2V0dGVyLTAxLWV4cGVjdGVkLnR4dDoKKworMjAxNS0wOS0x MCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIE5vZGUuYXBwZW5k Q2hpbGQobnVsbCkgLyByZXBsYWNlQ2hpbGQobnVsbCwgbnVsbCkgLyByZW1vdmVDaGlsZChudWxs KSAvIGluc2VydEJlZm9yZShudWxsLCByZWYpIHNob3VsZCB0aHJvdyBhIFR5cGVFcnJvcgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4OTcxCiAgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yMjU2MDg4Mz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL3NldHRlci10eXBlLWVuZm9yY2VtZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL3NldHRlci10eXBlLWVuZm9yY2VtZW50LWV4cGVjdGVkLnR4dAppbmRleCA5MTcx MmQwOTU0YmZhOWM3OTUwZmZiNjVkN2U2YTI1YmU0NWUzMThkLi5lYTY4Yzk1YjVjMDA2NzVlYmYz ZmNlMzZiNjA2N2EzNTBlY2JjNDFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9z ZXR0ZXItdHlwZS1lbmZvcmNlbWVudC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vc2V0dGVyLXR5cGUtZW5mb3JjZW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0zLDcgKzMsNyBA QCBUZXN0cyB0eXBlIGVuZm9yY2VtZW50IG9uIERPTSBzZXR0ZXJzLgogT24gc3VjY2VzcywgeW91 IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg Q09NUExFVEUiLgogCiAKLVBBU1MgZG9jdW1lbnQuYm9keSA9IG5vZGVsaXN0OyB0aHJldyBleGNl cHRpb24gRXJyb3I6IEhpZXJhcmNoeVJlcXVlc3RFcnJvcjogRE9NIEV4Y2VwdGlvbiAzLgorUEFT UyBkb2N1bWVudC5ib2R5ID0gbm9kZWxpc3Q7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFRo ZSBEb2N1bWVudC5ib2R5IGF0dHJpYnV0ZSBtdXN0IGJlIGFuIGluc3RhbmNlIG9mIEhUTUxFbGVt ZW50LgogUEFTUyB0YWJsZS50SGVhZCA9IG5vZGVsaXN0OyB0aHJldyBleGNlcHRpb24gVHlwZUVy cm9yOiBUaGUgSFRNTFRhYmxlRWxlbWVudC50SGVhZCBhdHRyaWJ1dGUgbXVzdCBiZSBhbiBpbnN0 YW5jZSBvZiBIVE1MVGFibGVTZWN0aW9uRWxlbWVudC4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50 LmJvZHktc2V0dGVyLTAxLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29ycy9k b2N1bWVudC5ib2R5LXNldHRlci0wMS1leHBlY3RlZC50eHQKaW5kZXggZWEzY2ZlNWRmNzM4MDY3 NjEwNzBlMjYzZmEyOTFkNDYyYWIyYjc5Ny4uNGZjNWVlMTFmYzA2Y2JmMTI0ODAyOTk1N2RiNjdj NDQ1OTFjN2UzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50 LmJvZHktc2V0dGVyLTAxLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2RvY3VtZW50cy9kb20tdHJlZS1hY2Nlc3Nv cnMvZG9jdW1lbnQuYm9keS1zZXR0ZXItMDEtZXhwZWN0ZWQudHh0CkBAIC0xLDcgKzEsNSBAQAog Ci1GQUlMIFNob3VsZCB0aHJvdyBhIFR5cGVFcnJvciB3aGVuIHRyeWluZyB0byBzZXQgZG9jdW1l bnQuYm9keSB0byBhIHN0cmluZy4gYXNzZXJ0X3Rocm93czogZnVuY3Rpb24gImZ1bmN0aW9uICgp IHsKLSAgICBkb2N1bWVudC5ib2R5ID0gInRleHQiCi0gIH0iIHRocmV3IG9iamVjdCAiRXJyb3I6 IEhpZXJhcmNoeVJlcXVlc3RFcnJvcjogRE9NIEV4Y2VwdGlvbiAzIiAoIkhpZXJhcmNoeVJlcXVl c3RFcnJvciIpIGV4cGVjdGVkIG9iamVjdCAiVHlwZUVycm9yIiAoIlR5cGVFcnJvciIpCitQQVNT IFNob3VsZCB0aHJvdyBhIFR5cGVFcnJvciB3aGVuIHRyeWluZyB0byBzZXQgZG9jdW1lbnQuYm9k eSB0byBhIHN0cmluZy4gCiBQQVNTIFNob3VsZCB0aHJvdyBhIEhpZXJhcmNoeVJlcXVlc3RFcnJv ciB3aGVuIHRyeWluZyB0byBzZXQgZG9jdW1lbnQuYm9keSB0byBhIGRpdiBlbGVtZW50LiAKIFBB U1MgU2hvdWxkIHRocm93IGEgSGllcmFyY2h5UmVxdWVzdEVycm9yIHdoZW4gdHJ5aW5nIHRvIHNl dCBkb2N1bWVudC5ib2R5IHdoZW4gdGhlcmUncyBubyByb290IGVsZW1lbnQuIAogUEFTUyBkb2N1 bWVudC5ib2R5IGhhcyBub3QgY2hhbmdlZCAK