149046 2015-09-10 15:01:39 -0700 WebInspectorUI should have a WebPage reference 2015-09-10 18:42:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1125040 0 joepeck 2015-09-10 15:01:39 -0700 * SUMMARY WebInspectorUI should have a WebPage reference. No need for a pointer, the WebPage's lifetime surrounds this object's lifetime. I did not do the same to WebKit::WebInspector, because that is an API::Object and someone could extend the lifetime (although I don't think we would handle that case properly if it did happen. 1125041 1 260959 joepeck 2015-09-10 15:02:21 -0700 Created attachment 260959 [PATCH] Proposed Fix 1125100 2 260959 ggaren 2015-09-10 17:55:17 -0700 Comment on attachment 260959 [PATCH] Proposed Fix r=me 1125122 3 260959 commit-queue 2015-09-10 18:42:20 -0700 Comment on attachment 260959 [PATCH] Proposed Fix Clearing flags on attachment: 260959 Committed r189601: <http://trac.webkit.org/changeset/189601> 1125123 4 commit-queue 2015-09-10 18:42:24 -0700 All reviewed patches have been landed. Closing bug. 260959 2015-09-10 15:02:21 -0700 2015-09-10 18:42:20 -0700 [PATCH] Proposed Fix reference.patch text/plain 5633 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MTgyM2M2Li44NzBmZjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTUtMDktMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWJJbnNwZWN0b3JVSSBzaG91bGQgaGF2ZSBhIFdlYlBhZ2UgcmVmZXJlbmNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkwNDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5jcHA6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYkluc3BlY3RvclVJLmg6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclVJOjpw YWdlKTogRGVsZXRlZC4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6Omluc3BlY3RvclVJKToKKworMjAxNS0wOS0xMCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFdlYkluc3BlY3RvclVJIGRvZXMgbm90IG5lZWQgdG8gYmUgYW4gQVBJOjpPYmplY3QK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTA0NQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVj dG9yVUkuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rv clVJLmNwcAppbmRleCBkNGRiYTc1Li5jYWM3NzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVjdG9yVUkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5jcHAKQEAgLTQ0LDEyICs0NCwx MiBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLVJl ZjxXZWJJbnNwZWN0b3JVST4gV2ViSW5zcGVjdG9yVUk6OmNyZWF0ZShXZWJQYWdlKiBwYWdlKQor UmVmPFdlYkluc3BlY3RvclVJPiBXZWJJbnNwZWN0b3JVSTo6Y3JlYXRlKFdlYlBhZ2UmIHBhZ2Up CiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgV2ViSW5zcGVjdG9yVUkocGFnZSkpOwogfQog Ci1XZWJJbnNwZWN0b3JVSTo6V2ViSW5zcGVjdG9yVUkoV2ViUGFnZSogcGFnZSkKK1dlYkluc3Bl Y3RvclVJOjpXZWJJbnNwZWN0b3JVSShXZWJQYWdlJiBwYWdlKQogICAgIDogbV9wYWdlKHBhZ2Up CiAgICAgLCBtX2luc3BlY3RlZFBhZ2VJZGVudGlmaWVyKDApCiAgICAgLCBtX3VuZGVyVGVzdChm YWxzZSkKQEAgLTc5LDcgKzc5LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSTo6ZXN0YWJsaXNoQ29u bmVjdGlvbihJUEM6OkF0dGFjaG1lbnQgZW5jb2RlZENvbm5lY3Rpb25JZGVudGkKICAgICBtX2Zy b250ZW5kTG9hZGVkID0gZmFsc2U7CiAgICAgbV91bmRlclRlc3QgPSB1bmRlclRlc3Q7CiAKLSAg ICBtX3BhZ2UtPmNvcmVQYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS5zZXRJbnNwZWN0b3JG cm9udGVuZENsaWVudCh0aGlzKTsKKyAgICBtX3BhZ2UuY29yZVBhZ2UoKS0+aW5zcGVjdG9yQ29u dHJvbGxlcigpLnNldEluc3BlY3RvckZyb250ZW5kQ2xpZW50KHRoaXMpOwogCiAgICAgbV9iYWNr ZW5kQ29ubmVjdGlvbiA9IElQQzo6Q29ubmVjdGlvbjo6Y3JlYXRlQ2xpZW50Q29ubmVjdGlvbihj b25uZWN0aW9uSWRlbnRpZmllciwgKnRoaXMpOwogICAgIG1fYmFja2VuZENvbm5lY3Rpb24tPm9w ZW4oKTsKQEAgLTkwLDggKzkwLDggQEAgdm9pZCBXZWJJbnNwZWN0b3JVSTo6d2luZG93T2JqZWN0 Q2xlYXJlZCgpCiAgICAgaWYgKG1fZnJvbnRlbmRIb3N0KQogICAgICAgICBtX2Zyb250ZW5kSG9z dC0+ZGlzY29ubmVjdENsaWVudCgpOwogCi0gICAgbV9mcm9udGVuZEhvc3QgPSBJbnNwZWN0b3JG cm9udGVuZEhvc3Q6OmNyZWF0ZSh0aGlzLCBtX3BhZ2UtPmNvcmVQYWdlKCkpOwotICAgIFNjcmlw dEdsb2JhbE9iamVjdDo6c2V0KGV4ZWNTdGF0ZUZyb21QYWdlKG1haW5UaHJlYWROb3JtYWxXb3Js ZCgpLCBtX3BhZ2UtPmNvcmVQYWdlKCkpLCBBU0NJSUxpdGVyYWwoIkluc3BlY3RvckZyb250ZW5k SG9zdCIpLCBtX2Zyb250ZW5kSG9zdC5nZXQoKSk7CisgICAgbV9mcm9udGVuZEhvc3QgPSBJbnNw ZWN0b3JGcm9udGVuZEhvc3Q6OmNyZWF0ZSh0aGlzLCBtX3BhZ2UuY29yZVBhZ2UoKSk7CisgICAg U2NyaXB0R2xvYmFsT2JqZWN0OjpzZXQoZXhlY1N0YXRlRnJvbVBhZ2UobWFpblRocmVhZE5vcm1h bFdvcmxkKCksIG1fcGFnZS5jb3JlUGFnZSgpKSwgQVNDSUlMaXRlcmFsKCJJbnNwZWN0b3JGcm9u dGVuZEhvc3QiKSwgbV9mcm9udGVuZEhvc3QuZ2V0KCkpOwogfQogCiB2b2lkIFdlYkluc3BlY3Rv clVJOjpmcm9udGVuZExvYWRlZCgpCkBAIC0xMDksOSArMTA5LDkgQEAgdm9pZCBXZWJJbnNwZWN0 b3JVSTo6c3RhcnRXaW5kb3dEcmFnKCkKIAogdm9pZCBXZWJJbnNwZWN0b3JVSTo6bW92ZVdpbmRv d0J5KGZsb2F0IHgsIGZsb2F0IHkpCiB7Ci0gICAgRmxvYXRSZWN0IGZyYW1lUmVjdCA9IG1fcGFn ZS0+Y29yZVBhZ2UoKS0+Y2hyb21lKCkud2luZG93UmVjdCgpOworICAgIEZsb2F0UmVjdCBmcmFt ZVJlY3QgPSBtX3BhZ2UuY29yZVBhZ2UoKS0+Y2hyb21lKCkud2luZG93UmVjdCgpOwogICAgIGZy YW1lUmVjdC5tb3ZlKHgsIHkpOwotICAgIG1fcGFnZS0+Y29yZVBhZ2UoKS0+Y2hyb21lKCkuc2V0 V2luZG93UmVjdChmcmFtZVJlY3QpOworICAgIG1fcGFnZS5jb3JlUGFnZSgpLT5jaHJvbWUoKS5z ZXRXaW5kb3dSZWN0KGZyYW1lUmVjdCk7CiB9CiAKIHZvaWQgV2ViSW5zcGVjdG9yVUk6OmJyaW5n VG9Gcm9udCgpCkBAIC0yNzQsNyArMjc0LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSTo6ZXZhbHVh dGVFeHByZXNzaW9uT25Mb2FkKGNvbnN0IFN0cmluZyYgZXhwcmVzc2lvbikKIHsKICAgICBpZiAo bV9mcm9udGVuZExvYWRlZCkgewogICAgICAgICBBU1NFUlQobV9xdWV1ZS5pc0VtcHR5KCkpOwot ICAgICAgICBtX3BhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLnNjcmlwdCgpLmV4ZWN1dGVT Y3JpcHQoZXhwcmVzc2lvbik7CisgICAgICAgIG1fcGFnZS5jb3JlUGFnZSgpLT5tYWluRnJhbWUo KS5zY3JpcHQoKS5leGVjdXRlU2NyaXB0KGV4cHJlc3Npb24pOwogICAgICAgICByZXR1cm47CiAg ICAgfQogCkBAIC0yODYsNyArMjg2LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSTo6ZXZhbHVhdGVQ ZW5kaW5nRXhwcmVzc2lvbnMoKQogICAgIEFTU0VSVChtX2Zyb250ZW5kTG9hZGVkKTsKIAogICAg IGZvciAoY29uc3QgU3RyaW5nJiBleHByZXNzaW9uIDogbV9xdWV1ZSkKLSAgICAgICAgbV9wYWdl LT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS5zY3JpcHQoKS5leGVjdXRlU2NyaXB0KGV4cHJlc3Np b24pOworICAgICAgICBtX3BhZ2UuY29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkuc2NyaXB0KCkuZXhl Y3V0ZVNjcmlwdChleHByZXNzaW9uKTsKIAogICAgIG1fcXVldWUuY2xlYXIoKTsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5o IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKaW5k ZXggYzNjMjA0Ni4uNzM5ODRiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKQEAgLTM3LDkgKzM3LDcgQEAgY2xhc3MgV2ViUGFn ZTsKIAogY2xhc3MgV2ViSW5zcGVjdG9yVUkgOiBwdWJsaWMgUmVmQ291bnRlZDxXZWJJbnNwZWN0 b3JVST4sIHB1YmxpYyBJUEM6OkNvbm5lY3Rpb246OkNsaWVudCwgcHVibGljIFdlYkNvcmU6Oklu c3BlY3RvckZyb250ZW5kQ2xpZW50IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUmVmPFdlYkluc3Bl Y3RvclVJPiBjcmVhdGUoV2ViUGFnZSopOwotCi0gICAgV2ViUGFnZSogcGFnZSgpIGNvbnN0IHsg cmV0dXJuIG1fcGFnZTsgfQorICAgIHN0YXRpYyBSZWY8V2ViSW5zcGVjdG9yVUk+IGNyZWF0ZShX ZWJQYWdlJik7CiAKICAgICAvLyBJbXBsZW1lbnRlZCBpbiBnZW5lcmF0ZWQgV2ViSW5zcGVjdG9y VUlNZXNzYWdlUmVjZWl2ZXIuY3BwCiAgICAgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShJUEM6OkNv bm5lY3Rpb24mLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJikgb3ZlcnJpZGU7CkBAIC0xMDQsNyArMTAy LDcgQEAgcHVibGljOgogICAgIGJvb2wgaXNVbmRlclRlc3QoKSBvdmVycmlkZSB7IHJldHVybiBt X3VuZGVyVGVzdDsgfQogCiBwcml2YXRlOgotICAgIGV4cGxpY2l0IFdlYkluc3BlY3RvclVJKFdl YlBhZ2UqKTsKKyAgICBleHBsaWNpdCBXZWJJbnNwZWN0b3JVSShXZWJQYWdlJik7CiAKICAgICB2 b2lkIGV2YWx1YXRlQ29tbWFuZE9uTG9hZChjb25zdCBTdHJpbmcmIGNvbW1hbmQsIGNvbnN0IFN0 cmluZyYgYXJndW1lbnQgPSBTdHJpbmcoKSk7CiAgICAgdm9pZCBldmFsdWF0ZUNvbW1hbmRPbkxv YWQoY29uc3QgU3RyaW5nJiBjb21tYW5kLCBjb25zdCBBU0NJSUxpdGVyYWwmIGFyZ3VtZW50KSB7 IGV2YWx1YXRlQ29tbWFuZE9uTG9hZChjb21tYW5kLCBTdHJpbmcoYXJndW1lbnQpKTsgfQpAQCAt MTEyLDcgKzExMCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBldmFsdWF0ZUV4cHJlc3Npb25Pbkxv YWQoY29uc3QgU3RyaW5nJiBleHByZXNzaW9uKTsKICAgICB2b2lkIGV2YWx1YXRlUGVuZGluZ0V4 cHJlc3Npb25zKCk7CiAKLSAgICBXZWJQYWdlKiBtX3BhZ2U7CisgICAgV2ViUGFnZSYgbV9wYWdl OwogCiAgICAgUmVmUHRyPElQQzo6Q29ubmVjdGlvbj4gbV9iYWNrZW5kQ29ubmVjdGlvbjsKICAg ICB1aW50NjRfdCBtX2luc3BlY3RlZFBhZ2VJZGVudGlmaWVyOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDQ0MzMzNDEuLjBiZTUxZWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTI5 NDMsNyArMjk0Myw3IEBAIFdlYkluc3BlY3RvclVJKiBXZWJQYWdlOjppbnNwZWN0b3JVSSgpCiAg ICAgaWYgKG1faXNDbG9zZWQpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIGlmICghbV9p bnNwZWN0b3JVSSkKLSAgICAgICAgbV9pbnNwZWN0b3JVSSA9IFdlYkluc3BlY3RvclVJOjpjcmVh dGUodGhpcyk7CisgICAgICAgIG1faW5zcGVjdG9yVUkgPSBXZWJJbnNwZWN0b3JVSTo6Y3JlYXRl KCp0aGlzKTsKICAgICByZXR1cm4gbV9pbnNwZWN0b3JVSS5nZXQoKTsKIH0KIAo=