149045 2015-09-10 14:03:46 -0700 Web Inspector: WebInspectorUI does not need to be an API::Object 2015-09-10 14:28:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck andersca bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1125017 0 joepeck 2015-09-10 14:03:46 -0700 * SUMMARY WebInspectorUI does not need to be an API::Object. WebKit::WebInspector is API - WKInspectorRef WebKit::WebInspectorUI is not API, it is just internal to WebKit. Switching to just RefCounted works. 1125018 1 260954 joepeck 2015-09-10 14:04:35 -0700 Created attachment 260954 [PATCH] Proposed Fix 1125027 2 260954 commit-queue 2015-09-10 14:28:39 -0700 Comment on attachment 260954 [PATCH] Proposed Fix Clearing flags on attachment: 260954 Committed r189592: <http://trac.webkit.org/changeset/189592> 1125028 3 commit-queue 2015-09-10 14:28:42 -0700 All reviewed patches have been landed. Closing bug. 260954 2015-09-10 14:04:35 -0700 2015-09-10 14:28:39 -0700 [PATCH] Proposed Fix api-object.patch text/plain 1746 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NGNlOTUyLi45MTgyM2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTUtMDktMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWJJbnNwZWN0b3JVSSBkb2VzIG5vdCBuZWVkIHRvIGJl IGFuIEFQSTo6T2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDkwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9BUEkvQVBJT2JqZWN0Lmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYkluc3BlY3RvclVJLmg6CisKKzIwMTUtMDktMTAgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51 c2VkIG1lbWJlciBpbiBXZWJQYWdlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDkwNDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVk L0FQSS9BUElPYmplY3QuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJT2JqZWN0LmgK aW5kZXggNjNiZTUwNC4uYTUxMjNjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVk L0FQSS9BUElPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSU9iamVj dC5oCkBAIC0xNjUsNyArMTY1LDYgQEAgcHVibGljOgogICAgICAgICBCdW5kbGVGcmFtZSwKICAg ICAgICAgQnVuZGxlSGl0VGVzdFJlc3VsdCwKICAgICAgICAgQnVuZGxlSW5zcGVjdG9yLAotICAg ICAgICBCdW5kbGVJbnNwZWN0b3JVSSwKICAgICAgICAgQnVuZGxlTmF2aWdhdGlvbkFjdGlvbiwK ICAgICAgICAgQnVuZGxlTm9kZUhhbmRsZSwKICAgICAgICAgQnVuZGxlUGFnZSwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JVSS5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKaW5kZXgg N2Q5MzUxMC4uYzNjMjA0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYkluc3BlY3RvclVJLmgKQEAgLTM1LDcgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYktp dCB7CiAKIGNsYXNzIFdlYlBhZ2U7CiAKLWNsYXNzIFdlYkluc3BlY3RvclVJIDogcHVibGljIEFQ STo6T2JqZWN0SW1wbDxBUEk6Ok9iamVjdDo6VHlwZTo6QnVuZGxlSW5zcGVjdG9yVUk+LCBwdWJs aWMgSVBDOjpDb25uZWN0aW9uOjpDbGllbnQsIHB1YmxpYyBXZWJDb3JlOjpJbnNwZWN0b3JGcm9u dGVuZENsaWVudCB7CitjbGFzcyBXZWJJbnNwZWN0b3JVSSA6IHB1YmxpYyBSZWZDb3VudGVkPFdl Ykluc3BlY3RvclVJPiwgcHVibGljIElQQzo6Q29ubmVjdGlvbjo6Q2xpZW50LCBwdWJsaWMgV2Vi Q29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnQgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8 V2ViSW5zcGVjdG9yVUk+IGNyZWF0ZShXZWJQYWdlKik7CiAK