149041 2015-09-10 13:08:34 -0700 Web Inspector: Prefer calling ContentViewContainer.updateLayout directly 2015-09-10 14:13:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1124992 0 mattbaker 2015-09-10 13:08:34 -0700 * SUMMARY Prefer calling ContentViewContainer.updateLayout directly. Parent views shouldn't manually call updateLayout on the container's current view. 1124993 1 webkit-bug-importer 2015-09-10 13:09:04 -0700 <rdar://problem/22648658> 1124995 2 260945 mattbaker 2015-09-10 13:12:34 -0700 Created attachment 260945 [Patch] Proposed Fix 1125023 3 260945 commit-queue 2015-09-10 14:13:35 -0700 Comment on attachment 260945 [Patch] Proposed Fix Clearing flags on attachment: 260945 Committed r189590: <http://trac.webkit.org/changeset/189590> 1125024 4 commit-queue 2015-09-10 14:13:38 -0700 All reviewed patches have been landed. Closing bug. 260945 2015-09-10 13:12:34 -0700 2015-09-10 14:13:35 -0700 [Patch] Proposed Fix bug-149041-20150910131227.patch text/plain 2664 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy MDMxOTExNjc2NzdhY2U0MGNmNTNkNWI1NzVmM2ZjOGYwNzQyOTU5Li5lOWZiZThlY2YxMzhlNjg1 MWZmNGZhN2Y5ZGM3ZjRhZWE5ZTcyZTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wOS0xMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJlZmVyIGNhbGxpbmcgQ29udGVudFZpZXdDb250 YWluZXIudXBkYXRlTGF5b3V0IGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkwNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDbGVhbmVkIHVwIHR3byBwbGFjZXMgd2hlcmUgYSBwYXJlbnQg dmlldyBkdXBsaWNhdGVkIGxvZ2ljIGVuY2Fwc3VsYXRlZCBieSBDb250ZW50Vmlld0NvbnRhaW5l ci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ2x1c3RlckNvbnRlbnRWaWV3Lmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNsdXN0ZXJDb250ZW50Vmlldy5wcm90b3R5cGUudXBk YXRlTGF5b3V0KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3Jk aW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRp bmdDb250ZW50Vmlldy5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKwogMjAxNS0wOS0wOCAgTWF0 dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog UkVHUkVTU0lPTiAocjE4OTE4OSk6IE1pc3NpbmcgYnJlYWtwb2ludCBjb250ZXh0IG1lbnUgZm9y IGRlYnVnZ2VyIHNpZGViYXIgdHJlZSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2x1c3RlckNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2x1c3RlckNvbnRlbnRWaWV3 LmpzCmluZGV4IDY2MWJlNTI3ZDI0YzA4NTg5NzM4ZjdjZGVkODUxODkxM2E3NGZhYzAuLjA0MTM1 OTE2Mjk5NTcxNjE4ZGU1OTYxYTk1MjNiYzcxYjIyNGM5MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NsdXN0ZXJDb250ZW50Vmlldy5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DbHVzdGVyQ29u dGVudFZpZXcuanMKQEAgLTYyLDkgKzYyLDcgQEAgV2ViSW5zcGVjdG9yLkNsdXN0ZXJDb250ZW50 VmlldyA9IGNsYXNzIENsdXN0ZXJDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KIAog ICAgIHVwZGF0ZUxheW91dCgpCiAgICAgewotICAgICAgICB2YXIgY3VycmVudENvbnRlbnRWaWV3 ID0gdGhpcy5fY29udGVudFZpZXdDb250YWluZXIuY3VycmVudENvbnRlbnRWaWV3OwotICAgICAg ICBpZiAoY3VycmVudENvbnRlbnRWaWV3KQotICAgICAgICAgICAgY3VycmVudENvbnRlbnRWaWV3 LnVwZGF0ZUxheW91dCgpOworICAgICAgICB0aGlzLl9jb250ZW50Vmlld0NvbnRhaW5lci51cGRh dGVMYXlvdXQoKTsKICAgICB9CiAKICAgICBzaG93bigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRleCA1Zjg5NmQ1OGI5ZTkxNDA3ZWIwZjZiNDE2 NTgxYTNmZDNiZTQ0MjlhLi5mZDIwMmRkMmQwZjBhYjMxNjY1ZDlmNmY0YTgxN2YzMWJlOTM0NDVl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U aW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKQEAg LTIxMywxMCArMjEzLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZp ZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGUKICAgICB1cGRhdGVMYXlv dXQoKQogICAgIHsKICAgICAgICAgdGhpcy5fY3VycmVudFRpbWVsaW5lT3ZlcnZpZXcudXBkYXRl TGF5b3V0Rm9yUmVzaXplKCk7Ci0KLSAgICAgICAgdmFyIGN1cnJlbnRDb250ZW50VmlldyA9IHRo aXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmN1cnJlbnRDb250ZW50VmlldzsKLSAgICAgICAgaWYg KGN1cnJlbnRDb250ZW50VmlldykKLSAgICAgICAgICAgIGN1cnJlbnRDb250ZW50Vmlldy51cGRh dGVMYXlvdXQoKTsKKyAgICAgICAgdGhpcy5fY29udGVudFZpZXdDb250YWluZXIudXBkYXRlTGF5 b3V0KCk7CiAgICAgfQogCiAgICAgc2F2ZVRvQ29va2llKGNvb2tpZSkK