149040 2015-09-10 12:48:51 -0700 Web Inspector: Remove unused member in WebPage 2015-09-10 14:06:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1124983 0 joepeck 2015-09-10 12:48:51 -0700 * SUMMARY Remove unused member (m_inspectorClient) in WebPage. 1124984 1 260942 joepeck 2015-09-10 12:49:54 -0700 Created attachment 260942 [PATCH] Proposed Fix 1124988 2 260942 bburg 2015-09-10 12:55:11 -0700 Comment on attachment 260942 [PATCH] Proposed Fix r=me (assuming EWS), wonder why this was there before. 1124999 3 joepeck 2015-09-10 13:16:16 -0700 (In reply to comment #2) > Comment on attachment 260942 [details] > [PATCH] Proposed Fix > > r=me (assuming EWS), wonder why this was there before. Previously it was passed to WebKit::WebInspector, but it isn't anymore. 1125019 4 260942 commit-queue 2015-09-10 14:06:12 -0700 Comment on attachment 260942 [PATCH] Proposed Fix Clearing flags on attachment: 260942 Committed r189589: <http://trac.webkit.org/changeset/189589> 1125020 5 commit-queue 2015-09-10 14:06:17 -0700 All reviewed patches have been landed. Closing bug. 260942 2015-09-10 12:49:54 -0700 2015-09-10 14:06:12 -0700 [PATCH] Proposed Fix unused-member.patch text/plain 2235 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNTI3YzkwLi43NGNlOTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTUtMDktMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2VkIG1lbWJlciBpbiBXZWJQYWdlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkwNDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5oOgorCiAyMDE1LTA5LTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBXZWJJbnNwZWN0b3JQcm94eSBpbnNw ZWN0b3JVUkwgcGF0aCBtZXRob2RzIHN0YXRpYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDYxZGI4NGQuLjQ0MzMzNDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTMzNyw3ICszMzcs NiBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwgY29uc3QgV2ViUGFnZUNyZWF0 aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICAgICAsIG1faW5EeW5hbWljU2l6ZVVwZGF0ZShm YWxzZSkKICAgICAsIG1fdm9sYXRpbGl0eVRpbWVyKCp0aGlzLCAmV2ViUGFnZTo6dm9sYXRpbGl0 eVRpbWVyRmlyZWQpCiAjZW5kaWYKLSAgICAsIG1faW5zcGVjdG9yQ2xpZW50KDApCiAgICAgLCBt X2JhY2tncm91bmRDb2xvcihDb2xvcjo6d2hpdGUpCiAgICAgLCBtX21heGltdW1SZW5kZXJpbmdT dXBwcmVzc2lvblRva2VuKDApCiAgICAgLCBtX3Njcm9sbFBpbm5pbmdCZWhhdmlvcihEb05vdFBp bikKQEAgLTM3MCw4ICszNjksNyBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwg Y29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICAgICBwYWdlQ29u ZmlndXJhdGlvbi5kcmFnQ2xpZW50ID0gbmV3IFdlYkRyYWdDbGllbnQodGhpcyk7CiAjZW5kaWYK ICAgICBwYWdlQ29uZmlndXJhdGlvbi5iYWNrRm9yd2FyZENsaWVudCA9IFdlYkJhY2tGb3J3YXJk TGlzdFByb3h5OjpjcmVhdGUodGhpcyk7Ci0gICAgbV9pbnNwZWN0b3JDbGllbnQgPSBuZXcgV2Vi SW5zcGVjdG9yQ2xpZW50KHRoaXMpOwotICAgIHBhZ2VDb25maWd1cmF0aW9uLmluc3BlY3RvckNs aWVudCA9IG1faW5zcGVjdG9yQ2xpZW50OworICAgIHBhZ2VDb25maWd1cmF0aW9uLmluc3BlY3Rv ckNsaWVudCA9IG5ldyBXZWJJbnNwZWN0b3JDbGllbnQodGhpcyk7CiAjaWYgVVNFKEFVVE9DT1JS RUNUSU9OX1BBTkVMKQogICAgIHBhZ2VDb25maWd1cmF0aW9uLmFsdGVybmF0aXZlVGV4dENsaWVu dCA9IG5ldyBXZWJBbHRlcm5hdGl2ZVRleHRDbGllbnQodGhpcyk7CiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IDQzNjI0NGMuLmQyMDdj MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAt MTM4MSw4ICsxMzgxLDYgQEAgcHJpdmF0ZToKICAgICBXZWJDb3JlOjpUaW1lciBtX3ZvbGF0aWxp dHlUaW1lcjsKICNlbmRpZgogCi0gICAgV2ViSW5zcGVjdG9yQ2xpZW50KiBtX2luc3BlY3RvckNs aWVudDsKLQogICAgIEhhc2hTZXQ8U3RyaW5nLCBDYXNlRm9sZGluZ0hhc2g+IG1fbWltZVR5cGVz V2l0aEN1c3RvbUNvbnRlbnRQcm92aWRlcnM7CiAgICAgV2ViQ29yZTo6Q29sb3IgbV9iYWNrZ3Jv dW5kQ29sb3I7CiAK