149028 2015-09-09 19:06:47 -0700 ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEachCodeBlock 2015-09-10 10:11:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin fpizlo ggaren mark.lam saam oldest_to_newest 1124803 0 ysuzuki 2015-09-09 19:06:47 -0700 ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEachCodeBlock 1124804 1 260903 ysuzuki 2015-09-09 19:07:42 -0700 Created attachment 260903 Patch 1124805 2 ysuzuki 2015-09-09 19:11:01 -0700 I searched with FunctionExecutableType and ensured that ModuleProgramExecutableType is handled in the other place. 1124827 3 260903 ysuzuki 2015-09-09 21:18:28 -0700 Comment on attachment 260903 Patch I'll merge this to https://bugs.webkit.org/show_bug.cgi?id=149027 1124828 4 ysuzuki 2015-09-09 21:18:50 -0700 *** This bug has been marked as a duplicate of bug 149027 *** 1124832 5 ysuzuki 2015-09-09 21:34:17 -0700 This is also difficult to reproduce this crash stably, so in the meantime, we 1124833 6 ysuzuki 2015-09-09 21:41:59 -0700 I attempted to merge this and https://bugs.webkit.org/show_bug.cgi?id=149027 with GC related tests, but they are difficult to reproduce with the tests. So in the meantime, separate these patches. 1124835 7 ysuzuki 2015-09-09 21:43:23 -0700 These faults are figured out during the ES6 Module WebCore integration. 1124886 8 260903 msaboff 2015-09-10 06:09:22 -0700 Comment on attachment 260903 Patch r=me 1124911 9 260903 ysuzuki 2015-09-10 09:25:10 -0700 Comment on attachment 260903 Patch Thank you! 1124927 10 260903 commit-queue 2015-09-10 10:11:45 -0700 Comment on attachment 260903 Patch Clearing flags on attachment: 260903 Committed r189571: <http://trac.webkit.org/changeset/189571> 1124928 11 commit-queue 2015-09-10 10:11:51 -0700 All reviewed patches have been landed. Closing bug. 260903 2015-09-09 19:07:42 -0700 2015-09-10 10:11:45 -0700 Patch bug-149028-20150909190735.patch text/plain 2277 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZDc3MDI3NWI4M2M3ZTI0OWZjMTYzYzkwMmVkODg2NDQwM2Y0M2U3Li40MmVhMzA0YzhjODY3Zjll MGFkZDlkYTk0ZTExYjFjMWY5NWUxODUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0wOS0wOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBNb2R1bGVQcm9ncmFtRXhlY3V0YWJsZSBzaG91bGQgcHJvdmlkZSBD b2RlQmxvY2sgdG8gU2NyaXB0RXhlY3V0YWJsZTo6Zm9yRWFjaENvZGVCbG9jaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MDI4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kdWxlUHJvZ3JhbUV4ZWN1 dGFibGUgc2hvdWxkIHByb3ZpZGUgQ29kZUJsb2NrIHNpbmNlIE1vZHVsZVByb2dyYW1FeGVjdXRh YmxlIGluaGVyaXRzCisgICAgICAgIFNjcmlwdEV4ZWN1dGFibGUuCisKKyAgICAgICAgKiBieXRl Y29kZS9Db2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6U2NyaXB0RXhlY3V0YWJsZTo6Zm9yRWFj aENvZGVCbG9jayk6CisKIDIwMTUtMDktMDkgIFN1a29sc2FrIFNha3NodXdvbmcgIDxzdWtvbHNh a0BnbWFpbC5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGludGVybmFsIGNhbGxzIGluIFdlYkFz c2VtYmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJs b2NrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKaW5kZXgg ZTYyMGU3ZWI3NTAxZjc4NTM1MjQxOWJjZjIwMWNhYzI5NDdlMTczZC4uYTUxZDBjZGRlZmRkNmNh OTFiMmU3OWU2MTIzOTY3N2FhNmMyYWZmYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9Db2RlQmxvY2suaApAQCAtMTI1NiwxMyArMTI1NiwxMyBAQCB0ZW1wbGF0ZSA8dHlwZW5h bWUgRnVuY3Rvcj4gaW5saW5lIHZvaWQgU2NyaXB0RXhlY3V0YWJsZTo6Zm9yRWFjaENvZGVCbG9j ayhGdW5jdAogICAgICAgICAgICAgY29kZUJsb2NrLT5mb3JFYWNoUmVsYXRlZENvZGVCbG9jayhz dGQ6OmZvcndhcmQ8RnVuY3Rvcj4oZnVuY3RvcikpOwogICAgICAgICBicmVhazsKICAgICB9Ci0g ICAgICAgIAorCiAgICAgY2FzZSBFdmFsRXhlY3V0YWJsZVR5cGU6IHsKICAgICAgICAgaWYgKENv ZGVCbG9jayogY29kZUJsb2NrID0ganNDYXN0PEV2YWxFeGVjdXRhYmxlKj4odGhpcyktPm1fZXZh bENvZGVCbG9jay5nZXQoKSkKICAgICAgICAgICAgIGNvZGVCbG9jay0+Zm9yRWFjaFJlbGF0ZWRD b2RlQmxvY2soc3RkOjpmb3J3YXJkPEZ1bmN0b3I+KGZ1bmN0b3IpKTsKICAgICAgICAgYnJlYWs7 CiAgICAgfQotICAgICAgICAKKwogICAgIGNhc2UgRnVuY3Rpb25FeGVjdXRhYmxlVHlwZTogewog ICAgICAgICBGdW5jdG9yIGYoc3RkOjpmb3J3YXJkPEZ1bmN0b3I+KGZ1bmN0b3IpKTsKICAgICAg ICAgRnVuY3Rpb25FeGVjdXRhYmxlKiBleGVjdXRhYmxlID0ganNDYXN0PEZ1bmN0aW9uRXhlY3V0 YWJsZSo+KHRoaXMpOwpAQCAtMTI3Miw2ICsxMjcyLDEzIEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBG dW5jdG9yPiBpbmxpbmUgdm9pZCBTY3JpcHRFeGVjdXRhYmxlOjpmb3JFYWNoQ29kZUJsb2NrKEZ1 bmN0CiAgICAgICAgICAgICBjb2RlQmxvY2stPmZvckVhY2hSZWxhdGVkQ29kZUJsb2NrKGYpOwog ICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBjYXNlIE1vZHVsZVByb2dyYW1FeGVjdXRhYmxl VHlwZTogeworICAgICAgICBpZiAoQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBqc0Nhc3Q8TW9kdWxl UHJvZ3JhbUV4ZWN1dGFibGUqPih0aGlzKS0+bV9tb2R1bGVQcm9ncmFtQ29kZUJsb2NrLmdldCgp KQorICAgICAgICAgICAgY29kZUJsb2NrLT5mb3JFYWNoUmVsYXRlZENvZGVCbG9jayhzdGQ6OmZv cndhcmQ8RnVuY3Rvcj4oZnVuY3RvcikpOworICAgICAgICBicmVhazsKKyAgICB9CisKICAgICBk ZWZhdWx0OgogICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0K