149013 2015-09-09 15:25:42 -0700 Web Inspector: Remove unused InspectorFrontendHost methods 2015-09-09 16:16:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1124717 0 joepeck 2015-09-09 15:25:42 -0700 * SUMMARY Remove unused InspectorFrontendHost methods. - IFH.canSaveAs - frontends should just use IFH.canSave (currently we don't so other ports would have issues saving...) - IFH.canInspectWorkers - this is a backend question, not a frontend host question, and there is Worker.canInspectWorkers 1124718 1 260882 joepeck 2015-09-09 15:26:23 -0700 Created attachment 260882 [PATCH] Proposed Fix 1124719 2 260882 bburg 2015-09-09 15:29:07 -0700 Comment on attachment 260882 [PATCH] Proposed Fix r=me 1124738 3 260882 commit-queue 2015-09-09 16:16:36 -0700 Comment on attachment 260882 [PATCH] Proposed Fix Clearing flags on attachment: 260882 Committed r189558: <http://trac.webkit.org/changeset/189558> 1124740 4 commit-queue 2015-09-09 16:16:42 -0700 All reviewed patches have been landed. Closing bug. 260882 2015-09-09 15:26:23 -0700 2015-09-09 16:16:36 -0700 [PATCH] Proposed Fix rm-more.patch text/plain 2176 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYjcyNTBkLi42YzQzYjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDktMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2VkIEluc3BlY3RvckZyb250ZW5kSG9z dCBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDkwMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpjYW5TYXZlQXMpOiBEZWxldGVkLgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpjYW5JbnNwZWN0V29ya2Vycyk6IERlbGV0 ZWQuCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oOgorICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsOgorCiAyMDE1LTA5LTA4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogTm8gbmVlZCBmb3IgW0N1c3RvbV0gSW1wbGVtZW50YXRpb24gb2Ygc29tZSBJbnNwZWN0 b3JGcm9udGVuZEhvc3QgbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAppbmRleCA0ZmM2MWExLi44ODg1ZTFjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcApA QCAtMzQ2LDE0ICszNDYsNCBAQCB2b2lkIEluc3BlY3RvckZyb250ZW5kSG9zdDo6YmVlcCgpCiAg ICAgc3lzdGVtQmVlcCgpOwogfQogCi1ib29sIEluc3BlY3RvckZyb250ZW5kSG9zdDo6Y2FuU2F2 ZUFzKCkKLXsKLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLWJvb2wgSW5zcGVjdG9yRnJvbnRlbmRI b3N0OjpjYW5JbnNwZWN0V29ya2VycygpCi17Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRnJvbnRlbmRIb3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRnJvbnRlbmRIb3N0LmgKaW5kZXggOTA2ZDMwZC4uNWVmODNjNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaApAQCAtOTIsOSArOTIs NiBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGJlZXAoKTsKIAotICAgIGJvb2wgY2FuSW5zcGVjdFdv cmtlcnMoKTsKLSAgICBib29sIGNhblNhdmVBcygpOwotCiBwcml2YXRlOgogI2lmIEVOQUJMRShD T05URVhUX01FTlVTKQogICAgIGZyaWVuZCBjbGFzcyBGcm9udGVuZE1lbnVQcm92aWRlcjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3Qu aWRsIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwK aW5kZXggODQ5YTQyYy4uOTE5Y2Q3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwKQEAgLTcwLDggKzcwLDQgQEAKICAgICBib29s ZWFuIGlzVW5kZXJUZXN0KCk7CiAKICAgICB2b2lkIGJlZXAoKTsKLQotICAgIC8vIERlcHJlY2F0 ZWQKLSAgICBib29sZWFuIGNhbkluc3BlY3RXb3JrZXJzKCk7Ci0gICAgYm9vbGVhbiBjYW5TYXZl QXMoKTsKIH07Cg==