149005 2015-09-09 10:59:20 -0700 Setting document.title when there is no title and no head element should no nothing 2015-09-09 15:12:01 -0700 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/dom.html#document.title InRadar, WebExposed P2 Normal --- 1 cdumez cdumez ap commit-queue esprehn+autocc kangil.han rniwa webkit-bug-importer oldest_to_newest 1124642 0 cdumez 2015-09-09 10:59:20 -0700 Setting document.title when there is no title and no head element should no nothing: https://html.spec.whatwg.org/multipage/dom.html#document.title Firefox and Chrome comply with the specification. However, WebKit returns the updated title when querying document.title after setting it. 1124643 1 cdumez 2015-09-09 10:59:54 -0700 rdar://problem/22567524 1124647 2 260865 cdumez 2015-09-09 11:30:03 -0700 Created attachment 260865 Patch 1124696 3 260865 rniwa 2015-09-09 14:25:51 -0700 Comment on attachment 260865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260865&action=review > Source/WebCore/dom/Document.cpp:1541 > + m_titleElement = createElement(titleTag, false); This boolean argument sucks :( We should replace it with enum class in the future. 1124711 4 260865 commit-queue 2015-09-09 15:11:55 -0700 Comment on attachment 260865 Patch Clearing flags on attachment: 260865 Committed r189555: <http://trac.webkit.org/changeset/189555> 1124712 5 commit-queue 2015-09-09 15:12:01 -0700 All reviewed patches have been landed. Closing bug. 260865 2015-09-09 11:30:03 -0700 2015-09-09 15:11:55 -0700 Patch bug-149005-20150909112957.patch text/plain 5098 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZiNGVmMGY2N2IyOGNi YTFhNjA3ZDdlZTExOGRkYjAzZWExMzg2OS4uNmY3NmQ0OWM5YzZiM2E4MDk1NTRmN2Q3YjA4YTRl NDg3YWZiMGIzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA5LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2V0dGluZyBkb2N1bWVudC50 aXRsZSB3aGVuIHRoZXJlIGlzIG5vIHRpdGxlIGFuZCBubyBoZWFkIGVsZW1lbnQgc2hvdWxkIG5v IG5vdGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0OTAwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjI1Njc1MjQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyBkb2N1bWVudC50aXRs ZSB3aGVuIHRoZXJlIGlzIG5vIHRpdGxlIGVsZW1lbnQgYW5kIG5vIGhlYWQKKyAgICAgICAgZWxl bWVudCBzaG91bGQgbm8gbm90aGluZzoKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnL211bHRpcGFnZS9kb20uaHRtbCNkb2N1bWVudC50aXRsZQorCisgICAgICAgIEZpcmVm b3ggYW5kIENocm9tZSBjb21wbHkgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbi4gSG93ZXZlciwgV2Vi S2l0CisgICAgICAgIHdhcyByZXR1cm5pbmcgdGhlIHVwZGF0ZWQgdGl0bGUgd2hlbiBxdWVyeWlu ZyBkb2N1bWVudC50aXRsZSBhZnRlcgorICAgICAgICBzZXR0aW5nIGl0LgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGRvbS9E b2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0VGl0bGUpOgorCiAy MDE1LTA5LTA5ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTg5NTM2IGFuZCByMTg5NTM4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKaW5kZXggYzA5NDFkMjUxOTE0MTQ1ODIwYjViZGM1MzA1OGQ2OGNkOTNm MzRhYi4uOWUwOWUzYzAzZDNhYWZiMjAxYTk3NWFmYTRiNWJkZWI3OGU0NmYzOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCkBAIC0xNTM1LDEwICsxNTM1LDExIEBAIHZvaWQgRG9jdW1lbnQ6OnNl dFRpdGxlKGNvbnN0IFN0cmluZyYgdGl0bGUpCiAgICAgaWYgKCFpc0hUTUxEb2N1bWVudCgpICYm ICFpc1hIVE1MRG9jdW1lbnQoKSkKICAgICAgICAgbV90aXRsZUVsZW1lbnQgPSBudWxscHRyOwog ICAgIGVsc2UgaWYgKCFtX3RpdGxlRWxlbWVudCkgewotICAgICAgICBpZiAoSFRNTEVsZW1lbnQq IGhlYWRFbGVtZW50ID0gaGVhZCgpKSB7Ci0gICAgICAgICAgICBtX3RpdGxlRWxlbWVudCA9IGNy ZWF0ZUVsZW1lbnQodGl0bGVUYWcsIGZhbHNlKTsKLSAgICAgICAgICAgIGhlYWRFbGVtZW50LT5h cHBlbmRDaGlsZChtX3RpdGxlRWxlbWVudCwgQVNTRVJUX05PX0VYQ0VQVElPTik7Ci0gICAgICAg IH0KKyAgICAgICAgYXV0byogaGVhZEVsZW1lbnQgPSBoZWFkKCk7CisgICAgICAgIGlmICghaGVh ZEVsZW1lbnQpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIG1fdGl0bGVFbGVtZW50ID0g Y3JlYXRlRWxlbWVudCh0aXRsZVRhZywgZmFsc2UpOworICAgICAgICBoZWFkRWxlbWVudC0+YXBw ZW5kQ2hpbGQobV90aXRsZUVsZW1lbnQsIEFTU0VSVF9OT19FWENFUFRJT04pOwogICAgIH0KIAog ICAgIC8vIFRoZSBET00gQVBJIGhhcyBubyBtZXRob2Qgb2Ygc3BlY2lmeWluZyBkaXJlY3Rpb24s IHNvIGFzc3VtZSBMVFIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA3Mjc4MmUw NTIwN2RlMzVhZjIxODkwYmY3MGM4MzJmOTFhNWIyZDE0Li5hYmIxM2JjYjVlNzdiZmE1NTk3MDIw YmY0NDYxNjc5ODc4ZjFiZTI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0wOS0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIFNldHRpbmcgZG9jdW1lbnQudGl0bGUgd2hlbiB0aGVyZSBpcyBubyB0aXRsZSBh bmQgbm8gaGVhZCBlbGVtZW50IHNob3VsZCBubyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkwMDUKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzIyNTY3NTI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlYmFzZWxpbmUgdGVzdHMgbm93IHRoYXQgbW9yZSBjaGVja3MgYXJlIHBhc3Npbmcu CisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9jdW1lbnRzL2RvbS10 cmVlLWFjY2Vzc29ycy9kb2N1bWVudC50aXRsZS0wMS1leHBlY3RlZC50eHQ6CisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2RvY3VtZW50cy9kb20tdHJlZS1hY2Nlc3NvcnMv ZG9jdW1lbnQudGl0bGUtMDItZXhwZWN0ZWQudHh0OgorCiAyMDE1LTA5LTA4ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZHJvcCBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQv bWVkaWEtZWxlbWVudHMvbG9jYXRpb24tb2YtdGhlLW1lZGlhLXJlc291cmNlL2N1cnJlbnRTcmMu aHRtbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9kb20vZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29ycy9kb2N1bWVudC50aXRs ZS0wMS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2h0bWwvZG9tL2RvY3VtZW50cy9kb20tdHJlZS1hY2Nlc3NvcnMvZG9jdW1lbnQudGl0 bGUtMDEtZXhwZWN0ZWQudHh0CmluZGV4IDBlZjczNmNjMmQxMjllMjkwZGE1MzZlZjdkYzVkY2Fk ODViM2U3ZGUuLjA5OThhNzFmNGUwOWRkOGM1NmRmMTg1YmQyOWE1OGQwMDY0Y2FiYjkgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9k b20vZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29ycy9kb2N1bWVudC50aXRsZS0wMS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9o dG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50LnRpdGxlLTAxLWV4 cGVjdGVkLnR4dApAQCAtMSw2ICsxLDYgQEAKIAogUEFTUyBkb2N1bWVudC50aXRsZSB3aXRoIGhl YWQgYmxvd24gYXdheSAKLUZBSUwgZG9jdW1lbnQudGl0bGUgd2l0aCBoZWFkIGJsb3duIGF3YXkg MSBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiIiBidXQgZ290ICJGQUlMIgotRkFJTCBVbnRpdGxl ZCAyIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJQQVNTIiBidXQgZ290ICJGQUlMIgotRkFJTCBQ QVNTIDMgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIlBBU1MyIiBidXQgZ290ICJGQUlMIgorUEFT UyBkb2N1bWVudC50aXRsZSB3aXRoIGhlYWQgYmxvd24gYXdheSAxIAorRkFJTCBVbnRpdGxlZCAy IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJQQVNTIiBidXQgZ290ICIiCitGQUlMIFBBU1MgMyBh c3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiUEFTUzIiIGJ1dCBnb3QgIiIKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1 bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50LnRpdGxlLTAyLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9j dW1lbnRzL2RvbS10cmVlLWFjY2Vzc29ycy9kb2N1bWVudC50aXRsZS0wMi1leHBlY3RlZC50eHQK aW5kZXggMGVmNzM2Y2MyZDEyOWUyOTBkYTUzNmVmN2RjNWRjYWQ4NWIzZTdkZS4uMDk5OGE3MWY0 ZTA5ZGQ4YzU2ZGYxODViZDI5YTU4ZDAwNjRjYWJiOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1bWVudHMvZG9tLXRy ZWUtYWNjZXNzb3JzL2RvY3VtZW50LnRpdGxlLTAyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2RvY3VtZW50cy9k b20tdHJlZS1hY2Nlc3NvcnMvZG9jdW1lbnQudGl0bGUtMDItZXhwZWN0ZWQudHh0CkBAIC0xLDYg KzEsNiBAQAogCiBQQVNTIGRvY3VtZW50LnRpdGxlIHdpdGggaGVhZCBibG93biBhd2F5IAotRkFJ TCBkb2N1bWVudC50aXRsZSB3aXRoIGhlYWQgYmxvd24gYXdheSAxIGFzc2VydF9lcXVhbHM6IGV4 cGVjdGVkICIiIGJ1dCBnb3QgIkZBSUwiCi1GQUlMIFVudGl0bGVkIDIgYXNzZXJ0X2VxdWFsczog ZXhwZWN0ZWQgIlBBU1MiIGJ1dCBnb3QgIkZBSUwiCi1GQUlMIFBBU1MgMyBhc3NlcnRfZXF1YWxz OiBleHBlY3RlZCAiUEFTUzIiIGJ1dCBnb3QgIkZBSUwiCitQQVNTIGRvY3VtZW50LnRpdGxlIHdp dGggaGVhZCBibG93biBhd2F5IDEgCitGQUlMIFVudGl0bGVkIDIgYXNzZXJ0X2VxdWFsczogZXhw ZWN0ZWQgIlBBU1MiIGJ1dCBnb3QgIiIKK0ZBSUwgUEFTUyAzIGFzc2VydF9lcXVhbHM6IGV4cGVj dGVkICJQQVNTMiIgYnV0IGdvdCAiIgogCg==