148995 2015-09-08 23:10:37 -0700 sendProcessWillSuspendImminently uses a wrong message flag 2015-09-10 13:14:05 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap dbates andersca barraclough dbates oldest_to_newest 1124562 0 ap 2015-09-08 23:10:37 -0700 WebProcessProxy::sendProcessWillSuspendImminently (and its NetworkProcess counterpart) passes IPC::InterruptWaitingIfSyncMessageArrives to sendSync, but this value can only be used with waitForMessage. Not sure if this is a real bug - this flag gets interpreted as IPC::InformPlatformProcessWillSuspend, which may or may not be what we are after here. This code was added in http://trac.webkit.org/r184105 1124976 1 260940 dbates 2015-09-10 12:32:22 -0700 Created attachment 260940 Patch 1124986 2 260940 ap 2015-09-10 12:51:34 -0700 Comment on attachment 260940 Patch Looks good, however please make the same fix in NetworkProcessProxy. 1124996 3 dbates 2015-09-10 13:13:09 -0700 (In reply to comment #2) > Comment on attachment 260940 [details] > Patch > > Looks good, however please make the same fix in NetworkProcessProxy. Will fix before landing. 1124997 4 dbates 2015-09-10 13:14:05 -0700 Committed r189587: <http://trac.webkit.org/changeset/189587> 260940 2015-09-10 12:32:22 -0700 2015-09-10 12:51:34 -0700 Patch bug-148995-20150910123216.patch text/plain 1737 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzA1NzZhYjVkMTA5NDYx MjdhZDVjY2RhYTVkYTU3YjYwMjNjYTY0My4uNzdhNmZiMThlNGZjOGFjOWFkNWM4OTY2ZTBkYzky MDgyN2ZiNGNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTEwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBzZW5kUHJvY2Vzc1dpbGxT dXNwZW5kSW1taW5lbnRseSB1c2VzIGEgd3JvbmcgbWVzc2FnZSBmbGFnCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg5OTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdXNlIG9mIGZsYWcgSVBD OjpJbnRlcnJ1cHRXYWl0aW5nSWZTeW5jTWVzc2FnZUFycml2ZXMgYXMgaXQgZG9lcyBub3QgbWFr ZQorICAgICAgICBzZW5zZSB3aGVuIHNlbmRpbmcgYSBzeW5jIG1lc3NhZ2UuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJv Y2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseSk6CisKIDIwMTUtMDkt MDcgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIERlYnVn UmVsZWFzZSBidWlsZHMgc2hvdWxkIGxpbmsgYWdhaW5zdCBsaWJXZWJLaXRTeXN0ZW1JbnRlcmZh Y2VFbENhcGl0YW4uYSBvbiAxMC4xMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcAppbmRleCAyNzFjNWRiZWEzODdiOGY0MGUzZjc2MzAyZTM5OWZiYTg4NDcx NWI0Li5iNGQwZjU5ZGU2NTY0ODZjZjUwYWFhZGY3NGNkMjA0MGNjNzZhNTY2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApAQCAtODkzLDggKzg5Myw3 IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpzZW5kUHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRs eSgpCiAgICAgICAgIHJldHVybjsKIAogICAgIGJvb2wgaGFuZGxlZCA9IGZhbHNlOwotICAgIHNl bmRTeW5jKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpQcm9jZXNzV2lsbFN1c3BlbmRJbW1pbmVudGx5 KCksIE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpQcm9jZXNzV2lsbFN1c3BlbmRJbW1pbmVudGx5OjpS ZXBseShoYW5kbGVkKSwKLSAgICAgICAgMCwgc3RkOjpjaHJvbm86OnNlY29uZHMoMSksIElQQzo6 SW50ZXJydXB0V2FpdGluZ0lmU3luY01lc3NhZ2VBcnJpdmVzKTsKKyAgICBzZW5kU3luYyhNZXNz YWdlczo6V2ViUHJvY2Vzczo6UHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseSgpLCBNZXNzYWdl czo6V2ViUHJvY2Vzczo6UHJvY2Vzc1dpbGxTdXNwZW5kSW1taW5lbnRseTo6UmVwbHkoaGFuZGxl ZCksIDAsIHN0ZDo6Y2hyb25vOjpzZWNvbmRzKDEpKTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzUHJv eHk6OnNlbmRQcmVwYXJlVG9TdXNwZW5kKCkK