148990 2015-09-08 18:34:39 -0700 Web Inspector: No need for [Custom] Implementation of some InspectorFrontendHost methods 2015-09-08 19:40:54 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1124505 0 joepeck 2015-09-08 18:34:39 -0700 * SUMMARY No need for [Custom] Implementation of some InspectorFrontendHost methods. Namely platform/port. 1124508 1 260823 joepeck 2015-09-08 18:35:58 -0700 Created attachment 260823 [PATCH] Proposed Fix 1124514 2 260823 commit-queue 2015-09-08 19:40:50 -0700 Comment on attachment 260823 [PATCH] Proposed Fix Clearing flags on attachment: 260823 Committed r189528: <http://trac.webkit.org/changeset/189528> 1124515 3 commit-queue 2015-09-08 19:40:54 -0700 All reviewed patches have been landed. Closing bug. 260823 2015-09-08 18:35:58 -0700 2015-09-08 19:40:50 -0700 [PATCH] Proposed Fix uncustom.patch text/plain 5129 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYTE0MmIxLi5kYjcyNTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDktMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBObyBuZWVkIGZvciBbQ3VzdG9tXSBJbXBsZW1lbnRhdGlv biBvZiBzb21lIEluc3BlY3RvckZyb250ZW5kSG9zdCBtZXRob2RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg5OTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSW5zcGVjdG9y RnJvbnRlbmRIb3N0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTSW5zcGVjdG9yRnJv bnRlbmRIb3N0OjpwbGF0Zm9ybSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpKU0luc3Bl Y3RvckZyb250ZW5kSG9zdDo6cG9ydCk6IERlbGV0ZWQuCisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3RvckZyb250ZW5kSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9u dGVuZEhvc3Q6OnBsYXRmb3JtKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckZyb250ZW5k SG9zdDo6cG9ydCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5o OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsOgorICAgICAg ICBVbmN1c3RvbWl6ZSBhIGZldyBiYXNpYyBmdW5jdGlvbnMuCisKIDIwMTUtMDktMDggIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBkb2N1bWVudC5pbXBvcnROb2Rl KG5vZGUsIGRlZXApOiBkZWVwJ3MgZGVmYXVsdCB2YWx1ZSBzaG91bGQgYmUgZmFsc2UKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVjdG9yRnJvbnRlbmRIb3N0 Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVjdG9yRnJvbnRl bmRIb3N0Q3VzdG9tLmNwcAppbmRleCA4NTUwZWI0Li44N2JiMjc3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luc3BlY3RvckZyb250ZW5kSG9zdEN1c3RvbS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RD dXN0b20uY3BwCkBAIC00OSwzOCArNDksNiBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKLUpTVmFsdWUgSlNJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnBsYXRm b3JtKEV4ZWNTdGF0ZSogZXhlY1N0YXRlKQotewotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZP Uk0oSU9TKQotICAgIERFUFJFQ0FURURfREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcs IHBsYXRmb3JtLCAoQVNDSUlMaXRlcmFsKCJtYWMiKSkpOwotI2VsaWYgT1MoV0lORE9XUykKLSAg ICBERVBSRUNBVEVEX0RFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBwbGF0Zm9ybSwg KEFTQ0lJTGl0ZXJhbCgid2luZG93cyIpKSk7Ci0jZWxpZiBPUyhMSU5VWCkKLSAgICBERVBSRUNB VEVEX0RFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBwbGF0Zm9ybSwgKEFTQ0lJTGl0 ZXJhbCgibGludXgiKSkpOwotI2VsaWYgT1MoRlJFRUJTRCkKLSAgICBERVBSRUNBVEVEX0RFRklO RV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBwbGF0Zm9ybSwgKEFTQ0lJTGl0ZXJhbCgiZnJl ZWJzZCIpKSk7Ci0jZWxpZiBPUyhPUEVOQlNEKQotICAgIERFUFJFQ0FURURfREVGSU5FX1NUQVRJ Q19MT0NBTChjb25zdCBTdHJpbmcsIHBsYXRmb3JtLCAoQVNDSUlMaXRlcmFsKCJvcGVuYnNkIikp KTsKLSNlbGlmIE9TKFNPTEFSSVMpCi0gICAgREVQUkVDQVRFRF9ERUZJTkVfU1RBVElDX0xPQ0FM KGNvbnN0IFN0cmluZywgcGxhdGZvcm0sIChBU0NJSUxpdGVyYWwoInNvbGFyaXMiKSkpOwotI2Vs c2UKLSAgICBERVBSRUNBVEVEX0RFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBwbGF0 Zm9ybSwgKEFTQ0lJTGl0ZXJhbCgidW5rbm93biIpKSk7Ci0jZW5kaWYKLSAgICByZXR1cm4ganNT dHJpbmdXaXRoQ2FjaGUoZXhlY1N0YXRlLCBwbGF0Zm9ybSk7Ci19Ci0KLUpTVmFsdWUgSlNJbnNw ZWN0b3JGcm9udGVuZEhvc3Q6OnBvcnQoRXhlY1N0YXRlKiBleGVjU3RhdGUpCi17Ci0jaWYgUExB VEZPUk0oR1RLKQotICAgIERFUFJFQ0FURURfREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJp bmcsIHBvcnQsIChBU0NJSUxpdGVyYWwoImd0ayIpKSk7Ci0jZWxpZiBQTEFURk9STShFRkwpCi0g ICAgREVQUkVDQVRFRF9ERUZJTkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0cmluZywgcG9ydCwgKEFT Q0lJTGl0ZXJhbCgiZWZsIikpKTsKLSNlbHNlCi0gICAgREVQUkVDQVRFRF9ERUZJTkVfU1RBVElD X0xPQ0FMKGNvbnN0IFN0cmluZywgcG9ydCwgKEFTQ0lJTGl0ZXJhbCgidW5rbm93biIpKSk7Ci0j ZW5kaWYKLSAgICByZXR1cm4ganNTdHJpbmdXaXRoQ2FjaGUoZXhlY1N0YXRlLCBwb3J0KTsKLX0K LQogI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQogc3RhdGljIHZvaWQgcG9wdWxhdGVDb250ZXh0 TWVudUl0ZW1zKEV4ZWNTdGF0ZSogZXhlYywgSlNBcnJheSogYXJyYXksIENvbnRleHRNZW51JiBt ZW51KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRl bmRIb3N0LmNwcAppbmRleCBiNTc1NGQ1Li40ZmM2MWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcApAQCAtMjI1LDYgKzIyNSwz NiBAQCBTdHJpbmcgSW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpkZWJ1Z2dhYmxlVHlwZSgpCiAgICAg cmV0dXJuIEFTQ0lJTGl0ZXJhbCgid2ViIik7CiB9CiAKK1N0cmluZyBJbnNwZWN0b3JGcm9udGVu ZEhvc3Q6OnBsYXRmb3JtKCkKK3sKKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykK KyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJtYWMiKTsKKyNlbGlmIE9TKFdJTkRPV1MpCisgICAg cmV0dXJuIEFTQ0lJTGl0ZXJhbCgid2luZG93cyIpOworI2VsaWYgT1MoTElOVVgpCisgICAgcmV0 dXJuIEFTQ0lJTGl0ZXJhbCgibGludXgiKTsKKyNlbGlmIE9TKEZSRUVCU0QpCisgICAgcmV0dXJu IEFTQ0lJTGl0ZXJhbCgiZnJlZWJzZCIpOworI2VsaWYgT1MoT1BFTkJTRCkKKyAgICByZXR1cm4g QVNDSUlMaXRlcmFsKCJvcGVuYnNkIik7CisjZWxpZiBPUyhTT0xBUklTKQorICAgIHJldHVybiBB U0NJSUxpdGVyYWwoInNvbGFyaXMiKTsKKyNlbHNlCisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgi dW5rbm93biIpOworI2VuZGlmCit9CisKK1N0cmluZyBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnBv cnQoKQoreworI2lmIFBMQVRGT1JNKEdUSykKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJndGsi KTsKKyNlbGlmIFBMQVRGT1JNKEVGTCkKKyAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJlZmwiKTsK KyNlbHNlCisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgidW5rbm93biIpOworI2VuZGlmCit9CisK IHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojpjb3B5VGV4dChjb25zdCBTdHJpbmcmIHRleHQp CiB7CiAgICAgUGFzdGVib2FyZDo6Y3JlYXRlRm9yQ29weUFuZFBhc3RlKCktPndyaXRlUGxhaW5U ZXh0KHRleHQsIFBhc3RlYm9hcmQ6OkNhbm5vdFNtYXJ0UmVwbGFjZSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmggYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmgKaW5kZXggOGYyZWUwYi4u OTA2ZDMwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuaApAQCAtNzAsNiArNzAsOSBAQCBwdWJsaWM6CiAgICAgU3RyaW5nIGxvY2FsaXpl ZFN0cmluZ3NVUkwoKTsKICAgICBTdHJpbmcgZGVidWdnYWJsZVR5cGUoKTsKIAorICAgIFN0cmlu ZyBwbGF0Zm9ybSgpOworICAgIFN0cmluZyBwb3J0KCk7CisKICAgICB2b2lkIGNvcHlUZXh0KGNv bnN0IFN0cmluZyYgdGV4dCk7CiAgICAgdm9pZCBvcGVuSW5OZXdUYWIoY29uc3QgU3RyaW5nJiB1 cmwpOwogICAgIGJvb2wgY2FuU2F2ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAppbmRleCAzYzU5ZmMwLi44NDlhNDJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmlk bAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmlk bApAQCAtNTksOCArNTksOSBAQAogICAgIHZvaWQgYXBwZW5kKERPTVN0cmluZyB1cmwsIERPTVN0 cmluZyBjb250ZW50KTsKICAgICB2b2lkIGNsb3NlKERPTVN0cmluZyB1cmwpOwogCi0gICAgW0N1 c3RvbV0gRE9NU3RyaW5nIHBsYXRmb3JtKCk7Ci0gICAgW0N1c3RvbV0gRE9NU3RyaW5nIHBvcnQo KTsKKyAgICBET01TdHJpbmcgcGxhdGZvcm0oKTsKKyAgICBET01TdHJpbmcgcG9ydCgpOworCiAg ICAgW0N1c3RvbV0gdm9pZCBzaG93Q29udGV4dE1lbnUoTW91c2VFdmVudCBldmVudCwgYW55IGl0 ZW1zKTsKICAgICB2b2lkIGRpc3BhdGNoRXZlbnRBc0NvbnRleHRNZW51RXZlbnQoRXZlbnQgZXZl bnQpOwogICAgIHZvaWQgc2VuZE1lc3NhZ2VUb0JhY2tlbmQoRE9NU3RyaW5nIG1lc3NhZ2UpOwo=