148986 2015-09-08 16:56:03 -0700 Remove unused DFG::dfgConvertJSValueToInt32() 2015-09-08 18:03:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sukolsak webkit-unassigned commit-queue oldest_to_newest 1124465 0 sukolsak 2015-09-08 16:56:03 -0700 Remove unused DFG::dfgConvertJSValueToInt32() and also remove DFG::JITCompiler::callOperation(D_JITOperation_EJ operation, ...) which was introduced in Bug 69806 for dfgConvertJSValueToNumber() and is no longer used. 1124467 1 260813 sukolsak 2015-09-08 17:01:08 -0700 Created attachment 260813 Patch 1124479 2 260813 ggaren 2015-09-08 17:14:56 -0700 Comment on attachment 260813 Patch r=me 1124492 3 260813 commit-queue 2015-09-08 18:03:28 -0700 Comment on attachment 260813 Patch Clearing flags on attachment: 260813 Committed r189523: <http://trac.webkit.org/changeset/189523> 1124493 4 commit-queue 2015-09-08 18:03:31 -0700 All reviewed patches have been landed. Closing bug. 260813 2015-09-08 17:01:08 -0700 2015-09-08 18:03:28 -0700 Patch bug-148986-20150908170103.patch text/plain 4418 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MjdiMDhjNDk1YjA3NzM2ODdiNzQ5OTE0YzBlMGM1MGE5NzAxNzg4Li44NWYyMzk2N2Q1ZDllMzZl MjMyOGE4YWE1NzU5Mjk1N2NkMDVlZjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNS0wOS0wOCAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIERGRzo6ZGZnQ29udmVydEpTVmFsdWVU b0ludDMyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODk4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSB1bnVzZWQgREZHOjpkZmdDb252ZXJ0SlNWYWx1ZVRvSW50MzIoKSBhbmQgYWxzbyBy ZW1vdmUKKyAgICAgICAgREZHOjpKSVRDb21waWxlcjo6Y2FsbE9wZXJhdGlvbihEX0pJVE9wZXJh dGlvbl9FSiBvcGVyYXRpb24sIC4uLikgd2hpY2gKKyAgICAgICAgd2FzIGludHJvZHVjZWQgaW4g QnVnIDY5ODA2IGZvciBkZmdDb252ZXJ0SlNWYWx1ZVRvTnVtYmVyKCkgYW5kIGlzIG5vCisgICAg ICAgIGxvbmdlciB1c2VkLgorCisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgorICAg ICAgICAqIGRmZy9ERkdPcGVyYXRpb25zLmg6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZl SklULmg6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNhbGxPcGVyYXRpb24p OiBEZWxldGVkLgorCiAyMDE1LTA5LTA4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgdW51c2VkIEhlYXA6OmdldENvbnNlcnZhdGl2ZVJl Z2lzdGVyUm9vdHMoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T3BlcmF0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMu Y3BwCmluZGV4IDEzMjhlOGUwMTk3Y2RiYjAxMzM5ODljMGZkMzg3ZGQ3ODQ3OTYwN2EuLjZhNjRi YzMzNjAyNmZhMTQwMzBiY2NlYWViZTU4YzhkZGViMzZkM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcApAQCAtMTI0MiwxNSArMTI0Miw2IEBAIHZvaWQg SklUX09QRVJBVElPTiBvcGVyYXRpb25Qcm9jZXNzVHlwZVByb2ZpbGVyTG9nREZHKEV4ZWNTdGF0 ZSogZXhlYykKICAgICBleGVjLT52bSgpLnR5cGVQcm9maWxlckxvZygpLT5wcm9jZXNzTG9nRW50 cmllcyhBU0NJSUxpdGVyYWwoIkxvZyBGdWxsLCBjYWxsZWQgZnJvbSBpbnNpZGUgREZHLiIpKTsK IH0KIAotc2l6ZV90IEpJVF9PUEVSQVRJT04gZGZnQ29udmVydEpTVmFsdWVUb0ludDMyKEV4ZWNT dGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUgdmFsdWUpCi17Ci0gICAgVk0qIHZtID0gJmV4ZWMt PnZtKCk7Ci0gICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgZXhlYyk7Ci0gICAg Ci0gICAgLy8gdG9JbnQzMi90b1VJbnQzMiByZXR1cm4gdGhlIHNhbWUgdmFsdWU7IHdlIHdhbnQg dGhlIHZhbHVlIHplcm8gZXh0ZW5kZWQgdG8gZmlsbCB0aGUgcmVnaXN0ZXIuCi0gICAgcmV0dXJu IEpTVmFsdWU6OmRlY29kZSh2YWx1ZSkudG9VSW50MzIoZXhlYyk7Ci19Ci0KIHZvaWQgSklUX09Q RVJBVElPTiBkZWJ1Z09wZXJhdGlvblByaW50U3BlY3VsYXRpb25GYWlsdXJlKEV4ZWNTdGF0ZSog ZXhlYywgdm9pZCogZGVidWdJbmZvUmF3LCB2b2lkKiBzY3JhdGNoKQogewogICAgIFZNKiB2bSA9 ICZleGVjLT52bSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP cGVyYXRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaApp bmRleCBhMjFjYzQ1ZGNlZGFiMWI1NTAyNDNjMzIyYWY4MzRkOGVhMDQ5MmM1Li43YWExMmQ4YTUy MDM5ZDJhZjRkNmEzMGYwNTc2YTBiMWM3ZjU1NTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR09wZXJhdGlvbnMuaApAQCAtMTQwLDEwICsxNDAsNiBAQCBpbnQ2NF90IEpJVF9PUEVS QVRJT04gb3BlcmF0aW9uQ29udmVydERvdWJsZVRvSW50NTIoZG91YmxlKTsKIAogdm9pZCBKSVRf T1BFUkFUSU9OIG9wZXJhdGlvblByb2Nlc3NUeXBlUHJvZmlsZXJMb2dERkcoRXhlY1N0YXRlKikg V1RGX0lOVEVSTkFMOwogCi0vLyBUaGVzZSBvcGVyYXRpb25zIGltcGxlbWVudCB0aGUgaW1wbGlj aXRseSBjYWxsZWQgVG9JbnQzMiBhbmQgVG9Cb29sZWFuIGNvbnZlcnNpb25zIGZyb20gRVM1Lgot Ly8gVGhpcyBjb252ZXJzaW9uIHJldHVybnMgYW4gaW50MzJfdCB3aXRoaW4gYSBzaXplX3Qgc3Vj aCB0aGF0IHRoZSB2YWx1ZSBpcyB6ZXJvIGV4dGVuZGVkIHRvIGZpbGwgdGhlIHJlZ2lzdGVyLgot c2l6ZV90IEpJVF9PUEVSQVRJT04gZGZnQ29udmVydEpTVmFsdWVUb0ludDMyKEV4ZWNTdGF0ZSos IEVuY29kZWRKU1ZhbHVlKSBXVEZfSU5URVJOQUw7Ci0KIHZvaWQgSklUX09QRVJBVElPTiBkZWJ1 Z09wZXJhdGlvblByaW50U3BlY3VsYXRpb25GYWlsdXJlKEV4ZWNTdGF0ZSosIHZvaWQqLCB2b2lk KikgV1RGX0lOVEVSTkFMOwogCiB2b2lkIEpJVF9PUEVSQVRJT04gdHJpZ2dlclJlb3B0aW1pemF0 aW9uTm93KENvZGVCbG9jayosIE9TUkV4aXRCYXNlKikgV1RGX0lOVEVSTkFMOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCmluZGV4IDY1N2E0MWVkN2Qz MjgxYTY5OTJhNzA3NGQ5ZTAzOGZlNGY1NDVmMzUuLjllZmRkNTQ2MTY1YTczY2ZmMzBjOGRmNDVm NmFhMWRlNjU4MTliODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklULmgKQEAgLTE0OTgsMTIgKzE0OTgsNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVy biBhcHBlbmRDYWxsKG9wZXJhdGlvbik7CiAgICAgfQogCi0gICAgSklUQ29tcGlsZXI6OkNhbGwg Y2FsbE9wZXJhdGlvbihEX0pJVE9wZXJhdGlvbl9FSiBvcGVyYXRpb24sIEZQUlJlZyByZXN1bHQs IEdQUlJlZyBhcmcxKQotICAgIHsKLSAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhl Y1N0YXRlKGFyZzEpOwotICAgICAgICByZXR1cm4gYXBwZW5kQ2FsbFNldFJlc3VsdChvcGVyYXRp b24sIHJlc3VsdCk7Ci0gICAgfQotCiAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlv bihaX0pJVE9wZXJhdGlvbl9FSlpaIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFy ZzEsIHVuc2lnbmVkIGFyZzIsIHVuc2lnbmVkIGFyZzMpCiAgICAgewogICAgICAgICBtX2ppdC5z ZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgVHJ1c3RlZEltbTMyKGFyZzIpLCBUcnVz dGVkSW1tMzIoYXJnMykpOwpAQCAtMTgyMSwxMiArMTgxNSw2IEBAIHB1YmxpYzoKICAgICAgICAg cmV0dXJuIGFwcGVuZENhbGwob3BlcmF0aW9uKTsKICAgICB9CiAKLSAgICBKSVRDb21waWxlcjo6 Q2FsbCBjYWxsT3BlcmF0aW9uKERfSklUT3BlcmF0aW9uX0VKIG9wZXJhdGlvbiwgRlBSUmVnIHJl c3VsdCwgR1BSUmVnIGFyZzFUYWcsIEdQUlJlZyBhcmcxUGF5bG9hZCkKLSAgICB7Ci0gICAgICAg IG1faml0LnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShFQUJJXzMyQklUX0RVTU1ZX0FSRyBh cmcxUGF5bG9hZCwgYXJnMVRhZyk7Ci0gICAgICAgIHJldHVybiBhcHBlbmRDYWxsU2V0UmVzdWx0 KG9wZXJhdGlvbiwgcmVzdWx0KTsKLSAgICB9Ci0KICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxs T3BlcmF0aW9uKFpfSklUT3BlcmF0aW9uX0VKWlogb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0LCBH UFJSZWcgYXJnMVRhZywgR1BSUmVnIGFyZzFQYXlsb2FkLCB1bnNpZ25lZCBhcmcyLCB1bnNpZ25l ZCBhcmczKQogICAgIHsKICAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRl KEVBQklfMzJCSVRfRFVNTVlfQVJHICBhcmcxUGF5bG9hZCwgYXJnMVRhZywgVHJ1c3RlZEltbTMy KGFyZzIpLCBUcnVzdGVkSW1tMzIoYXJnMykpOwo=