148979 2015-09-08 14:31:46 -0700 Web Inspector: Remove unused file: WebInspectorFrontendClient.h 2015-09-08 15:13:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1124396 0 joepeck 2015-09-08 14:31:46 -0700 * SUMMARY Remove unused file: WebInspectorFrontendClient.h. When transitioning to a WebInspectorUI process, it WebInspectorUI provides its own InspectorFrontendClient subclass. Nobody uses this file anymore (that I can tell). I searched and found no references. 1124397 1 260795 joepeck 2015-09-08 14:33:21 -0700 Created attachment 260795 [PATCH] Proposed Fix 1124417 2 260795 commit-queue 2015-09-08 15:13:44 -0700 Comment on attachment 260795 [PATCH] Proposed Fix Clearing flags on attachment: 260795 Committed r189509: <http://trac.webkit.org/changeset/189509> 1124418 3 commit-queue 2015-09-08 15:13:50 -0700 All reviewed patches have been landed. Closing bug. 260795 2015-09-08 14:33:21 -0700 2015-09-08 15:13:44 -0700 [PATCH] Proposed Fix frontendclient.patch text/plain 3519 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzMDU3NmFiLi5hZGFkOTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTUtMDktMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2VkIGZpbGU6IFdlYkluc3BlY3RvckZy b250ZW5kQ2xpZW50LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0ODk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JGcm9udGVuZENs aWVudC5oOiBSZW1vdmVkLgorICAgICAgICBVbnVzZWQgbm93LiBXZWJJbnNwZWN0b3JVSSBzdWJj bGFzc2VzIEluc3BlY3RvckZyb250ZW5kQ2xpZW50IGl0c2VsZi4KKwogMjAxNS0wOS0wNyAgQW5k eSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gRGVidWdSZWxlYXNl IGJ1aWxkcyBzaG91bGQgbGluayBhZ2FpbnN0IGxpYldlYktpdFN5c3RlbUludGVyZmFjZUVsQ2Fw aXRhbi5hIG9uIDEwLjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50LmgK ZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDkzZjY3MjMuLjAwMDAwMDAKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JGcm9udGVu ZENsaWVudC5oCisrKyAvZGV2L251bGwKQEAgLTEsNjMgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdo dCAoQykgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKgotICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKLSAqIGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Yg c291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNl LCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgot ICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBh Ym92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24gYW5k L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0gKgot ICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJ QlVUT1JTIGBgQVMgSVMnJwotICogQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElF UywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBUSEUgSU1QTElFRCBXQVJSQU5U SUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCi0gKiBQ VVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElU UyBDT05UUklCVVRPUlMKLSAqIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IKLSAqIENPTlNFUVVFTlRJQUwgREFNQUdF UyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GCi0gKiBTVUJT VElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsg T1IgQlVTSU5FU1MKLSAqIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBU SEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOCi0gKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJ TElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKQotICogQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRgotICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNp Zm5kZWYgV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRfaAotI2RlZmluZSBXZWJJbnNwZWN0b3JG cm9udGVuZENsaWVudF9oCi0KLSNpbmNsdWRlIDxXZWJDb3JlL0luc3BlY3RvckZyb250ZW5kQ2xp ZW50TG9jYWwuaD4KLQotbmFtZXNwYWNlIFdlYktpdCB7Ci0KLWNsYXNzIFdlYlBhZ2U7Ci0KLWNs YXNzIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50IDogcHVibGljIFdlYkNvcmU6Okluc3BlY3Rv ckZyb250ZW5kQ2xpZW50TG9jYWwgewotcHVibGljOgotICAgIFdlYkluc3BlY3RvckZyb250ZW5k Q2xpZW50KFdlYlBhZ2UqIHBhZ2UsIFdlYlBhZ2UqIGluc3BlY3RvclBhZ2UpOwotCi1wcml2YXRl OgotICAgIHZpcnR1YWwgU3RyaW5nIGxvY2FsaXplZFN0cmluZ3NVUkwoKSBvdmVycmlkZTsKLQot ICAgIHZpcnR1YWwgdm9pZCBicmluZ1RvRnJvbnQoKSBvdmVycmlkZTsKLSAgICB2aXJ0dWFsIHZv aWQgY2xvc2VXaW5kb3coKSBvdmVycmlkZTsKLQotICAgIHZpcnR1YWwgYm9vbCBjYW5TYXZlKCkg b3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2b2lkIHNhdmUoY29uc3QgU3RyaW5nJiwgY29uc3QgU3Ry aW5nJiwgYm9vbCBiYXNlNjRFbmNvZGVkLCBib29sIGZvcmNlU2F2ZUFzKSBvdmVycmlkZTsKLSAg ICB2aXJ0dWFsIHZvaWQgYXBwZW5kKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0cmluZyYpIG92ZXJy aWRlOwotCi0gICAgdmlydHVhbCB2b2lkIGF0dGFjaFdpbmRvdyhEb2NrU2lkZSkgb3ZlcnJpZGU7 Ci0gICAgdmlydHVhbCB2b2lkIGRldGFjaFdpbmRvdygpIG92ZXJyaWRlOwotCi0gICAgdmlydHVh bCB2b2lkIHNldEF0dGFjaGVkV2luZG93SGVpZ2h0KHVuc2lnbmVkKSBvdmVycmlkZTsKLSAgICB2 aXJ0dWFsIHZvaWQgc2V0QXR0YWNoZWRXaW5kb3dXaWR0aCh1bnNpZ25lZCkgb3ZlcnJpZGU7Ci0g ICAgdmlydHVhbCB2b2lkIHNldFRvb2xiYXJIZWlnaHQodW5zaWduZWQpIG92ZXJyaWRlOwotCi0g ICAgdmlydHVhbCB2b2lkIGluc3BlY3RlZFVSTENoYW5nZWQoY29uc3QgU3RyaW5nJikgb3ZlcnJp ZGU7Ci0KLSAgICBXZWJQYWdlKiBtX3BhZ2U7Ci19OwotCi19IC8vIG5hbWVzcGFjZSBXZWJLaXQK LQotI2VuZGlmIC8vIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50X2gK