148970 2015-09-08 10:58:49 -0700 AX: ARIA 1.1 @aria-placeholder 2015-10-07 11:18:33 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni esprehn+autocc gyuyoung.kim jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1124300 0 n_wang 2015-09-08 10:58:49 -0700 Add support for ARIA 1.1 attribute 'aria-placeholder'. http://www.w3.org/TR/wai-aria-1.1/#aria-placeholder Defines a short hint (a word or short phrase) intended to aid the user with data entry when the control has no value. A hint could be a sample value or a brief description of the expected format. 1124321 1 webkit-bug-importer 2015-09-08 11:29:41 -0700 <rdar://problem/22613822> 1131178 2 262563 n_wang 2015-10-06 17:47:43 -0700 Created attachment 262563 patch There's already a placeholderValue() function to get the value from placeholder attribute. Not sure the difference between placeholder and aria-placeholder from the spec. The logic for the patch is to get the value from aria-placeholder first, if not then check placeholder attribute. 1131340 3 262563 commit-queue 2015-10-07 11:18:28 -0700 Comment on attachment 262563 patch Clearing flags on attachment: 262563 Committed r190674: <http://trac.webkit.org/changeset/190674> 1131341 4 commit-queue 2015-10-07 11:18:33 -0700 All reviewed patches have been landed. Closing bug. 262563 2015-10-06 17:47:43 -0700 2015-10-07 11:18:28 -0700 patch patch.txt text/plain 4497 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDY1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTA2ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFSSUEgMS4xIEBhcmlhLXBsYWNl aG9sZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDg5NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBzdXBwb3J0IGZvciBhcmlhLXBsYWNlaG9sZGVyIGF0dHJpYnV0ZS4KKworICAgICAgICBN b2RpZmllZCBhY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwgdGVzdC4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpwbGFjZWhvbGRlclZhbHVlKToKKyAgICAgICAgKiBodG1s L0hUTUxBdHRyaWJ1dGVOYW1lcy5pbjoKKwogMjAxNS0xMC0wNiAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIElEQlJlcXVlc3RJZGVudGlmaWVyIHRv IElEQlJlc291cmNlSWRlbnRpZmllci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkocmV2aXNpb24gMTkwNjQ4KQor KysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjEyMCw2ICsyMTIwLDEwIEBAIGJvb2wgQWNjZXNzaWJpbGl0eU9i amVjdDo6aXNWYWx1ZUF1dG9maWwKIAogY29uc3QgQXRvbWljU3RyaW5nJiBBY2Nlc3NpYmlsaXR5 T2JqZWN0OjpwbGFjZWhvbGRlclZhbHVlKCkgY29uc3QKIHsKKyAgICBjb25zdCBBdG9taWNTdHJp bmcmIGFyaWFQbGFjZWhvbGRlciA9IGdldEF0dHJpYnV0ZShhcmlhX3BsYWNlaG9sZGVyQXR0cik7 CisgICAgaWYgKCFhcmlhUGxhY2Vob2xkZXIuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gYXJp YVBsYWNlaG9sZGVyOworICAgIAogICAgIGNvbnN0IEF0b21pY1N0cmluZyYgcGxhY2Vob2xkZXIg PSBnZXRBdHRyaWJ1dGUocGxhY2Vob2xkZXJBdHRyKTsKICAgICBpZiAoIXBsYWNlaG9sZGVyLmlz RW1wdHkoKSkKICAgICAgICAgcmV0dXJuIHBsYWNlaG9sZGVyOwpJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQXR0cmlidXRlTmFtZXMuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQXR0cmlidXRlTmFtZXMuaW4JKHJldmlzaW9uIDE5MDY0OCkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEF0dHJpYnV0ZU5hbWVzLmluCSh3b3JraW5nIGNvcHkpCkBAIC0z OCw2ICszOCw3IEBAIGFyaWEtbXVsdGlsaW5lCiBhcmlhLW11bHRpc2VsZWN0YWJsZQogYXJpYS1v cmllbnRhdGlvbgogYXJpYS1vd25zCithcmlhLXBsYWNlaG9sZGVyCiBhcmlhLXBvc2luc2V0CiBh cmlhLXByZXNzZWQKIGFyaWEtcmVhZG9ubHkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDY0OCkKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDE1LTEwLTA2ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFS SUEgMS4xIEBhcmlhLXBsYWNlaG9sZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDg5NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvcGxhY2Vob2xkZXItZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvcGxhY2Vob2xkZXIuaHRtbDoKKwogMjAxNS0xMC0w NiAgTmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBBUklBIDEuMTog YXJpYS1vcmllbnRhdGlvbiBub3cgZGVmYXVsdHMgdG8gdW5kZWZpbmVkLCBzdXBwb3J0ZWQgb24g bW9yZSBlbGVtZW50cywgYW5kIHJvbGUtc3BlY2lmaWMgZGVmYXVsdHMgYXJlIGRlZmluZWQuCklu ZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMTkwNjQ4KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9w bGFjZWhvbGRlci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw1IEBACi0g IAorICAgQmlydGhkYXk6CiswMy0xNC0xODc5CiBUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IHRo ZSBwbGFjZWhvbGRlciBpcyByZXR1cm5lZCBhcyB0aGUgY29ycmVjdCBhdHRyaWJ1dGUKIAogT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgpAQCAtNiw2ICs3LDcgQEAgT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQQogCiBQQVNTIGZpZWxkRWxlbWVudC5zdHJpbmdBdHRyaWJ1 dGVWYWx1ZSgnQVhQbGFjZWhvbGRlclZhbHVlJykgaXMgJ3NlYXJjaCcKIFBBU1MgcGFzcy5zdHJp bmdBdHRyaWJ1dGVWYWx1ZSgnQVhQbGFjZWhvbGRlclZhbHVlJykgaXMgJ1Bhc3N3b3JkJworUEFT UyBzZWFyY2guc3RyaW5nQXR0cmlidXRlVmFsdWUoJ0FYUGxhY2Vob2xkZXJWYWx1ZScpIGlzICdN TS1ERC1ZWVlZJwogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBM RVRFCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci5odG1sCShy ZXZpc2lvbiAxOTA2NDgpCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVy Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTksNiArOSw5IEBACiAKICAgICA8aW5wdXQgaWQ9InBh c3N3b3JkIiBjbGFzcz0iZmllbGQiIHR5cGU9InBhc3N3b3JkIiBuYW1lPSJzYzE3OTgiIHZhbHVl PSIiIHBsYWNlaG9sZGVyPSJQYXNzd29yZCIgc3BlbGxjaGVjaz0idHJ1ZSIgbWF4bGVuZ3RoPSI1 MDk2Ij4KICAgICAKKyAgICA8c3BhbiBpZD0ibGFiZWwiPkJpcnRoZGF5Ojwvc3Bhbj4KKyAgICA8 ZGl2IGlkPSJzZWFyY2giIHJvbGU9InNlYXJjaGJveCIgYXJpYS1sYWJlbGxlZGJ5PSJsYWJlbCIg YXJpYS1wbGFjZWhvbGRlcj0iTU0tREQtWVlZWSI+MDMtMTQtMTg3OTwvZGl2PgorICAgIAogICAg IDxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgogICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2Pgog ICAgICAKQEAgLTIzLDEwICsyNiwxMyBAQAogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInBhc3N3b3JkIikuZm9jdXMoKTsKICAgICAgICAgICAgIHZhciBwYXNzID0gYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CiAgICAgICAgICAgICBzaG91bGRCZSgi cGFzcy5zdHJpbmdBdHRyaWJ1dGVWYWx1ZSgnQVhQbGFjZWhvbGRlclZhbHVlJykiLCAiJ1Bhc3N3 b3JkJyIpOworICAgICAgICAgICAgCisgICAgICAgICAgICB2YXIgc2VhcmNoID0gYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJzZWFyY2giKTsKKyAgICAgICAg ICAgIHNob3VsZEJlKCJzZWFyY2guc3RyaW5nQXR0cmlidXRlVmFsdWUoJ0FYUGxhY2Vob2xkZXJW YWx1ZScpIiwgIidNTS1ERC1ZWVlZJyIpOwogCiAgICAgICAgIH0KICAgICA8L3NjcmlwdD4KIAog PHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgogPC9i b2R5PgotPC9odG1sPgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK