148959 2015-09-08 09:07:58 -0700 document.importNode(node, deep): deep's default value should be false 2015-09-08 12:39:54 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dom.spec.whatwg.org/#dom-document-importnode InRadar, WebExposed P2 Normal --- 1 cdumez cdumez ap commit-queue esprehn+autocc kangil.han rniwa webkit-bug-importer oldest_to_newest 1124247 0 cdumez 2015-09-08 09:07:58 -0700 document.importNode(node, deep): deep's default value should be false: https://dom.spec.whatwg.org/#interface-document https://dom.spec.whatwg.org/#dom-document-importnode Firefox and Chrome follow the specification. However, WebKit uses "true" for deep's default value. Note that WebKit use to have "false" as default value but this was changed in Bug 71190 because the DOM spec said to use "false" at the time :( 1124248 1 cdumez 2015-09-08 09:08:48 -0700 rdar://problem/22558915 1124265 2 260765 cdumez 2015-09-08 09:51:37 -0700 Created attachment 260765 Patch 1124353 3 260765 commit-queue 2015-09-08 12:39:50 -0700 Comment on attachment 260765 Patch Clearing flags on attachment: 260765 Committed r189502: <http://trac.webkit.org/changeset/189502> 1124355 4 commit-queue 2015-09-08 12:39:54 -0700 All reviewed patches have been landed. Closing bug. 260765 2015-09-08 09:51:37 -0700 2015-09-08 12:39:50 -0700 Patch bug-148959-20150908095131.patch text/plain 5223 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE1OGMzYjI0NjJkZTMx NDdiMDljNjJjOGMyMTY5NjIxMmQ0YmU5Mi4uOTY2NDI2NWViMTY0NGY5MGUzZmE1NGNhMTEwNTQ0 ZDEzZTkyMTE5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA5LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnQuaW1wb3J0Tm9k ZShub2RlLCBkZWVwKTogZGVlcCdzIGRlZmF1bHQgdmFsdWUgc2hvdWxkIGJlIGZhbHNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg5NTkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzIyNTU4OTE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBkZWVwIHBhcmFtZXRlcidzIGRlZmF1bHQgdmFs dWUgZm9yIGRvY3VtZW50LmltcG9ydE5vZGUoKSB0bworICAgICAgICBmYWxzZSwgYXMgcGVyIHRo ZSBsYXRlc3QgRE9NIHNwZWNpZmljYXRpb246CisgICAgICAgIC0gaHR0cHM6Ly9kb20uc3BlYy53 aGF0d2cub3JnLyNpbnRlcmZhY2UtZG9jdW1lbnQKKyAgICAgICAgLSBodHRwczovL2RvbS5zcGVj LndoYXR3Zy5vcmcvI2RvbS1kb2N1bWVudC1pbXBvcnRub2RlCisKKyAgICAgICAgRmlyZWZveCBh bmQgQ2hyb21lIGZvbGxvdyB0aGUgc3BlY2lmaWNhdGlvbi4gSG93ZXZlciwgV2ViS2l0IHdhcyB1 c2luZworICAgICAgICAidHJ1ZSIgZm9yIGRlZXAncyBkZWZhdWx0IHZhbHVlLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5OgorICAgICAgICBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVudC1pbXBvcnROb2RlLmh0bWwKKwor ICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Omlt cG9ydE5vZGUpOgorCiAyMDE1LTA5LTA4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZWR1Y2UgdXNlcyBvZiBQYXNzUmVmUHRyIGluIGZpbGVhcGkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmgKaW5kZXggZTUyMTA2NzAyODliMDk5ZGI5NTM5YjY0NGFkMjFkZWU3 ZWViN2U4MS4uOWVmNDhjOTMzODA3M2FlMDI5YzJlYTM3YzkzNzVkNWNlYjk5YTZkNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmgKQEAgLTM3NSw3ICszNzUsNyBAQCBwdWJsaWM6CiAgICAgUmVmUHRyPEF0 dHI+IGNyZWF0ZUF0dHJpYnV0ZShjb25zdCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNvZGUmKTsK ICAgICBSZWZQdHI8QXR0cj4gY3JlYXRlQXR0cmlidXRlTlMoY29uc3QgU3RyaW5nJiBuYW1lc3Bh Y2VVUkksIGNvbnN0IFN0cmluZyYgcXVhbGlmaWVkTmFtZSwgRXhjZXB0aW9uQ29kZSYsIGJvb2wg c2hvdWxkSWdub3JlTmFtZXNwYWNlQ2hlY2tzID0gZmFsc2UpOwogICAgIFJlZlB0cjxFbnRpdHlS ZWZlcmVuY2U+IGNyZWF0ZUVudGl0eVJlZmVyZW5jZShjb25zdCBTdHJpbmcmIG5hbWUsIEV4Y2Vw dGlvbkNvZGUmKTsKLSAgICBSZWZQdHI8Tm9kZT4gaW1wb3J0Tm9kZShOb2RlKiBpbXBvcnRlZE5v ZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKSB7IHJldHVybiBpbXBvcnROb2RlKGltcG9ydGVkTm9kZSwg dHJ1ZSwgZWMpOyB9CisgICAgUmVmUHRyPE5vZGU+IGltcG9ydE5vZGUoTm9kZSogaW1wb3J0ZWRO b2RlLCBFeGNlcHRpb25Db2RlJiBlYykgeyByZXR1cm4gaW1wb3J0Tm9kZShpbXBvcnRlZE5vZGUs IGZhbHNlLCBlYyk7IH0KICAgICBSZWZQdHI8Tm9kZT4gaW1wb3J0Tm9kZShOb2RlKiBpbXBvcnRl ZE5vZGUsIGJvb2wgZGVlcCwgRXhjZXB0aW9uQ29kZSYpOwogICAgIFdFQkNPUkVfRVhQT1JUIFJl ZlB0cjxFbGVtZW50PiBjcmVhdGVFbGVtZW50TlMoY29uc3QgU3RyaW5nJiBuYW1lc3BhY2VVUkks IGNvbnN0IFN0cmluZyYgcXVhbGlmaWVkTmFtZSwgRXhjZXB0aW9uQ29kZSYpOwogICAgIFdFQkNP UkVfRVhQT1JUIFJlZjxFbGVtZW50PiBjcmVhdGVFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUm LCBib29sIGNyZWF0ZWRCeVBhcnNlcik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTM0NWVjNWNlYTEzZjBhZTY0YWNkY2Ew NDMxYmVmY2QxNGYxZmVjNC4uOWRkZmZmZjI2ODYwNWY0M2Y2NDkwMTVhZjI4NGY1YjUzMjhlZTg3 MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTA4ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnQuaW1wb3J0Tm9kZShub2RlLCBkZWVwKTog ZGVlcCdzIGRlZmF1bHQgdmFsdWUgc2hvdWxkIGJlIGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg5NTkKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzIyNTU4OTE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9kb20vZG9jdW1lbnQtaW1wb3J0Tm9kZS1hcmd1bWVudHMuaHRtbDoKKyAg ICAgICAgRXhwbGljaXRseSBwYXNzIGRlZXAgcGFyYW1ldGVyIGFzIHRoZSB0ZXN0IHdhbnRzIGEg ZGVlcCBjbG9uZS4KKwogMjAxNS0wOS0wOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5j b20+CiAKICAgICAgICAgQ29udmVydCBtYW51YWwgdGVzdCBhZGRlZCBpbiBodHRwOi8vdHJhYy53 ZWJraXQub3JnL2NoYW5nZXNldC83MDMyMSB0byBhbiBhdXRvbWF0ZWQgdGVzdApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggNTIzOGVkZGMyNDhkY2JlNjI5MzFiY2QzOTU1Y2IwNDZl NDU3ZjQxMi4uNmU2ZGRhN2VlYTk1YjY1ZDRmODU3ZGQ1NTAyYmNlNWNiNzBjZGM0YiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDktMDggIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBkb2N1bWVudC5pbXBvcnRO b2RlKG5vZGUsIGRlZXApOiBkZWVwJ3MgZGVmYXVsdCB2YWx1ZSBzaG91bGQgYmUgZmFsc2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODk1OQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjI1NTg5MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL0Rv Y3VtZW50LWltcG9ydE5vZGUtZXhwZWN0ZWQudHh0OgorICAgICAgICBSZWJhc2VsaW5lIG5vdyB0 aGF0IGFuIGFkZGl0aW9uYWwgY2hlY2sgaXMgcGFzc2luZy4KKwogMjAxNS0wOS0wNyAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeHVwIGEg ZmV3IHJlY2VudGx5IGltcG9ydGVkIFczQyBIVE1MIHRlc3RzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtaW1wb3J0Tm9kZS1hcmd1bWVudHMuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LWltcG9ydE5vZGUtYXJndW1lbnRzLmh0bWwKaW5kZXgg NmQzZjM5MjhmYzY3NTIzNmZkZTZiZDQ3N2Q4ZTcwZjAzYjM1OWMzNi4uNTVlMDdkNDAwYzlkZjMx N2RlMzQxNDQ0N2M0OGUwZWUwMDNkZjViNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vZG9jdW1lbnQtaW1wb3J0Tm9kZS1hcmd1bWVudHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9kb2N1bWVudC1pbXBvcnROb2RlLWFyZ3VtZW50cy5odG1sCkBAIC0xNCw3ICsxNCw3 IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKIHZhciBkID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiZGl2Iik7CiBkLmlubmVySFRNTCA9ICI8c3Bhbj5oZWxsbyA8L3NwYW4+PHNwYW4+d29ybGQ8 L3NwYW4+IjsKIAotaW1wb3J0ZWQgPSBkb2N1bWVudC5pbXBvcnROb2RlKGQpOworaW1wb3J0ZWQg PSBkb2N1bWVudC5pbXBvcnROb2RlKGQsIHRydWUpOwogc2hvdWxkQmUoJ2ltcG9ydGVkLmNoaWxk Tm9kZXMubGVuZ3RoJywnMicpOwogc2hvdWxkQmVUcnVlKCJpbXBvcnRlZC50ZXh0Q29udGVudCA9 PSAnaGVsbG8gd29ybGQnIik7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL0RvY3VtZW50LWltcG9ydE5vZGUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20v bm9kZXMvRG9jdW1lbnQtaW1wb3J0Tm9kZS1leHBlY3RlZC50eHQKaW5kZXggM2ZiOGI0OGZmOWE0 ODM0M2QyM2UwMGZmYzg1OTc1Yzc1ZTMzYmQ1Ny4uYTE3NmQ1YjNlNDViNGIwYjJiZTZkN2VhMDJh NWEzNjU2ZGJkZDQwMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvRG9jdW1lbnQtaW1wb3J0Tm9kZS1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9k ZXMvRG9jdW1lbnQtaW1wb3J0Tm9kZS1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiAKLUZB SUwgTm8gJ2RlZXAnIGFyZ3VtZW50LiBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCBudWxsIGJ1dCBn b3QgRWxlbWVudCBub2RlIDxzcGFuPjwvc3Bhbj4KK1BBU1MgTm8gJ2RlZXAnIGFyZ3VtZW50LiAK IFBBU1MgVW5kZWZpbmVkICdkZWVwJyBhcmd1bWVudC4gCiBQQVNTIFRydWUgJ2RlZXAnIGFyZ3Vt ZW50LiAKIFBBU1MgRmFsc2UgJ2RlZXAnIGFyZ3VtZW50LiAK