148957 2015-09-08 08:40:04 -0700 Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition 2015-09-10 11:48:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hur.ims hur.ims commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 1124234 0 hur.ims 2015-09-08 08:40:04 -0700 There is no guarantee that only one thread calls GraphicsContext3D::compileShader() at a time so it would be better to use a thread local storage variable rather than use a static variable. In my case, the race condition is occurred when multiple instances of TextureMapperShaderProgram are created on each other thread and the constructors of TextureMapperShaderProgram call GraphicsContext3D::compileShader() simultaneously. 1124238 1 260761 hur.ims 2015-09-08 08:47:42 -0700 Created attachment 260761 Patch 1124965 2 260761 commit-queue 2015-09-10 11:48:07 -0700 Comment on attachment 260761 Patch Clearing flags on attachment: 260761 Committed r189580: <http://trac.webkit.org/changeset/189580> 1124966 3 commit-queue 2015-09-10 11:48:12 -0700 All reviewed patches have been landed. Closing bug. 260761 2015-09-08 08:47:42 -0700 2015-09-10 11:48:07 -0700 Patch bug-148957-20150909004737.patch text/plain 4443 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTgzZjJiMDRhYmE5MDU4 M2UzN2IzMDcxYjMyYTFlZjA5MDI2ZGE4OS4uNDE5ODljNTMyNmRiNmNkOTQ0Mjk1NTVlYzc0ZWY2 NTdiODM5MmM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA5LTA4ICBKaW55 b3VuZyBIdXIgIDxodXIuaW1zQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgU3RhdGljIHZhcmlh YmxlcyBpbiBHcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbiBzaG91bGQgYmUgYXZvaWRlZCBi ZWNhdXNlIG9mIHRoZSByYWNlIGNvbmRpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4OTU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgbm8gZ3VhcmFudGVlIHRoYXQgb25seSBvbmUg dGhyZWFkIGNhbGxzIEdyYXBoaWNzQ29udGV4dDNEOjpjb21waWxlU2hhZGVyKCkgYXQgYSB0aW1l IHNvIGl0IHdvdWxkIGJlIAorICAgICAgICBiZXR0ZXIgdG8gdXNlIGEgdGhyZWFkIGxvY2FsIHN0 b3JhZ2UgdmFyaWFibGUgcmF0aGVyIHRoYW4gdXNlIGEgc3RhdGljIHZhcmlhYmxlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3VyYWwgY2hhbmdlcy4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpnZXRDdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIpOgorICAg ICAgICAoV2ViQ29yZTo6c2V0Q3VycmVudE5hbWVIYXNoTWFwRm9yU2hhZGVyKToKKyAgICAgICAg KFdlYkNvcmU6Om5hbWVIYXNoRm9yU2hhZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dDNEOjpjb21waWxlU2hhZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDNEOjptYXBwZWRTeW1ib2xOYW1lKToKKwogMjAxNS0wOC0zMSAgRW5yaWNhIENhc3VjY2kg IDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBjdXJzb3IgbW92ZW1lbnQg Zm9yIFUrMjZGOSwgVSsxRjNDQiB3aXRoIHZhcmlhdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xD b21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBo aWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCBiNmVmYTQxYjZmZjA2ZDUwMjQxNjQ1 YzViYWRiZDNkYzY4Yjc3YjRjLi43YTk5MTA5NmJlYTlkYTZmNjViN2MyNGMxYzM5Njg3N2M4ODkx YzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAK QEAgLTc5LDcgKzc5LDIxIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIFNoYWRl ck5hbWVIYXNoKiBjdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIgPSBudWxscHRyOworc3RhdGlj IFRocmVhZFNwZWNpZmljPFNoYWRlck5hbWVIYXNoKj4mIGdldEN1cnJlbnROYW1lSGFzaE1hcEZv clNoYWRlcigpCit7CisgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VGbGFnOworICAgIHN0 YXRpYyBUaHJlYWRTcGVjaWZpYzxTaGFkZXJOYW1lSGFzaCo+KiBzaGFyZWROYW1lSGFzaDsKKyAg ICBzdGQ6OmNhbGxfb25jZShvbmNlRmxhZywgW10geworICAgICAgICBzaGFyZWROYW1lSGFzaCA9 IG5ldyBUaHJlYWRTcGVjaWZpYzxTaGFkZXJOYW1lSGFzaCo+OworICAgIH0pOworCisgICAgcmV0 dXJuICpzaGFyZWROYW1lSGFzaDsKK30KKworc3RhdGljIHZvaWQgc2V0Q3VycmVudE5hbWVIYXNo TWFwRm9yU2hhZGVyKFNoYWRlck5hbWVIYXNoKiBzaGFkZXJOYW1lSGFzaCkKK3sKKyAgICAqZ2V0 Q3VycmVudE5hbWVIYXNoTWFwRm9yU2hhZGVyKCkgPSBzaGFkZXJOYW1lSGFzaDsKK30KIAogLy8g SGFzaCBmdW5jdGlvbiB1c2VkIGJ5IHRoZSBBTkdMRSB0cmFuc2xhdG9yL2NvbXBpbGVyIHRvIGRv CiAvLyBzeW1ib2wgbmFtZSBtYW5nbGluZy4gU2luY2UgdGhpcyBpcyBhIHN0YXRpYyBtZXRob2Qs IGJlZm9yZQpAQCAtOTQsMTEgKzEwOCwxMCBAQCBzdGF0aWMgdWludDY0X3QgbmFtZUhhc2hGb3JT aGFkZXIoY29uc3QgY2hhciogbmFtZSwgc2l6ZV90IGxlbmd0aCkKICAgICBDU3RyaW5nIG5hbWVB c0NTdHJpbmcgPSBDU3RyaW5nKG5hbWUpOwogCiAgICAgLy8gTG9vayB1cCBuYW1lIGluIG91ciBs b2NhbCBtYXAuCi0gICAgaWYgKGN1cnJlbnROYW1lSGFzaE1hcEZvclNoYWRlcikgewotICAgICAg ICBTaGFkZXJOYW1lSGFzaDo6aXRlcmF0b3IgcmVzdWx0ID0gY3VycmVudE5hbWVIYXNoTWFwRm9y U2hhZGVyLT5maW5kKG5hbWVBc0NTdHJpbmcpOwotICAgICAgICBpZiAocmVzdWx0ICE9IGN1cnJl bnROYW1lSGFzaE1hcEZvclNoYWRlci0+ZW5kKCkpCi0gICAgICAgICAgICByZXR1cm4gcmVzdWx0 LT52YWx1ZTsKLSAgICB9CisgICAgU2hhZGVyTmFtZUhhc2gqJiBjdXJyZW50TmFtZUhhc2hNYXBG b3JTaGFkZXIgPSAqZ2V0Q3VycmVudE5hbWVIYXNoTWFwRm9yU2hhZGVyKCk7CisgICAgU2hhZGVy TmFtZUhhc2g6Oml0ZXJhdG9yIGZpbmRSZXN1bHQgPSBjdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFk ZXItPmZpbmQobmFtZUFzQ1N0cmluZyk7CisgICAgaWYgKGZpbmRSZXN1bHQgIT0gY3VycmVudE5h bWVIYXNoTWFwRm9yU2hhZGVyLT5lbmQoKSkKKyAgICAgICAgcmV0dXJuIGZpbmRSZXN1bHQtPnZh bHVlOwogCiAgICAgdW5zaWduZWQgaGFzaFZhbHVlID0gbmFtZUFzQ1N0cmluZy5oYXNoKCk7CiAK QEAgLTU2OCwxNCArNTgxLDE0IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFk ZXIoUGxhdGZvcm0zRE9iamVjdCBzaGFkZXIpCiAKICAgICBpZiAoIW5hbWVIYXNoTWFwRm9yU2hh ZGVycykKICAgICAgICAgbmFtZUhhc2hNYXBGb3JTaGFkZXJzID0gc3RkOjptYWtlX3VuaXF1ZTxT aGFkZXJOYW1lSGFzaD4oKTsKLSAgICBjdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIgPSBuYW1l SGFzaE1hcEZvclNoYWRlcnMuZ2V0KCk7CisgICAgc2V0Q3VycmVudE5hbWVIYXNoTWFwRm9yU2hh ZGVyKG5hbWVIYXNoTWFwRm9yU2hhZGVycy5nZXQoKSk7CiAgICAgbV9jb21waWxlci5zZXRSZXNv dXJjZXMoQU5HTEVSZXNvdXJjZXMpOwogCiAgICAgU3RyaW5nIHRyYW5zbGF0ZWRTaGFkZXJTb3Vy Y2UgPSBtX2V4dGVuc2lvbnMtPmdldFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2VBTkdMRShzaGFkZXIp OwogCiAgICAgQU5HTEVSZXNvdXJjZXMuSGFzaEZ1bmN0aW9uID0gcHJldmlvdXNIYXNoRnVuY3Rp b247CiAgICAgbV9jb21waWxlci5zZXRSZXNvdXJjZXMoQU5HTEVSZXNvdXJjZXMpOwotICAgIGN1 cnJlbnROYW1lSGFzaE1hcEZvclNoYWRlciA9IG51bGxwdHI7CisgICAgc2V0Q3VycmVudE5hbWVI YXNoTWFwRm9yU2hhZGVyKG51bGxwdHIpOwogCiAgICAgaWYgKCF0cmFuc2xhdGVkU2hhZGVyU291 cmNlLmxlbmd0aCgpKQogICAgICAgICByZXR1cm47CkBAIC04NzcsMTEgKzg5MCwxMSBAQCBTdHJp bmcgR3JhcGhpY3NDb250ZXh0M0Q6Om1hcHBlZFN5bWJvbE5hbWUoUGxhdGZvcm0zRE9iamVjdCBw cm9ncmFtLCBBTkdMRVNoYWRlcgogICAgICAgICAvLyBhbmQgYXJlbid0IGV2ZW4gcmVxdWlyZWQg dG8gYmUgdXNlZCBpbiBhbnkgc2hhZGVyIHByb2dyYW0uCiAgICAgICAgIGlmICghbmFtZUhhc2hN YXBGb3JTaGFkZXJzKQogICAgICAgICAgICAgbmFtZUhhc2hNYXBGb3JTaGFkZXJzID0gc3RkOjpt YWtlX3VuaXF1ZTxTaGFkZXJOYW1lSGFzaD4oKTsKLSAgICAgICAgY3VycmVudE5hbWVIYXNoTWFw Rm9yU2hhZGVyID0gbmFtZUhhc2hNYXBGb3JTaGFkZXJzLmdldCgpOworICAgICAgICBzZXRDdXJy ZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIobmFtZUhhc2hNYXBGb3JTaGFkZXJzLmdldCgpKTsKIAog ICAgICAgICBTdHJpbmcgZ2VuZXJhdGVkTmFtZSA9IGdlbmVyYXRlSGFzaGVkTmFtZShuYW1lKTsK IAotICAgICAgICBjdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIgPSBudWxscHRyOworICAgICAg ICBzZXRDdXJyZW50TmFtZUhhc2hNYXBGb3JTaGFkZXIobnVsbHB0cik7CiAKICAgICAgICAgbV9w b3NzaWJseVVudXNlZEF0dHJpYnV0ZU1hcC5zZXQoZ2VuZXJhdGVkTmFtZSwgbmFtZSk7CiAK