148956 2015-09-08 08:23:34 -0700 [GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint() 2015-09-25 02:42:49 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez webkit-unassigned cgarcia pnormand svillar yoon zan oldest_to_newest 1124230 0 clopez 2015-09-08 08:23:34 -0700 The following tests are crashing on the Debug build of WebKitGTK+ because of a failed assertion: Regressions: Unexpected crashes (9) css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html [ Crash ] css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html [ Crash ] css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html [ Crash ] css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html [ Crash ] fast/css-grid-layout/flex-content-sized-columns-resize.html [ Crash ] fast/dom/Window/window-resize-contents.html [ Crash ] fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Crash ] fast/dynamic/window-resize-scrollbars-test.html [ Crash ] fast/fixed-layout/fixed-layout.html [ Crash ] Backtrace (for fast/css-grid-layout/flex-content-sized-columns-resize.html): (gdb) bt #0 WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 #1 0x00007f2b8aba22e1 in WebKit::DrawingAreaImpl::display (this=0x1752720) at ../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:564 #2 0x00007f2b8aba2084 in WebKit::DrawingAreaImpl::forceRepaint (this=0x1752720) at ../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:220 #3 0x00007f2b8a9f397d in WebKit::WebPage::forceRepaintWithoutCallback() () at ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2625 #4 0x00007f2b8a8bdf6d in WKBundlePageForceRepaint (page=0x7f2b730054c0) at ../../Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:471 #5 0x00007f2b302a491c in WTR::InjectedBundlePage::dump (this=0x186f520) at ../../Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:851 #6 0x00007f2b302b47b7 in WTR::TestRunner::notifyDone (this=0x7f2b732f0348) at ../../Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:163 #7 0x00007f2b302cab3a in WTR::JSTestRunner::notifyDone (context=0x7fff9730d3d0, thisObject=0x7f2b730d3080, argumentCount=0, arguments=0x7fff9730cf40, exception=0x7fff9730cf08) at DerivedSources/InjectedBundle/JSTestRunner.cpp:249 #8 0x00007f2b85293169 in JSC::APICallbackFunction::call<JSC::JSCallbackFunction> (exec=0x7fff9730d3d0) at ../../Source/JavaScriptCore/API/APICallbackFunction.h:61 #9 0x00007f2b85c50e66 in JSC::LLInt::handleHostCall (execCallee=0x7fff9730d3d0, pc=0x7f2b732e7a70, callee=..., kind=JSC::CodeForCall) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1064 #10 0x00007f2b85c51e4a in JSC::LLInt::setUpCall (execCallee=0x7fff9730d3d0, pc=0x7f2b732e7a70, kind=JSC::CodeForCall, calleeAsValue=..., callLinkInfo=0x7f2b7334f6b8) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1110 [...] 1124237 1 clopez 2015-09-08 08:44:07 -0700 Marked accordingly in http://trac.webkit.org/changeset/189487 1125934 2 cgarcia 2015-09-15 04:27:37 -0700 This is because those tests (or at least fast/css-grid-layout/flex-content-sized-columns-resize.html, I haven't looked at the others but I guess it's the same thing), call notifyDone in the onresize event handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint() before dumping, but I'm not even sure that's actually needed with current WTR implementation. A layout would be enough, we don't really need to do the actual display. The thing is that when the view is resized DrawingAreaImpl::updateBackingStoreState() is called, if the size has changed, the FrameView::resize() method is called and all children are resized, so the onsresize handlers happen at that point, before the m_inUpdateBackingStoreState is set to false again. For WTR we could probably just return early from froceReapaint() when m_inUpdateBackingStoreState is true, because in that case we know the layout is updated because of the resize and the actual display is not really needed. But the UI process can also request a force repaint, so we could wait until the backing store update is done and then force the repaint. For WTR is will happen after the the dump, but it shouldn't be a problem. 1125935 3 261187 cgarcia 2015-09-15 04:36:52 -0700 Created attachment 261187 Patch 1128687 4 261187 zan 2015-09-25 02:27:26 -0700 Comment on attachment 261187 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261187&action=review Looks fine, sorry about the grammar nits. > Source/WebKit2/ChangeLog:10 > + before dumping, When the view is resized DrawingAreaImpl::updateBackingStoreState() Incorrect comma. > Source/WebKit2/ChangeLog:12 > + method is called and all children are resized, so the onsresize onsresize. > Source/WebKit2/ChangeLog:20 > + and then force the repaint. For WTR it will happen after the the Double the. 1128688 5 cgarcia 2015-09-25 02:37:58 -0700 (In reply to comment #4) > Comment on attachment 261187 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261187&action=review > > Looks fine, sorry about the grammar nits. :-) > > Source/WebKit2/ChangeLog:10 > > + before dumping, When the view is resized DrawingAreaImpl::updateBackingStoreState() > > Incorrect comma. > > > Source/WebKit2/ChangeLog:12 > > + method is called and all children are resized, so the onsresize > > onsresize. > > > Source/WebKit2/ChangeLog:20 > > + and then force the repaint. For WTR it will happen after the the > > Double the. Thanks! 1128689 6 cgarcia 2015-09-25 02:42:49 -0700 Committed r190238: <http://trac.webkit.org/changeset/190238> 261187 2015-09-15 04:36:52 -0700 2015-09-25 02:27:26 -0700 Patch wtr-assert.diff text/plain 5494 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNmFiNDYyLi4xMWQxMDRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDkt MTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX2luVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUgaW4g RHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KCkgYWZ0ZXIgRHJhd2luZ0FyZWFJbXBsOjpmb3JjZVJl cGFpbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ4OTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VW5za2lwIHRlc3RzIHRoYXQgc2hvdWxkIHBhc3Mgbm93LgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTUtMDktMTQgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9tZWRpYS9t ZWRpYS1kb2N1bWVudC1yZWZlcmVyLmh0bWwgaXMgZmxha3kKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNWM2YmY3OS4uMzdmYTcyZSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTY5OCwxNiArNjk4LDYgQEAgd2Vi a2l0Lm9yZy9iLzEyOTA1MCBmYXN0L3N1Yi1waXhlbC9jb21wb3NpdGluZy1sYXllcnMtb24tc3Vi cGl4ZWwtcG9zaXRpb24uaHRtbAogCiB3ZWJraXQub3JnL2IvMTQ0NzcxIGVkaXRpbmcvc2VsZWN0 aW9uL3NlbGVjdGlvbi1pbnZhbGlkLW9mZnNldC5odG1sIFsgQ3Jhc2ggXQogCi13ZWJraXQub3Jn L2IvMTQ4OTU2IFsgRGVidWcgXSBjc3MzL3ZpZXdwb3J0LXBlcmNlbnRhZ2UtbGVuZ3Rocy92aWV3 cG9ydC1wZXJjZW50YWdlLWxlbmd0aHMtYW5vbnltb3VzLWJsb2NrLmh0bWwgWyBDcmFzaCBdCi13 ZWJraXQub3JnL2IvMTQ4OTU2IFsgRGVidWcgXSBjc3MzL3ZpZXdwb3J0LXBlcmNlbnRhZ2UtbGVu Z3Rocy92aWV3cG9ydC1wZXJjZW50YWdlLWxlbmd0aHMtcGVyY2VudC1zaXplLWNoaWxkLmh0bWwg WyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTQ4OTU2IFsgRGVidWcgXSBjc3MzL3ZpZXdwb3J0LXBl cmNlbnRhZ2UtbGVuZ3Rocy92aWV3cG9ydC1wZXJjZW50YWdlLWxlbmd0aHMtcmVsYXRpdmUtZm9u dC1zaXplLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTQ4OTU2IFsgRGVidWcgXSBjc3Mz L3ZpZXdwb3J0LXBlcmNlbnRhZ2UtbGVuZ3Rocy92aWV3cG9ydC1wZXJjZW50YWdlLWxlbmd0aHMt cmVzaXplLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTQ4OTU2IFsgRGVidWcgXSBmYXN0 L2Nzcy1ncmlkLWxheW91dC9mbGV4LWNvbnRlbnQtc2l6ZWQtY29sdW1ucy1yZXNpemUuaHRtbCBb IENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xNDg5NTYgWyBEZWJ1ZyBdIGZhc3QvZG9tL1dpbmRvdy93 aW5kb3ctcmVzaXplLWNvbnRlbnRzLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTQ4OTU2 IFsgRGVidWcgXSBmYXN0L2RvbS9ydGwtc2Nyb2xsLXRvLWxlZnRtb3N0LWFuZC1yZXNpemUuaHRt bCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8xNDg5NTYgWyBEZWJ1ZyBdIGZhc3QvZHluYW1pYy93 aW5kb3ctcmVzaXplLXNjcm9sbGJhcnMtdGVzdC5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9i LzE0ODk1NiBbIERlYnVnIF0gZmFzdC9maXhlZC1sYXlvdXQvZml4ZWQtbGF5b3V0Lmh0bWwgWyBD cmFzaCBdCi0KICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEVuZCBvZiBDcmFz aGluZyB0ZXN0cwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRl eCAzZThiYTYxLi5jOTkyZGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTUtMDkt MTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX2luVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUgaW4g RHJhd2luZ0FyZWFJbXBsOjpkaXNwbGF5KCkgYWZ0ZXIgRHJhd2luZ0FyZWFJbXBsOjpmb3JjZVJl cGFpbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ4OTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBpcyBiZWNhdXNlIHRob3NlIHRlc3RzIGNhbGwgbm90aWZ5RG9uZSBpbiB0aGUgb25yZXNp emUgZXZlbnQKKyAgICAgICAgaGFuZGxlci4gSW5qZWN0ZWRCdW5kbGVQYWdlOjpkdW1wKCkgYWx3 YXlzIGNhbGxzIFdLQnVuZGxlUGFnZUZvcmNlUmVwYWludCgpCisgICAgICAgIGJlZm9yZSBkdW1w aW5nLCBXaGVuIHRoZSB2aWV3IGlzIHJlc2l6ZWQgRHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVCYWNr aW5nU3RvcmVTdGF0ZSgpCisgICAgICAgIGlzIGNhbGxlZCwgc28gaWYgdGhlIHNpemUgaGFzIGNo YW5nZWQgdGhlIEZyYW1lVmlldzo6cmVzaXplKCkKKyAgICAgICAgbWV0aG9kIGlzIGNhbGxlZCBh bmQgYWxsIGNoaWxkcmVuIGFyZSByZXNpemVkLCBzbyB0aGUgb25zcmVzaXplCisgICAgICAgIGhh bmRsZXJzIGhhcHBlbiBhdCB0aGF0IHBvaW50LCBiZWZvcmUgdGhlCisgICAgICAgIG1faW5VcGRh dGVCYWNraW5nU3RvcmVTdGF0ZSBpcyBzZXQgdG8gZmFsc2UgYWdhaW4uIEZvciBXVFIgd2UKKyAg ICAgICAgY291bGQgcHJvYmFibHkganVzdCByZXR1cm4gZWFybHkgZnJvbSBmcm9jZVJlYXBhaW50 KCkgd2hlbgorICAgICAgICBtX2luVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUgaXMgdHJ1ZSwgYmVj YXVzZSBpbiB0aGF0IGNhc2Ugd2Uga25vdworICAgICAgICB0aGUgbGF5b3V0IGlzIHVwZGF0ZWQg YmVjYXVzZSBvZiB0aGUgcmVzaXplIGFuZCB0aGUgYWN0dWFsIGRpc3BsYXkKKyAgICAgICAgaXMg bm90IHJlYWxseSBuZWVkZWQuIEJ1dCB0aGUgVUkgcHJvY2VzcyBjYW4gYWxzbyByZXF1ZXN0IGEg Zm9yY2UKKyAgICAgICAgcmVwYWludCwgc28gd2UgY291bGQgd2FpdCB1bnRpbCB0aGUgYmFja2lu ZyBzdG9yZSB1cGRhdGUgaXMgZG9uZQorICAgICAgICBhbmQgdGhlbiBmb3JjZSB0aGUgcmVwYWlu dC4gRm9yIFdUUiBpdCB3aWxsIGhhcHBlbiBhZnRlciB0aGUgdGhlCisgICAgICAgIGR1bXAsIGJ1 dCBpdCBzaG91bGRuJ3QgYmUgYSBwcm9ibGVtLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL0RyYXdpbmdBcmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1w bDo6Zm9yY2VSZXBhaW50KToKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjp1cGRh dGVCYWNraW5nU3RvcmVTdGF0ZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdp bmdBcmVhSW1wbC5oOgorCiAyMDE1LTA5LTE0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFdLV2ViVmlldyBzY3JvbGwgZGVjZWxlcmF0aW9uIHJhdGUg aXMgbm90IGJlaW5nIHNldCBwcm9wZXJseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAppbmRleCA1MTM5ZDlkLi4xYWZjZDYy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0Fy ZWFJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2lu Z0FyZWFJbXBsLmNwcApAQCAtMTk3LDYgKzE5NywxMiBAQCB2b2lkIERyYXdpbmdBcmVhSW1wbDo6 c2V0TGF5ZXJUcmVlU3RhdGVJc0Zyb3plbihib29sIGlzRnJvemVuKQogCiB2b2lkIERyYXdpbmdB cmVhSW1wbDo6Zm9yY2VSZXBhaW50KCkKIHsKKyAgICBpZiAobV9pblVwZGF0ZUJhY2tpbmdTdG9y ZVN0YXRlKSB7CisgICAgICAgIG1fZm9yY2VSZXBhaW50QWZ0ZXJCYWNraW5nU3RvcmVTdGF0ZVVw ZGF0ZSA9IHRydWU7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBtX2ZvcmNlUmVwYWlu dEFmdGVyQmFja2luZ1N0b3JlU3RhdGVVcGRhdGUgPSBmYWxzZTsKICAgICBzZXROZWVkc0Rpc3Bs YXkoKTsKIAogICAgIG1fd2ViUGFnZS5sYXlvdXRJZk5lZWRlZCgpOwpAQCAtMzc1LDYgKzM4MSw4 IEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVCYWNraW5nU3RvcmVTdGF0ZSh1aW50NjRf dCBzdGF0ZUlELCBib29sIHJlc3BvbmRJbW1lCiAgICAgfQogCiAgICAgbV9pblVwZGF0ZUJhY2tp bmdTdG9yZVN0YXRlID0gZmFsc2U7CisgICAgaWYgKG1fZm9yY2VSZXBhaW50QWZ0ZXJCYWNraW5n U3RvcmVTdGF0ZVVwZGF0ZSkKKyAgICAgICAgZm9yY2VSZXBhaW50KCk7CiB9CiAKIHZvaWQgRHJh d2luZ0FyZWFJbXBsOjpzZW5kRGlkVXBkYXRlQmFja2luZ1N0b3JlU3RhdGUoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5oCmluZGV4 IDk0ZGYzMWYuLjhmNTkzOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmgKQEAgLTEzMiw2ICsxMzIsOCBAQCBwcml2YXRlOgog ICAgIGJvb2wgbV9pc1BhaW50aW5nU3VzcGVuZGVkOwogICAgIGJvb2wgbV9hbHdheXNVc2VDb21w b3NpdGluZzsKIAorICAgIGJvb2wgbV9mb3JjZVJlcGFpbnRBZnRlckJhY2tpbmdTdG9yZVN0YXRl VXBkYXRlIHsgZmFsc2UgfTsKKwogICAgIFJ1bkxvb3A6OlRpbWVyPERyYXdpbmdBcmVhSW1wbD4g bV9kaXNwbGF5VGltZXI7CiAgICAgUnVuTG9vcDo6VGltZXI8RHJhd2luZ0FyZWFJbXBsPiBtX2V4 aXRDb21wb3NpdGluZ1RpbWVyOwogCg==