148954 2015-09-08 07:39:54 -0700 [Win][HighDPI] Video window placement is incorrect. 2015-09-08 11:23:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue oldest_to_newest 1124226 0 peavo 2015-09-08 07:39:54 -0700 We need to take the device scale factor into account when computing the position and size of the video window. 1124227 1 260759 peavo 2015-09-08 07:44:03 -0700 Created attachment 260759 Patch 1124282 2 260759 achristensen 2015-09-08 10:35:50 -0700 Comment on attachment 260759 Patch r=me. I noticed this earlier. 1124297 3 peavo 2015-09-08 10:55:12 -0700 (In reply to comment #2) > Comment on attachment 260759 [details] > Patch > > r=me. I noticed this earlier. Thanks for the review :) 1124316 4 260759 commit-queue 2015-09-08 11:23:33 -0700 Comment on attachment 260759 Patch Clearing flags on attachment: 260759 Committed r189498: <http://trac.webkit.org/changeset/189498> 1124318 5 commit-queue 2015-09-08 11:23:36 -0700 All reviewed patches have been landed. Closing bug. 260759 2015-09-08 07:44:03 -0700 2015-09-08 11:23:33 -0700 Patch bug-148954-20150908164357.patch text/plain 2470 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTQ4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTA4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXVtIaWdoRFBJXSBW aWRlbyB3aW5kb3cgcGxhY2VtZW50IGlzIGluY29ycmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODk1NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gc2NhbGUgd2luZG93IGRpbWVu c2lvbnMgd2l0aCBkZXZpY2Ugc2NhbGUgZmFjdG9yLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnNldFNpemUpOgor CiAyMDE1LTA5LTA4ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZWR1Y2UgdXNlcyBvZiBQYXNzUmVmUHRyIGluIGZpbGVhcGkKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZv dW5kYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCShyZXZpc2lvbiAx ODk0ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM0LDggKzIz NCwxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6CiAgICAgSW50 UG9pbnQgcG9zaXRpb25JbldpbmRvdyhtX2xhc3RQYWludFJlY3QubG9jYXRpb24oKSk7CiAKICAg ICBGcmFtZVZpZXcqIHZpZXcgPSBudWxscHRyOwotICAgIGlmIChtX3BsYXllciAmJiBtX3BsYXll ci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKSAmJiBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2Fk ZXIoKS0+ZG9jdW1lbnQoKSkKKyAgICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9IDEuMGY7Cisg ICAgaWYgKG1fcGxheWVyICYmIG1fcGxheWVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpICYmIG1f cGxheWVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLT5kb2N1bWVudCgpKSB7CiAgICAgICAgIHZp ZXcgPSBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKS0+ZG9jdW1lbnQoKS0+dmlldygp OworICAgICAgICBkZXZpY2VTY2FsZUZhY3RvciA9IG1fcGxheWVyLT5jYWNoZWRSZXNvdXJjZUxv YWRlcigpLT5kb2N1bWVudCgpLT5kZXZpY2VTY2FsZUZhY3RvcigpOworICAgIH0KIAogICAgIGlm ICh2aWV3KSB7CiAgICAgICAgIHNjcm9sbE9mZnNldCA9IHZpZXctPnNjcm9sbE9mZnNldEZvckZp eGVkUG9zaXRpb24oKTsKQEAgLTI0NCwxMCArMjQ3LDE1IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFGb3VuZGF0aW9uOjoKIAogICAgIHBvc2l0aW9uSW5XaW5kb3cubW92ZSgtc2Nyb2xs T2Zmc2V0LndpZHRoKCkudG9JbnQoKSwgLXNjcm9sbE9mZnNldC5oZWlnaHQoKS50b0ludCgpKTsK IAorICAgIGludCB4ID0gcG9zaXRpb25JbldpbmRvdy54KCkgKiBkZXZpY2VTY2FsZUZhY3RvcjsK KyAgICBpbnQgeSA9IHBvc2l0aW9uSW5XaW5kb3cueSgpICogZGV2aWNlU2NhbGVGYWN0b3I7Cisg ICAgaW50IHcgPSBtX3NpemUud2lkdGgoKSAqIGRldmljZVNjYWxlRmFjdG9yOworICAgIGludCBo ID0gbV9zaXplLmhlaWdodCgpICogZGV2aWNlU2NhbGVGYWN0b3I7CisKICAgICBpZiAobV9od25k VmlkZW8gJiYgIW1fbGFzdFBhaW50UmVjdC5pc0VtcHR5KCkpCi0gICAgICAgIDo6TW92ZVdpbmRv dyhtX2h3bmRWaWRlbywgcG9zaXRpb25JbldpbmRvdy54KCksIHBvc2l0aW9uSW5XaW5kb3cueSgp LCBtX3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgpLCBGQUxTRSk7CisgICAgICAgIDo6TW92 ZVdpbmRvdyhtX2h3bmRWaWRlbywgeCwgeSwgdywgaCwgRkFMU0UpOwogCi0gICAgUkVDVCByYyA9 IHsgMCwgMCwgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWlnaHQoKSB9OworICAgIFJFQ1QgcmMg PSB7IDAsIDAsIHcsIGggfTsKICAgICBtX3ZpZGVvRGlzcGxheS0+U2V0VmlkZW9Qb3NpdGlvbihu dWxscHRyLCAmcmMpOwogfQogCg==