148930 2015-09-07 07:12:10 -0700 [WebGL] Return correct values for GL_STENCIL_VALUE_MASK and GL_STENCIL_WRITE_MASK 2015-09-15 18:13:23 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 hur.ims hur.ims dino oldest_to_newest 1124116 0 hur.ims 2015-09-07 07:12:10 -0700 n 1124117 1 hur.ims 2015-09-07 07:14:26 -0700 It seems that ANGLE clamps GL_STENCIL_VALUE_MASK, GL_STENCIL_BACK_VALUE_MASK, GL_STENCIL_WRITEMASK and GL_STENCIL_BACK_WRITEMASK values into max integer, which results in the value change(0xffffffff --> 0x7fffffff) unintentionally. 1124120 2 260737 hur.ims 2015-09-07 07:22:41 -0700 Created attachment 260737 Patch 1124121 3 hur.ims 2015-09-07 07:35:19 -0700 Without this patch, fast/canvas/webgl/gl-get-calls.html fails on ANGLE backed OpenGL ES platform. 1124950 4 260737 dino 2015-09-10 11:08:19 -0700 Comment on attachment 260737 Patch We can apply this in WebKit, but you really need the change to be made in ANGLE. Also, is there a way to test this? 1124961 5 hur.ims 2015-09-10 11:33:59 -0700 (In reply to comment #4) > Comment on attachment 260737 [details] > Patch > > We can apply this in WebKit, but you really need the change to be made in > ANGLE. Also, is there a way to test this? Ok then, I think it would be safe to commit this patch after landed on ANGLE project first. I believe there is no way to test this because no ports are using ANGLE as its OpenGL implementation but mine. My team's port is using ANGLE backed OpenGL APIs so I could find this bug. Anyway, thanks for review! 1126078 6 hur.ims 2015-09-15 11:42:11 -0700 ANGLE seems implemented correctly based on the OpenGL ES 3.0 spec. So this patch should be abandoned. Instead, I'm trying to modify fast/canvas/webgl/gl-get-calls.html at https://bugs.webkit.org/show_bug.cgi?id=149174 1126079 7 hur.ims 2015-09-15 11:48:46 -0700 (In reply to comment #6) > ANGLE seems implemented correctly based on the OpenGL ES 3.0 spec. > So this patch should be abandoned. > > Instead, I'm trying to modify fast/canvas/webgl/gl-get-calls.html at > https://bugs.webkit.org/show_bug.cgi?id=149174 Review from an ANGLE people. https://chromium-review.googlesource.com/#/c/299564/ 260737 2015-09-07 07:22:41 -0700 2015-09-10 11:08:19 -0700 Patch bug-148930-20150907232236.patch text/plain 4198 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNzQ1ZGUxOWMyNzI2ZjZiMTAwNzllMjI1MWVjNWZjZTA3YTk0ZWViYS4uNjJmMjUyYjQ4Mjg2 Zjc0MDk2MDE2ZGQzNTRlMGEwOTMzMmQ3ZmQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA5LTA3ICBKaW55b3VuZyBIdXIgIDxodXIuaW1zQG5h dmVyY29ycC5jb20+CisKKyAgICAgICAgW1dlYkdMXSBSZXR1cm4gY29ycmVjdCB2YWx1ZXMgZm9y IEdMX1NURU5DSUxfVkFMVUVfTUFTSyBhbmQgR0xfU1RFTkNJTF9XUklURV9NQVNLCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg5MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzZWVtcyB0aGF0IEFO R0xFIGNsYW1wcyBHTF9TVEVOQ0lMX1ZBTFVFX01BU0ssIEdMX1NURU5DSUxfQkFDS19WQUxVRV9N QVNLLCBHTF9TVEVOQ0lMX1dSSVRFTUFTSworICAgICAgICBhbmQgR0xfU1RFTkNJTF9CQUNLX1dS SVRFTUFTSyB2YWx1ZXMgaW50byBtYXggaW50ZWdlciwgd2hpY2ggcmVzdWx0cyBpbiB0aGUgdmFs dWUgY2hhbmdlKDB4ZmZmZmZmZmYKKyAgICAgICAgLS0+IDB4N2ZmZmZmZmYpIHVuaW50ZW50aW9u YWxseS4KKyAgICAgICAgCisgICAgICAgICogc3JjL2xpYkFOR0xFL1N0YXRlLmNwcDoKKyAgICAg ICAgKGdsOjpTdGF0ZTo6Z2V0SW50ZWdlcnYpOgorCiAyMDE1LTA4LTIwICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2xlYW4gdXAgQ01ha2Ug YnVpbGQgYWZ0ZXIgcjE4ODY3MwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2xpYkFOR0xFL1N0YXRlLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJB TkdMRS9TdGF0ZS5jcHAKaW5kZXggZjY4MzdmNDJlMTJmZGIxNzA3MGMxZDI2NDk1ZjRlNjQ0ZTI1 ZjkyMy4uYjMwYjIxODNiNzUzZWY1YmVkZmMyOWUzZDAzNDAxMDIzYjMzNDlmYSAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL1N0YXRlLmNwcAorKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvU3RhdGUuY3BwCkBAIC0xMTk1LDEw ICsxMTk1LDEwIEBAIHZvaWQgU3RhdGU6OmdldEludGVnZXJ2KGNvbnN0IGdsOjpEYXRhICZkYXRh LCBHTGVudW0gcG5hbWUsIEdMaW50ICpwYXJhbXMpCiAgICAgICBjYXNlIEdMX0FDVElWRV9URVhU VVJFOiAgICAgICAgICAgICAgICAgICAgICAgICAgICpwYXJhbXMgPSBzdGF0aWNfY2FzdDxHTGlu dD4obUFjdGl2ZVNhbXBsZXIgKyBHTF9URVhUVVJFMCk7ICAgICBicmVhazsKICAgICAgIGNhc2Ug R0xfU1RFTkNJTF9GVU5DOiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKnBhcmFtcyA9IG1E ZXB0aFN0ZW5jaWwuc3RlbmNpbEZ1bmM7ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgY2FzZSBHTF9TVEVOQ0lMX1JFRjogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqcGFy YW1zID0gbVN0ZW5jaWxSZWY7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7Ci0gICAgICBjYXNlIEdMX1NURU5DSUxfVkFMVUVfTUFTSzogICAgICAgICAgICAgICAgICAg ICAgICpwYXJhbXMgPSBjbGFtcFRvSW50KG1EZXB0aFN0ZW5jaWwuc3RlbmNpbE1hc2spOyAgICAg ICAgICBicmVhazsKKyAgICAgIGNhc2UgR0xfU1RFTkNJTF9WQUxVRV9NQVNLOiAgICAgICAgICAg ICAgICAgICAgICAgKnBhcmFtcyA9IG1EZXB0aFN0ZW5jaWwuc3RlbmNpbE1hc2s7ICAgICAgICAg ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgY2FzZSBHTF9TVEVOQ0lMX0JBQ0tfRlVOQzogICAg ICAgICAgICAgICAgICAgICAgICAqcGFyYW1zID0gbURlcHRoU3RlbmNpbC5zdGVuY2lsQmFja0Z1 bmM7ICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICBjYXNlIEdMX1NURU5DSUxfQkFDS19S RUY6ICAgICAgICAgICAgICAgICAgICAgICAgICpwYXJhbXMgPSBtU3RlbmNpbEJhY2tSZWY7ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgIGNhc2UgR0xfU1RFTkNJ TF9CQUNLX1ZBTFVFX01BU0s6ICAgICAgICAgICAgICAgICAgKnBhcmFtcyA9IGNsYW1wVG9JbnQo bURlcHRoU3RlbmNpbC5zdGVuY2lsQmFja01hc2spOyAgICAgIGJyZWFrOworICAgICAgY2FzZSBH TF9TVEVOQ0lMX0JBQ0tfVkFMVUVfTUFTSzogICAgICAgICAgICAgICAgICAqcGFyYW1zID0gbURl cHRoU3RlbmNpbC5zdGVuY2lsQmFja01hc2s7ICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICBjYXNlIEdMX1NURU5DSUxfRkFJTDogICAgICAgICAgICAgICAgICAgICAgICAgICAgICpwYXJh bXMgPSBtRGVwdGhTdGVuY2lsLnN0ZW5jaWxGYWlsOyAgICAgICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgIGNhc2UgR0xfU1RFTkNJTF9QQVNTX0RFUFRIX0ZBSUw6ICAgICAgICAgICAgICAg ICAgKnBhcmFtcyA9IG1EZXB0aFN0ZW5jaWwuc3RlbmNpbFBhc3NEZXB0aEZhaWw7ICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgY2FzZSBHTF9TVEVOQ0lMX1BBU1NfREVQVEhfUEFTUzogICAgICAg ICAgICAgICAgICAqcGFyYW1zID0gbURlcHRoU3RlbmNpbC5zdGVuY2lsUGFzc0RlcHRoUGFzczsg ICAgICAgICAgICAgYnJlYWs7CkBAIC0xMjEyLDggKzEyMTIsOCBAQCB2b2lkIFN0YXRlOjpnZXRJ bnRlZ2Vydihjb25zdCBnbDo6RGF0YSAmZGF0YSwgR0xlbnVtIHBuYW1lLCBHTGludCAqcGFyYW1z KQogICAgICAgY2FzZSBHTF9CTEVORF9EU1RfQUxQSEE6ICAgICAgICAgICAgICAgICAgICAgICAg ICAqcGFyYW1zID0gbUJsZW5kLmRlc3RCbGVuZEFscGhhOyAgICAgICAgICAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICBjYXNlIEdMX0JMRU5EX0VRVUFUSU9OX1JHQjogICAgICAgICAgICAg ICAgICAgICAgICpwYXJhbXMgPSBtQmxlbmQuYmxlbmRFcXVhdGlvblJHQjsgICAgICAgICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgIGNhc2UgR0xfQkxFTkRfRVFVQVRJT05fQUxQSEE6ICAg ICAgICAgICAgICAgICAgICAgKnBhcmFtcyA9IG1CbGVuZC5ibGVuZEVxdWF0aW9uQWxwaGE7ICAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgY2FzZSBHTF9TVEVOQ0lMX1dSSVRFTUFT SzogICAgICAgICAgICAgICAgICAgICAgICAqcGFyYW1zID0gY2xhbXBUb0ludChtRGVwdGhTdGVu Y2lsLnN0ZW5jaWxXcml0ZW1hc2spOyAgICAgYnJlYWs7Ci0gICAgICBjYXNlIEdMX1NURU5DSUxf QkFDS19XUklURU1BU0s6ICAgICAgICAgICAgICAgICAgICpwYXJhbXMgPSBjbGFtcFRvSW50KG1E ZXB0aFN0ZW5jaWwuc3RlbmNpbEJhY2tXcml0ZW1hc2spOyBicmVhazsKKyAgICAgIGNhc2UgR0xf U1RFTkNJTF9XUklURU1BU0s6ICAgICAgICAgICAgICAgICAgICAgICAgKnBhcmFtcyA9IG1EZXB0 aFN0ZW5jaWwuc3RlbmNpbFdyaXRlbWFzazsgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg Y2FzZSBHTF9TVEVOQ0lMX0JBQ0tfV1JJVEVNQVNLOiAgICAgICAgICAgICAgICAgICAqcGFyYW1z ID0gbURlcHRoU3RlbmNpbC5zdGVuY2lsQmFja1dyaXRlbWFzazsgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICBjYXNlIEdMX1NURU5DSUxfQ0xFQVJfVkFMVUU6ICAgICAgICAgICAgICAgICAgICAg ICpwYXJhbXMgPSBtU3RlbmNpbENsZWFyVmFsdWU7ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBicmVhazsKICAgICAgIGNhc2UgR0xfSU1QTEVNRU5UQVRJT05fQ09MT1JfUkVBRF9UWVBFOiAg ICAgICAgICAgKnBhcmFtcyA9IG1SZWFkRnJhbWVidWZmZXItPmdldEltcGxlbWVudGF0aW9uQ29s b3JSZWFkVHlwZSgpOyAgIGJyZWFrOwogICAgICAgY2FzZSBHTF9JTVBMRU1FTlRBVElPTl9DT0xP Ul9SRUFEX0ZPUk1BVDogICAgICAgICAqcGFyYW1zID0gbVJlYWRGcmFtZWJ1ZmZlci0+Z2V0SW1w bGVtZW50YXRpb25Db2xvclJlYWRGb3JtYXQoKTsgYnJlYWs7Cg==