148927 2015-09-07 04:07:19 -0700 [EFL] Many of the css3/device-adapt/* tests failed after r188548. 2015-09-07 05:34:55 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148093 1 hs85.jeong hs85.jeong andersca commit-queue gyuyoung.kim lucas.de.marchi ossy sam oldest_to_newest 1124100 0 hs85.jeong 2015-09-07 04:07:19 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/24260/steps/layout-test/logs/stdio css3/device-adapt/opera/cascading-002.xhtml [ Failure ] css3/device-adapt/opera/cascading-003.xhtml [ Failure ] css3/device-adapt/opera/cascading-004.xhtml [ Failure ] css3/device-adapt/opera/constrain-001.xhtml [ Failure ] css3/device-adapt/opera/constrain-004.xhtml [ Failure ] css3/device-adapt/opera/constrain-005.xhtml [ Failure ] css3/device-adapt/opera/constrain-006.xhtml [ Failure ] css3/device-adapt/opera/constrain-007.xhtml [ Failure ] css3/device-adapt/opera/constrain-008.xhtml [ Failure ] css3/device-adapt/opera/constrain-010.xhtml [ Failure ] css3/device-adapt/opera/constrain-011.xhtml [ Failure ] css3/device-adapt/opera/constrain-013.xhtml [ Failure ] css3/device-adapt/opera/constrain-014.xhtml [ Failure ] css3/device-adapt/opera/constrain-015.xhtml [ Failure ] css3/device-adapt/opera/constrain-016.xhtml [ Failure ] css3/device-adapt/opera/constrain-017.xhtml [ Failure ] css3/device-adapt/opera/constrain-018.xhtml [ Failure ] css3/device-adapt/opera/constrain-019.xhtml [ Failure ] css3/device-adapt/opera/constrain-020.xhtml [ Failure ] css3/device-adapt/opera/syntax-001.xhtml [ Failure ] css3/device-adapt/opera/syntax-002.xhtml [ Failure ] css3/device-adapt/opera/syntax-003.xhtml [ Failure ] css3/device-adapt/viewport-width-check-window-innerwidth-correct.html [ Failure ] 1124101 1 260732 hs85.jeong 2015-09-07 04:28:35 -0700 Created attachment 260732 Patch 1124102 2 hs85.jeong 2015-09-07 04:35:13 -0700 This patch is twice checking the 'if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))' in TestController and TestControllerEfl. Do I move the check logic to TestController to remove the duplicated code? 1124103 3 260732 ossy 2015-09-07 04:35:31 -0700 Comment on attachment 260732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260732&action=review r=me > Tools/ChangeLog:9 > + overwritted by updatePlatformSpecificViewOptionsForTest after r188548. typo: overwritten > Tools/ChangeLog:14 > + (WTR::shouldUseFixedLayout): Return the true if the test is related with 'device-adapt'. nit: Please remove "the" before landing the patch. --> Return true ... 1124104 4 260733 hs85.jeong 2015-09-07 04:39:59 -0700 Created attachment 260733 Patch 1124105 5 hs85.jeong 2015-09-07 04:42:05 -0700 (In reply to comment #3) > Comment on attachment 260732 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260732&action=review > > r=me > > > Tools/ChangeLog:9 > > + overwritted by updatePlatformSpecificViewOptionsForTest after r188548. > > typo: overwritten > > > Tools/ChangeLog:14 > > + (WTR::shouldUseFixedLayout): Return the true if the test is related with 'device-adapt'. > > nit: Please remove "the" before landing the patch. --> Return true ... Oops... I fix the typo.. 1124107 6 hs85.jeong 2015-09-07 04:46:27 -0700 Your name looks like "Csaba Osztrogonác." in changeLog. Do I make the new patch? 1124109 7 ossy 2015-09-07 04:48:47 -0700 (In reply to comment #6) > Your name looks like "Csaba Osztrogonác." in changeLog. > Do I make the new patch? No problem, it is a bug of the review tool, it will be good in the commit log and the change log after landing. 1124113 8 260733 commit-queue 2015-09-07 05:34:50 -0700 Comment on attachment 260733 Patch Clearing flags on attachment: 260733 Committed r189464: <http://trac.webkit.org/changeset/189464> 1124114 9 commit-queue 2015-09-07 05:34:55 -0700 All reviewed patches have been landed. Closing bug. 260732 2015-09-07 04:28:35 -0700 2015-09-07 04:39:53 -0700 Patch bug-148927-20150907202830.patch text/plain 2446 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjQ3OTZkY2Q3YTZhNDRjNzA0NWYwZDg2MjgxMTFlNjU2 NDk5Y2UyZC4uMWZkMTcxNDhkODA3ODdjODBkMWM2ODMwYjA5NmE1ZmM0NGE0ZmFlNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE1LTA5LTA3ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBNYW55IG9mIHRoZSBjc3MzL2RldmljZS1hZGFwdC8qIHRlc3RzIGZh aWxlZCBhZnRlciByMTg4NTQ4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgZGV2aWNlLWFkYXB0LyogdGVzdHMgbmVlZCB0aGUgZml4ZWRMYXlvdXQgb3B0 aW9uIGJ1dCB1c2VGaXhlZExheW91dCBvcHRpb24gaXMKKyAgICAgICAgb3ZlcndyaXR0ZWQgYnkg dXBkYXRlUGxhdGZvcm1TcGVjaWZpY1ZpZXdPcHRpb25zRm9yVGVzdCBhZnRlciByMTg4NTQ4Lgor CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAg IChXVFI6OnNob3VsZFVzZUZpeGVkTGF5b3V0KTogUmVtb3ZlZCB0aGUgdW5uZWNlc3NhcnkgaW5k ZW50YXRpb25zLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVy RWZsLmNwcDoKKyAgICAgICAgKFdUUjo6c2hvdWxkVXNlRml4ZWRMYXlvdXQpOiBSZXR1cm4gdGhl IHRydWUgaWYgdGhlIHRlc3QgaXMgcmVsYXRlZCB3aXRoICdkZXZpY2UtYWRhcHQnLgorCiAyMDE1 LTA5LTA3ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhl IFByb2R1Y3Rpb24gYnVpbGQgYWZ0ZXIgcjE4OTQ1NS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5jcHAKaW5kZXggYWFlZmExY2JlYjkzYTdhMDZjMTkyMTM5YzQ2Zjg1OWRj NGRkNmFjZi4uYTY0NjBhYTdlNmM3NGIxMjYxNGU0NzNmZmRmNjI3YzE5MjVjZWVjNSAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTc4OSw4ICs3ODksOCBA QCBjb25zdCBjaGFyKiBUZXN0Q29udHJvbGxlcjo6bmV0d29ya1Byb2Nlc3NOYW1lKCkKIHN0YXRp YyBib29sIHNob3VsZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQog ewogI2lmIEVOQUJMRShDU1NfREVWSUNFX0FEQVBUQVRJT04pCi0gICAgICAgIGlmICh0ZXN0LnVy bENvbnRhaW5zKCJkZXZpY2UtYWRhcHQvIikgfHwgdGVzdC51cmxDb250YWlucygiZGV2aWNlLWFk YXB0XFwiKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmICh0ZXN0LnVybENvbnRh aW5zKCJkZXZpY2UtYWRhcHQvIikgfHwgdGVzdC51cmxDb250YWlucygiZGV2aWNlLWFkYXB0XFwi KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAjZW5kaWYKIAogICAgIHJldHVybiBmYWxzZTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcAppbmRl eCA2OWQyMGRmOTgxOTQ3MjZmZmM5NTFiOGEyOTk3M2ZjMWEwZmEzNjEyLi4yNjc0MWY1ZjE0ZThh MGFlODZjZmM3Nzc5M2ExZWIxZjBmMjc4NjY1IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3BwCkBAIC0xMzYsNiArMTM2LDExIEBAIGNvbnN0 IGNoYXIqIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUxpYnJhcnlQYXRoRm9yVGVzdGluZygpCiAK IHN0YXRpYyBib29sIHNob3VsZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0 ZXN0KQogeworI2lmIEVOQUJMRShDU1NfREVWSUNFX0FEQVBUQVRJT04pCisgICAgaWYgKHRlc3Qu dXJsQ29udGFpbnMoImRldmljZS1hZGFwdC8iKSB8fCB0ZXN0LnVybENvbnRhaW5zKCJkZXZpY2Ut YWRhcHRcXCIpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorCiAjaWYgVVNFKENPT1JE SU5BVEVEX0dSQVBISUNTKQogICAgIGlmICh0ZXN0LnVybENvbnRhaW5zKCJzdGlja3kvIikgfHwg dGVzdC51cmxDb250YWlucygic3RpY2t5XFwiKSkKICAgICAgICAgcmV0dXJuIHRydWU7Cg== 260733 2015-09-07 04:39:59 -0700 2015-09-07 05:34:50 -0700 Patch bug-148927-20150907203954.patch text/plain 2446 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjQ3OTZkY2Q3YTZhNDRjNzA0NWYwZDg2MjgxMTFlNjU2 NDk5Y2UyZC4uNjc0Zjg2ODZkOTA2MzZlYzUxZGY3ZTNiOWY0MThlNTFmYWU1MTFiNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE1LTA5LTA3ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBNYW55IG9mIHRoZSBjc3MzL2RldmljZS1hZGFwdC8qIHRlc3RzIGZh aWxlZCBhZnRlciByMTg4NTQ4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29u w6FjLgorCisgICAgICAgIGRldmljZS1hZGFwdC8qIHRlc3RzIG5lZWQgdGhlIGZpeGVkTGF5b3V0 IG9wdGlvbiBidXQgdXNlRml4ZWRMYXlvdXQgb3B0aW9uIGlzCisgICAgICAgIG92ZXJ3cml0dGVu IGJ5IHVwZGF0ZVBsYXRmb3JtU3BlY2lmaWNWaWV3T3B0aW9uc0ZvclRlc3QgYWZ0ZXIgcjE4ODU0 OC4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV1RSOjpzaG91bGRVc2VGaXhlZExheW91dCk6IFJlbW92ZWQgdGhlIHVubmVjZXNzYXJ5 IGluZGVudGF0aW9ucy4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9UZXN0Q29udHJv bGxlckVmbC5jcHA6CisgICAgICAgIChXVFI6OnNob3VsZFVzZUZpeGVkTGF5b3V0KTogUmV0dXJu IHRydWUgaWYgdGhlIHRlc3QgaXMgcmVsYXRlZCB3aXRoICdkZXZpY2UtYWRhcHQnLgorCiAyMDE1 LTA5LTA3ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhl IFByb2R1Y3Rpb24gYnVpbGQgYWZ0ZXIgcjE4OTQ1NS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5jcHAKaW5kZXggYWFlZmExY2JlYjkzYTdhMDZjMTkyMTM5YzQ2Zjg1OWRj NGRkNmFjZi4uYTY0NjBhYTdlNmM3NGIxMjYxNGU0NzNmZmRmNjI3YzE5MjVjZWVjNSAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTc4OSw4ICs3ODksOCBA QCBjb25zdCBjaGFyKiBUZXN0Q29udHJvbGxlcjo6bmV0d29ya1Byb2Nlc3NOYW1lKCkKIHN0YXRp YyBib29sIHNob3VsZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQog ewogI2lmIEVOQUJMRShDU1NfREVWSUNFX0FEQVBUQVRJT04pCi0gICAgICAgIGlmICh0ZXN0LnVy bENvbnRhaW5zKCJkZXZpY2UtYWRhcHQvIikgfHwgdGVzdC51cmxDb250YWlucygiZGV2aWNlLWFk YXB0XFwiKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIGlmICh0ZXN0LnVybENvbnRh aW5zKCJkZXZpY2UtYWRhcHQvIikgfHwgdGVzdC51cmxDb250YWlucygiZGV2aWNlLWFkYXB0XFwi KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAjZW5kaWYKIAogICAgIHJldHVybiBmYWxzZTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcAppbmRl eCA2OWQyMGRmOTgxOTQ3MjZmZmM5NTFiOGEyOTk3M2ZjMWEwZmEzNjEyLi4yNjc0MWY1ZjE0ZThh MGFlODZjZmM3Nzc5M2ExZWIxZjBmMjc4NjY1IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3BwCkBAIC0xMzYsNiArMTM2LDExIEBAIGNvbnN0 IGNoYXIqIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUxpYnJhcnlQYXRoRm9yVGVzdGluZygpCiAK IHN0YXRpYyBib29sIHNob3VsZFVzZUZpeGVkTGF5b3V0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0 ZXN0KQogeworI2lmIEVOQUJMRShDU1NfREVWSUNFX0FEQVBUQVRJT04pCisgICAgaWYgKHRlc3Qu dXJsQ29udGFpbnMoImRldmljZS1hZGFwdC8iKSB8fCB0ZXN0LnVybENvbnRhaW5zKCJkZXZpY2Ut YWRhcHRcXCIpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorCiAjaWYgVVNFKENPT1JE SU5BVEVEX0dSQVBISUNTKQogICAgIGlmICh0ZXN0LnVybENvbnRhaW5zKCJzdGlja3kvIikgfHwg dGVzdC51cmxDb250YWlucygic3RpY2t5XFwiKSkKICAgICAgICAgcmV0dXJuIHRydWU7Cg==