148921 2015-09-06 21:38:05 -0700 Dashboard: Remove use of z-index for ring overlay; use DOM ordering 2015-09-08 08:58:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes ap timothy oldest_to_newest 1124071 0 dbates 2015-09-06 21:38:05 -0700 Currently the WebKit Bot Watcher Dashboard uses the CSS property z-index to have the ring overlay image (<https://build.webkit.org/dashboard/Images/PlatformRing.png>) painted on top of each platform icon (e.g. <https://build.webkit.org/dashboard/Images/Yosemite.png>). We remove the use of the CSS property z-index by taking advantage of the transparency in the ring image and ordering the DOM such that the platform icon is before the ring image. 1124072 1 260729 dbates 2015-09-06 21:41:44 -0700 Created attachment 260729 Patch 1124242 2 260729 dbates 2015-09-08 08:58:40 -0700 Comment on attachment 260729 Patch Clearing flags on attachment: 260729 Committed r189489: <http://trac.webkit.org/changeset/189489> 1124243 3 dbates 2015-09-08 08:58:44 -0700 All reviewed patches have been landed. Closing bug. 260729 2015-09-06 21:41:44 -0700 2015-09-08 08:58:40 -0700 Patch bug-148921-20150906214140.patch text/plain 3447 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDU3Nzk2MjQ2YjhiMjlhNTRiNjY0MjQyNmM3YTExYTFj YTliN2MzYi4uZjAxZmM1Y2NmYjg2MWM5OWM2YzdiMWVmOGUwZGM3NzVlMDYzNGEwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0 IEBACiAyMDE1LTA5LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAg ICAgICBEYXNoYm9hcmQ6IFJlbW92ZSB1c2Ugb2Ygei1pbmRleCBmb3IgcmluZyBvdmVybGF5OyB1 c2UgRE9NIG9yZGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDg5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgcmluZyBpbWFnZSBpcyBwb3NpdGlvbmVkIGFib3ZlIHRoZSBwbGF0Zm9ybSBp Y29uIGluIG1hcmt1cCBhbmQgd2Ugc3BlY2lmeSB0aGUgQ1NTCisgICAgICAgIHByb3BlcnR5IHot aW5kZXggZm9yIHRoZSByaW5nIGltYWdlIHNvIHRoYXQgaXQgaXMgcGFpbnRlZCBvbiB0b3Agb2Yg dGhlIHBsYXRmb3JtIGljb24KKyAgICAgICAgaW5zdGVhZCBvZiBiZWxvdyBpdCAoYnkgRE9NIG9y ZGVyaW5nKS4gSW5zdGVhZCB3ZSBjYW4gdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIHRyYW5zcGFyZW5j eQorICAgICAgICBvZiB0aGUgcmluZyBpbWFnZSwgc3dpdGNoIHRoZSBvcmRlciBvZiB0aGVzZSBE T00gZWxlbWVudHMgYW5kIHJlbW92ZSB0aGUgdXNlIG9mIHRoZSBDU1MKKyAgICAgICAgcHJvcGVy dHkgei1pbmRleCB0byBhY2hpZXZlIGEgc2ltaWxhciBlZmZlY3QuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9h cmQvU2NyaXB0cy9NYWluLmpzOgorICAgICAgICAoZG9jdW1lbnRSZWFkeSk6IENyZWF0ZSB0aGUg cGxhdGZvcm0gaWNvbiBpbWFnZSBlbGVtZW50IGJlZm9yZSB0aGUgcmluZyBpbWFnZSBzdWNoIHRo YXQKKyAgICAgICAgdGhlIHJpbmcgaW1hZ2UgaXMgcGFpbnRlZCBvbiB0b3Agb2YgdGhlIHBsYXRm b3JtIGljb24uCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzczoKKyAgICAgICAgKHRh YmxlLnF1ZXVlLWdyaWQgdGQubG9nbyBpbWcucmluZyk6IFJlbW92ZWQgcHJvcGVydHkgei1pbmRl eC4KKworMjAxNS0wOS0wNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKICAg ICAgICAgRGFzaGJvYXJkOiBSZW1vdmUgZHVwbGljYXRlIGdlYXIgaWNvbiBkYXRhIFVSTHMKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODkyMAogCmRp ZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvTWFpbi5qcwppbmRleCA5NjViNjI2Y2NkMDUzZjk4NzFiY2EwNjhmYzUzNTcwNTgyNDdi Y2E4Li40OTYwYmQ1OGY3YjgwY2Y0ZThhY2JlMWZhZGUwN2QyMDYwYWNhZjJkIDEwMDY0NAotLS0g YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L01haW4uanMKQEAgLTIwMCwxNSArMjAwLDE1IEBAIGZ1bmN0aW9uIGRvY3VtZW50UmVhZHkoKQog ICAgICAgICB2YXIgY2VsbCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRkIik7CiAgICAgICAg IGNlbGwuY2xhc3NMaXN0LmFkZCgibG9nbyIpOwogCisgICAgICAgIHZhciBsb2dvSW1hZ2UgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbWciKTsKKyAgICAgICAgbG9nb0ltYWdlLmNsYXNzTGlz dC5hZGQoImxvZ28iKTsKKyAgICAgICAgY2VsbC5hcHBlbmRDaGlsZChsb2dvSW1hZ2UpOworCiAg ICAgICAgIHZhciByaW5nSW1hZ2UgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbWciKTsKICAg ICAgICAgcmluZ0ltYWdlLmNsYXNzTGlzdC5hZGQoInJpbmciKTsKICAgICAgICAgcmluZ0ltYWdl LnRpdGxlID0gcGxhdGZvcm0ucmVhZGFibGVOYW1lOwogICAgICAgICBjZWxsLmFwcGVuZENoaWxk KHJpbmdJbWFnZSk7CiAKLSAgICAgICAgdmFyIGxvZ29JbWFnZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImltZyIpOwotICAgICAgICBsb2dvSW1hZ2UuY2xhc3NMaXN0LmFkZCgibG9nbyIpOwot ICAgICAgICBjZWxsLmFwcGVuZENoaWxkKGxvZ29JbWFnZSk7Ci0KICAgICAgICAgdmFyIGhpZGVC dXR0b24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICAgICAgaGlkZUJ1dHRv bi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGZ1bmN0aW9uIChwbGF0Zm9ybU5hbWUpIHsgcmV0 dXJuIGZ1bmN0aW9uICgpIHsgc2V0dGluZ3MudG9nZ2xlSGlkZGVuUGxhdGZvcm0ocGxhdGZvcm1O YW1lKTsgfTsgfShwbGF0Zm9ybS5uYW1lKSApOwogICAgICAgICBoaWRlQnV0dG9uLnRleHRDb250 ZW50ID0gImhpZGUiOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzcyBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3MKaW5kZXggOTU1ODMyM2RkMGVkNmZlZDkxZDEx NDMyNTRiNjhmOTliYjY5ZjIyMS4uMjUzMDlmNTRiMmRlNjViZTNlM2UwNGE5MjdmNmFmNTdhZWUz ZTgyMiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzcworKysgYi9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9k YXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCkBAIC0xNTYsNyArMTU2LDYgQEAgdGFibGUucXVldWUt Z3JpZCB0ZC5sb2dvIGltZy5yaW5nIHsKICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgdG9w OiAyMHB4OwogICAgIGxlZnQ6IDE4cHg7Ci0gICAgei1pbmRleDogMTsKIH0KIAogdGFibGUucXVl dWUtZ3JpZCB0ZC5sb2dvIGltZy5sb2dvIHsK