148920 2015-09-06 21:05:04 -0700 Dashboard: Remove duplicate gear icon data URLs 2015-09-08 08:58:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes ap timothy oldest_to_newest 1124069 0 dbates 2015-09-06 21:05:04 -0700 Currently we duplicate the SVG data URL for the gear icon (shown in the top left of the dashboard) up to its fill color for each of its three states: collapsed, hover, and expanded. We can simplify the CSS selectors for the gear icon by treating the gear icon as a mask using -webkit-mask-image and specifying the appropriate fill color using the CSS property background-color. 1124070 1 260728 dbates 2015-09-06 21:06:33 -0700 Created attachment 260728 Patch 1124240 2 260728 dbates 2015-09-08 08:58:04 -0700 Comment on attachment 260728 Patch Clearing flags on attachment: 260728 Committed r189488: <http://trac.webkit.org/changeset/189488> 1124241 3 dbates 2015-09-08 08:58:09 -0700 All reviewed patches have been landed. Closing bug. 260728 2015-09-06 21:06:33 -0700 2015-09-08 08:58:04 -0700 Patch bug-148920-20150906210629.patch text/plain 5416 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTUyZTliYzgzZmIyY2NkNDliMDYyMDIwMDlmMGFlZjc5 NmU4NmU2ZS4uNDU3Nzk2MjQ2YjhiMjlhNTRiNjY0MjQyNmM3YTExYTFjYTliN2MzYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE1LTA5LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBEYXNoYm9hcmQ6IFJlbW92ZSBkdXBsaWNhdGUgZ2VhciBpY29uIGRhdGEgVVJMcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4OTIwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IHdl IGR1cGxpY2F0ZSB0aGUgU1ZHIGRhdGEgVVJMIGZvciB0aGUgZ2VhciBpY29uIHVwIHRvIGl0cyBm aWxsIGNvbG9yIGluIHRoZSBDU1MgcHJvcGVydHkKKyAgICAgICAgYmFja2dyb3VuZC1pbWFnZSBh c3NvY2lhdGVkIHdpdGggZWFjaCBvZiB0aGUgdGhyZWUgZ2VhciBpY29uIHN0YXRlczogY29sbGFw c2VkICguc2V0dGluZ3MpLCBob3ZlcgorICAgICAgICAoLnNldHRpbmdzOmhvdmVyKSwgYW5kIGV4 cGFuZGVkICguc2V0dGluZ3MtdmlzaWJsZSAuc2V0dGluZ3MpLiBJbnN0ZWFkIHdlIHNob3VsZCB1 c2UgdGhlIGdlYXIgaWNvbgorICAgICAgICBhcyBhIG1hc2sgYW5kIG1ha2UgdXNlIG9mIHRoZSBD U1MgYmFja2dyb3VuZC1jb2xvciB0byBkZWZpbmUgdGhlIGZpbGwgY29sb3IgZm9yIGVhY2ggb2Yg dGhlc2UgdGhyZWUKKyAgICAgICAgc3RhdGVzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9N YWluLmNzczoKKyAgICAgICAgKC5zZXR0aW5ncyk6IFVzZSBnZWFyIGljb24gYXMgbWFzayBhbmQg ZGVmaW5lIENTUyBiYWNrZ3JvdW5kLWNvbG9yIGZvciBjb2xsYXBzZWQgc3RhdGUuIAorICAgICAg ICAoLnNldHRpbmdzOmhvdmVyKTogT3ZlcnJpZGUgQ1NTIGJhY2tncm91bmQtY29sb3IgZm9yIGhv dmVyIHN0YXRlLgorICAgICAgICAoLnNldHRpbmdzLXZpc2libGUgLnNldHRpbmdzKTogT3ZlcnJp ZGUgQ1NTIGJhY2tncm91bmQtY29sb3IgZm9yIGV4cGFuZGVkIHN0YXRlLgorCiAyMDE1LTA5LTAy ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OKHIxODg1NDgpOiBTb21lIHRlc3RzIGNyYXNoIGFmdGVyIHIxODg1NDggYmVjYXVz ZSBpbmplY3RlZCBidW5kbGUgbWVzc2FnZXMgYXJlIHJlY2VpdmVkIGFmdGVyIHRoZSB0ZXN0IGZp bmlzaGVzCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzIGIvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1N0eWxlcy9NYWluLmNzcwppbmRleCBjYjdhMWU3NzI1Zjg0ZTg2ZWY2ZWY3ZTgzMzk5 ZjRkYzRjOGViMGZkLi45NTU4MzIzZGQwZWQ2ZmVkOTFkMTE0MzI1NGI2OGY5OWJiNjlmMjIxIDEw MDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCisrKyBiL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TdHlsZXMvTWFpbi5jc3MKQEAgLTc1LDE2ICs3NSwxNyBAQCBkaXYuY2VsbEJ1dHRvbi51bmhp ZGUsIGRpdi5hY2Nlc3NpYmlsaXR5QnV0dG9uLnVuaGlkZSB7CiAgICAgbGVmdDogNXB4OwogICAg IHdpZHRoOiAzNXB4OwogICAgIGhlaWdodDogMzVweDsKLSAgICBiYWNrZ3JvdW5kLWltYWdlOiB1 cmwoJ2RhdGE6aW1hZ2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAw L3N2ZyIgdmlld0JveD0iMCAwIDI1MCAyNTAiPjxwYXRoIGZpbGw9InJnYigxNjYsIDE1OCwgMTMw KSIgZD0iTTIxMywxNDR2LTM5aC0yMS4wNTVjLTEuNDc2LTUtMy41MS0xMC4wODUtNi4wNTEtMTQu NjY4bDE0LjY3My0xNC42OTdsLTI3LjU3OC0yNy41ODlsLTE0LjUyMSwxNC42NjUgQzE1My44ODUs NjAuMTcsMTQ5LDU4LjEzLDE0NCw1Ni42NTRWMzZoLTM5djIwLjY1NGMtNSwxLjQ3Ni0xMC4xODYs My41MS0xNC43NjksNi4wNTFMNzUuNDg0LDQ4LjAzM0w0Ny44NjksNzUuNjA5bDE0LjY1MiwxNC43 MjMgQzU5Ljk4MSw5NC45MTUsNTcuOTI5LDEwMCw1Ni40NTMsMTA1SDM2djM5aDIwLjQ1M2MxLjQ3 Niw1LDMuNTExLDkuOTg1LDYuMDUxLDE0LjU2OWwtMTQuNjcyLDE0LjY0NmwyNy41NzcsMjcuNTY1 bDE0LjgyMi0xNC42NzkgYzQuNTgzLDIuNTQxLDkuNzY5LDQuNTY5LDE0Ljc2OSw2LjA0NVYyMTNo Mzl2LTIwLjg1NGM1LTEuNDc2LDkuODg1LTMuNTEsMTQuNDY4LTYuMDUxbDE0LjU5NywxNC42NzJs MjcuNTQxLTI3LjU3NmwtMTQuNjkxLTE0LjYyMyBjMi41NC00LjU4Myw0LjU1Ni05LjU2OCw2LjAz MS0xNC41NjhIMjEzeiBNMTI0LjE5OSwxNjQuOWMtMjIuMzY3LDAtNDAuNS0xOC4xMzMtNDAuNS00 MC41czE4LjEzMy00MC41LDQwLjUtNDAuNSBzNDAuNSwxOC4xMzMsNDAuNSw0MC41UzE0Ni41NjYs MTY0LjksMTI0LjE5OSwxNjQuOXoiLz48L3N2Zz4nKTsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBy Z2IoMTY2LCAxNTgsIDEzMCk7CisgICAgLXdlYmtpdC1tYXNrLWltYWdlOiB1cmwoJ2RhdGE6aW1h Z2Uvc3ZnK3htbCw8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgdmlld0Jv eD0iMCAwIDI1MCAyNTAiPjxwYXRoIGQ9Ik0yMTMsMTQ0di0zOWgtMjEuMDU1Yy0xLjQ3Ni01LTMu NTEtMTAuMDg1LTYuMDUxLTE0LjY2OGwxNC42NzMtMTQuNjk3bC0yNy41NzgtMjcuNTg5bC0xNC41 MjEsMTQuNjY1IEMxNTMuODg1LDYwLjE3LDE0OSw1OC4xMywxNDQsNTYuNjU0VjM2aC0zOXYyMC42 NTRjLTUsMS40NzYtMTAuMTg2LDMuNTEtMTQuNzY5LDYuMDUxTDc1LjQ4NCw0OC4wMzNMNDcuODY5 LDc1LjYwOWwxNC42NTIsMTQuNzIzIEM1OS45ODEsOTQuOTE1LDU3LjkyOSwxMDAsNTYuNDUzLDEw NUgzNnYzOWgyMC40NTNjMS40NzYsNSwzLjUxMSw5Ljk4NSw2LjA1MSwxNC41NjlsLTE0LjY3Miwx NC42NDZsMjcuNTc3LDI3LjU2NWwxNC44MjItMTQuNjc5IGM0LjU4MywyLjU0MSw5Ljc2OSw0LjU2 OSwxNC43NjksNi4wNDVWMjEzaDM5di0yMC44NTRjNS0xLjQ3Niw5Ljg4NS0zLjUxLDE0LjQ2OC02 LjA1MWwxNC41OTcsMTQuNjcybDI3LjU0MS0yNy41NzZsLTE0LjY5MS0xNC42MjMgYzIuNTQtNC41 ODMsNC41NTYtOS41NjgsNi4wMzEtMTQuNTY4SDIxM3ogTTEyNC4xOTksMTY0LjljLTIyLjM2Nyww LTQwLjUtMTguMTMzLTQwLjUtNDAuNXMxOC4xMzMtNDAuNSw0MC41LTQwLjUgczQwLjUsMTguMTMz LDQwLjUsNDAuNVMxNDYuNTY2LDE2NC45LDEyNC4xOTksMTY0Ljl6Ii8+PC9zdmc+Jyk7CiAgICAg Y3Vyc29yOiBwb2ludGVyOwogfQogCiAuc2V0dGluZ3M6aG92ZXIgewotICAgIGJhY2tncm91bmQt aW1hZ2U6IHVybCgnZGF0YTppbWFnZS9zdmcreG1sLDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMjUwIDI1MCI+PHBhdGggZmlsbD0icmdiKDE4NSwg MTc1LCAxMjUpIiBkPSJNMjEzLDE0NHYtMzloLTIxLjA1NWMtMS40NzYtNS0zLjUxLTEwLjA4NS02 LjA1MS0xNC42NjhsMTQuNjczLTE0LjY5N2wtMjcuNTc4LTI3LjU4OWwtMTQuNTIxLDE0LjY2NSBD MTUzLjg4NSw2MC4xNywxNDksNTguMTMsMTQ0LDU2LjY1NFYzNmgtMzl2MjAuNjU0Yy01LDEuNDc2 LTEwLjE4NiwzLjUxLTE0Ljc2OSw2LjA1MUw3NS40ODQsNDguMDMzTDQ3Ljg2OSw3NS42MDlsMTQu NjUyLDE0LjcyMyBDNTkuOTgxLDk0LjkxNSw1Ny45MjksMTAwLDU2LjQ1MywxMDVIMzZ2MzloMjAu NDUzYzEuNDc2LDUsMy41MTEsOS45ODUsNi4wNTEsMTQuNTY5bC0xNC42NzIsMTQuNjQ2bDI3LjU3 NywyNy41NjVsMTQuODIyLTE0LjY3OSBjNC41ODMsMi41NDEsOS43NjksNC41NjksMTQuNzY5LDYu MDQ1VjIxM2gzOXYtMjAuODU0YzUtMS40NzYsOS44ODUtMy41MSwxNC40NjgtNi4wNTFsMTQuNTk3 LDE0LjY3MmwyNy41NDEtMjcuNTc2bC0xNC42OTEtMTQuNjIzIGMyLjU0LTQuNTgzLDQuNTU2LTku NTY4LDYuMDMxLTE0LjU2OEgyMTN6IE0xMjQuMTk5LDE2NC45Yy0yMi4zNjcsMC00MC41LTE4LjEz My00MC41LTQwLjVzMTguMTMzLTQwLjUsNDAuNS00MC41IHM0MC41LDE4LjEzMyw0MC41LDQwLjVT MTQ2LjU2NiwxNjQuOSwxMjQuMTk5LDE2NC45eiIvPjwvc3ZnPicpOworICAgIGJhY2tncm91bmQt Y29sb3I6IHJnYigxODUsIDE3NSwgMTI1KTsKIH0KIAogLnNldHRpbmdzLXZpc2libGUgLnNldHRp bmdzIHsKLSAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoJ2RhdGE6aW1hZ2Uvc3ZnK3htbCw8c3Zn IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgdmlld0JveD0iMCAwIDI1MCAyNTAi PjxwYXRoIGZpbGw9InJnYig3NiwgMTUxLCA2MSkiIGQ9Ik0yMTMsMTQ0di0zOWgtMjEuMDU1Yy0x LjQ3Ni01LTMuNTEtMTAuMDg1LTYuMDUxLTE0LjY2OGwxNC42NzMtMTQuNjk3bC0yNy41NzgtMjcu NTg5bC0xNC41MjEsMTQuNjY1IEMxNTMuODg1LDYwLjE3LDE0OSw1OC4xMywxNDQsNTYuNjU0VjM2 aC0zOXYyMC42NTRjLTUsMS40NzYtMTAuMTg2LDMuNTEtMTQuNzY5LDYuMDUxTDc1LjQ4NCw0OC4w MzNMNDcuODY5LDc1LjYwOWwxNC42NTIsMTQuNzIzIEM1OS45ODEsOTQuOTE1LDU3LjkyOSwxMDAs NTYuNDUzLDEwNUgzNnYzOWgyMC40NTNjMS40NzYsNSwzLjUxMSw5Ljk4NSw2LjA1MSwxNC41Njls LTE0LjY3MiwxNC42NDZsMjcuNTc3LDI3LjU2NWwxNC44MjItMTQuNjc5IGM0LjU4MywyLjU0MSw5 Ljc2OSw0LjU2OSwxNC43NjksNi4wNDVWMjEzaDM5di0yMC44NTRjNS0xLjQ3Niw5Ljg4NS0zLjUx LDE0LjQ2OC02LjA1MWwxNC41OTcsMTQuNjcybDI3LjU0MS0yNy41NzZsLTE0LjY5MS0xNC42MjMg YzIuNTQtNC41ODMsNC41NTYtOS41NjgsNi4wMzEtMTQuNTY4SDIxM3ogTTEyNC4xOTksMTY0Ljlj LTIyLjM2NywwLTQwLjUtMTguMTMzLTQwLjUtNDAuNXMxOC4xMzMtNDAuNSw0MC41LTQwLjUgczQw LjUsMTguMTMzLDQwLjUsNDAuNVMxNDYuNTY2LDE2NC45LDEyNC4xOTksMTY0Ljl6Ii8+PC9zdmc+ Jyk7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiKDc2LCAxNTEsIDYxKTsKIH0KIAogYm9keSB7 Cg==