148908 2015-09-06 02:39:27 -0700 Simplify JIT::emit_op_mod() 2015-09-06 07:38:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sukolsak webkit-unassigned commit-queue ggaren msaboff saam sukolsak oldest_to_newest 1124005 0 sukolsak 2015-09-06 02:39:27 -0700 The IDIV instruction on x86 divides the value in the EDX:EAX registers by the source operand and stores the quotient in EAX and the remainder in EDX. Therefore, we store the values that we don't want to be overwritten by IDIV in registers that are not EAX or EDX. This patch makes the intention clearer and makes the code easier to read. 1124006 1 260708 sukolsak 2015-09-06 02:41:23 -0700 Created attachment 260708 Patch 1124007 2 260708 msaboff 2015-09-06 03:03:44 -0700 Comment on attachment 260708 Patch r=me 1124010 3 260708 commit-queue 2015-09-06 07:38:20 -0700 Comment on attachment 260708 Patch Clearing flags on attachment: 260708 Committed r189444: <http://trac.webkit.org/changeset/189444> 1124011 4 commit-queue 2015-09-06 07:38:23 -0700 All reviewed patches have been landed. Closing bug. 260708 2015-09-06 02:41:23 -0700 2015-09-06 07:38:20 -0700 Patch bug-148908-20150906024120.patch text/plain 2063 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh OGQ2YjViYTJiZWUyOWM3NzdmM2UwMTMyOGQ5MGZiOTVkZWE1Y2Y2Li4wZjE0ZDNkNzJhZWFmN2Zj N2Q0OTM4MDE5YTRkYjJhZDZiOGZiOTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wOS0wNiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBTaW1wbGlmeSBKSVQ6OmVtaXRfb3BfbW9kKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODkwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBJRElWIGluc3RydWN0 aW9uIG9uIHg4NiBkaXZpZGVzIHRoZSB2YWx1ZSBpbiB0aGUgRURYOkVBWCByZWdpc3RlcnMKKyAg ICAgICAgYnkgdGhlIHNvdXJjZSBvcGVyYW5kIGFuZCBzdG9yZXMgdGhlIHF1b3RpZW50IGluIEVB WCBhbmQgdGhlIHJlbWFpbmRlcgorICAgICAgICBpbiBFRFguIFRoZXJlZm9yZSwgd2Ugc3RvcmUg dGhlIHZhbHVlcyB0aGF0IHdlIGRvbid0IHdhbnQgdG8gYmUKKyAgICAgICAgb3ZlcndyaXR0ZW4g YnkgSURJViBpbiByZWdpc3RlcnMgdGhhdCBhcmUgbm90IEVBWCBvciBFRFguIFRoaXMgcGF0Y2gK KyAgICAgICAgbWFrZXMgdGhlIGludGVudGlvbiBjbGVhcmVyIGFuZCBtYWtlcyB0aGUgY29kZSBl YXNpZXIgdG8gcmVhZC4KKworICAgICAgICAqIGppdC9KSVRBcml0aG1ldGljLmNwcDoKKyAgICAg ICAgKEpTQzo6SklUOjplbWl0X29wX21vZCk6CisKIDIwMTUtMDktMDUgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBKU0RvbGxhclZNUHJvdG90eXBlIGFmdGVy IHIxODkxNjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFyaXRo bWV0aWMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcApp bmRleCA1MDY3MWUyMjYyZjlkMTQ4YzA1ZTE2NWEzYTRiY2IzYmIxOGQyOWIzLi5mMTg4OWNmYWI2 MzdlYTc0MzIzM2Q3OTJlNDcxNWNiOGU0ZGM1MmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAKQEAgLTYxMSwxOSArNjExLDExIEBAIHZvaWQgSklUOjpl bWl0X29wX21vZChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIGludCBvcDIg PSBjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5kOwogCiAgICAgLy8gTWFrZSBzdXJlIHJl Z2lzdGVycyBhcmUgY29ycmVjdCBmb3IgeDg2IElESVYgaW5zdHJ1Y3Rpb25zLgotI2lmIENQVShY ODYpCi0gICAgYXV0byBlZHggPSByZWdUMTsKLSAgICBhdXRvIGVjeCA9IHJlZ1QyOwotI2VsaWYg T1MoV0lORE9XUykKLSAgICBhdXRvIGVkeCA9IHJlZ1QxOwotICAgIGF1dG8gZWN4ID0gcmVnVDU7 Ci0jZWxzZQotICAgIGF1dG8gZWR4ID0gcmVnVDI7Ci0gICAgYXV0byBlY3ggPSByZWdUMzsKLSNl bmRpZgogICAgIEFTU0VSVChyZWdUMCA9PSBYODZSZWdpc3RlcnM6OmVheCk7Ci0gICAgQVNTRVJU KGVkeCA9PSBYODZSZWdpc3RlcnM6OmVkeCk7Ci0gICAgQVNTRVJUKGVjeCA9PSBYODZSZWdpc3Rl cnM6OmVjeCk7CisgICAgYXV0byBlZHggPSBYODZSZWdpc3RlcnM6OmVkeDsKKyAgICBhdXRvIGVj eCA9IFg4NlJlZ2lzdGVyczo6ZWN4OworICAgIEFTU0VSVChyZWdUNCAhPSBlZHgpOworICAgIEFT U0VSVChyZWdUNCAhPSBlY3gpOwogCiAgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcnMob3AxLCBy ZWdUNCwgb3AyLCBlY3gpOwogICAgIGVtaXRKdW1wU2xvd0Nhc2VJZk5vdEltbWVkaWF0ZUludGVn ZXIocmVnVDQpOwo=