148900 2015-09-05 10:04:24 -0700 Fix JSDollarVMPrototype after r189160 2015-09-06 14:02:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue darin fpizlo msaboff saam oldest_to_newest 1123947 0 mark.lam 2015-09-05 10:04:24 -0700 JSDollarVMPrototype needs to be updated to match http://trac.webkit.org/changeset/189160 i.e. remove the JSC::Function bit in its property attributes. 1123948 1 260691 mark.lam 2015-09-05 10:08:44 -0700 Created attachment 260691 the fix. 1124001 2 260691 msaboff 2015-09-05 22:44:19 -0700 Comment on attachment 260691 the fix. r=me. 1124003 3 260691 commit-queue 2015-09-05 23:30:52 -0700 Comment on attachment 260691 the fix. Clearing flags on attachment: 260691 Committed r189443: <http://trac.webkit.org/changeset/189443> 1124004 4 commit-queue 2015-09-05 23:30:56 -0700 All reviewed patches have been landed. Closing bug. 1124042 5 darin 2015-09-06 13:41:33 -0700 Why no regression test? 1124050 6 mark.lam 2015-09-06 14:02:26 -0700 (In reply to comment #5) > Why no regression test? http://trac.webkit.org/changeset/189160 makes it such that this is simply the new way (not using the JSC::Function attribute) of calling putDirectNativeFunction(). r189160 changed every other place that uses putDirectNativeFunction() but missed this one case. I'm just following up on the missed case. The original patch did not think that this change warranted a regression test, and I applied the same standard for this patch. 260691 2015-09-05 10:08:44 -0700 2015-09-05 23:30:52 -0700 the fix. bug-148900.patch text/plain 1682 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5NDMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA5LTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggSlNEb2xsYXJWTVByb3RvdHlwZSBhZnRlciByMTg5MTYwLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4OTAwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNEb2xsYXJWTVByb3RvdHlwZSBuZWVkcyB0 byBiZSB1cGRhdGVkIHRvIG1hdGNoIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE4 OTE2MCBpLmUuCisgICAgICAgIHJlbW92ZSB0aGUgdXNlIG9mIEpTQzo6RnVuY3Rpb24gYml0IGlu IGl0cyBwcm9wZXJ0eSBhdHRyaWJ1dGVzLgorCisgICAgICAgICogdG9vbHMvSlNEb2xsYXJWTVBy b3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OkpTRG9sbGFyVk1Qcm90b3R5cGU6OmZpbmlzaENy ZWF0aW9uKToKKwogMjAxNS0wOS0wNCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZ2VudHMgc2hvdWxkIHNlbmQgbWVzc2FnZXMgdGhyb3Vn aCBGcm9udGVuZFJvdXRlciBpbnN0ZWFkIG9mIEZyb250ZW5kQ2hhbm5lbApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcAko cmV2aXNpb24gMTg5NDMzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFy Vk1Qcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDIsNyArNDAyLDcgQEAgdm9pZCBK U0RvbGxhclZNUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbgogICAgIAogICAgIGFkZEZ1bmN0aW9u KHZtLCBnbG9iYWxPYmplY3QsICJjcmFzaCIsIGZ1bmN0aW9uQ3Jhc2gsIDApOwogICAgIAotICAg IHB1dERpcmVjdE5hdGl2ZUZ1bmN0aW9uKHZtLCBnbG9iYWxPYmplY3QsIElkZW50aWZpZXI6OmZy b21TdHJpbmcoJnZtLCAiZGZnVHJ1ZSIpLCAwLCBmdW5jdGlvbkRGR1RydWUsIERGR1RydWVJbnRy aW5zaWMsIERvbnRFbnVtIHwgSlNDOjpGdW5jdGlvbik7CisgICAgcHV0RGlyZWN0TmF0aXZlRnVu Y3Rpb24odm0sIGdsb2JhbE9iamVjdCwgSWRlbnRpZmllcjo6ZnJvbVN0cmluZygmdm0sICJkZmdU cnVlIiksIDAsIGZ1bmN0aW9uREZHVHJ1ZSwgREZHVHJ1ZUludHJpbnNpYywgRG9udEVudW0pOwog ICAgIAogICAgIGFkZEZ1bmN0aW9uKHZtLCBnbG9iYWxPYmplY3QsICJsbGludFRydWUiLCBmdW5j dGlvbkxMaW50VHJ1ZSwgMCk7CiAgICAgYWRkRnVuY3Rpb24odm0sIGdsb2JhbE9iamVjdCwgImpp dFRydWUiLCBmdW5jdGlvbkpJVFRydWUsIDApOwo=