148894 2015-09-05 00:42:50 -0700 [WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in same directory 2016-11-10 00:04:31 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED P2 Normal --- 1 iyzsong webkit-unassigned cgarcia hhochleitner pnormand oldest_to_newest 1123906 0 iyzsong 2015-09-05 00:42:50 -0700 otherwise, failed with: ... [ 91%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o In file included from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/build/DerivedSources/ForwardingHeaders/WebCore/GUniquePtrGStreamer.h:1:0, from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebKit2/UIProcess/PageClient.h:38, from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebKit2/UIProcess/WebPageProxy.cpp:61: /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:25:41: fatal error: gst/pbutils/install-plugins.h: No such file or directory #include <gst/pbutils/install-plugins.h> ^ compilation terminated. Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:6367: recipe for target 'Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o' failed make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o] Error 1 ... 1198519 1 pnormand 2016-06-02 06:08:10 -0700 Is this issue still valid? 1224543 2 pnormand 2016-08-30 06:04:27 -0700 Assuming this bug can be closed, no follow-up feedback from the bug reporter and the build bots have no such issue either. Please reopen if any change is really needed :) 1247738 3 hhochleitner 2016-11-03 10:19:53 -0700 This is still a problem with 2.14 see https://github.com/NixOS/nixpkgs/blob/b137b8d1aa14637db1397aaffacf0524d95803e6/pkgs/development/libraries/webkitgtk/2.14.nix#L44 for our current workaround when removing it, i got [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o In file included from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/build/DerivedSources/ForwardingHeaders/WebCore/GUniquePtrGStreamer.h:1:0, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h:30, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h:30, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:41: /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:25:41: fatal error: gst/pbutils/install-plugins.h: No such file or directory compilation terminated. make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12932: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:1534: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [Makefile:150: all] Error 2 builder for ‘/nix/store/b0i8cbyxczybnnibb93l0jv7ma6k5f09-webkitgtk-2.14.2.drv’ failed with exit code 2 1248093 4 pnormand 2016-11-04 04:03:38 -0700 Thanks, this should be easy to fix. Please test the patch I'm about to upload here. 1248094 5 293877 pnormand 2016-11-04 04:05:54 -0700 Created attachment 293877 patch 1248095 6 293878 pnormand 2016-11-04 04:07:13 -0700 Created attachment 293878 patch 1248096 7 hhochleitner 2016-11-04 04:16:37 -0700 Thanks, I'm running a build with patch 293878 (sans ChangeLog update, which doesn't apply against 2.14.2) Will report back, when it finishes ... 1248120 8 hhochleitner 2016-11-04 07:49:32 -0700 Build of 2.14.2 + patch finished successfully. Thanks! 1248695 9 293878 cgarcia 2016-11-06 23:34:47 -0800 Comment on attachment 293878 patch View in context: https://bugs.webkit.org/attachment.cgi?id=293878&action=review I'm confused. I have no idea what pbutils is, but the bug title refers to GSTREAMER_BASE_INCLUDE_DIRS and WebKit2_INCLUDE_DIRECTORIES and the patch includes GSTREAMER_PBUTILS_INCLUDE_DIRS in WebKit2_SYSTEM_INCLUDE_DIRECTORIES > Source/WebKit2/ChangeLog:9 > + * PlatformGTK.cmake: The GStreamer pbutils include directory was > + missing in the header search path. Could you explain here what is broken? do we fail to build with any build config? 1249708 10 pnormand 2016-11-10 00:04:31 -0800 Committed r208528: <http://trac.webkit.org/changeset/208528> 293877 2016-11-04 04:05:54 -0700 2016-11-04 04:06:25 -0700 patch patch.patch text/plain 1442 pnormand RnJvbSBiNTkzYzI5ZjU3NzUwNDgyMWQyZDU2ZDMwNTg1ZWM1YTBjY2ZjNjI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDQgTm92IDIwMTYgMTI6MDE6MzAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw YXRjaAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICB8IDEwICsrKysrKysr KysKIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIHwgIDEgKwogMiBmaWxlcyBjaGFu Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDA3NjIyNzQuLjViZWEzOGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0xMS0wNCAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXUdTVFJFQU1FUl9CQVNFX0lO Q0xVREVfRElSUyBzaG91bGQgYmUgYWRkZWQgdG8gV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVT LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4ODk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0 Zm9ybUdUSy5jbWFrZTogVGhlIEdTdHJlYW1lciBwYnV0aWxzIGluY2x1ZGUgZGlyZWN0b3J5IHdh cworICAgICAgICBtaXNzaW5nIGluIHRoZSBoZWFkZXIgc2VhcmNoIHBhdGguCisKIDIwMTYtMTEt MDMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgR2l2 ZSBhbGwgdGhlIGdlb21ldHJ5IGNsYXNzZXMgYSBzaW5nbGUtYXJndW1lbnQgc2NhbGUoKSBmdW5j dGlvbiBmb3IgY29uc2lzdGVuY3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt R1RLLmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNzU5NTlh My4uMWI5YjViYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UK KysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTg4Nyw2ICs4ODcsNyBA QCBsaXN0KEFQUEVORCBXZWJLaXQyX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtF TkNIQU5UX0lOQ0xVREVfRElSU30KICAgICAke0dFT0NMVUVfSU5DTFVERV9ESVJTfQogICAgICR7 R1NUUkVBTUVSX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9BUFBfSU5DTFVERV9ESVJT fQogICAgICR7SEFSRkJVWlpfSU5DTFVERV9ESVJTfQogICAgICR7TElCU09VUF9JTkNMVURFX0RJ UlN9CiApCi0tIAoyLjEwLjE= 293878 2016-11-04 04:07:13 -0700 2016-11-06 23:34:47 -0800 patch patch.patch text/plain 1446 pnormand RnJvbSA1OTI1ZjAxYTAzMGY4YTM1NDE4MTVjNmEzY2E3MmQxYzlhNzI5NmQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDQgTm92IDIwMTYgMTI6MDE6MzAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw YXRjaAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICB8IDEwICsrKysrKysr KysKIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIHwgIDEgKwogMiBmaWxlcyBjaGFu Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDA3NjIyNzQuLjViZWEzOGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0xMS0wNCAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXUdTVFJFQU1FUl9CQVNFX0lO Q0xVREVfRElSUyBzaG91bGQgYmUgYWRkZWQgdG8gV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVT LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4ODk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0 Zm9ybUdUSy5jbWFrZTogVGhlIEdTdHJlYW1lciBwYnV0aWxzIGluY2x1ZGUgZGlyZWN0b3J5IHdh cworICAgICAgICBtaXNzaW5nIGluIHRoZSBoZWFkZXIgc2VhcmNoIHBhdGguCisKIDIwMTYtMTEt MDMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgR2l2 ZSBhbGwgdGhlIGdlb21ldHJ5IGNsYXNzZXMgYSBzaW5nbGUtYXJndW1lbnQgc2NhbGUoKSBmdW5j dGlvbiBmb3IgY29uc2lzdGVuY3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt R1RLLmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNzU5NTlh My4uMTM3YzFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UK KysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTg4Nyw2ICs4ODcsNyBA QCBsaXN0KEFQUEVORCBXZWJLaXQyX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtF TkNIQU5UX0lOQ0xVREVfRElSU30KICAgICAke0dFT0NMVUVfSU5DTFVERV9ESVJTfQogICAgICR7 R1NUUkVBTUVSX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9QQlVUSUxTX0lOQ0xVREVf RElSU30KICAgICAke0hBUkZCVVpaX0lOQ0xVREVfRElSU30KICAgICAke0xJQlNPVVBfSU5DTFVE RV9ESVJTfQogKQotLSAKMi4xMC4x