148855 2015-09-04 17:04:00 -0700 Script element with an empty for or event attributes should not execute 2015-10-19 11:32:30 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 150335 1 rniwa cdumez cdumez commit-queue esprehn+autocc ggaren kangil.han rniwa webkit-bug-importer oldest_to_newest 1123746 0 rniwa 2015-09-04 17:04:00 -0700 See https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script When a script element has "for" or "event" attributes, we should not execute the script as a result of step 12. This bug was found by the newly added test: LayoutTests/http/tests/w3c/html/semantics/scripting-1/the-script-element/script-for-event.html 1123747 1 webkit-bug-importer 2015-09-04 17:05:45 -0700 <rdar://problem/22588156> 1134082 2 263342 cdumez 2015-10-16 15:32:29 -0700 Created attachment 263342 Patch 1134373 3 263342 darin 2015-10-18 15:54:43 -0700 Comment on attachment 263342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263342&action=review > Source/WebCore/dom/ScriptElement.cpp:372 > forAttribute = forAttribute.stripWhiteSpace(); Looks like this uses the wrong stripping function; should be stripLeadingAndTrailingHTMLSpaces. 1134407 4 263342 commit-queue 2015-10-18 16:44:33 -0700 Comment on attachment 263342 Patch Clearing flags on attachment: 263342 Committed r191270: <http://trac.webkit.org/changeset/191270> 1134408 5 commit-queue 2015-10-18 16:44:38 -0700 All reviewed patches have been landed. Closing bug. 263342 2015-10-16 15:32:29 -0700 2015-10-18 16:44:33 -0700 Patch bug-148855-20151016153153.patch text/plain 3744 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY3OTc5Zjk3MmQ3MmQ0 YzMxNmUwMWNkZWExODY3NDczZWNjMDcyZS4uMjlkMTY5NjdkYWUxN2JlMjc1NWIzYTUyODBhZjU2 Y2YyOTYxZTdjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTEwLTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2NyaXB0IGVsZW1lbnQgd2l0 aCBhbiBlbXB0eSBmb3Igb3IgZXZlbnQgYXR0cmlidXRlcyBzaG91bGQgbm90IGV4ZWN1dGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODg1NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjI1ODgxNTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQSBzY3JpcHQgZWxlbWVudCB3aXRoIGFuIGVtcHR5IGZv ciBvciBldmVudCBhdHRyaWJ1dGVzIHNob3VsZCBub3QgZXhlY3V0ZQorICAgICAgICBhcyBwZXI6 CisgICAgICAgIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL3NjcmlwdGlu Zy5odG1sI3ByZXBhcmUtYS1zY3JpcHQgKHN0ZXAgMTIpCisKKyAgICAgICAgT3VyIGltcGxlbWVu dGF0aW9uIGhhZCBhIGJ1ZyB3aGVyZSBpdCB3b3VsZCBub3QgY29ycmVjdGx5IGRpZmZlcmVudGlh dGUKKyAgICAgICAgYW4gZW1wdHkgYXR0cmlidXRlIGZyb20gYSBtaXNzaW5nIG9uZS4gVGhpcyBw YXRjaCBmaXhlcyB0aGlzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVk IGJ5IGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBkb20vU2NyaXB0RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHRFbGVtZW50Ojppc1NjcmlwdEZvckV2ZW50U3VwcG9ydGVk KToKKwogMjAxNS0xMC0xNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBIaWRlIGFsbCBwbHVnaW4gbmFtZXMgZXhjZXB0IEZsYXNoLCBKYXZhLCBhbmQgUXVp Y2tUaW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAKaW5kZXggZWI3OTc0ZTc0ODkz YjA0NWZmOWRlNjc3N2Q1ZGY3MzY1YzJhZDQ1Zi4uMGQ1MGM5ZWY1MzcwZGQ3Y2Q5ZTYzZDdkMjMx NmUzZmZmMTQ3YjczNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcApAQCAtMzY4 LDcgKzM2OCw3IEBAIGJvb2wgU2NyaXB0RWxlbWVudDo6aXNTY3JpcHRGb3JFdmVudFN1cHBvcnRl ZCgpIGNvbnN0CiB7CiAgICAgU3RyaW5nIGV2ZW50QXR0cmlidXRlID0gZXZlbnRBdHRyaWJ1dGVW YWx1ZSgpOwogICAgIFN0cmluZyBmb3JBdHRyaWJ1dGUgPSBmb3JBdHRyaWJ1dGVWYWx1ZSgpOwot ICAgIGlmICghZXZlbnRBdHRyaWJ1dGUuaXNFbXB0eSgpICYmICFmb3JBdHRyaWJ1dGUuaXNFbXB0 eSgpKSB7CisgICAgaWYgKCFldmVudEF0dHJpYnV0ZS5pc051bGwoKSAmJiAhZm9yQXR0cmlidXRl LmlzTnVsbCgpKSB7CiAgICAgICAgIGZvckF0dHJpYnV0ZSA9IGZvckF0dHJpYnV0ZS5zdHJpcFdo aXRlU3BhY2UoKTsKICAgICAgICAgaWYgKCFlcXVhbElnbm9yaW5nQ2FzZShmb3JBdHRyaWJ1dGUs ICJ3aW5kb3ciKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nCmluZGV4IDg2ZDBiNTRmNTY2MTAwZmRlMTg1Yzg5OGZmZmM5MDc0MGQ4ZTE4NDku LmU3ZDE0Yzg2OWFhNmIyNGYyMjBhNGE5N2E1OTAwMjYzNjQ4MDEyZWQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEwLTE2ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2NyaXB0IGVsZW1lbnQgd2l0aCBhbiBl bXB0eSBmb3Igb3IgZXZlbnQgYXR0cmlidXRlcyBzaG91bGQgbm90IGV4ZWN1dGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODg1NQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjI1ODgxNTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBleGlzdGluZyBXM0MgSFRNTCB0ZXN0IG5vdyB0 aGF0IG1vcmUgY2hlY2tzIGFyZSBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQt Zm9yLWV2ZW50LWV4cGVjdGVkLnR4dDoKKwogMjAxNS0xMC0xNiAgWW91ZW5uIEZhYmxldCAgPHlv dWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFVwZGF0ZSB0ZXN0aGFybmVzcy5q cyB0byB3ZWItcGxhdGZvcm0tdGVzdHMgdmVyc2lvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmct MS90aGUtc2NyaXB0LWVsZW1lbnQvc2NyaXB0LWZvci1ldmVudC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3Nj cmlwdGluZy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQtZm9yLWV2ZW50LWV4cGVjdGVkLnR4 dAppbmRleCBjZTY3MzIxOWY1MWM2YzQ4ZmYzZmZiMWU2MTIyYjllZWJhYzY4ODc3Li42OTQ0Zjcz NTNjNjlkY2RhZDllNmNiN2JiNGYxZGRlNTEyOWVkYzRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGlu Zy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQtZm9yLWV2ZW50LWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50 aWNzL3NjcmlwdGluZy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQtZm9yLWV2ZW50LWV4cGVj dGVkLnR4dApAQCAtNSw5ICs1LDkgQEAgUEFTUyBTY3JpcHQgMQogUEFTUyBTY3JpcHQgMiAKIFBB U1MgU2NyaXB0IDMgCiBQQVNTIFNjcmlwdCA0IAotRkFJTCBTY3JpcHQgNSBhc3NlcnRfZXF1YWxz OiBzY3JpcHQgZm9yPSIiIGV2ZW50PSJvbmxvYWQiIGV4cGVjdGVkIGZhbHNlIGJ1dCBnb3QgdHJ1 ZQotRkFJTCBTY3JpcHQgNiBhc3NlcnRfZXF1YWxzOiBzY3JpcHQgZm9yPSJ3aW5kb3ciIGV2ZW50 PSIiIGV4cGVjdGVkIGZhbHNlIGJ1dCBnb3QgdHJ1ZQotRkFJTCBTY3JpcHQgNyBhc3NlcnRfZXF1 YWxzOiBzY3JpcHQgZm9yPSIiIGV2ZW50PSIiIGV4cGVjdGVkIGZhbHNlIGJ1dCBnb3QgdHJ1ZQor UEFTUyBTY3JpcHQgNSAKK1BBU1MgU2NyaXB0IDYgCitQQVNTIFNjcmlwdCA3IAogUEFTUyBTY3Jp cHQgOCAKIFBBU1MgU2NyaXB0IDkgCiBQQVNTIFNjcmlwdCAxMCAK