148852 2015-09-04 16:52:37 -0700 script.text should behave like script.textContent on setting 2016-08-27 10:47:05 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa kling cdumez commit-queue esprehn+autocc gyuyoung.kim kling webkit-bug-importer oldest_to_newest 1123741 0 rniwa 2015-09-04 16:52:37 -0700 See https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text The setter implementation of HTMLScriptElement.prototype.text should be identical to that of textContent but it isn't. This bug was found by the newly added test: LayoutTests/http/tests/w3c/html/semantics/scripting-1/the-script-element/script-text.html 1223910 1 287204 kling 2016-08-27 09:21:00 -0700 Created attachment 287204 Patch 1223911 2 webkit-bug-importer 2016-08-27 09:21:39 -0700 <rdar://problem/28044640> 1223913 3 287204 cdumez 2016-08-27 09:57:29 -0700 Comment on attachment 287204 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287204&action=review r=me with comment. > Source/WebCore/html/HTMLScriptElement.cpp:85 > + setTextContent(value, IGNORE_EXCEPTION); I believe this cannot actually throw. If this is the case, then we should use ASSERT_NOT_EXCEPTION, not IGNORE_EXCEPTION. If it can actually throw, then we should use [SetterRaisesException] on the text attribute and relay the exception to the caller. 1223914 4 287204 kling 2016-08-27 10:02:15 -0700 Comment on attachment 287204 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287204&action=review >> Source/WebCore/html/HTMLScriptElement.cpp:85 >> + setTextContent(value, IGNORE_EXCEPTION); > > I believe this cannot actually throw. If this is the case, then we should use ASSERT_NOT_EXCEPTION, not IGNORE_EXCEPTION. If it can actually throw, then we should use [SetterRaisesException] on the text attribute and relay the exception to the caller. Hmm. You are probably right about this. I suspect the same is also true for HTMLAnchorElement.text and HTMLTitleElement.text 1223915 5 287205 kling 2016-08-27 10:16:00 -0700 Created attachment 287205 Patch for landing 1223918 6 287205 commit-queue 2016-08-27 10:47:00 -0700 Comment on attachment 287205 Patch for landing Clearing flags on attachment: 287205 Committed r205079: <http://trac.webkit.org/changeset/205079> 1223919 7 commit-queue 2016-08-27 10:47:05 -0700 All reviewed patches have been landed. Closing bug. 287204 2016-08-27 09:21:00 -0700 2016-08-27 10:16:00 -0700 Patch bug-148852.diff text/plain 3337 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGRlZDhhZmQuLjI4YzE1NDAgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTA4LTI2ICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBzY3JpcHQudGV4dCBz aG91bGQgYmVoYXZlIGxpa2Ugc2NyaXB0LnRleHRDb250ZW50IG9uIHNldHRpbmcKKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0ODg1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGlj cy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1lbnQvc2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0 OgorCisyMDE2LTA4LTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAg ICAgICBUaGUgOmVuYWJsZWQvOmRpc2FibGVkIHNlbGVjdG9ycyBzaG91bGQgb25seSBtYXRjaCBl bGVtZW50cyB0aGF0IGNhbiBiZSBkaXNhYmxlZC4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzE2MTI1NT4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1l bnQvc2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVs ZW1lbnQvc2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0CmluZGV4IDVhODJlOGMuLjY4YjlmMDUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRt bC9zZW1hbnRpY3Mvc2NyaXB0aW5nLTEvdGhlLXNjcmlwdC1lbGVtZW50L3NjcmlwdC10ZXh0LWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQt dGV4dC1leHBlY3RlZC50eHQKQEAgLTEsOCArMSw4IEBACiAKIFBBU1MgR2V0dGVyIAogUEFTUyBT ZXR0ZXIgKG5vbi1lbXB0eSBzdHJpbmcpIAotRkFJTCBTZXR0ZXIgKGVtcHR5IHN0cmluZykgYXNz ZXJ0X2VxdWFsczogZXhwZWN0ZWQgbnVsbCBidXQgZ290IFRleHQgbm9kZSAiIgorUEFTUyBTZXR0 ZXIgKGVtcHR5IHN0cmluZykgCiBQQVNTIFNldHRlciAobnVsbCkgCiBQQVNTIFNldHRlciAodW5k ZWZpbmVkKSAKLUZBSUwgU2V0dGVyICh0ZXh0IG5vZGUgcmV1c2UpIGFzc2VydF9ub3RfZXF1YWxz OiBnb3QgZGlzYWxsb3dlZCB2YWx1ZSBUZXh0IG5vZGUgInR3byIKK1BBU1MgU2V0dGVyICh0ZXh0 IG5vZGUgcmV1c2UpIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzIyZWVmNC4uZWQzMjk1NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA4LTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFw cGxlLmNvbT4KIAorICAgICAgICBzY3JpcHQudGV4dCBzaG91bGQgYmVoYXZlIGxpa2Ugc2NyaXB0 LnRleHRDb250ZW50IG9uIHNldHRpbmcKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0 ODg1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBI VE1MU2NyaXB0RWxlbWVudC50ZXh0IHNob3VsZCBiZWhhdmUganVzdCBsaWtlIC50ZXh0Q29udGVu dCB3aGVuIHNldHRpbmcsCisgICAgICAgIHNvIGp1c3QgZm9yd2FyZCBzZXRUZXh0KCkgdG8gc2V0 VGV4dENvbnRlbnQoKS4KKworICAgICAgICBUZXN0OiBpbXBvcnQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1lbnQvc2NyaXB0 LXRleHQuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MU2NyaXB0RWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MU2NyaXB0RWxlbWVudDo6c2V0VGV4dCk6CisKKzIwMTYtMDgtMjYg IEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFRoZSA6ZW5hYmxl ZC86ZGlzYWJsZWQgc2VsZWN0b3JzIHNob3VsZCBvbmx5IG1hdGNoIGVsZW1lbnRzIHRoYXQgY2Fu IGJlIGRpc2FibGVkLgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTYxMjU1PgogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTY3JpcHRFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCmluZGV4IGJlMzhlOGUuLjA1 OGU4MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCkBAIC03 OSwxOSArNzksMTAgQEAgdm9pZCBIVE1MU2NyaXB0RWxlbWVudDo6ZmluaXNoZWRJbnNlcnRpbmdT dWJ0cmVlKCkKICAgICBTY3JpcHRFbGVtZW50OjpmaW5pc2hlZEluc2VydGluZ1N1YnRyZWUoKTsK IH0KIAorLy8gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2Uvc2NyaXB0aW5n Lmh0bWwjZG9tLXNjcmlwdC10ZXh0CiB2b2lkIEhUTUxTY3JpcHRFbGVtZW50OjpzZXRUZXh0KGNv bnN0IFN0cmluZyYgdmFsdWUpCiB7Ci0gICAgUmVmPEhUTUxTY3JpcHRFbGVtZW50PiBwcm90ZWN0 ZWRUaGlzKCp0aGlzKTsKLQotICAgIGlmIChoYXNPbmVDaGlsZCgpICYmIGlzPFRleHQ+KCpmaXJz dENoaWxkKCkpKSB7Ci0gICAgICAgIGRvd25jYXN0PFRleHQ+KCpmaXJzdENoaWxkKCkpLnNldERh dGEodmFsdWUpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgaWYgKGhhc0NoaWxkTm9k ZXMoKSkKLSAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsKLQotICAgIGFwcGVuZENoaWxkKGRvY3Vt ZW50KCkuY3JlYXRlVGV4dE5vZGUodmFsdWUpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBzZXRU ZXh0Q29udGVudCh2YWx1ZSwgSUdOT1JFX0VYQ0VQVElPTik7CiB9CiAKIHZvaWQgSFRNTFNjcmlw dEVsZW1lbnQ6OnNldEFzeW5jKGJvb2wgYXN5bmMpCg== 287205 2016-08-27 10:16:00 -0700 2016-08-27 10:47:00 -0700 Patch for landing land-148852.diff text/plain 3334 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGRlZDhhZmQuLjc4NWMyMmIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTA4LTI2ICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBzY3JpcHQudGV4dCBz aG91bGQgYmVoYXZlIGxpa2Ugc2NyaXB0LnRleHRDb250ZW50IG9uIHNldHRpbmcKKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0ODg1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJp cyBEdW1lei4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9z Y3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1lbnQvc2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0Ogor CisyMDE2LTA4LTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAg ICBUaGUgOmVuYWJsZWQvOmRpc2FibGVkIHNlbGVjdG9ycyBzaG91bGQgb25seSBtYXRjaCBlbGVt ZW50cyB0aGF0IGNhbiBiZSBkaXNhYmxlZC4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzE2MTI1NT4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1lbnQv c2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1l bnQvc2NyaXB0LXRleHQtZXhwZWN0ZWQudHh0CmluZGV4IDVhODJlOGMuLjY4YjlmMDUgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3Mvc2NyaXB0aW5nLTEvdGhlLXNjcmlwdC1lbGVtZW50L3NjcmlwdC10ZXh0LWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL3NjcmlwdGluZy0xL3RoZS1zY3JpcHQtZWxlbWVudC9zY3JpcHQtdGV4 dC1leHBlY3RlZC50eHQKQEAgLTEsOCArMSw4IEBACiAKIFBBU1MgR2V0dGVyIAogUEFTUyBTZXR0 ZXIgKG5vbi1lbXB0eSBzdHJpbmcpIAotRkFJTCBTZXR0ZXIgKGVtcHR5IHN0cmluZykgYXNzZXJ0 X2VxdWFsczogZXhwZWN0ZWQgbnVsbCBidXQgZ290IFRleHQgbm9kZSAiIgorUEFTUyBTZXR0ZXIg KGVtcHR5IHN0cmluZykgCiBQQVNTIFNldHRlciAobnVsbCkgCiBQQVNTIFNldHRlciAodW5kZWZp bmVkKSAKLUZBSUwgU2V0dGVyICh0ZXh0IG5vZGUgcmV1c2UpIGFzc2VydF9ub3RfZXF1YWxzOiBn b3QgZGlzYWxsb3dlZCB2YWx1ZSBUZXh0IG5vZGUgInR3byIKK1BBU1MgU2V0dGVyICh0ZXh0IG5v ZGUgcmV1c2UpIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzIyZWVmNC4uMDI0YTVhNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDIwIEBACiAyMDE2LTA4LTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAorICAgICAgICBzY3JpcHQudGV4dCBzaG91bGQgYmVoYXZlIGxpa2Ugc2NyaXB0LnRl eHRDb250ZW50IG9uIHNldHRpbmcKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0ODg1 Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICBIVE1MU2Ny aXB0RWxlbWVudC50ZXh0IHNob3VsZCBiZWhhdmUganVzdCBsaWtlIC50ZXh0Q29udGVudCB3aGVu IHNldHRpbmcsCisgICAgICAgIHNvIGp1c3QgZm9yd2FyZCBzZXRUZXh0KCkgdG8gc2V0VGV4dENv bnRlbnQoKS4KKworICAgICAgICBUZXN0OiBpbXBvcnQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9o dG1sL3NlbWFudGljcy9zY3JpcHRpbmctMS90aGUtc2NyaXB0LWVsZW1lbnQvc2NyaXB0LXRleHQu aHRtbAorCisgICAgICAgICogaHRtbC9IVE1MU2NyaXB0RWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MU2NyaXB0RWxlbWVudDo6c2V0VGV4dCk6CisKKzIwMTYtMDgtMjYgIEFuZHJl YXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFRoZSA6ZW5hYmxlZC86ZGlz YWJsZWQgc2VsZWN0b3JzIHNob3VsZCBvbmx5IG1hdGNoIGVsZW1lbnRzIHRoYXQgY2FuIGJlIGRp c2FibGVkLgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTYxMjU1PgogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTY3JpcHRFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCmluZGV4IGJlMzhlOGUuLjczNzc3YjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNjcmlwdEVsZW1lbnQuY3BwCkBAIC03OSwxOSAr NzksMTAgQEAgdm9pZCBIVE1MU2NyaXB0RWxlbWVudDo6ZmluaXNoZWRJbnNlcnRpbmdTdWJ0cmVl KCkKICAgICBTY3JpcHRFbGVtZW50OjpmaW5pc2hlZEluc2VydGluZ1N1YnRyZWUoKTsKIH0KIAor Ly8gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2Uvc2NyaXB0aW5nLmh0bWwj ZG9tLXNjcmlwdC10ZXh0CiB2b2lkIEhUTUxTY3JpcHRFbGVtZW50OjpzZXRUZXh0KGNvbnN0IFN0 cmluZyYgdmFsdWUpCiB7Ci0gICAgUmVmPEhUTUxTY3JpcHRFbGVtZW50PiBwcm90ZWN0ZWRUaGlz KCp0aGlzKTsKLQotICAgIGlmIChoYXNPbmVDaGlsZCgpICYmIGlzPFRleHQ+KCpmaXJzdENoaWxk KCkpKSB7Ci0gICAgICAgIGRvd25jYXN0PFRleHQ+KCpmaXJzdENoaWxkKCkpLnNldERhdGEodmFs dWUpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgaWYgKGhhc0NoaWxkTm9kZXMoKSkK LSAgICAgICAgcmVtb3ZlQ2hpbGRyZW4oKTsKLQotICAgIGFwcGVuZENoaWxkKGRvY3VtZW50KCku Y3JlYXRlVGV4dE5vZGUodmFsdWUpLCBJR05PUkVfRVhDRVBUSU9OKTsKKyAgICBzZXRUZXh0Q29u dGVudCh2YWx1ZSwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiB9CiAKIHZvaWQgSFRNTFNjcmlwdEVs ZW1lbnQ6OnNldEFzeW5jKGJvb2wgYXN5bmMpCg==