148848 2015-09-04 16:34:59 -0700 Add a layout test for https://bugs.webkit.org/show_bug.cgi?id=148845 2015-09-29 10:14:48 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 sabouhallawa sabouhallawa dino webkit-bug-importer zimmermann oldest_to_newest 1123726 0 sabouhallawa 2015-09-04 16:34:59 -0700 Add the test case attached to https://bugs.webkit.org/show_bug.cgi?id=148845 as LayoutTests/svg/as-image/svg-cached-no-intrinsic-size-draw-canvas.html. Add this test to LayoutTests/TestExpectations and mark it [ Failure ]. 1123779 1 260662 sabouhallawa 2015-09-04 17:41:46 -0700 Created attachment 260662 Patch 1125212 2 260662 darin 2015-09-11 10:27:03 -0700 Comment on attachment 260662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260662&action=review > LayoutTests/ChangeLog:8 > + Add the layout test and mark it as failed in TestExpectations. Why? That’s not usually how we do these things. 1128946 3 sabouhallawa 2015-09-27 16:56:21 -0700 (In reply to comment #2) > Comment on attachment 260662 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260662&action=review > > > LayoutTests/ChangeLog:8 > > + Add the layout test and mark it as failed in TestExpectations. > > Why? That’s not usually how we do these things. My purpose of this patch was to submit the test case even if I do not have the fix ready. For me usually writing the test usually takes more time than fixing the code. But I agree I should not do thing differently. So I am closing this bug as WONTFIX. Fixing the other bug https://bugs.webkit.org/show_bug.cgi?id=148845 should include both the fix and the test case. 260662 2015-09-04 17:41:46 -0700 2015-09-11 10:27:03 -0700 Patch bug-148848-20150904174144.patch text/plain 4001 sabouhallawa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4OTM5OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTA0ICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgbGF5b3V0IHRlc3Qg Zm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg4NDUgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg4NDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIGxheW91 dCB0ZXN0IGFuZCBtYXJrIGl0IGFzIGZhaWxlZCBpbiBUZXN0RXhwZWN0YXRpb25zLgorCisgICAg ICAgICogVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBzdmcvYXMtaW1hZ2Uvc3ZnLWNhY2hl ZC1uby1pbnRyaW5zaWMtc2l6ZS1kcmF3LWNhbnZhcy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBzdmcvYXMtaW1hZ2Uvc3ZnLWNhY2hlZC1uby1pbnRyaW5zaWMtc2l6ZS1kcmF3LWNh bnZhcy5odG1sOiBBZGRlZC4KKwogMjAxNS0wOS0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkZCBidWcgbnVtYmVyIGZvciBodHRwL3Rl c3RzL3czYy9odG1sL3NlbWFudGljcy90ZXh0LWxldmVsLXNlbWFudGljcy90aGUtd2JyLWVsZW1l bnQvd2JyLWVsZW1lbnQuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxODkz NjkpCisrKyBMYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC02 NDMsMyArNjQzLDUgQEAgd2Via2l0Lm9yZy9iLzE0ODgwNSBpbXBvcnRlZC93M2MvY3NzL2Nzcwog d2Via2l0Lm9yZy9iLzE0ODgwNSBpbXBvcnRlZC93M2MvY3NzL2Nzcy1tdWx0aWNvbC0xL211bHRp Y29sLWZpbGwtYXV0by54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4 MDUgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wtMS9tdWx0aWNvbC16ZXJvLWhlaWdodC0w MDEueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQ4ODA1IGltcG9ydGVk L3czYy9jc3MvY3NzLW11bHRpY29sLTEvbXVsdGljb2wtc3Bhbi1hbGwtY2hpbGQtMDAxLnhodCBb IEltYWdlT25seUZhaWx1cmUgXQorCit3ZWJraXQub3JnL2IvMTQ4ODQ1IHN2Zy9hcy1pbWFnZS9z dmctY2FjaGVkLW5vLWludHJpbnNpYy1zaXplLWRyYXctY2FudmFzLmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9hcy1pbWFnZS9zdmctY2FjaGVkLW5vLWlu dHJpbnNpYy1zaXplLWRyYXctY2FudmFzLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvc3ZnL2FzLWltYWdlL3N2Zy1jYWNoZWQtbm8taW50cmluc2ljLXNpemUtZHJhdy1j YW52YXMtZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N2Zy9hcy1p bWFnZS9zdmctY2FjaGVkLW5vLWludHJpbnNpYy1zaXplLWRyYXctY2FudmFzLWV4cGVjdGVkLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorICA8c3R5bGU+CisgICAgZGl2IHsKKyAgICAgIHdpZHRoOiAxMDBweDsKKyAg ICAgIGhlaWdodDogMTAwcHg7CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKyAgICAg IGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICB9CisgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9k eT4KKyAgPGRpdj48L2Rpdj4KKyAgPGRpdj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6 IExheW91dFRlc3RzL3N2Zy9hcy1pbWFnZS9zdmctY2FjaGVkLW5vLWludHJpbnNpYy1zaXplLWRy YXctY2FudmFzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2FzLWltYWdlL3N2 Zy1jYWNoZWQtbm8taW50cmluc2ljLXNpemUtZHJhdy1jYW52YXMuaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3N2Zy9hcy1pbWFnZS9zdmctY2FjaGVkLW5vLWludHJpbnNpYy1zaXpl LWRyYXctY2FudmFzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1OCBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGU+CisgICAgaW1nLCBjYW52YXMgewor ICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICB9CisgIDwvc3R5 bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgPGltZz4KKyAgPGNhbnZhcz48L2NhbnZhcz4KKyAgPHNj cmlwdD4KKyAgICB3aW5kb3cuVGVzdCA9IHsKKyAgICAgIF9pbWFnZSA6IG51bGwsCisgICAgICBf aW1hZ2VVcmwgOiAKKyAgICAgICAgImRhdGE6aW1hZ2Uvc3ZnK3htbDt1dGY4LCBcCisgICAgICAg IDxzdmcgdmVyc2lvbj0nMS4xJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHZp ZXdCb3g9JzAgMCAxMDAwIDEwMDAnPiBcCisgICAgICAgICAgPHJlY3Qgd2lkdGg9JzEwMCUnIGhl aWdodD0nMTAwJScgZmlsbD0nZ3JlZW4nLz4gXAorICAgICAgICA8L3N2Zz4iLAorICAgICAgX2lt YWdlTG9hZGVkIDogZmFsc2UsCisgICAgICAKKyAgICAgIF9sb2FkSW1hZ2UgOiBmdW5jdGlvbigp IHsKKyAgICAgICAgdGhpcy5faW1hZ2UgPSBuZXcgSW1hZ2UoKTsKKyAgICAgIAorICAgICAgICB2 YXIgc2VsZiA9IHRoaXM7CisgICAgICAgIHRoaXMuX2ltYWdlLm9ubG9hZCA9IGZ1bmN0aW9uKCkg eworICAgICAgICAgIHNlbGYuX2ltYWdlTG9hZGVkID0gdHJ1ZTsKKyAgICAgICAgfTsKKyAgICAg ICAgdGhpcy5faW1hZ2Uuc3JjID0gdGhpcy5faW1hZ2VVcmw7CisgICAgICB9LAorICAgIAorICAg ICAgX3JlcmVuZGVyQ2FudmFzIDogZnVuY3Rpb24oKSB7CisgICAgICAgIGlmKCF0aGlzLl9pbWFn ZUxvYWRlZCkKKyAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3Vt ZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJjYW52YXMiKVswXTsKKyAgICAgICAgdmFyIGN0eCA9 IGNhbnZhcy5nZXRDb250ZXh0KCIyZCIpOworICAgICAgICBjdHguZHJhd0ltYWdlKHRoaXMuX2lt YWdlLCAwLCAwLCBjYW52YXMud2lkdGgsIGNhbnZhcy5oZWlnaHQpOworICAgICAgICBjbGVhcklu dGVydmFsKHRoaXMuX2ludGVydmFsSWQpOworICAgICAgICAKKyAgICAgICAgaWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgfSwK KyAgICAKKyAgICAgIHJ1biA6IGZ1bmN0aW9uKCkgeworICAgICAgICBpZiAod2luZG93LnRlc3RS dW5uZXIpCisgICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIHRo aXMuX2xvYWRJbWFnZSgpOworICAgICAgICB0aGlzLl9pbnRlcnZhbElkID0gc2V0SW50ZXJ2YWwo dGhpcy5fcmVyZW5kZXJDYW52YXMuYmluZCh0aGlzKSwgMjAwKTsKKyAgICAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoImltZyIpWzBdLnNyYyA9IHRoaXMuX2ltYWdlVXJsOworICAg ICAgfQorICAgIH07CisgICAgd2luZG93LlRlc3QucnVuKCk7CisgIDwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgo=