148844 2015-09-04 16:23:09 -0700 Import a Chromium <input type=color> test 2015-09-04 22:32:51 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=119094 P2 Normal --- 1 jhoneycutt jhoneycutt aestes dbates wenson_hsieh oldest_to_newest 1123708 0 jhoneycutt 2015-09-04 16:23:09 -0700 Import a Chromium <input type=color> test that tests that no crash occurs when changing the color with the picker open. 1123711 1 260644 jhoneycutt 2015-09-04 16:24:10 -0700 Created attachment 260644 Patch 1123773 2 jhoneycutt 2015-09-04 17:34:13 -0700 Committed r189408: <http://trac.webkit.org/changeset/189408> 1123873 3 ap 2015-09-04 22:32:51 -0700 This test asserts in WebKit1. Will skip for now, but this is really the wrong way to not implement a feature - we should not assert on legitimate code paths. #if ENABLE(INPUT_TYPE_COLOR) std::unique_ptr<ColorChooser> WebChromeClient::createColorChooser(ColorChooserClient* client, const Color& initialColor) { // FIXME: Implement <input type='color'> for WK1 (Bug 119094). ASSERT_NOT_REACHED(); return nullptr; } #endif 260644 2015-09-04 16:24:10 -0700 2015-09-04 16:47:31 -0700 Patch bug-148844-20150904162408.patch text/plain 1922 jhoneycutt U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzJkYWMwN2VlZjE0ZTc5ZTNkMzAz MThjNjMwMTA4MzNmZjIwOTEzNi4uMDVjZGUzMmY4ZjBmNWU2MDI1ZWYyMTdjM2FkOWYwMGY4Njdl Y2M1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTA0ICBKb24gSG9uZXljdXR0ICA8 amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wb3J0IGEgQ2hyb21pdW0gPGlucHV0 IHR5cGU9Y29sb3I+IHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDg4NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGZhc3QvZm9ybXMvY29sb3IvY29sb3Itc3VnZ2VzdGlvbi1waWNrZXItY3Jh c2gtb24tc2V0LXZhbHVlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jt cy9jb2xvci9jb2xvci1zdWdnZXN0aW9uLXBpY2tlci1jcmFzaC1vbi1zZXQtdmFsdWUuaHRtbDog QWRkZWQuCisKIDIwMTUtMDktMDEgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgdGhlIHByZXZpb3VzIGNvbW1pdCBoYWQgaW5jb3JyZWN0IGV4cGVj dGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvY29sb3IvY29sb3It c3VnZ2VzdGlvbi1waWNrZXItY3Jhc2gtb24tc2V0LXZhbHVlLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvY29sb3IvY29sb3Itc3VnZ2VzdGlvbi1waWNrZXItY3Jhc2gtb24t c2V0LXZhbHVlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kM2Q0ZGVkOTYxNDhhM2ZmYmEzMDlm YTMwM2ZmYjZjMDFmY2YwNDVlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9jb2xvci9jb2xvci1zdWdnZXN0aW9uLXBpY2tlci1jcmFzaC1vbi1zZXQtdmFsdWUtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IENSQVNI LiBjcmJ1Zy5jb20vNDU0NzQ4IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9j b2xvci9jb2xvci1zdWdnZXN0aW9uLXBpY2tlci1jcmFzaC1vbi1zZXQtdmFsdWUuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvY29sb3IvY29sb3Itc3VnZ2VzdGlvbi1waWNrZXItY3Jhc2gt b24tc2V0LXZhbHVlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uM2YxMmViZDA0YjBiYWJjYjc0YWMzZjU4MGNk MGM0YmY0OTQyZTk5MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv Y29sb3IvY29sb3Itc3VnZ2VzdGlvbi1waWNrZXItY3Jhc2gtb24tc2V0LXZhbHVlLmh0bWwKQEAg LTAsMCArMSwxMyBAQAorPCFET0NUWVBFIGh0bWw+CisKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMg bm90IENSQVNILiBjcmJ1Zy5jb20vNDU0NzQ4Cis8aW5wdXQgaWQ9ImNvbG9yIiBsaXN0PSJzaW5n bGUiIHR5cGU9ImNvbG9yIi8+CisKKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cit2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnY29sb3InKTsKK2lucHV0LmZvY3VzKCk7CitldmVudFNlbmRlci5rZXlEb3duKCcg Jyk7CitpbnB1dC52YWx1ZSA9ICcjNDQ0NDQ0JzsKKzwvc2NyaXB0Pgo=