148841 2015-09-04 16:13:48 -0700 sectionRowIndex must return -1 when its parent is not a table, tbody, thead, or tfoot 2015-09-29 21:31:48 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex InRadar P2 Normal --- 1 rniwa cdumez cdumez commit-queue esprehn+autocc gyuyoung.kim webkit-bug-importer oldest_to_newest 1123696 0 rniwa 2015-09-04 16:13:48 -0700 See https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex When tr element's parent is not one of table, tbody, thead, or tfoot, sectionRowIndex must return -1. This bug was found by the newly imported test: LayoutTests/http/tests/w3c/html/semantics/tabular-data/the-tr-element/sectionRowIndex.html 1123698 1 webkit-bug-importer 2015-09-04 16:14:32 -0700 <rdar://problem/22586870> 1129483 2 262135 cdumez 2015-09-29 20:18:31 -0700 Created attachment 262135 Patch 1129485 3 262135 rniwa 2015-09-29 20:22:01 -0700 Comment on attachment 262135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262135&action=review > Source/WebCore/html/HTMLTableRowElement.cpp:88 > + RefPtr<HTMLCollection> rows; It's horrible that we have to create a HTML collection here :( 1129487 4 262135 cdumez 2015-09-29 20:24:14 -0700 Comment on attachment 262135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262135&action=review >> Source/WebCore/html/HTMLTableRowElement.cpp:88 >> + RefPtr<HTMLCollection> rows; > > It's horrible that we have to create a HTML collection here :( If we see this being hot then we can optimize. But the new implementation is at least correct. 1129494 5 262135 commit-queue 2015-09-29 21:31:43 -0700 Comment on attachment 262135 Patch Clearing flags on attachment: 262135 Committed r190337: <http://trac.webkit.org/changeset/190337> 1129495 6 commit-queue 2015-09-29 21:31:48 -0700 All reviewed patches have been landed. Closing bug. 262135 2015-09-29 20:18:31 -0700 2015-09-29 21:31:43 -0700 Patch bug-148841-20150929201808.patch text/plain 4621 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRmOTZmMzU0MGE2ZWI5 MGYyM2M0ODFkYTE3NjgzMWNmODJkNTM3YS4uMDNhMzAwYWNhYzgyYWRmNzE0ZDdhZWMwMWVhODVl MDBmYzg2MmJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA5LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgc2VjdGlvblJvd0luZGV4IG11 c3QgcmV0dXJuIC0xIHdoZW4gaXRzIHBhcmVudCBpcyBub3QgYSB0YWJsZSwgdGJvZHksIHRoZWFk LCBvciB0Zm9vdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ4ODQxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjU4Njg3MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgSFRNTFRhYmxlUm93 RWxlbWVudC5zZWN0aW9uUm93SW5kZXggdG8gbWF0Y2ggdGhlIHNwZWNpZmljYXRpb246CisgICAg ICAgIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL3RhYmxlcy5odG1sI2Rv bS10ci1zZWN0aW9ucm93aW5kZXgKKworICAgICAgICBJbiBwYXJ0aWN1bGFyLCBpdCBub3cgcmV0 dXJucyAtMSBpZiB0aGUgcGFyZW50IGlzIG5vdCBhIHRhYmxlLCB0Ym9keSwKKyAgICAgICAgdGhl YWQgYW5kIHRmb290LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBodG1sL0hUTUxUYWJsZVJvd0VsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRhYmxlUm93RWxlbWVudDo6c2VjdGlvblJvd0luZGV4 KToKKwogMjAxNS0wOS0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgRm9sbG93dXAgdG8gIk1vdmUgV2ViS2l0MiBBc3luY1Rhc2sgdG8gV2ViQ29yZSBDcm9z c1RocmVhZFRhc2suIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFibGVS b3dFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlUm93RWxlbWVudC5j cHAKaW5kZXggNTk3N2NiNDZlODRiY2M4MWM1ZmFhMWE2M2VlNGVmMzEyNjg4Y2I3Ni4uOTAzMGM1 MjkzNmY5NWM1ZmU5MmU5YTgzYzFhOTk2Njc0OTg3MzllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MVGFibGVSb3dFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxUYWJsZVJvd0VsZW1lbnQuY3BwCkBAIC04MSwxNiArODEsMjUgQEAgaW50IEhUTUxU YWJsZVJvd0VsZW1lbnQ6OnJvd0luZGV4KCkgY29uc3QKIAogaW50IEhUTUxUYWJsZVJvd0VsZW1l bnQ6OnNlY3Rpb25Sb3dJbmRleCgpIGNvbnN0CiB7Ci0gICAgaW50IHJJbmRleCA9IDA7Ci0gICAg Y29uc3QgTm9kZSAqbiA9IHRoaXM7Ci0gICAgZG8gewotICAgICAgICBuID0gbi0+cHJldmlvdXNT aWJsaW5nKCk7Ci0gICAgICAgIGlmIChuICYmIG4tPmhhc1RhZ05hbWUodHJUYWcpKQotICAgICAg ICAgICAgckluZGV4Kys7CisgICAgYXV0byogcGFyZW50ID0gcGFyZW50Tm9kZSgpOworICAgIGlm ICghcGFyZW50KQorICAgICAgICByZXR1cm4gLTE7CisKKyAgICBSZWZQdHI8SFRNTENvbGxlY3Rp b24+IHJvd3M7CisgICAgaWYgKGlzPEhUTUxUYWJsZVNlY3Rpb25FbGVtZW50PigqcGFyZW50KSkK KyAgICAgICAgcm93cyA9IGRvd25jYXN0PEhUTUxUYWJsZVNlY3Rpb25FbGVtZW50PigqcGFyZW50 KS5yb3dzKCk7CisgICAgZWxzZSBpZiAoaXM8SFRNTFRhYmxlRWxlbWVudD4oKnBhcmVudCkpCisg ICAgICAgIHJvd3MgPSBkb3duY2FzdDxIVE1MVGFibGVFbGVtZW50PigqcGFyZW50KS5yb3dzKCk7 CisgICAgZWxzZQorICAgICAgICByZXR1cm4gLTE7CisKKyAgICB1bnNpZ25lZCBsZW5ndGggPSBy b3dzLT5sZW5ndGgoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kp IHsKKyAgICAgICAgaWYgKHJvd3MtPml0ZW0oaSkgPT0gdGhpcykKKyAgICAgICAgICAgIHJldHVy biBpOwogICAgIH0KLSAgICB3aGlsZSAobik7CiAKLSAgICByZXR1cm4gckluZGV4OworICAgIHJl dHVybiAtMTsKIH0KIAogUmVmUHRyPEhUTUxUYWJsZUNlbGxFbGVtZW50PiBIVE1MVGFibGVSb3dF bGVtZW50OjppbnNlcnRDZWxsKGludCBpbmRleCwgRXhjZXB0aW9uQ29kZSYgZWMpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA0YTNjM2YyYjhlYjQ2ZmIwZjAwODIxYWZjZThkZGE5 NDNiODUzOWE5Li4zMDRjNWRkZDlhNDg2OTUxODRjZDFiMzBiMmJlY2UyZWQyZDM1ZDVmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wOS0yOSAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIHNlY3Rpb25Sb3dJbmRl eCBtdXN0IHJldHVybiAtMSB3aGVuIGl0cyBwYXJlbnQgaXMgbm90IGEgdGFibGUsIHRib2R5LCB0 aGVhZCwgb3IgdGZvb3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0ODg0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjI1ODY4NzA+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXM0Mg SFRNTCB0ZXN0IG5vdyB0aGF0IG1vcmUgY2hlY2tzIGFyZSBwYXNzaW5nLgorCisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3RhYnVsYXItZGF0YS90aGUtdHItZWxl bWVudC9zZWN0aW9uUm93SW5kZXgtZXhwZWN0ZWQudHh0OgorCiAyMDE1LTA5LTI4ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRHJvcCBzdXBwb3J0IGZvciBsZWdh Y3kgRXZlbnRFeGNlcHRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvdGFidWxhci1kYXRhL3RoZS10ci1lbGVt ZW50L3NlY3Rpb25Sb3dJbmRleC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL3RhYnVsYXItZGF0YS90aGUtdHIt ZWxlbWVudC9zZWN0aW9uUm93SW5kZXgtZXhwZWN0ZWQudHh0CmluZGV4IDYyN2NjZmM0NzEzMjUz OWZiZWY3MjYzMmVmOTcyYTRiMGE5MzhlY2QuLjhmYTJkZDUwYzJkMWQ4YTNkN2I5NGM1YTU0NTE2 Y2RmMzY2YWEyN2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvdGFidWxhci1kYXRhL3RoZS10ci1lbGVtZW50L3Nl Y3Rpb25Sb3dJbmRleC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy90YWJ1bGFyLWRhdGEvdGhlLXRyLWVs ZW1lbnQvc2VjdGlvblJvd0luZGV4LWV4cGVjdGVkLnR4dApAQCAtOCwxMiArOCwxMiBAQCBQQVNT IFJvdyBpbiB0aGVhZCBpbiBuZXN0ZWQgdGFibGUgaW4gSFRNTAogUEFTUyBSb3cgaW4gaW1wbGlj aXQgdGJvZHkgaW4gbmVzdGVkIHRhYmxlIGluIEhUTUwgCiBQQVNTIFJvdyBpbiBleHBsaWNpdCB0 Ym9keSBpbiBuZXN0ZWQgdGFibGUgaW4gSFRNTCAKIFBBU1MgUm93IGluIHNjcmlwdC1jcmVhdGVk IHRhYmxlIAotRkFJTCBSb3cgaW4gc2NyaXB0LWNyZWF0ZWQgZGl2IGluIHRhYmxlIGFzc2VydF9l cXVhbHM6IGV4cGVjdGVkIC0xIGJ1dCBnb3QgMAorUEFTUyBSb3cgaW4gc2NyaXB0LWNyZWF0ZWQg ZGl2IGluIHRhYmxlIAogUEFTUyBSb3cgaW4gc2NyaXB0LWNyZWF0ZWQgdGhlYWQgaW4gdGFibGUg CiBQQVNTIFJvdyBpbiBzY3JpcHQtY3JlYXRlZCB0Ym9keSBpbiB0YWJsZSAKIFBBU1MgUm93IGlu IHNjcmlwdC1jcmVhdGVkIHRmb290IGluIHRhYmxlIAotRkFJTCBSb3cgaW4gc2NyaXB0LWNyZWF0 ZWQgdHIgaW4gdGJvZHkgaW4gdGFibGUgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgLTEgYnV0IGdv dCAwCi1GQUlMIFJvdyBpbiBzY3JpcHQtY3JlYXRlZCB0ZCBpbiB0ciBpbiB0Ym9keSBpbiB0YWJs ZSBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAtMSBidXQgZ290IDAKK1BBU1MgUm93IGluIHNjcmlw dC1jcmVhdGVkIHRyIGluIHRib2R5IGluIHRhYmxlIAorUEFTUyBSb3cgaW4gc2NyaXB0LWNyZWF0 ZWQgdGQgaW4gdHIgaW4gdGJvZHkgaW4gdGFibGUgCiBQQVNTIFJvdyBpbiBzY3JpcHQtY3JlYXRl ZCBuZXN0ZWQgdGFibGUgCiBQQVNTIFJvdyBpbiBzY3JpcHQtY3JlYXRlZCB0aGVhZCBpbiBuZXN0 ZWQgdGFibGUgCiBQQVNTIFJvdyBpbiBzY3JpcHQtY3JlYXRlZCB0Ym9keSBpbiBuZXN0ZWQgdGFi bGUgCg==