14882 2007-08-04 09:58:17 -0700 REGRESSION (r24866): text/plain documents are always downloaded 2007-11-21 03:33:48 -0800 1 1 1 Unclassified WebKit Page Loading 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Major --- 1 ddkilzer webkit-unassigned beidson james mrowe oldest_to_newest 2958 0 ddkilzer 2007-08-04 09:58:17 -0700 * SUMMARY Clicking on a link that returns a text/plain document is always downloaded. There is no way to view it in the browser. * STEPS TO REPRODUCE 1. Launch Safari/WebKit. 2. Click on a text/plain link. * EXPECTED RESULTS The text/plain document should be viewed within the browser. * ACTUAL RESULTS The text/plain document is always downloaded. * REGRESSION This is a regression from shipping Safari 2.0.4 (419.3) with original WebKit, as well as the Safari 3 Public Beta v. 3.0.3 (522.12.1). * NOTES Probably regressed in r24866, the fix for Bug 14824. 2959 1 15839 ddkilzer 2007-08-04 10:00:45 -0700 Created attachment 15839 Test case 2960 2 ddkilzer 2007-08-04 10:01:11 -0700 <rdar://problem/5386550> 2964 3 ddkilzer 2007-08-04 11:07:09 -0700 (In reply to comment #0) > * NOTES > Probably regressed in r24866, the fix for Bug 14824. Confirmed. 2966 4 ddkilzer 2007-08-04 12:05:51 -0700 I have a patch for this. 2967 5 15842 ddkilzer 2007-08-04 12:28:02 -0700 Created attachment 15842 Patch v1 Proposed fix. 2972 6 ddkilzer 2007-08-04 19:14:01 -0700 Fixed in r24869. Thanks for the review olliej! 2974 7 beidson 2007-08-04 22:12:02 -0700 This rebroke http://bugs.webkit.org/show_bug.cgi?id=14824 Granted, I did screw up the original fix, but this isn't the right fix - I'll explore the reasons why in http://bugs.webkit.org/show_bug.cgi?id=14824 61904 8 james 2007-11-21 03:15:23 -0800 This is still broken in Safari 3.0.4 (5523.10) in certain cases . Here are the response headers for a file that still gets downloaded (Note: document served with HTTP Basic authentication) HTTP/1.1 200 OK Wed, 21 Nov 2007 11:08:50 GMT Apache/1.3.31 (Unix) PHP/4.4.3 PHP/4.4.3 gzip Accept-Encoding close chunked text/plain;charset=utf-8 61907 9 james 2007-11-21 03:21:45 -0800 Possibly related to http://bugs.webkit.org/show_bug.cgi?id=15771 61908 10 ddkilzer 2007-11-21 03:25:00 -0800 (In reply to comment #8) > This is still broken in Safari 3.0.4 (5523.10) in certain cases . Here are the > response headers for a file that still gets downloaded (Note: document served > with HTTP Basic authentication) > > HTTP/1.1 200 OK > Wed, 21 Nov 2007 11:08:50 GMT > Apache/1.3.31 (Unix) PHP/4.4.3 > PHP/4.4.3 > gzip > Accept-Encoding > close > chunked > text/plain;charset=utf-8 Hi James, please open a new bug report for this issue. Also, please include the header names with the field values above, and please state whether you're using Tiger or Leopard. Thanks! 61912 11 james 2007-11-21 03:33:48 -0800 http://bugs.webkit.org/show_bug.cgi?id=16084 15839 2007-08-04 10:00:45 -0700 2007-08-04 10:37:15 -0700 Test case bug-14882-test.txt text/plain 50 ddkilzer UEFTUzogWW91IHNob3VsZCBzZWUgdGhpcyBtZXNzYWdlIGluIHRoZSBicm93c2VyLgo= 15842 2007-08-04 12:28:02 -0700 2007-08-04 17:20:52 -0700 Patch v1 bug-14882-v1.diff text/plain 4091 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDg2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDctMDgtMDQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBmaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODgyCisg ICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzODY1NTA+IFJFR1JFU1NJT04gKHIyNDg2Nik6IHRl eHQvcGxhaW4gZG9jdW1lbnRzIGFyZSBhbHdheXMgZG93bmxvYWRlZAorCisgICAgICAgIFRoZSBz dXBwb3J0ZWROb25JbWFnZU1pbWVUeXBlcyBsaXN0IGlzIHVzZWQgdG8gZGV0ZXJtaW5lIHdoaWNo IE1JTUUgdHlwZXMgbWF5IGJlIHZpZXdlZAorICAgICAgICB3aXRoaW4gdGhlIHdlYiBicm93c2Vy IChlLmcuLCBwbHVnLWlucyBhZGQgdGhlaXIgb3duIE1JTUUgdHlwZXMgdG8gdGhlIGxpc3QgZHVy aW5nCisgICAgICAgIGluaXRpYWxpemF0aW9uKSwgc28gd2UgbXVzdCBhZGQgInRleHQvcGxhaW4i IGFuZCAidGV4dC8iIGJhY2sgdG8gdGhlIGxpc3QuICBTaW5jZQorICAgICAgICB0aGlzIGNoYW5n ZSB3b3VsZCB0aGVuIGJyZWFrIERPTUltcGxlbWVudGF0aW9uOjppc1RleHRNSU1FVHlwZSgpLCB0 aGF0IG1ldGhvZCB3YXMgcmV2ZXJ0ZWQKKyAgICAgICAgdG8gaXRzIG9yaWdpbmFsIGZvcm0gYW5k IE1JTUVUeXBlUmVnaXN0cnk6OnNob3VsZFRyZWF0QXNUZXh0KCkgd2FzIHJlbW92ZWQuCisKKyAg ICAgICAgKiBkb20vRE9NSW1wbGVtZW50YXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9N SW1wbGVtZW50YXRpb246OmlzVGV4dE1JTUVUeXBlKTogUmV2ZXJ0IHRvIHByZXZpb3VzIHZlcnNp b24uCisgICAgICAgICogcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppbml0aWFsaXNlU3VwcG9ydGVkTm9uSW1hZ2VNaW1lVHlwZXMpOiBBZGRlZCBiYWNr ICJ0ZXh0L3BsYWluIiBhbmQgInRleHQvIiB0byB0aGUgbGlzdC4KKyAgICAgICAgKFdlYkNvcmU6 Ok1JTUVUeXBlUmVnaXN0cnk6OnNob3VsZFRyZWF0QXNUZXh0KTogUmVtb3ZlZC4KKyAgICAgICAg KiBwbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5Lmg6CisKIDIwMDctMDgtMDMgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlcgpJbmRl eDogV2ViQ29yZS9kb20vRE9NSW1wbGVtZW50YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvZG9tL0RPTUltcGxlbWVudGF0aW9uLmNwcAkocmV2aXNpb24gMjQ4NjgpCisrKyBXZWJDb3Jl L2RvbS9ET01JbXBsZW1lbnRhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDYg QEAKICNpbmNsdWRlICJJbWFnZS5oIgogI2luY2x1ZGUgIkltYWdlRG9jdW1lbnQuaCIKICNpbmNs dWRlICJNZWRpYUxpc3QuaCIKLSNpbmNsdWRlICJNSU1FVHlwZVJlZ2lzdHJ5LmgiCiAjaW5jbHVk ZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsdWdpbkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiUGx1Z0lu SW5mb1N0b3JlLmgiCkBAIC0zMzAsNyArMzI5LDEyIEBAIGJvb2wgRE9NSW1wbGVtZW50YXRpb246 OmlzWE1MTUlNRVR5cGUoY28KIAogYm9vbCBET01JbXBsZW1lbnRhdGlvbjo6aXNUZXh0TUlNRVR5 cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIHsKLSAgICByZXR1cm4gTUlNRVR5cGVSZWdpc3Ry eTo6c2hvdWxkVHJlYXRBc1RleHQobWltZVR5cGUpOworICAgIGlmIChtaW1lVHlwZSA9PSAiYXBw bGljYXRpb24veC1qYXZhc2NyaXB0IiB8fAorICAgICAgICAobWltZVR5cGUuc3RhcnRzV2l0aCgi dGV4dC8iKSAmJiBtaW1lVHlwZSAhPSAidGV4dC9odG1sIiAmJgorICAgICAgICAgbWltZVR5cGUg IT0gInRleHQveG1sIiAmJiBtaW1lVHlwZSAhPSAidGV4dC94c2wiKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CisgICAgCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBQYXNzUmVmUHRyPEhUTUxEb2N1 bWVudD4gRE9NSW1wbGVtZW50YXRpb246OmNyZWF0ZUhUTUxEb2N1bWVudChjb25zdCBTdHJpbmcm IHRpdGxlKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCShyZXZpc2lv biAyNDg2OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTExMiw2ICsxMTIsOCBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXNlU3VwcG9y dGVkTm9uSW1hZ2VNCiAgICAgICAidGV4dC9odG1sIiwKICAgICAgICJ0ZXh0L3htbCIsCiAgICAg ICAidGV4dC94c2wiLAorICAgICAgInRleHQvcGxhaW4iLAorICAgICAgInRleHQvIiwKICAgICAg ICJhcHBsaWNhdGlvbi94LWphdmFzY3JpcHQiLAogICAgICAgImFwcGxpY2F0aW9uL3htbCIsCiAg ICAgICAiYXBwbGljYXRpb24veGh0bWwreG1sIiwKQEAgLTE4NCwxMSArMTg2LDYgQEAgYm9vbCBN SU1FVHlwZVJlZ2lzdHJ5Ojppc0phdmFBcHBsZXRNSU1FVAogICAgICAgICB8fCBtaW1lVHlwZS5z dGFydHNXaXRoKCJhcHBsaWNhdGlvbi94LWphdmEtdm0iLCBmYWxzZSk7CiB9CiAKLWJvb2wgTUlN RVR5cGVSZWdpc3RyeTo6c2hvdWxkVHJlYXRBc1RleHQoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkK LXsKLSAgICByZXR1cm4gbWltZVR5cGUgPT0gImFwcGxpY2F0aW9uL3gtamF2YXNjcmlwdCIgfHwg KG1pbWVUeXBlLnN0YXJ0c1dpdGgoInRleHQvIikgJiYgIWlzU3VwcG9ydGVkTm9uSW1hZ2VNSU1F VHlwZShtaW1lVHlwZSkpOwotfQotCiBIYXNoU2V0PFN0cmluZz4gJk1JTUVUeXBlUmVnaXN0cnk6 OmdldFN1cHBvcnRlZEltYWdlTUlNRVR5cGVzKCkKIHsKICAgICBpZiAoIXN1cHBvcnRlZEltYWdl TUlNRVR5cGVzKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgJKHJldmlzaW9u IDI0ODY4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgJKHdvcmtpbmcg Y29weSkKQEAgLTU1LDExICs1NSw2IEBAIHB1YmxpYzoKICAgICAvLyBDaGVjayB0byBzZWUgaWYg YSBtaW1lIHR5cGUgaXMgYSB2YWxpZCBKYXZhIGFwcGxldCBtaW1lIHR5cGUKICAgICBzdGF0aWMg Ym9vbCBpc0phdmFBcHBsZXRNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKTsKICAgICAK LSAgICAvLyBDaGVjayB0byBzZWUgaWYgYSBtaW1lIHR5cGUgc2hvdWxkIGJlIHRyZWF0ZWQgYXMg dGV4dAotICAgIC8vIGFwcGxpY2F0aW9uL2phdmFzY3JpcHQgaXMgb25lIHRoYXQgc2hvdWxkIGJl IGV2ZW4gdGhvdWdoIGl0IGRvZXNuJ3Qgc3RhcnQgd2l0aCB0ZXh0LwotICAgIC8vIHRleHQvaHRt bCBpcyBvbmUgdGhhdCAqc2hvdWxkbid0KiBiZSBieSBkZWZhdWx0IGV2ZW4gdGhvdWdoIGl0ICpk b2VzKiBzdGFydCB3aXRoIHRleHQvCi0gICAgc3RhdGljIGJvb2wgc2hvdWxkVHJlYXRBc1RleHQo Y29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7Ci0KICAgICBzdGF0aWMgSGFzaFNldDxTdHJpbmc+JiBn ZXRTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlcygpOwogICAgIHN0YXRpYyBIYXNoU2V0PFN0cmluZz4m IGdldFN1cHBvcnRlZEltYWdlUmVzb3VyY2VNSU1FVHlwZXMoKTsKICAgICBzdGF0aWMgSGFzaFNl dDxTdHJpbmc+JiBnZXRTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlcygpOwo=