148815 2015-09-04 13:01:34 -0700 column-rule-style: outset/inset doesn't work 2016-01-06 17:36:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 148813 1 rniwa zalan bdakin commit-queue esprehn+autocc glenn hyatt kondapallykalyan mcatanzaro webkit-bug-importer zalan oldest_to_newest 1123565 0 rniwa 2015-09-04 13:01:34 -0700 column-rule-style: outset/inset doesn't seem to work according to the newly imported tests: imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht 1123566 1 webkit-bug-importer 2015-09-04 13:02:35 -0700 <rdar://problem/22582644> 1126418 2 zalan 2015-09-16 11:44:00 -0700 Outset seems to be painted properly. However the reference test seems somewhat odd with display: table and border collapsing on. (which produces the double stripes). I am not sure what the intention was with this reference setup. 1126420 3 zalan 2015-09-16 11:47:50 -0700 (In reply to comment #2) > Outset seems to be painted properly. However the reference test seems > somewhat odd with display: table and border collapsing on. (which produces > the double stripes). > I am not sure what the intention was with this reference setup. Oh, it's because of this: "'border-style' values of column-rule are interpreted as in the collapsing border model in which case 'inset' value is drawn the same as 'ridge'. " 1126481 4 261331 zalan 2015-09-16 15:13:49 -0700 Created attachment 261331 Patch 1126483 5 zalan 2015-09-16 15:14:04 -0700 *** Bug 148811 has been marked as a duplicate of this bug. *** 1126705 6 261331 hyatt 2015-09-17 08:56:02 -0700 Comment on attachment 261331 Patch r=me 1126718 7 261331 commit-queue 2015-09-17 10:03:42 -0700 Comment on attachment 261331 Patch Clearing flags on attachment: 261331 Committed r189916: <http://trac.webkit.org/changeset/189916> 1126719 8 commit-queue 2015-09-17 10:03:48 -0700 All reviewed patches have been landed. Closing bug. 1153300 9 mcatanzaro 2016-01-06 17:36:09 -0800 These tests: imported/w3c/css/css-multicol-1/multicol-rule-inset-000.xht [ ImageOnlyFailure ] imported/w3c/css/css-multicol-1/multicol-rule-outset-000.xht [ ImageOnlyFailure ] Are still failing on the GTK port, see bug #152823. 261331 2015-09-16 15:13:49 -0700 2015-09-17 10:03:42 -0700 Patch bug-148815-20150916151337.patch text/plain 5771 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkwY2Y0NWNjNGUyZTdh ZDczOWFkYzkxM2Y3NjE2MTgwYzEzMWM1NS4uMTg1NmRiMWQzOTAyOWI4ODc0Yzk0MDVkYmZlZTM1 MjEwN2NjMzhmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA5LTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgY29sdW1uLXJ1bGUtc3R5bGU6 IG91dHNldC9pbnNldCBkb2Vzbid0IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0ODgxNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjI1ODI2 NDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1tdWx0aWNvbC0xLyNjcnMKKyAgICAgICAgVGhlIDzi gJhib3JkZXItc3R5bGXigJk+IHZhbHVlcyBhcmUgaW50ZXJwcmV0ZWQgYXMgaW4gdGhlIGNvbGxh cHNpbmcgYm9yZGVyIG1vZGVsLgorCisgICAgICAgIFVuc2tpcHBlZCA0IG11bHRpY29sdW1uIHRl c3RzLCAKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJNdWx0aUNvbHVtblNldDo6cGFpbnRDb2x1bW5SdWxlcyk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpjb2xsYXBzZWRCb3JkZXJTdHlsZSk6IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5n L3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAgICAgIChXZWJDb3JlOjpjb2xsYXBzZWRCb3JkZXJT dHlsZSk6CisKIDIwMTUtMDktMTUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgog CiAgICAgICAgIE1vdmUgbW9zdCBJREIgb2JqZWN0IGVuY29kaW5nL2RlY29kaW5nIGZyb20gV2Vi S2l0MiB0byBXZWJDb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck11bHRpQ29sdW1uU2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJN dWx0aUNvbHVtblNldC5jcHAKaW5kZXggNDBkY2IyZTQyYzNiMjMyYWIxZGJlNTllOGE4YmMyMzcx ZWY3NmFkMC4uYzdkYTEyZjk0YzFjODQ5ODNlMTQwZWU2MjcyZmE3M2RjNDJmZjNiNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uU2V0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5TZXQuY3BwCkBA IC01NzcsNyArNTc3LDcgQEAgdm9pZCBSZW5kZXJNdWx0aUNvbHVtblNldDo6cGFpbnRDb2x1bW5S dWxlcyhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG8KICAgICBjb25zdCBSZW5k ZXJTdHlsZSYgYmxvY2tTdHlsZSA9IHBhcmVudCgpLT5zdHlsZSgpOwogICAgIGNvbnN0IENvbG9y JiBydWxlQ29sb3IgPSBibG9ja1N0eWxlLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0 eUNvbHVtblJ1bGVDb2xvcik7CiAgICAgYm9vbCBydWxlVHJhbnNwYXJlbnQgPSBibG9ja1N0eWxl LmNvbHVtblJ1bGVJc1RyYW5zcGFyZW50KCk7Ci0gICAgRUJvcmRlclN0eWxlIHJ1bGVTdHlsZSA9 IGJsb2NrU3R5bGUuY29sdW1uUnVsZVN0eWxlKCk7CisgICAgRUJvcmRlclN0eWxlIHJ1bGVTdHls ZSA9IGNvbGxhcHNlZEJvcmRlclN0eWxlKGJsb2NrU3R5bGUuY29sdW1uUnVsZVN0eWxlKCkpOwog ICAgIExheW91dFVuaXQgcnVsZVRoaWNrbmVzcyA9IGJsb2NrU3R5bGUuY29sdW1uUnVsZVdpZHRo KCk7CiAgICAgTGF5b3V0VW5pdCBjb2xHYXAgPSBjb2x1bW5HYXAoKTsKICAgICBib29sIHJlbmRl clJ1bGUgPSBydWxlU3R5bGUgPiBCSElEREVOICYmICFydWxlVHJhbnNwYXJlbnQ7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCmluZGV4IDExNWZmYzc5NzQ4 NmI3OWE5ZmNjNDhjOGI3YzA4NjljNmM3Y2Q4ZjguLmYyODY2MGY1NmY2NDhlYTI3NDgzNGFjOGFh NjQ4OWY5ODBlZDUxYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZUNlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZUNlbGwuY3BwCkBAIC0xMDkwLDE1ICsxMDkwLDYgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnBh aW50KFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQK ICAgICBSZW5kZXJCbG9ja0Zsb3c6OnBhaW50KHBhaW50SW5mbywgcGFpbnRPZmZzZXQpOwogfQog Ci1zdGF0aWMgRUJvcmRlclN0eWxlIGNvbGxhcHNlZEJvcmRlclN0eWxlKEVCb3JkZXJTdHlsZSBz dHlsZSkKLXsKLSAgICBpZiAoc3R5bGUgPT0gT1VUU0VUKQotICAgICAgICByZXR1cm4gR1JPT1ZF OwotICAgIGlmIChzdHlsZSA9PSBJTlNFVCkKLSAgICAgICAgcmV0dXJuIFJJREdFOwotICAgIHJl dHVybiBzdHlsZTsKLX0KLQogc3RydWN0IENvbGxhcHNlZEJvcmRlciB7CiAgICAgQ29sbGFwc2Vk Qm9yZGVyVmFsdWUgYm9yZGVyVmFsdWU7CiAgICAgQm94U2lkZSBzaWRlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAppbmRleCAzNjNjZjU5MWFjMGYwYzU0 ZjdjMGQ5NTUwNTkxMDY5NjZmM2MyYTJhLi42YTFiZDFjZmZmNDlhY2Y1ZmJmZGU4OTcwMTIwOTFk NjIyMWM2NGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5 bGUuaApAQCAtMjIyNyw2ICsyMjI3LDE1IEBAIGlubGluZSBMYXlvdXRVbml0IGFkanVzdExheW91 dFVuaXRGb3JBYnNvbHV0ZVpvb20oTGF5b3V0VW5pdCB2YWx1ZSwgY29uc3QgUmVuZGVyCiAgICAg cmV0dXJuIHZhbHVlIC8gc3R5bGUuZWZmZWN0aXZlWm9vbSgpOwogfQogCitpbmxpbmUgRUJvcmRl clN0eWxlIGNvbGxhcHNlZEJvcmRlclN0eWxlKEVCb3JkZXJTdHlsZSBzdHlsZSkKK3sKKyAgICBp ZiAoc3R5bGUgPT0gT1VUU0VUKQorICAgICAgICByZXR1cm4gR1JPT1ZFOworICAgIGlmIChzdHls ZSA9PSBJTlNFVCkKKyAgICAgICAgcmV0dXJuIFJJREdFOworICAgIHJldHVybiBzdHlsZTsKK30K KwogaW5saW5lIGJvb2wgUmVuZGVyU3R5bGU6OnNldFpvb20oZmxvYXQgZikKIHsKICAgICBzZXRF ZmZlY3RpdmVab29tKGVmZmVjdGl2ZVpvb20oKSAqIGYpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU2ZjRiNTg1MTliMjRj MmJkMzQxOTQ0ZTk0Y2I5ZjJhODIwZmE4NWEuLjE4N2RhYWQxYzA3NDhiMGRlY2FmYWZkMzUxMzJh NTRmMWMxMjExYWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wOS0xNiAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIGNvbHVtbi1ydWxlLXN0eWxlOiBvdXRz ZXQvaW5zZXQgZG9lc24ndCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDg4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLW11bHRpY29sLTEvI2Ny cworICAgICAgICBUaGUgPOKAmGJvcmRlci1zdHlsZeKAmT4gdmFsdWVzIGFyZSBpbnRlcnByZXRl ZCBhcyBpbiB0aGUgY29sbGFwc2luZyBib3JkZXIgbW9kZWwuCisKKyAgICAgICAgKiBUZXN0RXhw ZWN0YXRpb25zOgorCiAyMDE1LTA5LTE1ICBBbmR5IFZhbldhZ29uZXIgIDx0aGV0YWxlY3JhZnRl ckBnbWFpbC5jb20+CiAKICAgICAgICAgW0lOVExdIEltcGxlbWVudCBzdXBwb3J0ZWRMb2NhbGVz T2Ygb24gSW50bCBDb25zdHJ1Y3RvcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDkzMDNlNTM0MWRh NDYzMDkyNGQ0MzZmNDIwYTFkN2Q0N2JiZmMzMTQuLjc2ZTU5MjA0NTc3NDk4ZjViNGQ3ZWQ1ZjBl MGU5NDlhYzY1MTAzOTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNjM4LDEzICs2MzgsOSBAQCBp bXBvcnRlZC93M2MvY3NzL2Nzcy1tdWx0aWNvbC0xL211bHRpY29sLXNwYW4tYWxsLWNoaWxkLTAw Mi54aHQgWyBXb250Rml4IF0KIHdlYmtpdC5vcmcvYi8xNDg4MTggaW1wb3J0ZWQvdzNjL2Nzcy9j c3MtbXVsdGljb2wtMS9tdWx0aWNvbC1maWxsLWF1dG8tYmxvY2stY2hpbGRyZW4tMDAyLnhodCBb IEltYWdlT25seUZhaWx1cmUgXSAjIG9ubHkgc2Nyb2xsYmFyCiB3ZWJraXQub3JnL2IvMTQ4ODE4 IGltcG9ydGVkL3czYy9jc3MvY3NzLW11bHRpY29sLTEvbXVsdGljb2wtbmVzdGVkLWNvbHVtbi1y dWxlLTAwMS54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0gIyBvbmx5IHNjcm9sbGJhcgogCi13ZWJr aXQub3JnL2IvMTQ4ODExIGltcG9ydGVkL3czYy9jc3MvY3NzLW11bHRpY29sLTEvbXVsdGljb2wt cnVsZS1pbnNldC0wMDAueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTQ4 ODExIGltcG9ydGVkL3czYy9jc3MvY3NzLW11bHRpY29sLTEvbXVsdGljb2wtcnVsZS1vdXRzZXQt MDAwLnhodCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE0ODgxMiBpbXBvcnRl ZC93M2MvY3NzL2Nzcy1tdWx0aWNvbC0xL211bHRpY29sLXdpZHRoLXNtYWxsLTAwMS54aHQgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4MTQgaW1wb3J0ZWQvdzNjL2Nzcy9j c3MtbXVsdGljb2wtMS9tdWx0aWNvbC1icmVhay0wMDAueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMTQ4ODE0IGltcG9ydGVkL3czYy9jc3MvY3NzLW11bHRpY29sLTEvbXVs dGljb2wtYnJlYWstMDAxLnhodCBbIEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE0 ODgxNSBpbXBvcnRlZC93M2MvY3NzL2Nzcy1tdWx0aWNvbC0xL211bHRpY29sLXJ1bGUtc3R5bGUt b3V0c2V0LTAwMS54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNDg4MTUg aW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wtMS9tdWx0aWNvbC1ydWxlLXN0eWxlLWluc2V0 LTAwMS54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4MTYgaW1wb3J0 ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wtMS9tdWx0aWNvbC1ydWxlLTAwNC54aHQgWyBJbWFnZU9u bHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4MjMgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVs dGljb2wtMS9tdWx0aWNvbC1zcGFuLWFsbC1tYXJnaW4tbmVzdGVkLTAwMy54aHQgWyBJbWFnZU9u bHlGYWlsdXJlIF0KIAo=