148809 2015-09-04 12:00:52 -0700 swipe-start-hysteresis-failures is flaky 2015-09-04 23:54:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap oldest_to_newest 1123528 0 thorton 2015-09-04 12:00:52 -0700 swipe-start-hysteresis-failures is flaky 1123531 1 260606 thorton 2015-09-04 12:01:14 -0700 Created attachment 260606 Patch 1123532 2 260606 ap 2015-09-04 12:03:08 -0700 Comment on attachment 260606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260606&action=review > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") I don't see this new shouldBe in expected results. 1123538 3 thorton 2015-09-04 12:20:35 -0700 (In reply to comment #2) > Comment on attachment 260606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260606&action=review > > > LayoutTests/swipe/swipe-start-hysteresis-failures.html:70 > > + shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.") > > I don't see this new shouldBe in expected results. Hmm, my shouldBe only logs if it fails. Maybe I should change that. 1123894 4 ap 2015-09-04 23:50:14 -0700 http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=swipe-start-hysteresis-failures Please land? 1123895 5 thorton 2015-09-04 23:54:05 -0700 I did. http://trac.webkit.org/changeset/189370 260606 2015-09-04 12:01:14 -0700 2015-09-04 12:03:08 -0700 Patch bug-148809-20150904120112.patch text/plain 2574 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MzYzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWIyODcwNGEwMGZkYTllYWEyY2Uw NDBjMzY1NGM4NTcxZjhkYmEzZS4uODBmOTgxYTM1OWU4MjUwMWNmZjRhYTcxNWVhMzQxNDE1YmE0 YWNiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTA0ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIHN3aXBlLXN0YXJ0LWh5c3RlcmVzaXMt ZmFpbHVyZXMgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0ODgwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogc3dpcGUvc3dpcGUtc3RhcnQtaHlzdGVyZXNpcy1mYWlsdXJlcy5odG1sOgor ICAgICAgICAqIHN3aXBlL3N3aXBlLXN0YXJ0LWh5c3RlcmVzaXMtZmFpbHVyZXMtZXhwZWN0ZWQu dHh0OgorICAgICAgICBJbnN0ZWFkIG9mIGRlcGVuZGluZyBvbiB0aGUgc3BlY2lmaWMgdGltaW5n IG9mIGRpZFN0YXJ0U3dpcGUgdnMuIHRoZSBldmVudHMKKyAgICAgICAgaW4gdGhpcyBjYXNlLCBq dXN0IG1ha2Ugc3VyZSB3ZSBoaXQgaXQgYnkgdGhlIHRpbWUgdGhlIHRlc3QgZmluaXNoZXMuCisK IDIwMTUtMDktMDQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtt ZWRpYWNvbnRyb2xzXSBUZXN0IHRoZSBvcmRlcmluZyBvZiBlbGVtZW50cyBpbiB0aGUgY29udHJv bHMgcGFuZWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N3aXBlL3N3aXBlLXN0YXJ0LWh5c3Rl cmVzaXMtZmFpbHVyZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3dpcGUvc3dpcGUtc3Rh cnQtaHlzdGVyZXNpcy1mYWlsdXJlcy1leHBlY3RlZC50eHQKaW5kZXggMDJlNGY3Yjg0ZjRjMzAw MzUxM2JkMDY0YmQ5MTY3MGZhMTFmMzNlZi4uNWE0ODBhOTgwNGNlMjE5MTRjOGY5ODJmNWJjMDEx OWU3ZGViZTU3OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3dpcGUvc3dpcGUtc3RhcnQtaHlz dGVyZXNpcy1mYWlsdXJlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3dpcGUvc3dp cGUtc3RhcnQtaHlzdGVyZXNpcy1mYWlsdXJlcy1leHBlY3RlZC50eHQKQEAgLTE3LDcgKzE3LDYg QEAgc2Nyb2xsIGV2ZW50IChkZWx0YSAwIDAsIHBoYXNlICdlbmRlZCcpCiBzd2lwZSBldmVudCAo ZGVsdGEgMCAwLCBwaGFzZSAnbWF5YmVnaW4nKQogc2Nyb2xsIGV2ZW50IChkZWx0YSAzIDEsIHBo YXNlICdiZWdhbicpCiBzY3JvbGwgZXZlbnQgKGRlbHRhIDAgMCwgcGhhc2UgJ2NoYW5nZWQnKQot ZGlkQmVnaW5Td2lwZQogc2Nyb2xsIGV2ZW50IChkZWx0YSAwIDAsIHBoYXNlICdlbmRlZCcpCiBz d2lwZSBldmVudCAoZGVsdGEgMCAwLCBwaGFzZSAnZW5kZWQnKQogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9zd2lwZS9zd2lwZS1zdGFydC1oeXN0ZXJlc2lzLWZhaWx1cmVzLmh0bWwgYi9MYXlv dXRUZXN0cy9zd2lwZS9zd2lwZS1zdGFydC1oeXN0ZXJlc2lzLWZhaWx1cmVzLmh0bWwKaW5kZXgg NmYyZGY2M2FkM2JmNGI1MWNlYjRmYTdkNDA5MzE4Zjk3MmYyMTUwMy4uNjU4MTdkM2YyZTMyN2M1 YmJkYzMwNDYyODIzN2YzMDc4NjJlZGU5ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3dpcGUv c3dpcGUtc3RhcnQtaHlzdGVyZXNpcy1mYWlsdXJlcy5odG1sCisrKyBiL0xheW91dFRlc3RzL3N3 aXBlL3N3aXBlLXN0YXJ0LWh5c3RlcmVzaXMtZmFpbHVyZXMuaHRtbApAQCAtNTksMTQgKzU5LDE1 IEBAIGZ1bmN0aW9uIGRvUmVndWxhclN3aXBlR2VzdHVyZSgpCiB7CiAgICAgLy8gU3dhcCBpbiBh IGRpZmZlcmVudCBjYWxsYmFjayB0aGF0IG1ha2VzIHN1cmUgd2UgKmRvKiByZWFjaCBkaWRCZWdp blN3aXBlLgogICAgIHRlc3RSdW5uZXIuY2xlYXJUZXN0UnVubmVyQ2FsbGJhY2tzKCk7CisgICAg dmFyIHNhd0RpZEJlZ2luU3dpcGUgPSBmYWxzZTsKICAgICB0ZXN0UnVubmVyLmluc3RhbGxEaWRC ZWdpblN3aXBlQ2FsbGJhY2soZnVuY3Rpb24gKCkgewotICAgICAgICBsb2coImRpZEJlZ2luU3dp cGUiKTsKLQorICAgICAgICBzYXdEaWRCZWdpblN3aXBlID0gdHJ1ZTsKICAgICAgICAgLy8gTmVl ZCBhIHN3aXBlLWVuZCBldmVudCB0byBjbGVhbiB1cC4KICAgICAgICAgZXZlbnRRdWV1ZS5lbnF1 ZXVlU3dpcGVFdmVudCgwLCAwLCAnZW5kZWQnKTsKICAgICB9KTsKIAogICAgIHRlc3RSdW5uZXIu aW5zdGFsbERpZFJlbW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayhmdW5jdGlvbiAoKSB7CisgICAg ICAgIHNob3VsZEJlKHRydWUsIHNhd0RpZEJlZ2luU3dpcGUsICJUaGUgbGFzdCBnZXN0dXJlIHNo b3VsZCBzdGFydCBhIHN3aXBlLCBiZWNhdXNlIGl0IGlzIHN1ZmZpY2llbnQgbWFnbml0dWRlIGFu ZCBpbiB0aGUgY29ycmVjdCBkaXJlY3Rpb24uIikKICAgICAgICAgdGVzdENvbXBsZXRlKCk7CiAg ICAgfSk7CiAK