148787 2015-09-03 22:30:00 -0700 Document.body should return the first body / frameset child of the html element 2015-09-04 10:40:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 InRadar, WebExposed P2 Normal --- 1 cdumez cdumez commit-queue esprehn+autocc kangil.han kling rniwa webkit-bug-importer oldest_to_newest 1123350 0 cdumez 2015-09-03 22:30:00 -0700 Document.body should return the *first* body / frameset child of the html element as per the specification: https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 Chrome and Firefox both behave correctly. However, WebKit first looks for a frameset child and returns it if it find one. It then falls back to looking for a body child. document.body thus returns a wrong result in this case: <html> <body></body> <frameset></frameset> </html> This is covered by the following newly imported W3C test: http/tests/w3c/html/dom/documents/dom-tree-accessors/document.body-getter.html 1123351 1 cdumez 2015-09-03 22:30:35 -0700 rdar://problem/22566850 1123352 2 260568 cdumez 2015-09-03 22:35:34 -0700 Created attachment 260568 Patch 1123484 3 260568 commit-queue 2015-09-04 10:40:17 -0700 Comment on attachment 260568 Patch Clearing flags on attachment: 260568 Committed r189354: <http://trac.webkit.org/changeset/189354> 1123485 4 commit-queue 2015-09-04 10:40:21 -0700 All reviewed patches have been landed. Closing bug. 260568 2015-09-03 22:35:34 -0700 2015-09-04 10:40:17 -0700 Patch bug-148787-20150903223532.patch text/plain 4411 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RjYmRlMDkwNzYwMjdk ZWNhN2FlNTllOWZmYjdkZTdlZmIzMTllZi4uNzk4MjY3MTI0YTVhZDkyN2E0ODE0YTRkMWRlZjI5 ZTBlYjdhNzdkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA5LTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRG9jdW1lbnQuYm9keSBzaG91 bGQgcmV0dXJuIHRoZSBmaXJzdCBib2R5IC8gZnJhbWVzZXQgY2hpbGQgb2YgdGhlIGh0bWwgZWxl bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4 Nzg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjU2Njg1MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb2N1bWVudC5ib2R5IHNob3VsZCByZXR1 cm4gdGhlICpmaXJzdCogYm9keSAvIGZyYW1lc2V0IGNoaWxkIG9mIHRoZSBodG1sCisgICAgICAg IGVsZW1lbnQgYXMgcGVyIHRoZSBzcGVjaWZpY2F0aW9uOgorICAgICAgICBodHRwczovL2h0bWwu c3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9kb20uaHRtbCN0aGUtYm9keS1lbGVtZW50LTIKKwor ICAgICAgICBDaHJvbWUgYW5kIEZpcmVmb3ggYm90aCBiZWhhdmUgY29ycmVjdGx5LiBIb3dldmVy LCBXZWJLaXQgd2FzIHByaW9yaXRpemluZworICAgICAgICBmcmFtZXNldCBvdmVyIGJvZHkuIFRo aXMgcGF0Y2ggZml4ZXMgdGhpcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292 ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpib2R5T3JGcmFtZXNldCk6CisKIDIwMTUtMDktMDMg IENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxODkzMzguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAw ZjYzN2FhODA4Y2Q4Mzc4M2RmMDY0MjQwYTE3YjI4ZWNmNjBkNDgyLi44OTdiYWUyYjEzYjI3MzE4 YjkxM2RhNWI3NzdjY2M2NDhhM2U4NzI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTI0 NzcsMTMgKzI0NzcsMTUgQEAgSFRNTEJvZHlFbGVtZW50KiBEb2N1bWVudDo6Ym9keSgpIGNvbnN0 CiAKIEhUTUxFbGVtZW50KiBEb2N1bWVudDo6Ym9keU9yRnJhbWVzZXQoKSBjb25zdAogewotICAg IC8vIElmIHRoZSBkb2N1bWVudCBlbGVtZW50IGNvbnRhaW5zIGJvdGggYSBmcmFtZXNldCBhbmQg YSBib2R5LCB0aGUgZnJhbWVzZXQgd2lucy4KKyAgICAvLyBSZXR1cm4gdGhlIGZpcnN0IGJvZHkg b3IgZnJhbWVzZXQgY2hpbGQgb2YgdGhlIGh0bWwgZWxlbWVudC4KICAgICBhdXRvKiBlbGVtZW50 ID0gZG9jdW1lbnRFbGVtZW50KCk7CiAgICAgaWYgKCFlbGVtZW50KQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKLSAgICBpZiAoYXV0byogZnJhbWVzZXQgPSBjaGlsZHJlbk9mVHlwZTxIVE1MRnJh bWVTZXRFbGVtZW50PigqZWxlbWVudCkuZmlyc3QoKSkKLSAgICAgICAgcmV0dXJuIGZyYW1lc2V0 OwotICAgIHJldHVybiBjaGlsZHJlbk9mVHlwZTxIVE1MQm9keUVsZW1lbnQ+KCplbGVtZW50KS5m aXJzdCgpOworICAgIGZvciAoYXV0byYgY2hpbGQgOiBjaGlsZHJlbk9mVHlwZTxIVE1MRWxlbWVu dD4oKmVsZW1lbnQpKSB7CisgICAgICAgIGlmIChpczxIVE1MQm9keUVsZW1lbnQ+KGNoaWxkKSB8 fCBpczxIVE1MRnJhbWVTZXRFbGVtZW50PihjaGlsZCkpCisgICAgICAgICAgICByZXR1cm4gJmNo aWxkOworICAgIH0KKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogdm9pZCBEb2N1bWVudDo6c2V0 Qm9keU9yRnJhbWVzZXQoUGFzc1JlZlB0cjxIVE1MRWxlbWVudD4gcHJwTmV3Qm9keSwgRXhjZXB0 aW9uQ29kZSYgZWMpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDdjNzA0ZDMwNjNkNTY5ZWUwMGFmNmFmODhmMmY2MWIxMmQ5 YTEwMi4uZjAwMDljNTJlMjM5ZjdjZGNiNGVmNjZhY2RkNWM0N2U4ZTAxM2E2NyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSw1ICsxLDE3IEBACiAyMDE1LTA5LTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKKyAgICAgICAgRG9jdW1lbnQuYm9keSBzaG91bGQgcmV0dXJuIHRoZSBmaXJzdCBib2R5IC8g ZnJhbWVzZXQgY2hpbGQgb2YgdGhlIGh0bWwgZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4Nzg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8yMjU2Njg1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZWJhc2VsaW5lIHRlc3Qgbm93IHRoYXQgYSBuZXcgY2hlY2sgaXMgcGFzc2luZy4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMvdzNjL2h0bWwvZG9tL2RvY3VtZW50cy9kb20tdHJlZS1hY2Nl c3NvcnMvZG9jdW1lbnQuYm9keS1nZXR0ZXItZXhwZWN0ZWQudHh0OgorCisyMDE1LTA5LTAzICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgcmVi YXNlbGluZSBodHRwL3Rlc3RzL3czYy9odG1sL2RvbS9keW5hbWljLW1hcmt1cC1pbnNlcnRpb24v b3BlbmluZy10aGUtaW5wdXQtc3RyZWFtLzAwNy5odG1sCiAKICAgICAgICAgVGhpcyBpcyBhIG5l dyB0ZXN0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93M2MvaHRtbC9kb20v ZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29ycy9kb2N1bWVudC5ib2R5LWdldHRlci1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3czYy9odG1sL2RvbS9kb2N1bWVudHMvZG9t LXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50LmJvZHktZ2V0dGVyLWV4cGVjdGVkLnR4dAppbmRleCA4 MDFmYWZmYzRmYzlmYmIzMzdkMTAyYWMyODFjMDg3OTNjYWMwYjY5Li45NTU5OGUzNzVhNzBlNDI4 M2JlMGMxYjk4OGEzYzU5YmRlZGVkOWFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3czYy9odG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50LmJv ZHktZ2V0dGVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3czYy9o dG1sL2RvbS9kb2N1bWVudHMvZG9tLXRyZWUtYWNjZXNzb3JzL2RvY3VtZW50LmJvZHktZ2V0dGVy LWV4cGVjdGVkLnR4dApAQCAtMSw5ICsxLDkgQEAKIAogUEFTUyBDaGlsZGxlc3MgZG9jdW1lbnQg CiBQQVNTIENoaWxkbGVzcyBodG1sIGVsZW1lbnQgCi1GQUlMIEJvZHkgZm9sbG93ZWQgYnkgZnJh bWVzZXQgaW5zaWRlIHRoZSBodG1sIGVsZW1lbnQgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgRWxl bWVudCBub2RlIDxib2R5PjwvYm9keT4gYnV0IGdvdCBFbGVtZW50IG5vZGUgPGZyYW1lc2V0Pjwv ZnJhbWVzZXQ+CitQQVNTIEJvZHkgZm9sbG93ZWQgYnkgZnJhbWVzZXQgaW5zaWRlIHRoZSBodG1s IGVsZW1lbnQgCiBQQVNTIEZyYW1lc2V0IGZvbGxvd2VkIGJ5IGJvZHkgaW5zaWRlIHRoZSBodG1s IGVsZW1lbnQgCi1GQUlMIEJvZHkgZm9sbG93ZWQgYnkgZnJhbWVzZXQgaW5zaWRlIGEgbm9uLUhU TUwgaHRtbCBlbGVtZW50IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIG51bGwgYnV0IGdvdCBFbGVt ZW50IG5vZGUgPGZyYW1lc2V0PjwvZnJhbWVzZXQ+CitGQUlMIEJvZHkgZm9sbG93ZWQgYnkgZnJh bWVzZXQgaW5zaWRlIGEgbm9uLUhUTUwgaHRtbCBlbGVtZW50IGFzc2VydF9lcXVhbHM6IGV4cGVj dGVkIG51bGwgYnV0IGdvdCBFbGVtZW50IG5vZGUgPGJvZHk+PC9ib2R5PgogRkFJTCBGcmFtZXNl dCBmb2xsb3dlZCBieSBib2R5IGluc2lkZSBhIG5vbi1IVE1MIGh0bWwgZWxlbWVudCBhc3NlcnRf ZXF1YWxzOiBleHBlY3RlZCBudWxsIGJ1dCBnb3QgRWxlbWVudCBub2RlIDxmcmFtZXNldD48L2Zy YW1lc2V0PgogUEFTUyBOb24tSFRNTCBib2R5IGZvbGxvd2VkIGJ5IGJvZHkgaW5zaWRlIHRoZSBo dG1sIGVsZW1lbnQgCiBQQVNTIE5vbi1IVE1MIGZyYW1lc2V0IGZvbGxvd2VkIGJ5IGJvZHkgaW5z aWRlIHRoZSBodG1sIGVsZW1lbnQgCg==