148773 2015-09-03 19:14:21 -0700 Range.deleteContents cannot delete DocType 2015-09-17 08:51:27 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa cdumez ap cdumez commit-queue darin esprehn+autocc kangil.han rniwa webkit-bug-importer oldest_to_newest 1123279 0 rniwa 2015-09-03 19:14:21 -0700 <!DOCTYPE html> <html> <body> <script> var range = document.createRange(); range.setStart(document, 0); range.setEnd(document, 1); range.deleteContents(); </script> </body> </html> throws an exception because we attempt to insert a DOCTYPE into a document fragment inside Range::processContents but it shouldn't. This bug was found by the newly added test: LayoutTests/http/tests/w3c/dom/ranges/Range-deleteContents.html 1123280 1 webkit-bug-importer 2015-09-03 19:14:56 -0700 <rdar://problem/22571280> 1126575 2 261355 cdumez 2015-09-16 19:50:45 -0700 Created attachment 261355 Patch 1126703 3 261355 cdumez 2015-09-17 08:51:21 -0700 Comment on attachment 261355 Patch Clearing flags on attachment: 261355 Committed r189914: <http://trac.webkit.org/changeset/189914> 1126704 4 cdumez 2015-09-17 08:51:27 -0700 All reviewed patches have been landed. Closing bug. 261355 2015-09-16 19:50:45 -0700 2015-09-17 08:51:21 -0700 Patch bug-148773-20150916195032.patch text/plain 6406 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkzNWI1MmMzMTg4ODZm NzEzMGM0ZjhlMTM4MWI1OWQ5MGY1ZDE5ZS4uY2E1ZjhkMjY4ZjViYWNiNTQ3NDYxNDViMWM1MTQ0 YjJmOWQ1NjI3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE1LTA5LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgUmFuZ2UuZGVsZXRlQ29udGVu dHMgY2Fubm90IGRlbGV0ZSBEb2NUeXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDg3NzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIyNTcxMjgw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJhbmdl LmRlbGV0ZUNvbnRlbnRzKCkgd2FzIG5vdCBhYmxlIHRvIGRlbGV0ZSBhIERvY3VtZW50VHlwZSBO b2RlLCBhbmQKKyAgICAgICAgd2FzIHRocm93aW5nIGEgSElFUkFSQ0hZX1JFUVVFU1RfRVJSLiBU aGUgRE9NIHNwZWNpZmljYXRpb24gZG9lcyBub3QKKyAgICAgICAgc2F5IHdlIHNob3VsZCB0aHJv dyBpbiBzdWNoIGNhc2U6CisgICAgICAgIGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jZG9t LXJhbmdlLWRlbGV0ZWNvbnRlbnRzCisKKyAgICAgICAgSG93ZXZlciwgUmFuZ2UuZXh0cmFjdENv bnRlbnRzKCkgc2hvdWxkIHN0aWxsIHRocm93IGFuIGV4Y2VwdGlvbgorICAgICAgICBpZiBhbnkg b2YgdGhlIGNvbnRhaW5lZCBjaGlsZHJlbiBpbiBhIERvY3VtZW50VHlwZSBOb2RlOgorICAgICAg ICBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcvI2NvbmNlcHQtcmFuZ2UtZXh0cmFjdCAoU3Rl cCAxMikKKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0LgorCisgICAgICAgICogZG9tL1JhbmdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJh bmdlOjpkZWxldGVDb250ZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpSYW5nZTo6ZXh0cmFjdENv bnRlbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlJhbmdlOjpjaGVja0RlbGV0ZUV4dHJhY3QpOgor ICAgICAgICAqIGRvbS9SYW5nZS5oOgorCisyMDE1LTA5LTE2ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CisKICAgICAgICAgRWxlbWVudCdzIGF0dHJpYnV0ZSBOUyBBUEkgc2hvdWxk IGRlZmluZWQgdHJlYXQgdW5kZWZpbmVkIG5hbWVzcGFjZSBhcyBudWxsCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkyMzgKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzIyNTYyMjA0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1Jhbmdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9SYW5nZS5jcHAKaW5kZXggMjY1MDhjZjA0NzJkNGYw ZWRlZmE1ZDM1NTdjZTkyM2M3OGIxYjkyNS4uZjFhYTIyMTUwNzI5NTk4YTkzN2I2ZWNhYWZjNGM2 ZjhhYTcyNjNlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFuZ2UuY3BwCkBAIC00ODksNyArNDg5LDcgQEAgYm9vbCBS YW5nZTo6Ym91bmRhcnlQb2ludHNWYWxpZCgpIGNvbnN0CiAKIHZvaWQgUmFuZ2U6OmRlbGV0ZUNv bnRlbnRzKEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAgIGNoZWNrRGVsZXRlRXh0cmFjdChlYyk7 CisgICAgY2hlY2tEZWxldGVFeHRyYWN0KERlbGV0ZSwgZWMpOwogICAgIGlmIChlYykKICAgICAg ICAgcmV0dXJuOwogCkBAIC04MzYsNyArODM2LDcgQEAgUmVmUHRyPE5vZGU+IFJhbmdlOjpwcm9j ZXNzQW5jZXN0b3JzQW5kVGhlaXJTaWJsaW5ncyhBY3Rpb25UeXBlIGFjdGlvbiwgTm9kZSogY28K IAogUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IFJhbmdlOjpleHRyYWN0Q29udGVudHMoRXhjZXB0 aW9uQ29kZSYgZWMpCiB7Ci0gICAgY2hlY2tEZWxldGVFeHRyYWN0KGVjKTsKKyAgICBjaGVja0Rl bGV0ZUV4dHJhY3QoRXh0cmFjdCwgZWMpOwogICAgIGlmIChlYykKICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAKQEAgLTEzMzQsNyArMTMzNCw3IEBAIHZvaWQgUmFuZ2U6OnNldFN0YXJ0QmVmb3Jl KE5vZGUqIHJlZk5vZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIHNldFN0YXJ0KHJlZk5vZGUt PnBhcmVudE5vZGUoKSwgcmVmTm9kZS0+Y29tcHV0ZU5vZGVJbmRleCgpLCBlYyk7CiB9CiAKLXZv aWQgUmFuZ2U6OmNoZWNrRGVsZXRlRXh0cmFjdChFeGNlcHRpb25Db2RlJiBlYykKK3ZvaWQgUmFu Z2U6OmNoZWNrRGVsZXRlRXh0cmFjdChBY3Rpb25UeXBlIGFjdGlvbiwgRXhjZXB0aW9uQ29kZSYg ZWMpCiB7CiAgICAgZWMgPSAwOwogICAgIGlmICghY29tbW9uQW5jZXN0b3JDb250YWluZXIoKSkK QEAgLTEzNDYsNyArMTM0Niw4IEBAIHZvaWQgUmFuZ2U6OmNoZWNrRGVsZXRlRXh0cmFjdChFeGNl cHRpb25Db2RlJiBlYykKICAgICAgICAgICAgIGVjID0gTk9fTU9ESUZJQ0FUSU9OX0FMTE9XRURf RVJSOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAgICAgIGlmIChuLT5ub2Rl VHlwZSgpID09IE5vZGU6OkRPQ1VNRU5UX1RZUEVfTk9ERSkgeworCisgICAgICAgIGlmIChhY3Rp b24gPT0gRXh0cmFjdCAmJiBuLT5ub2RlVHlwZSgpID09IE5vZGU6OkRPQ1VNRU5UX1RZUEVfTk9E RSkgewogICAgICAgICAgICAgZWMgPSBISUVSQVJDSFlfUkVRVUVTVF9FUlI7CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9SYW5n ZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmgKaW5kZXggNmY3ZTM4OGViYWU5MTFiMGRk OWU2N2QyMjFmNDY1ZTVlMDFmZDJkMi4uYzhmMjk5M2FkZDBkMTU5ZmFjNTJiZGFjN2YxY2M5MzBi ZGU1ZjZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmgKQEAgLTE2MSwxMCArMTYxLDEwIEBAIHByaXZhdGU6CiAK ICAgICBOb2RlKiBjaGVja05vZGVXT2Zmc2V0KE5vZGUqLCBpbnQgb2Zmc2V0LCBFeGNlcHRpb25D b2RlJikgY29uc3Q7CiAgICAgdm9pZCBjaGVja05vZGVCQShOb2RlKiwgRXhjZXB0aW9uQ29kZSYp IGNvbnN0OwotICAgIHZvaWQgY2hlY2tEZWxldGVFeHRyYWN0KEV4Y2VwdGlvbkNvZGUmKTsKICAg ICBib29sIGNvbnRhaW5lZEJ5UmVhZE9ubHkoKSBjb25zdDsKIAogICAgIGVudW0gQWN0aW9uVHlw ZSB7IERlbGV0ZSwgRXh0cmFjdCwgQ2xvbmUgfTsKKyAgICB2b2lkIGNoZWNrRGVsZXRlRXh0cmFj dChBY3Rpb25UeXBlLCBFeGNlcHRpb25Db2RlJik7CiAgICAgUmVmUHRyPERvY3VtZW50RnJhZ21l bnQ+IHByb2Nlc3NDb250ZW50cyhBY3Rpb25UeXBlLCBFeGNlcHRpb25Db2RlJik7CiAgICAgc3Rh dGljIFJlZlB0cjxOb2RlPiBwcm9jZXNzQ29udGVudHNCZXR3ZWVuT2Zmc2V0cyhBY3Rpb25UeXBl LCBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+LCBOb2RlKiwgdW5zaWduZWQgc3RhcnRPZmZz ZXQsIHVuc2lnbmVkIGVuZE9mZnNldCwgRXhjZXB0aW9uQ29kZSYpOwogICAgIHN0YXRpYyB2b2lk IHByb2Nlc3NOb2RlcyhBY3Rpb25UeXBlLCBWZWN0b3I8UmVmUHRyPE5vZGU+PiYsIFBhc3NSZWZQ dHI8Tm9kZT4gb2xkQ29udGFpbmVyLCBQYXNzUmVmUHRyPE5vZGU+IG5ld0NvbnRhaW5lciwgRXhj ZXB0aW9uQ29kZSYpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggMmE3ZDA1MmQ4 ODQzYTVhOTFiMzMwN2Q1OGNiNGVlNjIyMTBiYzg2MC4uYTZmNDJlYTVkNWY3ZWFlNzM1OGE0ZDNk ZWM0NDFlYjQxN2JkNDQzMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMTcgQEAKIDIwMTUtMDktMTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAor ICAgICAgICBSYW5nZS5kZWxldGVDb250ZW50cyBjYW5ub3QgZGVsZXRlIERvY1R5cGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODc3MworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjI1NzEyODA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXM0MgRE9NIHRlc3Qgbm93IHRoYXQgbW9y ZSBjaGVja3MgYXJlIHBhc3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZG9t L3Jhbmdlcy9SYW5nZS1kZWxldGVDb250ZW50cy1leHBlY3RlZC50eHQ6CisKKzIwMTUtMDktMTYg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBFbGVtZW50J3MgYXR0 cmlidXRlIE5TIEFQSSBzaG91bGQgdHJlYXQgZGVmaW5lZCB1bmRlZmluZWQgbmFtZXNwYWNlIGFz IG51bGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 OTIzOAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjI1NjIyMDQ+CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9yYW5nZXMvUmFuZ2Ut ZGVsZXRlQ29udGVudHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9kb20vcmFuZ2VzL1JhbmdlLWRlbGV0ZUNvbnRlbnRzLWV4cGVjdGVk LnR4dAppbmRleCA2NjYwMGQ5NTUwNTJlNDRlY2Y4MDJkNjFmNDhjMmE5OGMyYTYzMTM1Li5iZjVj N2NhZGZlZTlhNmFiOGU4NjY0NmI5ODAwMTk5NGQ2MjY0YzJkIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9yYW5nZXMvUmFuZ2UtZGVs ZXRlQ29udGVudHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvZG9tL3Jhbmdlcy9SYW5nZS1kZWxldGVDb250ZW50cy1leHBlY3Rl ZC50eHQKQEAgLTQ4LDEwICs0OCwxMCBAQCBQQVNTIFJlc3VsdGluZyBET00gZm9yIHJhbmdlIDIx IFtwYXJhc1swXSwgMCwgcGFyYXNbMF0uZmlyc3RDaGlsZCwgN10KIFBBU1MgUmVzdWx0aW5nIGN1 cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjEgW3BhcmFzWzBdLCAwLCBwYXJhc1swXS5maXJzdENo aWxkLCA3XSAKIFBBU1MgUmVzdWx0aW5nIERPTSBmb3IgcmFuZ2UgMjIgW3Rlc3REaXYsIDIsIHBh cmFzWzRdLCAxXSAKIFBBU1MgUmVzdWx0aW5nIGN1cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjIg W3Rlc3REaXYsIDIsIHBhcmFzWzRdLCAxXSAKLUZBSUwgUmVzdWx0aW5nIERPTSBmb3IgcmFuZ2Ug MjMgW2RvY3VtZW50LCAwLCBkb2N1bWVudCwgMV0gSGllcmFyY2h5UmVxdWVzdEVycm9yOiBET00g RXhjZXB0aW9uIDMKLUZBSUwgUmVzdWx0aW5nIGN1cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjMg W2RvY3VtZW50LCAwLCBkb2N1bWVudCwgMV0gdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2 YWx1YXRpbmcgJ2FjdHVhbFJvb3RzJykKLUZBSUwgUmVzdWx0aW5nIERPTSBmb3IgcmFuZ2UgMjQg W2RvY3VtZW50LCAwLCBkb2N1bWVudCwgMl0gSGllcmFyY2h5UmVxdWVzdEVycm9yOiBET00gRXhj ZXB0aW9uIDMKLUZBSUwgUmVzdWx0aW5nIGN1cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjQgW2Rv Y3VtZW50LCAwLCBkb2N1bWVudCwgMl0gdW5kZWZpbmVkIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1 YXRpbmcgJ2FjdHVhbFJvb3RzJykKK1BBU1MgUmVzdWx0aW5nIERPTSBmb3IgcmFuZ2UgMjMgW2Rv Y3VtZW50LCAwLCBkb2N1bWVudCwgMV0gCitQQVNTIFJlc3VsdGluZyBjdXJzb3IgcG9zaXRpb24g Zm9yIHJhbmdlIDIzIFtkb2N1bWVudCwgMCwgZG9jdW1lbnQsIDFdIAorUEFTUyBSZXN1bHRpbmcg RE9NIGZvciByYW5nZSAyNCBbZG9jdW1lbnQsIDAsIGRvY3VtZW50LCAyXSAKK1BBU1MgUmVzdWx0 aW5nIGN1cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjQgW2RvY3VtZW50LCAwLCBkb2N1bWVudCwg Ml0gCiBQQVNTIFJlc3VsdGluZyBET00gZm9yIHJhbmdlIDI1IFtjb21tZW50LCAyLCBjb21tZW50 LCAzXSAKIFBBU1MgUmVzdWx0aW5nIGN1cnNvciBwb3NpdGlvbiBmb3IgcmFuZ2UgMjUgW2NvbW1l bnQsIDIsIGNvbW1lbnQsIDNdIAogUEFTUyBSZXN1bHRpbmcgRE9NIGZvciByYW5nZSAyNiBbdGVz dERpdiwgMCwgY29tbWVudCwgNV0gCg==