148766 2015-09-03 18:13:28 -0700 WatchpointsOnStructureStubInfo doesn't need to be reference counted 2015-09-03 18:21:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All RESOLVED FIXED P2 Normal --- 148718 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb msaboff nrotem oliver saam sam oldest_to_newest 1123254 0 fpizlo 2015-09-03 18:13:28 -0700 It doesn't need to be reference counted because the only RefPtr to it is in StructureStubInfo. Therefore, it can be a unique_ptr. 1123255 1 260546 fpizlo 2015-09-03 18:14:25 -0700 Created attachment 260546 the patch 1123256 2 260546 saam 2015-09-03 18:16:35 -0700 Comment on attachment 260546 the patch r=me 1123258 3 fpizlo 2015-09-03 18:21:15 -0700 Landed in http://trac.webkit.org/changeset/189328 260546 2015-09-03 18:14:25 -0700 2015-09-03 18:16:35 -0700 the patch blah.patch text/plain 4258 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MzI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTA5LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg V2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0dWJJbmZvIGRvZXNuJ3QgbmVlZCB0byBiZSByZWZlcmVu Y2UgY291bnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ4NzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSXQgZG9lc24ndCBuZWVkIHRvIGJlIHJlZmVyZW5jZSBjb3VudGVkIGJlY2F1c2UgdGhlIG9u bHkgUmVmUHRyIHRvIGl0IGlzIGluCisgICAgICAgIFN0cnVjdHVyZVN0dWJJbmZvLiBUaGVyZWZv cmUsIGl0IGNhbiBiZSBhIHVuaXF1ZV9wdHIuCisKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1 cmVTdHViQ2xlYXJpbmdXYXRjaHBvaW50LmNwcDoKKyAgICAgICAgKEpTQzo6V2F0Y2hwb2ludHNP blN0cnVjdHVyZVN0dWJJbmZvOjphZGRXYXRjaHBvaW50KToKKyAgICAgICAgKEpTQzo6V2F0Y2hw b2ludHNPblN0cnVjdHVyZVN0dWJJbmZvOjplbnN1cmVSZWZlcmVuY2VBbmRBZGRXYXRjaHBvaW50 KToKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1cmVTdHViQ2xlYXJpbmdXYXRjaHBvaW50Lmg6 CisgICAgICAgIChKU0M6OldhdGNocG9pbnRzT25TdHJ1Y3R1cmVTdHViSW5mbzo6V2F0Y2hwb2lu dHNPblN0cnVjdHVyZVN0dWJJbmZvKToKKyAgICAgICAgKEpTQzo6V2F0Y2hwb2ludHNPblN0cnVj dHVyZVN0dWJJbmZvOjpjb2RlQmxvY2spOgorICAgICAgICAqIGJ5dGVjb2RlL1N0cnVjdHVyZVN0 dWJJbmZvLmg6CisgICAgICAgIChKU0M6OmdldFN0cnVjdHVyZVN0dWJJbmZvQ29kZU9yaWdpbik6 CisKIDIwMTUtMDktMDMgIEJhc2lsZSBDbGVtZW50ICA8YmFzaWxlX2NsZW1lbnRAYXBwbGUuY29t PgogCiAgICAgICAgIEphdmFTY3JpcHQgZnVuY3Rpb25zIHNob3VsZCByZXN0b3JlIHRoZSBzdGFj ayBwb2ludGVyIGFmdGVyIGEgY2FsbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1N0cnVjdHVyZVN0dWJDbGVhcmluZ1dhdGNocG9pbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViQ2xlYXJpbmdXYXRjaHBv aW50LmNwcAkocmV2aXNpb24gMTg5MzIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1N0cnVjdHVyZVN0dWJDbGVhcmluZ1dhdGNocG9pbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC03NiwxMSArNzYsMTEgQEAgU3RydWN0dXJlU3R1YkNsZWFyaW5nV2F0Y2hwb2ludCogV2F0Y2hw bwogfQogCiBTdHJ1Y3R1cmVTdHViQ2xlYXJpbmdXYXRjaHBvaW50KiBXYXRjaHBvaW50c09uU3Ry dWN0dXJlU3R1YkluZm86OmVuc3VyZVJlZmVyZW5jZUFuZEFkZFdhdGNocG9pbnQoCi0gICAgUmVm UHRyPFdhdGNocG9pbnRzT25TdHJ1Y3R1cmVTdHViSW5mbz4mIGhvbGRlclJlZiwgQ29kZUJsb2Nr KiBjb2RlQmxvY2ssCisgICAgc3RkOjp1bmlxdWVfcHRyPFdhdGNocG9pbnRzT25TdHJ1Y3R1cmVT dHViSW5mbz4mIGhvbGRlclJlZiwgQ29kZUJsb2NrKiBjb2RlQmxvY2ssCiAgICAgU3RydWN0dXJl U3R1YkluZm8qIHN0dWJJbmZvLCBjb25zdCBPYmplY3RQcm9wZXJ0eUNvbmRpdGlvbiYga2V5KQog ewogICAgIGlmICghaG9sZGVyUmVmKQotICAgICAgICBob2xkZXJSZWYgPSBhZG9wdFJlZihuZXcg V2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0dWJJbmZvKGNvZGVCbG9jaywgc3R1YkluZm8pKTsKKyAg ICAgICAgaG9sZGVyUmVmID0gc3RkOjptYWtlX3VuaXF1ZTxXYXRjaHBvaW50c09uU3RydWN0dXJl U3R1YkluZm8+KGNvZGVCbG9jaywgc3R1YkluZm8pOwogICAgIGVsc2UgewogICAgICAgICBBU1NF UlQoaG9sZGVyUmVmLT5tX2NvZGVCbG9jayA9PSBjb2RlQmxvY2spOwogICAgICAgICBBU1NFUlQo aG9sZGVyUmVmLT5tX3N0dWJJbmZvID09IHN0dWJJbmZvKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViQ2xlYXJpbmdXYXRjaHBvaW50LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJDbGVh cmluZ1dhdGNocG9pbnQuaAkocmV2aXNpb24gMTg5MzIyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJDbGVhcmluZ1dhdGNocG9pbnQuaAkod29ya2luZyBj b3B5KQpAQCAtMzMsOCArMzMsNiBAQAogCiAjaW5jbHVkZSA8d3RmL0Zhc3RNYWxsb2MuaD4KICNp bmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KLSNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgot I2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAogbmFtZXNwYWNlIEpTQyB7CiAKQEAgLTcyLDcgKzcw LDkgQEAgcHJpdmF0ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3RydWN0dXJlU3R1YkNsZWFyaW5n V2F0Y2hwb2ludD4gbV9uZXh0OwogfTsKIAotY2xhc3MgV2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0 dWJJbmZvIDogcHVibGljIFJlZkNvdW50ZWQ8V2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0dWJJbmZv PiB7CitjbGFzcyBXYXRjaHBvaW50c09uU3RydWN0dXJlU3R1YkluZm8geworICAgIFdURl9NQUtF X05PTkNPUFlBQkxFKFdhdGNocG9pbnRzT25TdHJ1Y3R1cmVTdHViSW5mbyk7CisgICAgV1RGX01B S0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgV2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0 dWJJbmZvKENvZGVCbG9jayogY29kZUJsb2NrLCBTdHJ1Y3R1cmVTdHViSW5mbyogc3R1YkluZm8p CiAgICAgICAgIDogbV9jb2RlQmxvY2soY29kZUJsb2NrKQpAQCAtODUsNyArODUsNyBAQCBwdWJs aWM6CiAgICAgU3RydWN0dXJlU3R1YkNsZWFyaW5nV2F0Y2hwb2ludCogYWRkV2F0Y2hwb2ludChj b25zdCBPYmplY3RQcm9wZXJ0eUNvbmRpdGlvbiYga2V5KTsKICAgICAKICAgICBzdGF0aWMgU3Ry dWN0dXJlU3R1YkNsZWFyaW5nV2F0Y2hwb2ludCogZW5zdXJlUmVmZXJlbmNlQW5kQWRkV2F0Y2hw b2ludCgKLSAgICAgICAgUmVmUHRyPFdhdGNocG9pbnRzT25TdHJ1Y3R1cmVTdHViSW5mbz4mIGhv bGRlclJlZiwKKyAgICAgICAgc3RkOjp1bmlxdWVfcHRyPFdhdGNocG9pbnRzT25TdHJ1Y3R1cmVT dHViSW5mbz4mIGhvbGRlclJlZiwKICAgICAgICAgQ29kZUJsb2NrKiwgU3RydWN0dXJlU3R1Yklu Zm8qLCBjb25zdCBPYmplY3RQcm9wZXJ0eUNvbmRpdGlvbiYga2V5KTsKICAgICAKICAgICBDb2Rl QmxvY2sqIGNvZGVCbG9jaygpIGNvbnN0IHsgcmV0dXJuIG1fY29kZUJsb2NrOyB9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3RydWN0dXJlU3R1YkluZm8uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3RydWN0dXJlU3R1YkluZm8u aAkocmV2aXNpb24gMTg5MzIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1N0 cnVjdHVyZVN0dWJJbmZvLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzMCw3ICsyMzAsNyBAQCBzdHJ1 Y3QgU3RydWN0dXJlU3R1YkluZm8gewogCiAgICAgUmVmUHRyPEpJVFN0dWJSb3V0aW5lPiBzdHVi Um91dGluZTsKICAgICBDb2RlTG9jYXRpb25DYWxsIGNhbGxSZXR1cm5Mb2NhdGlvbjsKLSAgICBS ZWZQdHI8V2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0dWJJbmZvPiB3YXRjaHBvaW50czsKKyAgICBz dGQ6OnVuaXF1ZV9wdHI8V2F0Y2hwb2ludHNPblN0cnVjdHVyZVN0dWJJbmZvPiB3YXRjaHBvaW50 czsKIH07CiAKIGlubGluZSBDb2RlT3JpZ2luIGdldFN0cnVjdHVyZVN0dWJJbmZvQ29kZU9yaWdp bihTdHJ1Y3R1cmVTdHViSW5mbyYgc3RydWN0dXJlU3R1YkluZm8pCg==