148745 2015-09-03 11:48:45 -0700 Improve access specifier use in RenderObject 2015-09-03 14:03:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 savagobr webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1123106 0 savagobr 2015-09-03 11:48:45 -0700 Probably thanks to changes along the years, RenderObject has access specifiers all over the place. This patch will remove 4 unneeded specifiers while keeping private functions grouped together. 1123111 1 260505 savagobr 2015-09-03 11:50:19 -0700 Created attachment 260505 Patch 1123135 2 260505 mmaxfield 2015-09-03 13:13:04 -0700 Comment on attachment 260505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260505&action=review > Source/WebCore/rendering/RenderObject.h:844 > + // Helper functions. Dangerous to use! This comment is not helpful. 1123152 3 260505 commit-queue 2015-09-03 14:03:52 -0700 Comment on attachment 260505 Patch Clearing flags on attachment: 260505 Committed r189286: <http://trac.webkit.org/changeset/189286> 1123153 4 commit-queue 2015-09-03 14:03:57 -0700 All reviewed patches have been landed. Closing bug. 260505 2015-09-03 11:50:19 -0700 2015-09-03 14:03:52 -0700 Patch bug-148745-20150903115018.patch text/plain 3643 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE4NTAxZTQwZDk1OTM5 YWEzZmVlN2U5YWQ2ZjllODU0NDE3MTA2Ni4uZWRiNzAzYTZjZGYyODI1YzYwYjZhNzk2NzY3MzUw ODdiY2VlZDJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA5LTAzICBBZGVu aWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBJbXBy b3ZlIGFjY2VzcyBzcGVjaWZpZXIgdXNlIGluIFJlbmRlck9iamVjdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzQ1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnNldFByZXZpb3VzU2libGluZyk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnNldE5leHRTaWJsaW5nKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck9iamVjdDo6aXNTZXROZWVkc0xheW91dEZvcmJpZGRlbik6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnNldE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4pOgorCiAyMDE1 LTA5LTAyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE11dGF0 aW9uT2JzZXJ2ZXIgc2hvdWxkIGFjY2VwdCBhdHRyaWJ1dGVGaWx0ZXIsIGF0dHJpYnV0ZU9sZFZh bHVlLCBhbmQgY2hhcmFjdGVyRGF0YU9sZFZhbHVlIG9uIHRoZWlyIG93bgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4IGNiYzBiOTAyNGZiZjkzYmUyYjlkZGFmNzdi NTFhZDEzMGM2ZGY1NTEuLjhjZGNjMThkZjI4ZDM5MjUzNzE1MDczMjFkNGM0M2M4MDEzMzU3OTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTI1MiwyNCArMjUy LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBjcmVhdGVzQW5vbnltb3VzV3JhcHBlcigp IGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vCiAKLXByb3RlY3RlZDoKLSAgICAvLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KLSAgICAvLyBIZWxwZXIgZnVuY3Rpb25zLiBEYW5nZXJvdXMg dG8gdXNlIQotICAgIHZvaWQgc2V0UHJldmlvdXNTaWJsaW5nKFJlbmRlck9iamVjdCogcHJldmlv dXMpIHsgbV9wcmV2aW91cyA9IHByZXZpb3VzOyB9Ci0gICAgdm9pZCBzZXROZXh0U2libGluZyhS ZW5kZXJPYmplY3QqIG5leHQpIHsgbV9uZXh0ID0gbmV4dDsgfQotICAgIHZvaWQgc2V0UGFyZW50 KFJlbmRlckVsZW1lbnQqKTsKLSAgICAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8KLXByaXZhdGU6Ci0jaWZuZGVmIE5ERUJVRwotICAgIGJvb2wgaXNTZXROZWVkc0xh eW91dEZvcmJpZGRlbigpIGNvbnN0IHsgcmV0dXJuIG1fc2V0TmVlZHNMYXlvdXRGb3JiaWRkZW47 IH0KLSAgICB2b2lkIHNldE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4oYm9vbCBmbGFnKSB7IG1fc2V0 TmVlZHNMYXlvdXRGb3JiaWRkZW4gPSBmbGFnOyB9Ci0jZW5kaWYKLQotICAgIHZvaWQgYWRkQWJz b2x1dGVSZWN0Rm9yTGF5ZXIoTGF5b3V0UmVjdCYgcmVzdWx0KTsKLSAgICB2b2lkIHNldExheWVy TmVlZHNGdWxsUmVwYWludCgpOwotICAgIHZvaWQgc2V0TGF5ZXJOZWVkc0Z1bGxSZXBhaW50Rm9y UG9zaXRpb25lZE1vdmVtZW50TGF5b3V0KCk7Ci0KLXB1YmxpYzoKICNpZiBFTkFCTEUoVFJFRV9E RUJVR0dJTkcpCiAgICAgdm9pZCBzaG93Tm9kZVRyZWVGb3JUaGlzKCkgY29uc3Q7CiAgICAgdm9p ZCBzaG93UmVuZGVyVHJlZUZvclRoaXMoKSBjb25zdDsKQEAgLTI4MCw3ICsyNjIsNiBAQCBwdWJs aWM6CiAgICAgdm9pZCBzaG93UmVnaW9uc0luZm9ybWF0aW9uKCkgY29uc3Q7CiAjZW5kaWYKIAot cHVibGljOgogICAgIGJvb2wgaXNQc2V1ZG9FbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbm9kZSgp ICYmIG5vZGUoKS0+aXNQc2V1ZG9FbGVtZW50KCk7IH0KIAogICAgIGJvb2wgaXNSZW5kZXJFbGVt ZW50KCkgY29uc3QgeyByZXR1cm4gIWlzVGV4dCgpOyB9CkBAIC04NTksNiArODQwLDEyIEBAIHB1 YmxpYzoKICAgICBSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbkVudW0gc2hvdWxkUmVzcGVjdEltYWdl T3JpZW50YXRpb24oKSBjb25zdDsKIAogcHJvdGVjdGVkOgorICAgIC8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLworICAgIC8vIEhlbHBlciBmdW5jdGlvbnMuIERhbmdl cm91cyB0byB1c2UhCisgICAgdm9pZCBzZXRQcmV2aW91c1NpYmxpbmcoUmVuZGVyT2JqZWN0KiBw cmV2aW91cykgeyBtX3ByZXZpb3VzID0gcHJldmlvdXM7IH0KKyAgICB2b2lkIHNldE5leHRTaWJs aW5nKFJlbmRlck9iamVjdCogbmV4dCkgeyBtX25leHQgPSBuZXh0OyB9CisgICAgdm9pZCBzZXRQ YXJlbnQoUmVuZGVyRWxlbWVudCopOworICAgIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLwogICAgIHZvaWQgYWRkUERGVVJMUmVjdChQYWludEluZm8mLCBjb25zdCBM YXlvdXRQb2ludCYpOwogICAgIE5vZGUmIG5vZGVGb3JOb25Bbm9ueW1vdXMoKSBjb25zdCB7IEFT U0VSVCghaXNBbm9ueW1vdXMoKSk7IHJldHVybiBtX25vZGU7IH0KIApAQCAtODc5LDYgKzg2Niwx NSBAQCBwcm90ZWN0ZWQ6CiAgICAgc3RhdGljIHZvaWQgY2FsY3VsYXRlQm9yZGVyU3R5bGVDb2xv cihjb25zdCBFQm9yZGVyU3R5bGUmLCBjb25zdCBCb3hTaWRlJiwgQ29sb3ImKTsKIAogcHJpdmF0 ZToKKyNpZm5kZWYgTkRFQlVHCisgICAgYm9vbCBpc1NldE5lZWRzTGF5b3V0Rm9yYmlkZGVuKCkg Y29uc3QgeyByZXR1cm4gbV9zZXROZWVkc0xheW91dEZvcmJpZGRlbjsgfQorICAgIHZvaWQgc2V0 TmVlZHNMYXlvdXRJc0ZvcmJpZGRlbihib29sIGZsYWcpIHsgbV9zZXROZWVkc0xheW91dEZvcmJp ZGRlbiA9IGZsYWc7IH0KKyNlbmRpZgorCisgICAgdm9pZCBhZGRBYnNvbHV0ZVJlY3RGb3JMYXll cihMYXlvdXRSZWN0JiByZXN1bHQpOworICAgIHZvaWQgc2V0TGF5ZXJOZWVkc0Z1bGxSZXBhaW50 KCk7CisgICAgdm9pZCBzZXRMYXllck5lZWRzRnVsbFJlcGFpbnRGb3JQb3NpdGlvbmVkTW92ZW1l bnRMYXlvdXQoKTsKKwogICAgIHZvaWQgcmVtb3ZlRnJvbVJlbmRlckZsb3dUaHJlYWQoKTsKICAg ICB2b2lkIHJlbW92ZUZyb21SZW5kZXJGbG93VGhyZWFkSW5jbHVkaW5nRGVzY2VuZGFudHMoYm9v bCk7CiAgICAgTm9kZSogZ2VuZXJhdGluZ1BzZXVkb0hvc3RFbGVtZW50KCkgY29uc3Q7Cg==