148735 2015-09-02 18:46:10 -0700 REGRESSION(r188206): [EFL] Missing to adjust scrollbar size to ewk_view_contents_size_get API test 2015-11-23 17:18:02 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 147725 1 gyuyoung.kim gyuyoung.kim commit-queue hs85.jeong lucas.de.marchi ossy oldest_to_newest 1123008 0 gyuyoung.kim 2015-09-02 18:46:10 -0700 I missed to fix other tests in r189256. I'm sorry about it. I upload an additional fix again :( 1123009 1 260471 gyuyoung.kim 2015-09-02 18:46:50 -0700 Created attachment 260471 Patch 1123063 2 260471 gyuyoung.kim 2015-09-02 21:57:13 -0700 Comment on attachment 260471 Patch Hmm, EFL API test is now fine. Is this flaky ? :( 1143589 3 hs85.jeong 2015-11-19 22:36:03 -0800 gyuyoung, ewk_view_contents_size_get API test have failed for a long time. It doesn't looks flaky. https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25635/steps/API%20tests/logs/stdio [ RUN ] EWK2ViewTest.ewk_view_contents_size_get ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1328: Failure Value of: contentsWidth Actual: 390 Expected: environment->defaultWidth() / 2 Which is: 400 ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1329: Failure Value of: contentsHeight Actual: 290 Expected: environment->defaultHeight() / 2 Which is: 300 [ FAILED ] EWK2ViewTest.ewk_view_contents_size_get (219 ms) 1144132 4 266081 gyuyoung.kim 2015-11-23 00:37:56 -0800 Created attachment 266081 Patch 1144133 5 gyuyoung.kim 2015-11-23 00:39:18 -0800 (In reply to comment #3) > gyuyoung, ewk_view_contents_size_get API test have failed for a long time. > It doesn't looks flaky. > > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/25635/steps/API%20tests/logs/stdio > > [ RUN ] EWK2ViewTest.ewk_view_contents_size_get > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1328: Failure > Value of: contentsWidth > Actual: 390 > Expected: environment->defaultWidth() / 2 > Which is: 400 > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1329: Failure > Value of: contentsHeight > Actual: 290 > Expected: environment->defaultHeight() / 2 > Which is: 300 > [ FAILED ] EWK2ViewTest.ewk_view_contents_size_get (219 ms) I forget this. But this test was fine as soon as I update this fix. It is weird. Anyway now I reproduce this failure locally. And this patch is still valid for the failure. 1144177 6 gyuyoung.kim 2015-11-23 07:01:24 -0800 Ossy, could you take a look ? 1144178 7 266081 ossy 2015-11-23 07:21:16 -0800 Comment on attachment 266081 Patch rs=me 1144250 8 266081 commit-queue 2015-11-23 17:17:59 -0800 Comment on attachment 266081 Patch Clearing flags on attachment: 266081 Committed r192754: <http://trac.webkit.org/changeset/192754> 1144251 9 commit-queue 2015-11-23 17:18:02 -0800 All reviewed patches have been landed. Closing bug. 260471 2015-09-02 18:46:50 -0700 2015-11-23 00:37:50 -0800 Patch bug-148735-20150903104648.patch text/plain 2033 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2M2NWYyODA0NjFiNzc4 OTY0ODU0M2M3NWJlNWJmMjllYTQ2OTBkNS4uNDNkODY3ZTdhMzZjMjBiMzFjYWExMmU2ZWE2ZGI1 MGMyZjdhYjQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA5LTAyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KIAorICAgICAgICBSRUdSRVNTSU9O KHIxODgyMDYpOiBbRUZMXSBNaXNzaW5nIHRvIGFkanVzdCBzY3JvbGxiYXIgc2l6ZSB0byBld2tf dmlld19jb250ZW50c19zaXplX2dldCBBUEkgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjE4OTI1NiBtaXNzZWQgdG8gYWRqdXN0IHNjcm9sbGJh ciBzaXplIHRvIG90aGVyIHRlc3RzIGluIGV3a192aWV3X2NvbnRlbnRzX3NpemVfZ2V0KCkgQVBJ IHRlc3QuCisgICAgICAgIEluIHRoaXMgY2FzZSB3ZSBuZWVkIHRvIGFwcGx5IHNjcm9sbGJhciBz aXplIHRvIGJvdGggd2lkdGggYW5kIGhlaWdodCB1bmxpa2UgcHJldmlvdXMgZml4LiBCZWNhdXNl CisgICAgICAgIGhvcml6b250YWwgc2Nyb2xsYmFyIGlzIHNob3duIHRvbyBzaW5jZSBkZXZpY2Ug cGl4ZWwgcmF0aW8oPSAyLjApIGlzIGFkanVzdGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOgorICAgICAgICAoVEVTVF9GKToKKworMjAx NS0wOS0wMiAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CisKICAgICAg ICAgUkVHUkVTU0lPTihyMTg4MjA2KTogW0VGTF0gQWRqdXN0IHNjcm9sbGJhciB3aWR0aCB0byBl d2tfdmlld19jb250ZW50c19zaXplX2dldCBBUEkgdGVzdCAKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODcwMQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5k ZXggY2JjZGZjNjkyZWJmMzhlNDIyZDc2ODg4Y2E4ODJiOTkyMjA5ZjU4Yy4uN2FiNTVmYjUxOTIz MDUwMTQyMTE0ZGM0OGRkNWI0MzI1MGUzZGIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtMTIx NSw4ICsxMjE1LDggQEAgVEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdrX3ZpZXdfY29udGVudHNfc2l6 ZV9nZXQpCiAgICAgQVNTRVJUX1RSVUUobG9hZFVybFN5bmMoZW52aXJvbm1lbnQtPmRlZmF1bHRU ZXN0UGFnZVVybCgpKSk7CiAgICAgZXdrX3ZpZXdfY29udGVudHNfc2l6ZV9nZXQod2ViVmlldygp LCAmY29udGVudHNXaWR0aCwgJmNvbnRlbnRzSGVpZ2h0KTsKIAotICAgIEVYUEVDVF9FUShlbnZp cm9ubWVudC0+ZGVmYXVsdFdpZHRoKCkgLyAyLCBjb250ZW50c1dpZHRoKTsKLSAgICBFWFBFQ1Rf RVEoZW52aXJvbm1lbnQtPmRlZmF1bHRIZWlnaHQoKSAvIDIsIGNvbnRlbnRzSGVpZ2h0KTsKKyAg ICBFWFBFQ1RfRVEoZW52aXJvbm1lbnQtPmRlZmF1bHRXaWR0aCgpIC8gMiAtIHNjcm9sbEJhcldp ZHRoLCBjb250ZW50c1dpZHRoKTsKKyAgICBFWFBFQ1RfRVEoZW52aXJvbm1lbnQtPmRlZmF1bHRI ZWlnaHQoKSAvIDIgLSBzY3JvbGxCYXJXaWR0aCwgY29udGVudHNIZWlnaHQpOwogI2VuZGlmCiAK ICAgICBjb25zdCBjaGFyIGZpeGVkQ29udGVudHNTaXplW10gPQo= 266081 2015-11-23 00:37:56 -0800 2015-11-23 17:17:59 -0800 Patch bug-148735-20151123173741.patch text/plain 1949 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2U2Mzc4ODcyNjI4NGMw YmEzZjE1YzhhM2I1OWNjMWY3YjE2MGQzYy4uOTNlOTEwNzUyZTY4OWQ5MjYzNmQ1YzhhMmUyYmZi NWVjOWY1MDMzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTIzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O KHIxODgyMDYpOiBbRUZMXSBNaXNzaW5nIHRvIGFkanVzdCBzY3JvbGxiYXIgc2l6ZSB0byBld2tf dmlld19jb250ZW50c19zaXplX2dldCBBUEkgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjE4OTI1NiBtaXNzZWQgdG8gYWRqdXN0IHNjcm9sbGJh ciBzaXplIHRvIG90aGVyIHRlc3RzIGluIGV3a192aWV3X2NvbnRlbnRzX3NpemVfZ2V0KCkgQVBJ IHRlc3QuCisgICAgICAgIEluIHRoaXMgY2FzZSB3ZSBuZWVkIHRvIGFwcGx5IHNjcm9sbGJhciBz aXplIHRvIGJvdGggd2lkdGggYW5kIGhlaWdodCB1bmxpa2UgcHJldmlvdXMgZml4LiBCZWNhdXNl CisgICAgICAgIGhvcml6b250YWwgc2Nyb2xsYmFyIGlzIGFsc28gc2hvd24gc2luY2UgZGV2aWNl IHBpeGVsIHJhdGlvKD0gMi4wKSBpcyBhZGp1c3RlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcDoKKyAgICAgICAgKFRFU1RfRik6CisKIDIw MTUtMTEtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEFkZCBtaXNzaW5nIGluc3BlY3RvciBmaWxlIHRvIEdUSysgY29t cGlsYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90 ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggNzU4YTRmNWJiOTVmNmM5NzAwOWM5NWQ4 YjBiZTFmNWE4NTNjOTc0Yi4uNTMxZDhhNjQ3OTczNmQ2NDdhZGZhNWQ2NjgxMmZlMGYyN2Y1ZGQ5 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVz dF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rl c3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtMTMyNSw4ICsxMzI1LDggQEAgVEVTVF9GKEVXSzJW aWV3VGVzdCwgZXdrX3ZpZXdfY29udGVudHNfc2l6ZV9nZXQpCiAgICAgQVNTRVJUX1RSVUUobG9h ZFVybFN5bmMoZW52aXJvbm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKSk7CiAgICAgZXdrX3Zp ZXdfY29udGVudHNfc2l6ZV9nZXQod2ViVmlldygpLCAmY29udGVudHNXaWR0aCwgJmNvbnRlbnRz SGVpZ2h0KTsKIAotICAgIEVYUEVDVF9FUShlbnZpcm9ubWVudC0+ZGVmYXVsdFdpZHRoKCkgLyAy LCBjb250ZW50c1dpZHRoKTsKLSAgICBFWFBFQ1RfRVEoZW52aXJvbm1lbnQtPmRlZmF1bHRIZWln aHQoKSAvIDIsIGNvbnRlbnRzSGVpZ2h0KTsKKyAgICBFWFBFQ1RfRVEoZW52aXJvbm1lbnQtPmRl ZmF1bHRXaWR0aCgpIC8gMiAtIHNjcm9sbEJhcldpZHRoLCBjb250ZW50c1dpZHRoKTsKKyAgICBF WFBFQ1RfRVEoZW52aXJvbm1lbnQtPmRlZmF1bHRIZWlnaHQoKSAvIDIgLSBzY3JvbGxCYXJXaWR0 aCwgY29udGVudHNIZWlnaHQpOwogI2VuZGlmCiAKICAgICBjb25zdCBjaGFyIGZpeGVkQ29udGVu dHNTaXplW10gPQo=