148729 2015-09-02 16:45:38 -0700 Node.textContent = undefined should be equivalent to textContent = "" 2015-09-02 19:51:17 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://heycam.github.io/webidl/#es-nullable-type InRadar P2 Normal --- 1 rniwa rniwa cdumez commit-queue darin kling oldest_to_newest 1122962 0 rniwa 2015-09-02 16:45:38 -0700 http://w3c-test.org/dom/nodes/Node-textContent.html fails because we don't treat undefined as an empty string in textContent's setter. 1122963 1 rniwa 2015-09-02 16:47:01 -0700 <rdar://problem/22549558> 1122964 2 cdumez 2015-09-02 16:49:55 -0700 As per https://heycam.github.io/webidl/#es-nullable-type, since the attribute is nullable, "if V is null or undefined, then return the IDL nullable type T? value null". Our generated bindings missed the "or undefined" part. I believe there is even a FIXME comment about this in the bindings generator already. 1122982 3 260462 rniwa 2015-09-02 17:57:19 -0700 Created attachment 260462 Fixes the bug 1123028 4 260462 commit-queue 2015-09-02 19:51:12 -0700 Comment on attachment 260462 Fixes the bug Clearing flags on attachment: 260462 Committed r189269: <http://trac.webkit.org/changeset/189269> 1123029 5 commit-queue 2015-09-02 19:51:17 -0700 All reviewed patches have been landed. Closing bug. 260462 2015-09-02 17:57:19 -0700 2015-09-02 19:51:12 -0700 Fixes the bug bug-148729-20150902175718.patch text/plain 4399 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTI2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE5vZGUudGV4dENvbnRlbnQgPSB1 bmRlZmluZWQgc2hvdWxkIGJlIGVxdWl2YWxlbnQgdG8gdGV4dENvbnRlbnQgPSAiIgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NzI5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXNzaWduaW5nIHVuZGVm aW5lZCB0byB0ZXh0Q29udGVudCBzaG91bGQgYmUgZXF1aXZhbGVudCB0byBhc3NpZ25pbmcgYW4g ZW1wdHkgc3RyaW5nIHRvIGl0IGxpa2UgaW5uZXJIVE1MLgorICAgICAgICBUaGlzIGlzIGJlY2F1 c2UgdGV4dENvbnRlbnQgaXMgZGVmaW5lZCBhcyBhbiBET01TdHJpbmc/IGF0dHJpYnV0ZSBpbiBE T000IFsxXSBhbmQgV2ViSURMIGRlZmluZXMgRUNNQVNjcmlwdAorICAgICAgICB1bmRlZmluZWQg dG8gYmUgdHJlYXRlZCBhcyBudWxsIGZvciBudWxsYWJsZSB0eXBlcyBbMl0uCisKKyAgICAgICAg VGhlIG5ldyBiZWhhdmlvciBtYXRjaGVzIHRoYXQgb2YgRmlyZWZveCBhbmQgQ2hyb21lLgorCisg ICAgICAgIFsxXSBodHRwczovL2RvbS5zcGVjLndoYXR3Zy5vcmcvI25vZGUKKyAgICAgICAgWzJd IGh0dHBzOi8vaGV5Y2FtLmdpdGh1Yi5pby93ZWJpZGwvI2VzLW51bGxhYmxlLXR5cGUKKyAgICAg ICAgCisgICAgICAgICogZG9tL05vZGUuaWRsOgorCiAyMDE1LTA5LTAyICBEZWFuIEphY2tzb24g IDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc29tZSBIb3VkaW5pIHNwZWNzIHRvIHRo ZSBmZWF0dXJlcyBsaXN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaWRsCShyZXZpc2lvbiAxODkyNjYpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTkxLDcgKzkx LDcgQEAKICAgICBbVHJlYXRSZXR1cm5lZE51bGxTdHJpbmdBcz1OdWxsXSByZWFkb25seSBhdHRy aWJ1dGUgRE9NU3RyaW5nICAgICAgIGJhc2VVUkk7CiAKICAgICAvLyBGSVhNRTogdGhlIHNwZWMg c2F5cyB0aGlzIGNhbiBhbHNvIHJhaXNlIG9uIHJldHJpZXZhbC4KLSAgICBbVHJlYXRSZXR1cm5l ZE51bGxTdHJpbmdBcz1OdWxsLCBUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBTZXR0ZXJSYWlzZXNF eGNlcHRpb25dIGF0dHJpYnV0ZSBET01TdHJpbmcgdGV4dENvbnRlbnQ7CisgICAgW1RyZWF0UmV0 dXJuZWROdWxsU3RyaW5nQXM9TnVsbCwgVHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJlYXRVbmRl ZmluZWRBcz1OdWxsU3RyaW5nLCBTZXR0ZXJSYWlzZXNFeGNlcHRpb25dIGF0dHJpYnV0ZSBET01T dHJpbmcgdGV4dENvbnRlbnQ7CiAKICAgICBib29sZWFuICAgICAgICAgICAgaXNTYW1lTm9kZShb RGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIE5vZGUgb3RoZXIpOwogICAgIGJvb2xlYW4gICAg ICAgICAgICBpc0VxdWFsTm9kZShbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIE5vZGUgb3Ro ZXIpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MjY2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDktMDIgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTm9kZS50ZXh0Q29udGVudCA9IHVuZGVm aW5lZCBzaG91bGQgYmUgZXF1aXZhbGVudCB0byB0ZXh0Q29udGVudCA9ICIiCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg3MjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lZCB0aGUgdGVz dCBub3cgdGhhdCB0ZXN0IGNhc2VzIHBhc3MuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3czYy9k b20vbm9kZXMvTm9kZS10ZXh0Q29udGVudC1leHBlY3RlZC50eHQ6CisKIDIwMTUtMDktMDIgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBhaW50IGNsZWFudXA6 CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3czYy9kb20vbm9kZXMvTm9kZS10ZXh0Q29u dGVudC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93 M2MvZG9tL25vZGVzL05vZGUtdGV4dENvbnRlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxODky NjYpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3czYy9kb20vbm9kZXMvTm9kZS10ZXh0Q29u dGVudC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI0LDE0ICsyNCwxNCBAQCBQQVNT IERvY3VtZW50RnJhZ21lbnQgd2l0aG91dCBjaGlsZHJlbiBzCiBQQVNTIERvY3VtZW50RnJhZ21l bnQgd2l0aCBlbXB0eSB0ZXh0IG5vZGUgYXMgY2hpbGQgc2V0IHRvIG51bGwgCiBQQVNTIERvY3Vt ZW50RnJhZ21lbnQgd2l0aCBjaGlsZHJlbiBzZXQgdG8gbnVsbCAKIFBBU1MgRG9jdW1lbnRGcmFn bWVudCB3aXRoIGRlc2NlbmRhbnRzIHNldCB0byBudWxsIAotRkFJTCBFbGVtZW50IHdpdGhvdXQg Y2hpbGRyZW4gc2V0IHRvIHVuZGVmaW5lZCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiIiBidXQg Z290ICJ1bmRlZmluZWQiCi1GQUlMIEVsZW1lbnQgd2l0aCBlbXB0eSB0ZXh0IG5vZGUgYXMgY2hp bGQgc2V0IHRvIHVuZGVmaW5lZCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiIiBidXQgZ290ICJ1 bmRlZmluZWQiCi1GQUlMIEVsZW1lbnQgd2l0aCBjaGlsZHJlbiBzZXQgdG8gdW5kZWZpbmVkIGFz c2VydF9lcXVhbHM6IGV4cGVjdGVkICIiIGJ1dCBnb3QgInVuZGVmaW5lZCIKLUZBSUwgRWxlbWVu dCB3aXRoIGRlc2NlbmRhbnRzIHNldCB0byB1bmRlZmluZWQgYXNzZXJ0X2VxdWFsczogZXhwZWN0 ZWQgIiIgYnV0IGdvdCAidW5kZWZpbmVkIgotRkFJTCBEb2N1bWVudEZyYWdtZW50IHdpdGhvdXQg Y2hpbGRyZW4gc2V0IHRvIHVuZGVmaW5lZCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiIiBidXQg Z290ICJ1bmRlZmluZWQiCi1GQUlMIERvY3VtZW50RnJhZ21lbnQgd2l0aCBlbXB0eSB0ZXh0IG5v ZGUgYXMgY2hpbGQgc2V0IHRvIHVuZGVmaW5lZCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAiIiBi dXQgZ290ICJ1bmRlZmluZWQiCi1GQUlMIERvY3VtZW50RnJhZ21lbnQgd2l0aCBjaGlsZHJlbiBz ZXQgdG8gdW5kZWZpbmVkIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICIiIGJ1dCBnb3QgInVuZGVm aW5lZCIKLUZBSUwgRG9jdW1lbnRGcmFnbWVudCB3aXRoIGRlc2NlbmRhbnRzIHNldCB0byB1bmRl ZmluZWQgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIiIgYnV0IGdvdCAidW5kZWZpbmVkIgorUEFT UyBFbGVtZW50IHdpdGhvdXQgY2hpbGRyZW4gc2V0IHRvIHVuZGVmaW5lZCAKK1BBU1MgRWxlbWVu dCB3aXRoIGVtcHR5IHRleHQgbm9kZSBhcyBjaGlsZCBzZXQgdG8gdW5kZWZpbmVkIAorUEFTUyBF bGVtZW50IHdpdGggY2hpbGRyZW4gc2V0IHRvIHVuZGVmaW5lZCAKK1BBU1MgRWxlbWVudCB3aXRo IGRlc2NlbmRhbnRzIHNldCB0byB1bmRlZmluZWQgCitQQVNTIERvY3VtZW50RnJhZ21lbnQgd2l0 aG91dCBjaGlsZHJlbiBzZXQgdG8gdW5kZWZpbmVkIAorUEFTUyBEb2N1bWVudEZyYWdtZW50IHdp dGggZW1wdHkgdGV4dCBub2RlIGFzIGNoaWxkIHNldCB0byB1bmRlZmluZWQgCitQQVNTIERvY3Vt ZW50RnJhZ21lbnQgd2l0aCBjaGlsZHJlbiBzZXQgdG8gdW5kZWZpbmVkIAorUEFTUyBEb2N1bWVu dEZyYWdtZW50IHdpdGggZGVzY2VuZGFudHMgc2V0IHRvIHVuZGVmaW5lZCAKIFBBU1MgRWxlbWVu dCB3aXRob3V0IGNoaWxkcmVuIHNldCB0byAiIiAKIFBBU1MgRWxlbWVudCB3aXRoIGVtcHR5IHRl eHQgbm9kZSBhcyBjaGlsZCBzZXQgdG8gIiIgCiBQQVNTIEVsZW1lbnQgd2l0aCBjaGlsZHJlbiBz ZXQgdG8gIiIgCg==