<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>148702</bug_id>
          
          <creation_ts>2015-09-01 21:15:25 -0700</creation_ts>
          <short_desc>[GStreamer] Simplify linking pads in AudioDestination and correct old comment.</short_desc>
          <delta_ts>2015-09-02 10:39:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hyemi Shin">hyemi.sin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1122753</commentid>
    <comment_count>0</comment_count>
    <who name="Hyemi Shin">hyemi.sin</who>
    <bug_when>2015-09-01 21:15:25 -0700</bug_when>
    <thetext>After https://bugs.webkit.org/show_bug.cgi?id=139370 applied, many lines had been changed but one comment wasn&apos;t changed along implementation.
And linking src pad of webkitAudioSrc could be simplified because whole elements are linked in one function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122754</commentid>
    <comment_count>1</comment_count>
    <who name="Hyemi Shin">hyemi.sin</who>
    <bug_when>2015-09-01 21:32:04 -0700</bug_when>
    <thetext>I&apos;m in trouble with uploading my patch behind proxy..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122777</commentid>
    <comment_count>2</comment_count>
      <attachid>260412</attachid>
    <who name="Hyemi Shin">hyemi.sin</who>
    <bug_when>2015-09-01 22:51:52 -0700</bug_when>
    <thetext>Created attachment 260412
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122800</commentid>
    <comment_count>3</comment_count>
      <attachid>260412</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-09-02 02:42:29 -0700</bug_when>
    <thetext>Comment on attachment 260412
Patch

Rejecting attachment 260412 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 260412, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: &lt;http://svn.webkit.org:80&gt; Mac OS Forge
Password for &apos;commit-queue@webkit.org&apos;: 
Authentication realm: &lt;http://svn.webkit.org:80&gt; Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/132523</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122802</commentid>
    <comment_count>4</comment_count>
      <attachid>260412</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2015-09-02 03:19:40 -0700</bug_when>
    <thetext>Comment on attachment 260412
Patch

Let&apos;s try again...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122804</commentid>
    <comment_count>5</comment_count>
      <attachid>260412</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-09-02 04:05:41 -0700</bug_when>
    <thetext>Comment on attachment 260412
Patch

Rejecting attachment 260412 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 260412, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: &lt;http://svn.webkit.org:80&gt; Mac OS Forge
Password for &apos;commit-queue@webkit.org&apos;: 
Authentication realm: &lt;http://svn.webkit.org:80&gt; Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/132706</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122812</commentid>
    <comment_count>6</comment_count>
      <attachid>260412</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-09-02 06:18:22 -0700</bug_when>
    <thetext>Comment on attachment 260412
Patch

Rejecting attachment 260412 from commit-queue.

hyemi.sin@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122856</commentid>
    <comment_count>7</comment_count>
      <attachid>260412</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-09-02 10:39:19 -0700</bug_when>
    <thetext>Comment on attachment 260412
Patch

Clearing flags on attachment: 260412

Committed r189255: &lt;http://trac.webkit.org/changeset/189255&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1122857</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-09-02 10:39:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>260412</attachid>
            <date>2015-09-01 22:51:52 -0700</date>
            <delta_ts>2015-09-02 10:39:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-148702-20150902145233.patch</filename>
            <type>text/plain</type>
            <size>3056</size>
            <attacher name="Hyemi Shin">hyemi.sin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE2NjVlMGNkMzVkYjNm
ZGNiMGI0NGY4ZGE0ZTgzMTc1NjlkNzZhNC4uNTFjOGZjYjUzMjRlYzRhYzAzYjRiNzhhZjFlODQ2
MmVlNGI5YjYzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA5LTAxICBIeWVt
aSBTaGluICA8aHllbWkuc2luQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIFNp
bXBsaWZ5IGxpbmtpbmcgcGFkcyBpbiBBdWRpb0Rlc3RpbmF0aW9uIGFuZCBjb3JyZWN0IG9sZCBj
b21tZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTQ4NzAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
U2ltcGxpZnkgbGlua2luZyBzcmMgcGFkIG9mIHdlYmtpdEF1ZGlvU3JjIGFuZCBzaW5rIHBhZCBv
ZiBhdWRpb0NvbnZlcnQKKyAgICAgICAgdG8gb25lIGxpbmUgYmVjYXVzZSBpbXBsZW1lbnRhdGlv
biBjaGFuZ2VkIG5vdCB0byB1c2Ugc2VwZXJhdGUgZnVuY3Rpb24KKyAgICAgICAgdG8gY29tcGxl
dGUgYnVpbGRpbmcgcmVzdCBvZiBwaXBlbGluZXMuCisgICAgICAgIENvcnJlY3Qgb2xkIGNvbW1l
bnQgYWxzbyB0aGVyZSBpcyBubyBtb3JlIHdhdnBhcnNlIGVsZW1lbnQuCisKKyAgICAgICAgTm8g
bmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp
by9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyOjpBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVy
KToKKwogMjAxNS0wOS0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAg
ICAgICBSZW5hbWUgU2hhZG93Um9vdDo6aG9zdEVsZW1lbnQgdG8gc2hhZG93Um9vdDo6aG9zdCB0
byBtYXRjaCB0aGUgbGF0ZXN0IHNwZWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyLmNwcCBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVh
bWVyLmNwcAppbmRleCBlNTA5NmM4OTk4ZDA4ZmUzMGRjNTcwOGFlOGUzYTI4NGI4ZDI3MDk2Li5m
MzU5OTg4ZTIyNDQ5Y2I4ZWMzYWQxNDY5NmM3NWFhM2EwMTc3NjE4IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlvbkdTdHJl
YW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1
ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwCkBAIC04Nyw4ICs4Nyw2IEBAIEF1ZGlvRGVzdGlu
YXRpb25HU3RyZWFtZXI6OkF1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIoQXVkaW9JT0NhbGxiYWNr
JiBjYWxsYmFjaywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicHJvdmlkZXIiLCAmbV9jYWxsYmFjaywK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAiZnJhbWVzIiwgZnJhbWVzVG9QdWxsLCBOVUxMKSk7CiAKLSAg
ICBHUmVmUHRyPEdzdFBhZD4gc3JjUGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0
aWNfcGFkKHdlYmtpdEF1ZGlvU3JjLCAic3JjIikpOwotCiAgICAgR1JlZlB0cjxHc3RFbGVtZW50
PiBhdWRpb1NpbmsgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImF1dG9hdWRpb3NpbmsiLCAw
KTsKICAgICBtX2F1ZGlvU2lua0F2YWlsYWJsZSA9IGF1ZGlvU2luazsKICAgICBpZiAoIWF1ZGlv
U2luaykgewpAQCAtMTExLDExICsxMDksOCBAQCBBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyOjpB
dWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKEF1ZGlvSU9DYWxsYmFjayYgY2FsbGJhY2ssCiAgICAg
R3N0RWxlbWVudCogYXVkaW9SZXNhbXBsZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiYXVk
aW9yZXNhbXBsZSIsIDApOwogICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTihtX3BpcGVsaW5l
KSwgd2Via2l0QXVkaW9TcmMsIGF1ZGlvQ29udmVydCwgYXVkaW9SZXNhbXBsZSwgYXVkaW9TaW5r
LmdldCgpLCBOVUxMKTsKIAotICAgIC8vIExpbmsgd2F2cGFyc2UncyBzcmMgcGFkIHRvIGF1ZGlv
Y29udmVydCBzaW5rIHBhZC4KLSAgICBHUmVmUHRyPEdzdFBhZD4gc2lua1BhZCA9IGFkb3B0R1Jl
Zihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChhdWRpb0NvbnZlcnQsICJzaW5rIikpOwotICAg
IGdzdF9wYWRfbGlua19mdWxsKHNyY1BhZC5nZXQoKSwgc2lua1BhZC5nZXQoKSwgR1NUX1BBRF9M
SU5LX0NIRUNLX05PVEhJTkcpOwotCi0gICAgLy8gTGluayBhdWRpb2NvbnZlcnQgdG8gYXVkaW9z
aW5rIGFuZCByb2xsIHN0YXRlcy4KKyAgICAvLyBMaW5rIHNyYyBwYWRzIGZyb20gd2Via2l0QXVk
aW9TcmMgdG8gYXVkaW9Db252ZXJ0ICEgYXVkaW9SZXNhbXBsZSAhIGF1dG9hdWRpb3NpbmsuCisg
ICAgZ3N0X2VsZW1lbnRfbGlua19wYWRzX2Z1bGwod2Via2l0QXVkaW9TcmMsICJzcmMiLCBhdWRp
b0NvbnZlcnQsICJzaW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOwogICAgIGdzdF9l
bGVtZW50X2xpbmtfcGFkc19mdWxsKGF1ZGlvQ29udmVydCwgInNyYyIsIGF1ZGlvUmVzYW1wbGUs
ICJzaW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOwogICAgIGdzdF9lbGVtZW50X2xp
bmtfcGFkc19mdWxsKGF1ZGlvUmVzYW1wbGUsICJzcmMiLCBhdWRpb1NpbmsuZ2V0KCksICJzaW5r
IiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>