148678 2015-09-01 08:47:49 -0700 Web Inspector: visual style editor fields should restore previous value when invalid inputs are entered 2018-10-25 01:31:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=148580 InRadar P2 Normal --- 147563 1 bburg webkit-unassigned hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1122544 0 bburg 2015-09-01 08:47:49 -0700 This is a followup bug to https://bugs.webkit.org/show_bug.cgi?id=148580. We shouldn't be storing the input state in the DOM, it should be kept in the widget class separately and synced when valid values are committed. 1122545 1 webkit-bug-importer 2015-09-01 08:48:17 -0700 <rdar://problem/22518919> 1124429 2 hi 2015-09-08 16:02:25 -0700 (In reply to comment #0) > We shouldn't be storing the input state in the DOM, it should be kept in the > widget class separately and synced when valid values are committed. I agree with you that we should have member variables for the current value, but I am not sure about "restore previous value when invalid inputs are entered". What exactly do you mean by that? Would it be something like "display: foo;"? If so, I don't think we should just revert to the previous value because that would remove any support for other browsers/custom css. Maybe something like a warning saying "this won't work"... 1472029 3 hi 2018-10-25 01:31:18 -0700 The Visual styles sidebar was removed in r236298 <https://webkit.org/b/189807>.