148677 2015-09-01 08:33:03 -0700 Web Inspector: add pixel area column to layout timeline view 2016-06-30 15:30:01 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1122538 0 bburg 2015-09-01 08:33:03 -0700 Showing the dimensions is nice but the area is more important from a performance impact perspective. We could even highlight paints above some threshold, like >50% of the viewport or something. But just having the data (again) would be nice. 1122539 1 webkit-bug-importer 2015-09-01 08:33:33 -0700 <rdar://problem/22518762> 1122556 2 timothy 2015-09-01 09:54:23 -0700 We had area. I can't remember why we removed it. 1203662 3 281627 mattbaker 2016-06-19 17:32:17 -0700 Created attachment 281627 [Patch] Proposed Fix 1203776 4 281627 bburg 2016-06-20 10:18:19 -0700 Comment on attachment 281627 [Patch] Proposed Fix r=me Where is the px^2 string used? 1203796 5 281627 joepeck 2016-06-20 10:49:41 -0700 Comment on attachment 281627 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281627&action=review > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:52 > + area: this._record.width * this._record.height, > width: this._record.width, > height: this._record.height, > area: this._record.width * this._record.height, Area is already here on line 52. 1206862 6 281627 bburg 2016-06-30 14:35:41 -0700 Comment on attachment 281627 [Patch] Proposed Fix Clearing review queue. Please remove duplicate 'area'. 1206874 7 282473 mattbaker 2016-06-30 15:00:17 -0700 Created attachment 282473 [Patch] Proposed Fix 1206892 8 282473 commit-queue 2016-06-30 15:29:57 -0700 Comment on attachment 282473 [Patch] Proposed Fix Clearing flags on attachment: 282473 Committed r202713: <http://trac.webkit.org/changeset/202713> 1206893 9 commit-queue 2016-06-30 15:30:01 -0700 All reviewed patches have been landed. Closing bug. 281627 2016-06-19 17:32:17 -0700 2016-06-30 15:00:09 -0700 [Patch] Proposed Fix bug-148677-20160619173211.patch text/plain 3656 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZDliOTc4NTM3OTA1ZTNkOGM5ODViM2Q2YjczMGIzMmViZWNmNjI0Li5lYTI1MWQ2MjQzZGU1Njk5 ZjA1YmEzYWRiNTQ5MTQ0ZThjZGFjNzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0wNi0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIHBpeGVsIGFyZWEgY29sdW1uIHRvIGxheW91 dCB0aW1lbGluZSB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDg2NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIyNTE4NzYyPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTG9jYWxpemF0aW9u cy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICBOZXcgIkFyZWEiIGFuZCAi cHjCsiIgc3RyaW5ncy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGlt ZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTGF5b3V0VGltZWxp bmVEYXRhR3JpZE5vZGUucHJvdG90eXBlLmdldCBkYXRhKToKKyAgICAgICAgQWRkIGFyZWEgZGF0 YS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVWaWV3Lmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lVmlldyk6CisgICAgICAgIEFk ZCAiQXJlYSIgY29sdW1uLgorCiAyMDE2LTA2LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjAyMTUy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHBy b2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRp b25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggOTdhYjAwMzBmNjg2MmFiYzlh ZDJlN2Y2ZDNiNjcyMGUwYjk4OTljZC4uYzQ0YjA5YjdmMTQ5ZDM4ODVkMmYxZGE5NWZhMGNmYmZh OTM0ZTE3ZCAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA0OQp6Y21aMi1nMDxsVT54Tzwr JHMmZVNoQ35KPmhGQXMjMjNzSWpWc0s7dGklbkojKTd7KiElOTZrTj8tY2QoMDhSLUcKQTYjeEpM CgpkZWx0YSA2Nwp6Y21ab1QhTWZ4Rz54Tz5TJEAqI25sUmJzYENQeEc1T2t0aFBgZjk4NG09aFRr clV4VzVpY2Z3IWlIOC0pVkpNcWsKV0FrSnQhYFRRaUYkK0E9UkhuVUl0Y0A2KnNfWk07aQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91 dFRpbWVsaW5lRGF0YUdyaWROb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMKaW5kZXggYWIwMjY2ZTA4 ZTQxOTRhYzA1NDdmMGU2NjQ2N2E1NzVlZDdlNGY0ZC4uNDlkOTg2YzA4MDhmMjEyZWFlY2FiMjZh OGM2MzY3ZGUzMzc5ZDdiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3Jp ZE5vZGUuanMKQEAgLTQ2LDYgKzQ2LDcgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lRGF0 YUdyaWROb2RlID0gY2xhc3MgTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUgZXh0ZW4KICAgICAg ICAgICAgIHRoaXMuX2NhY2hlZERhdGEgPSB7CiAgICAgICAgICAgICAgICAgdHlwZTogdGhpcy5f cmVjb3JkLmV2ZW50VHlwZSwKICAgICAgICAgICAgICAgICBuYW1lOiB0aGlzLmRpc3BsYXlOYW1l KCksCisgICAgICAgICAgICAgICAgYXJlYTogdGhpcy5fcmVjb3JkLndpZHRoICogdGhpcy5fcmVj b3JkLmhlaWdodCwKICAgICAgICAgICAgICAgICB3aWR0aDogdGhpcy5fcmVjb3JkLndpZHRoLAog ICAgICAgICAgICAgICAgIGhlaWdodDogdGhpcy5fcmVjb3JkLmhlaWdodCwKICAgICAgICAgICAg ICAgICBhcmVhOiB0aGlzLl9yZWNvcmQud2lkdGggKiB0aGlzLl9yZWNvcmQuaGVpZ2h0LApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0 VGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvTGF5b3V0VGltZWxpbmVWaWV3LmpzCmluZGV4IGRkOTUyYmM0OWMzY2YyMzI2MWI5NTY4Yjdm M2QwMjU3ZWNkMWZiMjIuLmNiZWVkMmExOWFjNjA2YTgxNjU1NzcxYzFjNmI5MzIyYzgxN2NlYmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xh eW91dFRpbWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZVZpZXcuanMKQEAgLTMxLDcgKzMxLDcgQEAgV2ViSW5z cGVjdG9yLkxheW91dFRpbWVsaW5lVmlldyA9IGNsYXNzIExheW91dFRpbWVsaW5lVmlldyBleHRl bmRzIFdlYkluc3BlY3Rvci4KIAogICAgICAgICBjb25zb2xlLmFzc2VydCh0aW1lbGluZS50eXBl ID09PSBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQuVHlwZS5MYXlvdXQsIHRpbWVsaW5lKTsK IAotICAgICAgICBsZXQgY29sdW1ucyA9IHt0eXBlOiB7fSwgbmFtZToge30sIGxvY2F0aW9uOiB7 fSwgd2lkdGg6IHt9LCBoZWlnaHQ6IHt9LCBzdGFydFRpbWU6IHt9LCB0b3RhbFRpbWU6IHt9fTsK KyAgICAgICAgbGV0IGNvbHVtbnMgPSB7dHlwZToge30sIG5hbWU6IHt9LCBsb2NhdGlvbjoge30s IGFyZWE6IHt9LCB3aWR0aDoge30sIGhlaWdodDoge30sIHN0YXJ0VGltZToge30sIHRvdGFsVGlt ZToge319OwogCiAgICAgICAgIGNvbHVtbnMubmFtZS50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0 cmluZygiVHlwZSIpOwogICAgICAgICBjb2x1bW5zLm5hbWUud2lkdGggPSAiMTUlIjsKQEAgLTU1 LDYgKzU1LDkgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lVmlldyA9IGNsYXNzIExheW91 dFRpbWVsaW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgY29sdW1ucy5sb2Nh dGlvbi50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiSW5pdGlhdG9yIik7CiAgICAgICAg IGNvbHVtbnMubG9jYXRpb24ud2lkdGggPSAiMjUlIjsKIAorICAgICAgICBjb2x1bW5zLmFyZWEu dGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFyZWEiKTsKKyAgICAgICAgY29sdW1ucy5h cmVhLndpZHRoID0gIjglIjsKKwogICAgICAgICBjb2x1bW5zLndpZHRoLnRpdGxlID0gV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJXaWR0aCIpOwogICAgICAgICBjb2x1bW5zLndpZHRoLndpZHRoID0g IjglIjsKIAo= 282473 2016-06-30 15:00:17 -0700 2016-06-30 15:29:57 -0700 [Patch] Proposed Fix bug-148677-20160630145955.patch text/plain 2243 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 NzAzMTc1MDY3Nzk0ZWNiZTU2ODUwNGFiMDNjMWU2YjVjZDY0N2E2Li5hNDFlMTE4Yzg4NzgwNzdj MWVmZTYzYmNiMjgxYzMxN2M4NjQ1OTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wNi0zMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIHBpeGVsIGFyZWEgY29sdW1uIHRvIGxheW91 dCB0aW1lbGluZSB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDg2NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIyNTE4NzYyPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB2aWV3IGNhbiBz aW1wbHkgYWRkIHRoZSBjb2x1bW4uIExheW91dFRpbWVsaW5lRGF0YUdyaWROb2RlCisgICAgICAg IGFscmVhZHkgaW5jbHVkZXMgYXJlYSBkYXRhIGFuZCBjZWxsIGZvcm1hdHRpbmcuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5MYXlvdXRUaW1lbGluZVZpZXcpOgorCiAyMDE2LTA2LTMwICBOaWtpdGEg VmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEFkZCAic3ByaW5nIiB0byB0cmFuc2l0aW9uLXRpbWluZy1mdW5jdGlvbiB2YWx1ZSBhdXRvY29t cGxldGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvTGF5b3V0VGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVWaWV3LmpzCmluZGV4IGRkOTUyYmM0OWMzY2Yy MzI2MWI5NTY4YjdmM2QwMjU3ZWNkMWZiMjIuLmNiZWVkMmExOWFjNjA2YTgxNjU1NzcxYzFjNmI5 MzIyYzgxN2NlYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZVZpZXcuanMKQEAgLTMxLDcgKzMx LDcgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lVmlldyA9IGNsYXNzIExheW91dFRpbWVs aW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KIAogICAgICAgICBjb25zb2xlLmFzc2VydCh0 aW1lbGluZS50eXBlID09PSBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQuVHlwZS5MYXlvdXQs IHRpbWVsaW5lKTsKIAotICAgICAgICBsZXQgY29sdW1ucyA9IHt0eXBlOiB7fSwgbmFtZToge30s IGxvY2F0aW9uOiB7fSwgd2lkdGg6IHt9LCBoZWlnaHQ6IHt9LCBzdGFydFRpbWU6IHt9LCB0b3Rh bFRpbWU6IHt9fTsKKyAgICAgICAgbGV0IGNvbHVtbnMgPSB7dHlwZToge30sIG5hbWU6IHt9LCBs b2NhdGlvbjoge30sIGFyZWE6IHt9LCB3aWR0aDoge30sIGhlaWdodDoge30sIHN0YXJ0VGltZTog e30sIHRvdGFsVGltZToge319OwogCiAgICAgICAgIGNvbHVtbnMubmFtZS50aXRsZSA9IFdlYklu c3BlY3Rvci5VSVN0cmluZygiVHlwZSIpOwogICAgICAgICBjb2x1bW5zLm5hbWUud2lkdGggPSAi MTUlIjsKQEAgLTU1LDYgKzU1LDkgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lVmlldyA9 IGNsYXNzIExheW91dFRpbWVsaW5lVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAg Y29sdW1ucy5sb2NhdGlvbi50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiSW5pdGlhdG9y Iik7CiAgICAgICAgIGNvbHVtbnMubG9jYXRpb24ud2lkdGggPSAiMjUlIjsKIAorICAgICAgICBj b2x1bW5zLmFyZWEudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFyZWEiKTsKKyAgICAg ICAgY29sdW1ucy5hcmVhLndpZHRoID0gIjglIjsKKwogICAgICAgICBjb2x1bW5zLndpZHRoLnRp dGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJXaWR0aCIpOwogICAgICAgICBjb2x1bW5zLndp ZHRoLndpZHRoID0gIjglIjsKIAo=